summaryrefslogtreecommitdiff
path: root/cui/source/inc
AgeCommit message (Collapse)Author
2017-07-06GSoC: Recent Charaters Toolbar Dropdown ControlAkshay Deep
Change-Id: Ib04d26fa5556e5c32db6799c16d0bbedc45504ec Reviewed-on: https://gerrit.libreoffice.org/38944 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-04loplugin:unusedfields in cui..idlNoel Grandin
Change-Id: Icb393cc0b2f79ded154e186ab6975b95e5126903 Reviewed-on: https://gerrit.libreoffice.org/39496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: cuiStephan Bergmann
Change-Id: Id8c4baf8c22cde50c22e4dcbcb475d78294baf5d
2017-07-02nMinPasswdLen is "currently not supported" ever sinceStephan Bergmann
...the code's introduction with 7cd3ea794099e257d99748908855e61aa9df89eb "#i109634# password to open/modify dialog", and demonstrated to be always passed in as 0 with 673b436c3592c5747f3dce4947168d6fa3ba45ea "loplugin:constantparam in vcl" Change-Id: Ic7eee77b114f39a0c016148e9176f58dcfc53ebc
2017-06-28Implement search feature in the Kayboard tabMuhammet Kara
of the Customize dialog. Once you type a search term in the box, non-matching functions are filtered out in the current category. The filter operation takes place, and updates as you type. If user changes category while there is still a search term in the box, the filter is also applied to the newly selected category. Change-Id: I5ef086af60e0f339af6a113fa6a52555d4f765d9 Reviewed-on: https://gerrit.libreoffice.org/38814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 3667beb986e8c03c925566a585b0504c7943fede) Reviewed-on: https://gerrit.libreoffice.org/39356 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-06-23loplugin:unusedfields in cuiNoel Grandin
Change-Id: I6d3ef43ab915d65794f1052f1f184eda10d39e1a Reviewed-on: https://gerrit.libreoffice.org/39136 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21Resolves: tdf#105740 select without selecting.. tdf#101588 b0rkEike Rathke
The initial color, if determined, must result in being selected. Differentiate between pre-selected and user-selected. Regression of commit 429be969b39867d6d9f36978c9ac15b601e78ba6 Date: Mon Dec 12 21:24:20 2016 +0100 Change-Id: I928af131d03c61a8e474e5cd356aea8b766112fa
2017-06-19GSoC: Glyph View and Recent Characters Control in Special Characters dialogAkshay Deep
Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 Reviewed-on: https://gerrit.libreoffice.org/37496 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-14Let CreateItemSet return unique_ptrStephan Bergmann
...and address resulting loplugin:useuniqueptr Change-Id: Ia79eb8d59ce5092b2d93b656eab687096baedf17
2017-06-13Use unique_ptr for SvxHpLinkDlg::mpItemSetStephan Bergmann
Change-Id: I6ad2669afe3853196bb1fce9c7c81af640831116
2017-06-12Get rid of last remainders of SetPos nonsenseKatarina Behrens
Change-Id: I6ebff09322e40adfc616a9003424fd1d4ff748ce Reviewed-on: https://gerrit.libreoffice.org/38629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12clang-tidy readability-delete-null-pointerNoel Grandin
which in turn triggered some loplugin:useuniqueptr Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64 Reviewed-on: https://gerrit.libreoffice.org/38281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-20tdf#107822: Apply custom pattern even if not saved as presetKatarina Behrens
do the same ff1f83dd08b7b0169301ffe0a53499a27af613b9 does for gradients and hatches also here. Additionally remove bool member variable, no eye deer what its purpose was anyway, it was written multiple times but never read Change-Id: Iebb811906e92827969da028ee66d90ac477b0bdf Reviewed-on: https://gerrit.libreoffice.org/37690 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-20cleanup unused css/script/ includesJochen Nitschke
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19loplugin:unusedfieldsNoel Grandin
make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18can drop CUI_RESSTR nowCaolán McNamara
Change-Id: I2e2319e661614dc8ba464479324b4719bcfa120e
2017-05-16tdf#107853 tdf#107854 Hide useless style familiesMaxim Monastirsky
Change-Id: I9918cbbf6b030e0f1f0a5dee153bedc8a53f91d8 Reviewed-on: https://gerrit.libreoffice.org/37688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-16loplugin:checkunusedparams variousNoel Grandin
Change-Id: I5d1cc807134230d86e0226a12fada204004312d3 Reviewed-on: https://gerrit.libreoffice.org/37675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16cleanup code in IconChoiceDialog::ActivatePageImplNoel Grandin
which has been this way ever since commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui And pass the SfxItemSet as a pointer up the constructor hierarchy, instead of a reference, since the base class wants a pointer anyway Change-Id: Iac4081fb5f3fc9cb9b0223f903d74ba84cdd5f6c Reviewed-on: https://gerrit.libreoffice.org/37664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11SearchForAlreadyLoadedDoc does nothing usefulNoel Grandin
at least as far back as commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Author: Mathias Bauer <mba@openoffice.org> Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui Change-Id: Ic8284d722a6222d26fc33ef62be62435dde8e0bd Reviewed-on: https://gerrit.libreoffice.org/37462 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09tdf#103491 Show correct label for the current UI element typeMaxim Monastirsky
Change-Id: Ia7ad3c9e6d70fd47aa8346403682a17a70c5c237 Reviewed-on: https://gerrit.libreoffice.org/37432 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-09Resolves: tdf#62702 allow ole objects to be inserted as iconsCaolán McNamara
under windows on "create new", "further objects" you get the native windows insert object dialog which has the "Display As Icon" option, but on Linux etc (or using our own dialog) there isn't that option so add a "Display as icon" checkbox in our own dialog and generate an icon through SvFileInformationManager::GetImage Change-Id: I0a400189031900bd1e387465ec4ba57847cb5394
2017-05-09tdf#106681 Styles category for the Add Commands dialogMaxim Monastirsky
Change-Id: I7332967863697d3ad68a533b9fc603de2fdc87ef Reviewed-on: https://gerrit.libreoffice.org/37422 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-03fix missing gallery iconsCaolán McNamara
Change-Id: Ie0d8acebcf9d30802296814c58a35244eb813748
2017-04-28tdf#105841: Avoid REGRESSION!!!Tor Lillqvist
Let's reinstate the name charade instead. Pitäkää tunkkinne. This reverts commit 5941496601600269296dde3e4ff8b615a8bb45ca. This reverts commit db231633af4667e24281e0be69ab63ad3081fdc3. Change-Id: I7d9890f3bd478bac195c1a7a59ff9822c2c83653
2017-04-28tdf#107437 Fix display of Start/End Quote window titlesGabor Kelemen
Drop this string surgery nonsense. We translators can surely handle four more words. Change-Id: I44be5fae7cc61dcac960cc5c33c60f0b5d354675 Reviewed-on: https://gerrit.libreoffice.org/37003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27Add custom HIDs for Customize - Toolbars pageGabor Kelemen
All items should have one as this page is reusing the ui file of the Menus page Change-Id: I9b691db70391eda90035761098ebc4d91d6a5b5b Reviewed-on: https://gerrit.libreoffice.org/36397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25remove bitmaps from .src filesCaolán McNamara
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24coverity#1405477 Uninitialized pointer fieldCaolán McNamara
and coverity#1405476 Uninitialized pointer field Change-Id: I6f6a13f5c3037ff11636938135bad72f8b3419d2
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-04coverity#1403732 Mixing enum typesCaolán McNamara
and coverity#1403735 Mixing enum types coverity#1403737 Mixing enum types Change-Id: I278b7d5116d4157e6aa4483d8eef42325e4bc03b
2017-04-02Hide useless label for adjacent cells on border tabpageTamás Zolnai
This adjacent cell settings is used only for Calc documents. Check box was hidden, but label was not. Change-Id: I6dcf3bb4ee316c9f3d653fc4f8f9dbcaf393e416 Reviewed-on: https://gerrit.libreoffice.org/36013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-31use actual UNO enums in svxNoel Grandin
Change-Id: I00f53260667861ca2595892b5605479da3401adb Reviewed-on: https://gerrit.libreoffice.org/35913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30Related: tdf#106080 support a 'none' color in search by formatCaolán McNamara
so we can show the initial no-color selected state differently than the automatic color default color Change-Id: Ib3020e507b1555cb446c2b501f60b67222dc115c Reviewed-on: https://gerrit.libreoffice.org/35863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29Resolves: tdf#106080 fix explicitly setting automatic in search by formatCaolán McNamara
this is still somewhat broken in that what you see is not what you get if you don't explicitly set automatic, but clears the regression part of things in that the old broken behavior is restored instead of the new broken behavior Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup itempool includesJochen Nitschke
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10 Reviewed-on: https://gerrit.libreoffice.org/35313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16remove unused defines from HRC files in cuiNoel Grandin
Change-Id: I170dfc5970896365322dedf4fb797478653578a0 Reviewed-on: https://gerrit.libreoffice.org/35250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>