summaryrefslogtreecommitdiff
path: root/cui/source/tabpages/tparea.cxx
AgeCommit message (Collapse)Author
2019-09-26now drop TabPageParent intermediateCaolán McNamara
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24now guaranteed to have a controller and not a vcl::DialogCaolán McNamara
Change-Id: Ic8ba0234d4b2e13d59d743e6f03a229756484131 Reviewed-on: https://gerrit.libreoffice.org/79442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-29tdf#42949 Fix IWYU warnings in cui/source/{options,tabpages}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b6fda67ef7de65cc7b468dded862cd47dfd4269 Reviewed-on: https://gerrit.libreoffice.org/78078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-25tdf#42949 Fix IWYU warnings in cui/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1b6e58623b64b11cb1a5ac5c7fba73e8cc04d07 Reviewed-on: https://gerrit.libreoffice.org/75522 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-18Avoid needless copy of itemMike Kaganski
Change-Id: Ifdf4f3559065dca5eeff61fffa9de223778691f4 Reviewed-on: https://gerrit.libreoffice.org/74238 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-17tdf#124549 Check Button toggle state before toggle.Shubham Goyal
Change-Id: I362cbc5613010e6586d63d6ebe45b40f05ffcbf1 Reviewed-on: https://gerrit.libreoffice.org/74117 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-31remove newly unused SfxTabDialogCaolán McNamara
Change-Id: Iebbfe2ab66ff6e058c90c85de747f549cbc36aa5 Reviewed-on: https://gerrit.libreoffice.org/73156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-07tdf#62699 Drop pass-through header file include/svx/xattr.hxxGabor Kelemen
Change-Id: I8db9a4de494fbd045a0f4da810c3887ce62dd350 Reviewed-on: https://gerrit.libreoffice.org/71595 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-29tdf#62699 Drop pass-through header file include/svx/xfillit.hxxGabor Kelemen
Change-Id: I6598d81b166486f3c48b119cc136b9f6e6c2a12c Reviewed-on: https://gerrit.libreoffice.org/71336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19drop some includesCaolán McNamara
Change-Id: I6f9765208e807da336146e55f0f1cbcb46316d4c Reviewed-on: https://gerrit.libreoffice.org/70935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-03various cleanups - no behavior changeTomaž Vajngerl
Change-Id: I28749d31ba272f26df9b79201cb106911692f6f7 Reviewed-on: https://gerrit.libreoffice.org/70199 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124155 change "gradient tab page" - increment & angle sliderTomaž Vajngerl
Remove slider for increments as the increments should better be left to "auto" and rarely modified (setting a value means it will use a limitied amount of increments, but auto effectively means as much as it is needed and can use the native backend for drawing). OTOH use a slider for setting the "angle" as it is already present in hatch tab page. Angle needs a slider as it is usually one of the main properties of a gradient (especially linear). Increase the tab pages a bit (10px on every side) to have a bit of breating space for all the widgets. Change-Id: I66167fe2c97b53bc3627237279332bdd59fb03d7 Reviewed-on: https://gerrit.libreoffice.org/70175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-20tdf#122943 Don't add properties to style when Highlighting and AreaJim Raykowski
...tab pages are simply visited Change-Id: I490275bf7e27160d312bb5b6ad7001298549f7e8 Reviewed-on: https://gerrit.libreoffice.org/69455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-17don't need m_aColorSizeCaolán McNamara
Change-Id: I27740ae0bff0d1676799ddfba76eab5e7a299f66 Reviewed-on: https://gerrit.libreoffice.org/69354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-17Resolves: tdf#124058 factor bitmap page into size req when its toggled onCaolán McNamara
post ctor time Change-Id: I8257c8ffdfc4dab9893ab7d2d67e218dd3f8097c Reviewed-on: https://gerrit.libreoffice.org/69353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02tdf#122790 Improve background tab page for writer tablesJim Raykowski
This patch improves the new background tab page use for setting Writer table cell, row, and table backgrounds. Now cell, row, and table backgrounds fill tab page according to the fill style of each and can all be set in the same opening of a Table Properties dialog. This patch also makes the Reset reset background settings to initial settings of dialog opening. Change-Id: I567ef9229232f02d98b45a81309e920dca854bed Reviewed-on: https://gerrit.libreoffice.org/66844 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-28GetDialogController not valid yetCaolán McNamara
Change-Id: I476744d8f351f4ab2afce5974355a066edc8a4a6 Reviewed-on: https://gerrit.libreoffice.org/68489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Related: tdf#123711 better optimal size for highlighting tabCaolán McNamara
it only uses the color subtab, so just measure ones which can be visible Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784 Reviewed-on: https://gerrit.libreoffice.org/68431 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18stray fprintfCaolán McNamara
Change-Id: I1bb4ee9354914db21d0440f83c156069a5efd9f9 Reviewed-on: https://gerrit.libreoffice.org/65355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-13Resolves: tdf#120481 gradient subpage 12 pixels too shortCaolán McNamara
because the max preferred-size of the subpages is taken and applied as the size-request of the container parent. But the container parent as a 6px border, so the subpages end up hosted in a parent which allocates them 12px less than they hoped for. As they are instantiated in the parent to measure them, measure their parent instead and that calculates in the parent's border to end up with what they wanted Change-Id: Ib270b90f9c2fed7f8bd042cc66d0d10ad3c6f183 Reviewed-on: https://gerrit.libreoffice.org/65058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01tdf#121083: EDITOR UI Hatch background color not read back from editorTamás Zolnai
Change-Id: Ic64fda8184a4cac244fe992dd72db9d67d35870c Reviewed-on: https://gerrit.libreoffice.org/62735 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-09-20SvxTabPage with a dummy PointChanged impl is just SfxTabPageCaolán McNamara
Change-Id: I520353fe1e4695f29e0646d52a492c3a63b90060 Reviewed-on: https://gerrit.libreoffice.org/60830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18loplugin:unusedfields improve search for unused collection fieldsNoel Grandin
look for collection-like fields that are never added to, and are therefore effectively unused Change-Id: Id52c5500ea5e3d2436fb5915aebb86278bf2d925 Reviewed-on: https://gerrit.libreoffice.org/60661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-13background tab reserves size for pages it never showsCaolán McNamara
Change-Id: I47e4b9481139bf05c4454712fa2f3f2d7cfbe10c Reviewed-on: https://gerrit.libreoffice.org/60415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld writer page style dialog and SvxBorderBackgroundDlgCaolán McNamara
writer, format page is complete Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45 Reviewed-on: https://gerrit.libreoffice.org/60058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06loplugin:simplifyconstruct in canvas..cuiNoel Grandin
Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14 Reviewed-on: https://gerrit.libreoffice.org/60074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03weld SvxAreaTabPageCaolán McNamara
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03weld SvxTextAttrPageCaolán McNamara
with a a11y rework to be more like the insert special char a11y also, route a11y questions about a custom widgets parent to the gtk toolkits underlying default implementation, keeping only questions about ourself to be handled by the XAccessible focus rectangles in RectCtl work again, seems that got lost somewhere along the way Change-Id: I62237d45668f4438aec6031cc5a48c38de21bf98 Reviewed-on: https://gerrit.libreoffice.org/53767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-22place an intermediate class as parent for SfxTabPagesCaolán McNamara
so a SfxTabPage can be parented by a vcl::Window or a welded native notebook tabpage. That ways the same SfxTabPage can be used at the same time in both a native dialog or a vcl dialog. The impl can be changed to the weld api, and when hosted in a native dialog the vcl impl of that will be instantiated, while native otherwise. e.g. print options appearing in print options dialog and general options. This allows incremental changeover. Change-Id: I6f1fed1e8d0898b01853bb878757bad41cbf9bba Reviewed-on: https://gerrit.libreoffice.org/53193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-07Pass full item set to bitmap tabpagesKatarina Behrens
Change-Id: I5d72b582f98538fdf5efe40bfca686dc0cdfc013 Reviewed-on: https://gerrit.libreoffice.org/52364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-07tdf#42949 Remove unnecessary localization headers from cuiGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<dialmgr.hxx\> cui | xargs grep -c CuiResId | grep :0$ | grep -v /pch Change-Id: I6229a59ea202fb6d95a34351d3fe742dfca4e6fb Reviewed-on: https://gerrit.libreoffice.org/52409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in canvas..cuiNoel Grandin
Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a Reviewed-on: https://gerrit.libreoffice.org/49642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: cuiStephan Bergmann
Change-Id: Ibd88b2ee4252733c5aeee97bec27f34b8e555364
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-06-23loplugin:unusedfields in cuiNoel Grandin
Change-Id: I6d3ef43ab915d65794f1052f1f184eda10d39e1a Reviewed-on: https://gerrit.libreoffice.org/39136 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12Get rid of last remainders of SetPos nonsenseKatarina Behrens
Change-Id: I6ebff09322e40adfc616a9003424fd1d4ff748ce Reviewed-on: https://gerrit.libreoffice.org/38629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-08tdf#107087: Select bitmap fill from preset listKatarina Behrens
Also remove member variable that is used just once Change-Id: I369299aed75a3b44048aa09ba86b79e552cf6d14 Reviewed-on: https://gerrit.libreoffice.org/38551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-19This doesn't have to be member variable, it is used just onceKatarina Behrens
and then forgotten again Change-Id: Id94639415bd1679b67d5d3094dee8b8f8f3d3167 Reviewed-on: https://gerrit.libreoffice.org/36690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-16remove unused defines from HRC files in cuiNoel Grandin
Change-Id: I170dfc5970896365322dedf4fb797478653578a0 Reviewed-on: https://gerrit.libreoffice.org/35250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06tdf#103847: Pass also XFillStyleItem to subtabsKatarina Behrens
this resolves the issue of non-preset gradient and hatch values not being shown. Bitmap is still broken (beyond repair) Change-Id: Ifad8f3a56b534e26def69c0b0bb2ed55de53bcda Reviewed-on: https://gerrit.libreoffice.org/34908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-20tdf#103224: Get the initial colour rightKatarina Behrens
Change-Id: I59309f5b433eb7aa92d05ce7d373d69cb413b258 Reviewed-on: https://gerrit.libreoffice.org/34383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-09tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-15tdf#104221: Make up for non-existent FillItemSetKatarina Behrens
for fill:none option Change-Id: I12ada9276a613f157976650148f2389126d16f08 Reviewed-on: https://gerrit.libreoffice.org/32050 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-12Mark as localTakeshi Abe
Change-Id: Ic8ed367a5774eb3a939163fb1c1fe9518c3d7d2d Reviewed-on: https://gerrit.libreoffice.org/31855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
generated by cgit (git 2.34.1) at 2024-08-19 00:05:34 +0000