summaryrefslogtreecommitdiff
path: root/cui/source/tabpages
AgeCommit message (Collapse)Author
2015-04-23tdf#82784: cui: Area tab page: do not override imported bitmapsMichael Stahl
Check that we don't clobber a custom bitmap in the dialog. The (non-obvious) trick is that the name of these is non-empty, so we can check that to filter out pool default items that Draw likes to put into item sets (?), as well as just plain weird items that Draw likes to put into item sets, while avoiding relying on the surprisingly implemented ImpGraphic::operator==(). (regression from 38d0047da7f964c862360b48d88cc869ad376b6b) Change-Id: I0b94e49ef3a9a32c188c3b117a57f780f55e1584 (cherry picked from commit 171fb61c6526daf83d6948a543a1614215590946) Reviewed-on: https://gerrit.libreoffice.org/15371 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-04Follow-up tdf#84288: call SetRectangleAttributes only onceKatarina Behrens
cherry-picking code from master (4.5) branch to 4.4 branch sadly didn't remove/replace the faulty m_pCtlXRectPreview->SetRectangleAttributes line b/c 4.4 code calls it a bit earlier. I noticed too late and dtardon was too quick with merging. Change-Id: Ib6e43c4475aacd5d87d9b82f321c24386187b736 Reviewed-on: https://gerrit.libreoffice.org/15114 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-04tdf#84228: Fix annoying double shadow in previewKatarina Behrens
SfxItemSet passed to ActivatePage method contains both rectangle AND shadow attributes, causing the old shadow to stick around even after new shadow attributes have been set. Thus, set shadow to none in a local copy of SfxItemSet and use that one to repaint the rectangle Change-Id: If798351fbecaaf951ef0479ae4a2c70d2db68ca4 Reviewed-on: https://gerrit.libreoffice.org/15099 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-12-25Resolves fdo#87581: Pb to delete words with 2 initials in Autocorr ExceptJulien Nabet
Cherry-picked from a5811c70bb443190a76a52585580659f96a58a04 Change-Id: I49b97c5c1546f0410542cb67540c5507c95bec98 Reviewed-on: https://gerrit.libreoffice.org/13618 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-11-28fdo#70861: cui: fix crash in SvxExtParagraphTabPageMichael Stahl
SvxExtParagraphTabPage::Reset() must not request a pool default for SID_ATTR_PARA_PAGENUM because it simply does not exist; the item is backed by a member of SwPageDesc in Writer. Change-Id: I9b157f048cd986566f9b01f3677b53d5974b6c8d (cherry picked from commit 9c1a1b98776ca2216d82af303394a09f2bac0471)
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-05Use basegfx library function to clamp numbersKatarina Behrens
Change-Id: I3142f55ecf94ce2143e92492243bc5959322704f
2014-10-30Remove checks for HTMLMODE_SOME_STYLESHarri Pitkänen
HTMLMODE_SOME_STYLES is enabled for all supported HTML export modes so there is never need to disable these elements in the paragraph dialog. Change-Id: I43df54a6ce900c8a9f957522eb85ca67b6cd756f Reviewed-on: https://gerrit.libreoffice.org/12091 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28loplugin: cstylecastNoel Grandin
Change-Id: I287dcb0ca728747ec91b5c3cdd986e60998e3928
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02coverity#1242752 Uninitialized pointer fieldCaolán McNamara
Change-Id: I3485a29fe5ce88834b2ef0d30b9c32516befa0ff
2014-10-02coverity#1242766 Unused valueCaolán McNamara
Change-Id: If7d33882d612788fba051ebae56468b80e96e09f
2014-10-02coverity#1242785 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic97bd7c3fa2f192113d702f9338cb3eaeae6109c
2014-10-02coverity#1242826 Uninitialized pointer fieldCaolán McNamara
Change-Id: I6292d16d8925aa8562942a016bb02ba3785196a3
2014-10-02coverity#1242829 Uninitialized pointer fieldCaolán McNamara
Change-Id: I902d5ed03979264b9d228f91a4a50b912a1eade5
2014-10-02coverity#1242909 Unused value and const things upCaolán McNamara
Change-Id: Ib98a81a04f721917ee3c1fdd19d23a37c5d2c481
2014-10-01coverity#1242928 Uninitialized pointer fieldCaolán McNamara
Change-Id: I841306c664ddc5d81ce1c84357de3b2daf32964a
2014-09-25fdo#78783: fixed init position to 1 and using cssStefan Weiberg
Change-Id: Ib7c62ce23290056c42bfa89fbac91212e7ae0ab6 Reviewed-on: https://gerrit.libreoffice.org/11409 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-08-25Consistency around SdrMetricItem in svx/sderitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I4a0715b18bc3aa032779252cad2450c905a467a4
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-18Consistency around XColorItem in svx/sdshcitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18Consistency around SdrPercentItem in svx/sdshtitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I4e98c362f811c19f03766d0c78f10c795d3ac79d
2014-08-18Consistency around SdrOnOffItem in svx/sdtcfitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18prevent out-of-bounds string accessEike Rathke
... while entering a * star symbol format code and there's no fill character following the * yet. Change-Id: I006f125ceefccba6a95ea033fd434d98e5d4f1c2
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18ErrorBox->MessageDialogCaolán McNamara
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18Consistency around SdrMetricItem in svx/sdsxyitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on. Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as return value in case of failure and in the related tests. Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-15fdo#48110 disable the "Automatically" currency unless already usedEike Rathke
This disables the "Automatically" currency listbox entry in the number formats dialog and makes it unselectable, unless such currency format was already used at the current position of a loaded document. Getting completely rid of the listbox entry if not used is more cumbersome as the positions are tied to the list entries in SvxNumberFormatShell::aCurCurrencyList, but at least the disabled entry prevents accidental or ill intended selection of that awkward format. Change-Id: I16f3e88feede34e3f83afb108f253fb53d82d34d
2014-08-12fdo#41350 "Expand Single Word" only shown active for "Last line: Justified"Joren De Cuyper
Change-Id: Ibe90d041f15fd007026676ea626c672a9805b263 Reviewed-on: https://gerrit.libreoffice.org/10656 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-10cui align: no need for OLocalResourceAccessThomas Arnhold
Change-Id: Id500403fb70787cd856e2413d7a8e9a949942ac0
2014-08-07Consistency around SdrMetricItem in svx/sxmlhitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I65c36bde166c5f78db8c76364fd057017982fed6
2014-08-07Consistency around SdrYesNoItem in svx/sxmsuitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
2014-08-06Consistency around SdrMetricItem in svx/sxelditm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." (SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly ---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing SdrEdgeLine1DeltaItem::Clone override" before 3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless derivation of SdrMetricItem.) Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
generated by cgit (git 2.34.1) at 2024-06-23 04:51:34 +0000