summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)Author
2021-05-19use toggle instead of click for RadioButtonCaolán McNamara
only listen for one toggle for the button grouping Change-Id: I0c1866c25793ffce50bcf5f5a07fcdc98f64aacc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19use toggle instead of click for RadioButtonCaolán McNamara
only listen for one toggle for the button grouping Change-Id: I937331aebc2391e4026f69f16f9c7c9216981d0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115817 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19tdf#142317 chardlg UI: show approx auto-esc % based on EscPropJustin Luth
Subscripts and Superscripts normally have "automatic" enabled. The value shown (in the greyed out raised/lowered by field) was showing 8%. Well, that value is true only for default nProp of 58%. If nProp is a non-default value, it is better to show (an approximation) of the actual percentage that is used to raise/lower the character. [Note: this only affects the initial view when the dialog is first opened. After any changes, it will show the value in the saved user settings.] Change-Id: Ife26e0c4f99a41e7568591f0a60cc7068dc3fd90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115739 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-18tdf#112369 allow to disable the add command button in menu customizebaltasarq
Instead of showing an alert dialog reporting that a command is already present in a given menu, enable or disable the add command button when needed. Change-Id: I52b9477896d4775ae2033c057fa1b5bfccb6a749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115057 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-05-18tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to openMatt K
The Tip-of-the-Day dialog is made non-modal and stays on-top of the main window while allowing the user to interact with the rest of application. Change-Id: I51e1a3488ab74d8371b71a8585d1512ce051f637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113782 Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-17gtk4: reenable buttonCaolán McNamara
rename label_line_wrap to label_wrap while I'm at it Change-Id: I3964c4b40d86fb6ef1fd3733088ffd80e57415ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-14gtk4: advertise as gtk4 not gtk3Caolán McNamara
Change-Id: I7f38238109f79cc8b87d41999a8355879761a894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11fix leak in SvxHpLinkDlgNoel Grandin
Change-Id: Idefd194a81585efc09d38593a6e40f77733d06ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11tdf#84502 CuiConfigGroupListBox Macros,Styles like category for SidebarJim Raykowski
Decks Change-Id: I4d41952547c98ba66c40c1aa1e9776cdf31304c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100455 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-05-06use Widget::get_clipboardCaolán McNamara
there's no different from GetSystemClipboard except potentially for the libreofficekit case where per-frame clipboards are possible Change-Id: I3173e39f81a03a7cbe114ebca6020d5ed36a659a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05tdf#141935 svx cui: apply line cap setting of line stylesLászló Németh
Only line dash pattern of the selected line style was applied on the selected line or shape using the 1) Line Style popup menu of Drawing toolbar and sidebar pane Properties and 2) Style popup menu of Line pane of Line setting dialog window. Now both line dash and line cap settings are applied, supporting the usage of the new "rounded" preset styles and the old not "rounded" versions. Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac "tdf#141933 add preset dash styles with round cap". Change-Id: Ib3f64afcdcb50545166d40476a03a4b45f7d0b8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114461 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-04tdf#141202 Set "Ctrl+Alt+=" as the default shortcut to insert Math objectsRafael Lima
Change-Id: I8a0dcfcac1f7e6d5d5efdec8091dadf3b3c098c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112962 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-29rename ECKEN -> CORNERNoel Grandin
Change-Id: I24438213431bd2866e2bcefc8a054a03bc975ef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29freeze without thawCaolán McNamara
which was already SetUpdateMode(FALSE) without matching SetUpdateMode(TRUE) in: commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui and then remove the outside freeze/thaw pair, which may in practice have worked around the unbalanced inner freeze/thaw, from SvxEventConfigPage::SelectHdl_Impl in favour of the inner freeze/thaw so the select can work on a thawed treeview Change-Id: I6dbcfd000f717047354e7cdcfb9b3a502e1fbbe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29remove support for BITMASK in vcl backendsNoel Grandin
Rather use a proper alpha channel if we need transparency. This is another small step towards merged alpha in our vcl layer. I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation. Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29tdf#135997: make sure that the two lists are same lengthMike Kaganski
This fixes the strange assumption that when searching the two lists (character names and font names) independently, the two found positions will necessarily correspond to each other. Instead, the positions of the match must be the same, which is implemented now. Also the input from configuration is sanitized. Change-Id: I920de7414387e181e11183b8a22776a72b6be419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114722 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-28use string_view in INetURLObject::encodeNoel Grandin
Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27tdf#137470 use a more proper URL for the extensionsChristian Lohmaier
also hide the download-count, since those numbers are completely made up by the script Change-Id: I15b53a8a023c34ecc6a544b88ad35800891e4327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114740 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-04-27tdf#138751 Localize items in Notebookbar customization dropdownsGabor Kelemen
Change-Id: Idb1483e083f7758acb83da6c3ca9403c40ac9a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114447 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27Related: tdf#130326 allow bulk_insert_for_each to insert under a nodeCaolán McNamara
Change-Id: Iad14638a33710ef0b790c702e7eab2283726f2fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114571 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-23this Sequence can be a std::vectorNoel Grandin
Change-Id: I678db4ed598b3e1061857e942185b2307fbb9e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22Resolves: tdf#141721 text from 1st col not clipped if 2nd col is emptyCaolán McNamara
Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20use OUString::Concat here, not OUStringLiteralNoel Grandin
Change-Id: Ia2172bcab60f32c9d9d4f6ca0230484343eef69b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-19use more string_view in comphelper::stringNoel Grandin
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-16Remove description from mobile macro selectorSzymon Kłos
Change-Id: I76d9a73c65d0c7759b56a3d7b69aadf5b58d7da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112327 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114206 Tested-by: Jenkins
2021-04-16Remove unused code from Macro Selector dialogSzymon Kłos
Change-Id: I9930fd7eaf2410447f84aa4798478a10915ea738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114205 Tested-by: Jenkins
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09remove vcl/waitobj.hxxCaolán McNamara
create vcl/locktoplevels.hxx for the utility to set all toplevel windows modally locked Change-Id: I964484d238852e830e1e5c0b86b3bebb3b41a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09-Werror,-Wreorder-ctor (clang-cl)Stephan Bergmann
Change-Id: I3c5fd8e875c6c0d36e97d76b0c51308799eeb351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09Recheck include/ with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-07lok: async exception dialog messages for VBA macrosHenry Castro
Change-Id: Ia713343541f8102de85f7ac57202780afba3da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111855 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113686 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07lok: fix the empty script node type container without "+" symbol expanderHenry Castro
According to description in https://bz.apache.org/ooo/show_bug.cgi?id=30923 "In this case I think it's an acceptable solution to display a '+' symbol for all library nodes, and if a library has no children and the user clicks on the '+' symbol, the '+' will disappear". Unfortunately this behaviour is not well driven for final users' client side, so they misinterpret as a bug. After tracing the method hasChildNodes(), the log result indicates that this method does not load the libraries, but it is necessary to iterate applying the method getChildNodes(), which will cause to load all libraries and determine if the child has a script CONTAINER node type to assign the '+' symbol. Also, I have traced the loading libraries when the Macro Selector dialog pops up and the result it load once, so I do not think it is a problem loading a small finite number of libraries today. Change-Id: I4ae5395b6afa7b7d6ff2b2ec692771e93c46c529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112636 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113693 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05Related: tdf#141499 don't grab focus during teardown of dialogCaolán McNamara
Change-Id: Ib55825294b4276cf36d7ce13562dc52b71f2a5bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-02vcl: remove GetBitCount and GetColorCount from Bitmap{Ex}Tomaž Vajngerl
We can cast the PixelFormat enum to int for the same information and we can use the enum to reduce ambiguity when possible. Change-Id: I6ea648139465568cdeb12e5f5f75c7b609365bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113188 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-01tdf#141333 use a vertical step increment of one row heightCaolán McNamara
for font feature scrolled window Change-Id: I000d53af7128377930644591a096c94366da281b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-01tdf#140343 sw page rtl gutter margin: add UIMiklos Vajna
And extend SwFrame::UpdateAttrFrame() so that the layout is updated when the UI mutates the doc model. Change-Id: I4112388981187226f97ec39f4c44ffb3cc1e5253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113440 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-30tdf#140839 - TotD image sizeHeiko Tietze
Previous size of 100x120 has shown to be too small for thumbnails so we agreed on 150x150 Change-Id: Ia43bc424a164024e8a4ecf851cad3fab4f342e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113343 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-25tdf#134734 tdf#141059 tdf#122508 cui,sw,xmloff: BackgroundFullSizeMichael Stahl
* add BackgroundFullSize property to PageProperties * add a checkbox on the SvxPageDescPage * marshal the item via SfxGrabBagItem to avoid changing svxids.hrc * add RES_BACKGROUND_FULL_SIZE item, pool default is "true" which is appropriate for Word import filters * ODF export: remove hard-coded export in XMLPageMasterExportPropMapper::ContextFilter() * use it in SwFrame::PaintSwFrameBackground() * fix painting of bitmaps by also using the page frame area in SwFrame::GetBackgroundBrush(), which was the reason why f006b6339e20af6a3fbd60d97d21590d4ebf5021 painted things inconsistently * force repaint in lcl_DescSetAttr()/SwFrame::UpdateAttrFrame() Change-Id: I4cb64f87c01d17c051936e9b8128395fbb8b4fe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112594 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-24QR Code Dialog: Change term 'border' to 'margin'homeboy445
This adds a margin around the qr code (white space), not a border. Change-Id: If3e74dfe19dd7f9c063eaa6439810d617a99cb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112831 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-21Fix GenerateQRCode when ENABLE_ZXING is not definedChristophe JAILLET
Since commit 562d7767f987, 'GenerateQRCode()' returns a OString, not a OUString. Fix the case where ENABLE_ZXING is not defined. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Change-Id: I29d9c559401b49caceb8a8941bbe9962b489e3f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-21Avoid OUString-to-OString conversion: just generate OStringMike Kaganski
Change-Id: Ied47aa0ca42a73715678482424d7d593d18d25aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-20tdf#139778 Switch to ZXing for generating QR codehomeboy445
Change-Id: Ief944266d5183bb862afe99ec6b0bdaca4956938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112534 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-01 12:06:43 +0000