summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)Author
2020-01-01weld PageStylesPanelCaolán McNamara
Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-31tdf#108458 related: Make command tooltip show in tooltipJim Raykowski
Make Customize > Keyboard > Function TreeView show command tooltip in the tooltip. Change-Id: I5d2ca7090e00d7c18d792da73c567cdfd6895da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85776 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-30rename SvxDialControl back to DialControlCaolán McNamara
Change-Id: I4dcf12b6eccf18a0659c5d5f9cd58bd104c4dc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-29tdf#124176 Use pragma once instead of header guarderto
Change-Id: I904c2b37a51c03d51503c0b460201392ec8894a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85628 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedmethodsNoel Grandin
Change-Id: Iad97bdbcbec4cbbccf3df9b9d682e744b0c1982e Reviewed-on: https://gerrit.libreoffice.org/85709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedfieldsNoel Grandin
Change-Id: Ib2314f23efe953398ed0a5e88305842c812e18bb Reviewed-on: https://gerrit.libreoffice.org/85708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20tdf#124176: Use pragma once instead of include guardsSıla Genç
Change-Id: I88d5517d42b6c5b6809f062a789e7dd85394f6db Reviewed-on: https://gerrit.libreoffice.org/85601 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#124176: Use pragma once instead of include guardsSelim Şeker
Change-Id: I626d4a08161a6c81b4bb014d847f0c05d90fda35 Reviewed-on: https://gerrit.libreoffice.org/85449 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#108458 Show tooltips in CuiConfigFunctionListBoxJim Raykowski
Change-Id: I6644e939c644c827e2b3ad019b975a3845585063 Reviewed-on: https://gerrit.libreoffice.org/84555 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-19tdf#124176: Use pragma once instead of header guardBatuhan Görkem Benzer
Change-Id: I720508aa4bfd77f15b5d713e4d948b06af0be4c2 Reviewed-on: https://gerrit.libreoffice.org/85414 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsMesut Çifci
Change-Id: I377809c01053ebaf2fe004478e144509adbbdd1f Reviewed-on: https://gerrit.libreoffice.org/85416 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: I47be8a0488b7ff7ce176f10aaf90b8be6913cc8a Reviewed-on: https://gerrit.libreoffice.org/85412 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsOnur Yilmaz
Change-Id: I2f58499164254eab1d2f628b3b64710e1d2efbeb Reviewed-on: https://gerrit.libreoffice.org/85415 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsDesmin Alpaslan
Change-Id: Ib14b28a9508b28460a6063f7ddd322869823b49a Reviewed-on: https://gerrit.libreoffice.org/85413 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsKemal Ayhan
Change-Id: I8f8641d41a3c394c494d0e5f6cd5a06949e22fa6 Reviewed-on: https://gerrit.libreoffice.org/85410 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: I1f6d66a0d4a06338671579e9be2dbdc5cd673d50 Reviewed-on: https://gerrit.libreoffice.org/85411 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsMuhammet Kara
Change-Id: I3df73c321efa7fa3e8a87608c3c7189f7d839ac8 Reviewed-on: https://gerrit.libreoffice.org/85384 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18sal_Char->char in cppcanvas..cuiNoel Grandin
Change-Id: I7e9fa7011f1e0bf143f86055718c772caebf8ee6 Reviewed-on: https://gerrit.libreoffice.org/85397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#127294 Remove spaces; follow design guidelines for tips-of-the-daySeth Chaiklin
- converted to design guidelines all quotes all menus items apostrophe (U+2019) em-dash (U+2014) minus (U+2212) expanded contractions - Corrected spelling and grammar mistakes. - Simplified wording in some tips - tried to clarify uri explanation in relation to help Change-Id: Ic9984fdc09813d2b43324a104d5c30420671c6b9 Reviewed-on: https://gerrit.libreoffice.org/85228 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-17Fix macro security UI usability problemsJan-Marek Glogowski
* Don't hide the option dialogs "Macro security" push button. I don't see any reason, why these settings should be hidden, if macros are disabled or settings locked. At least a user can now check, what is going on (still nothing shows disabled macros for a document in the UI AFAIK). * Don't scale the lock icons of the trusted list boxes. This just uses the same alignments, which the macro security level lock image uses, otherwise the image is scaled to fit the whole space of its layout cell. * Don't disable the trusted list boxes. If the setting is locked, it's sufficient to disable all the buttons, which allow modification (so View can stay enabled). This way you can still scroll the list. Correct button handling is already implemented and works for me. * Catch exceptions of broken certificate data. If your config contains certificates, which can't be correctly decoded, the NSS backend will throw an exception, which kills the dialog, but not the nested loop, resulting in a locked LO. Also show an error dialog with the broken base64-encoded data. Change-Id: I79002e0ce85cf9a9017caf858407f2f635a3a074 Reviewed-on: https://gerrit.libreoffice.org/85056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-17ui: show wait mouse pointer on operations in Expert ConfigurationVasily Melenchuk
Expert Configuration is loading, resetting and searching values very slowly, so will be great to indicate busy status to user. Change-Id: Ic0d428d01a9f71ff899979162e1b307cd7cd7401 Reviewed-on: https://gerrit.libreoffice.org/85242 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-16Related tdf#105225: Remove old background tab page codeJim Raykowski
All uses of SvxBackgroundTabPage have been replaced by a new background tab page derived from the SvxAreaTabPage. This patch removes the SvxBackgroundTabPage code and code used only by it. Change-Id: I83a2a04c0bf908cdc630fa091cd5ccdfb5d9381d Reviewed-on: https://gerrit.libreoffice.org/85194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-13size group is ignoring hidden widgets, leading to labels overlapping entriesCaolán McNamara
https://developer.gnome.org/gtk3/stable/GtkSizeGroup.html#gtk-size-group-set-ignore-hidden "Measuring the size of hidden widgets ... they will report a size of 0 nowadays, and thus, their size will not affect the other size group members" Which is unfortunate. So before we hide any labels, take the size group width and set it as explicit preferred size. Change-Id: If7c0f1ebd9f03914c74fde85b876549de76853c2 Reviewed-on: https://gerrit.libreoffice.org/85097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13loplugin:expandablemethodsNoel Grandin
Change-Id: I333d91ea5ce78c82e9bb107f934614efc7bfb8f7 Reviewed-on: https://gerrit.libreoffice.org/85078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12theChild->getName() already available as uiNameCaolán McNamara
Change-Id: I2792b2ac4f0d17dfc2fe68eeacb4dee2173fe5d2 Reviewed-on: https://gerrit.libreoffice.org/85068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12children[n] already available as theChildCaolán McNamara
Change-Id: I3eeb072ff393033fb681956b4ac7fe1c71745a0d Reviewed-on: https://gerrit.libreoffice.org/85067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12tdf#105225 New UNO and Writer Web background tab pagesJim Raykowski
Change-Id: Id3e7d1c24d086624f053085e3134792b95188c23 Reviewed-on: https://gerrit.libreoffice.org/64991 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-11Related: tdf#129300 clear properties that are set back to their original stateCaolán McNamara
Change-Id: Ic957afbdcf6decef07d15fa10a560e560de5795a Reviewed-on: https://gerrit.libreoffice.org/84951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScIndentItem to provide a descriptionCaolán McNamara
Change-Id: Ieb1a12f35cf8974c557c6e52eac0cd9fb7f80914 Reviewed-on: https://gerrit.libreoffice.org/84945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScHyphenateCell to provide a descriptionCaolán McNamara
Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4 Reviewed-on: https://gerrit.libreoffice.org/84892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScLineBreakCell to provide a descriptionCaolán McNamara
Change-Id: Ief739616163c68e0e30d6287fdac90c1bcc9d13f Reviewed-on: https://gerrit.libreoffice.org/84879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScVerticalStackCell to provide a descriptionCaolán McNamara
Change-Id: I8ed99f19ff6f4751c0867147fc1a60ac917f083b Reviewed-on: https://gerrit.libreoffice.org/84876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 make Automatic/Distributed state what is automaticCaolán McNamara
Change-Id: Ib246479761556858e92052edf86a18753d44c583 Reviewed-on: https://gerrit.libreoffice.org/84893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11tdf#129300 If it would create no change, don't force itCaolán McNamara
otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-10missing include (Windows --disable-pch; Translate::ExpandVariables)Stephan Bergmann
Change-Id: Iab20b7e8d7975615c128deb8d02940ede1e8ddd7 Reviewed-on: https://gerrit.libreoffice.org/84862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-10Related: tdf#129300 add ScShrinkToFitCell to provide a descriptionCaolán McNamara
Change-Id: I628562f1013825e5ba3c0daaf5ee6b098616b6d0 Reviewed-on: https://gerrit.libreoffice.org/84866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-10Related: tdf#129300 add ScRotateValueItem description in degreesCaolán McNamara
by inheriting from SdrAngleItem Change-Id: Ifcaf46b12d685e683984e15ba2264c191c0d1e5f Reviewed-on: https://gerrit.libreoffice.org/84847 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-10force vclcanvas use with Skia, like it's with OpenGL (tdf#129076)Luboš Luňák
Related to tdf#93870. Change-Id: Ie0cb64c05c0fde6a774ce8558d06943870e775fe Reviewed-on: https://gerrit.libreoffice.org/84758 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-09drop newly unused SfxFloatingWindowCaolán McNamara
Change-Id: I8ac3957579c76a89b9692bdb50cbe7a56e1693e3 Reviewed-on: https://gerrit.libreoffice.org/84444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-08Resolves: tdf#129243 check return to see if results validCaolán McNamara
Change-Id: Ia4169cda3c1a596ceedd074dd0e59898f9c72ff9 Reviewed-on: https://gerrit.libreoffice.org/84695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06Resolves: tdf#128923 should be able to change attributes of multiple lines...Caolán McNamara
without changing color Change-Id: I76cf21af4611afc11bf1861abe7d0b903362e798 Reviewed-on: https://gerrit.libreoffice.org/84637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06tdf#121658 Add option to not hyphenate words in CAPSSamuel Mehrbrodt
* Add checkbox to pagraph dialog * Store property in paragraph model * Move docx import/export from grabbag to paragraph model * Add ODF import/export * Add ODF unit test * Add layout test Change-Id: Id4e7c5a0ad145c042f862995d227c31ae2aa0abd Reviewed-on: https://gerrit.libreoffice.org/83979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-12-06tdf#127305 display selected text in URL field QR Code Dialogshubham goyal
Change-Id: Ic0d36225cc2c509c706a4599d45b92c6b9fea40e Reviewed-on: https://gerrit.libreoffice.org/78879 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-05Remove some unused friend declarationsStephan Bergmann
...which no longer find the befriended classes anyway (and would need to e.g. be rewritten using non-elabortated type names if they were still relevant) after f853ec317f6af1b8c65cc5bd758371689c75118d "Extend loplugin:external to warn about classes" moved the befriending classes into (unnamed) sub-namespaces. (Except on Windows, but where clang-cl now flagged them with "error: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Werror,-Wmicrosoft-unqualified-friend]".) Change-Id: Iad7a184dbb62b130f6d93693c16cfd5c9b08fcc1 Reviewed-on: https://gerrit.libreoffice.org/84578 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03tdf#129134 ApplicationColors Scrolled List moves too littleCaolán McNamara
Change-Id: I5cb6ac017f1d2a916297676724d523634afb2020 Reviewed-on: https://gerrit.libreoffice.org/84252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-01Resolves: tdf#129119 no SfxViewFrame in startcenterCaolán McNamara
Change-Id: I16d8207314146df3dd7f5b11182650066cc97fde Reviewed-on: https://gerrit.libreoffice.org/84148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>