summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)Author
2022-03-14add TypedWhichId version of QueryStateNoel Grandin
Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-10tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroGautham Krishnan
Change-Id: If35c679839b39a01e474f7b0b0abee570e85bdd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130798 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-07do not pass XComponentContext to officecfg::...::get() callsLuboš Luňák
It's used only for the ConfigurationWrapper singleton, so it's used only the first time and then ignored. It also causes calls to comphelper::getProcessComponentContext() for every single invocation despite the value not being needed, and the calls may not be cheap (it's ~5% CPU during ODS save because relatively frequent calls to officecfg::Office::Common::Save::ODF::DefaultVersion::get()). Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-04cid#1500632 Using a moved objectCaolán McNamara
Change-Id: I5e7dd51c9f9b2b295ded161307bbe9a6a23c42de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130997 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-01use SfxItemSet::GetItemIfSet in cuiNoel Grandin
Change-Id: I0a6dbf50d29adf9da9512a9136709bf563e478f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-25Advanced Diagram support: cleanup/consolidate with existing codeArmin Le Grand (Allotropia)
Reorganized and streamlined, use IDiagramHelper as main interface now also for existing code. Had to adapt oox::Shape && Diagram handling since there the import gets handled very different. This ensures that a Diagram is detected at export and that the same happens for now as before Had to add a detection that resetting the GrabBag is meant to disable the Diagam functionality. That is very indirect, but has to stay for compaibility reasons for now Change-Id: I620b7d61cd84b5f9dd8ae4dc890ebf70ce779cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130389 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-24use more TypedWhichIdNoel Grandin
Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-22Advanced Diagram support: first additions/reorganizationsArmin Le Grand (Allotropia)
To allow advanced Diagram/SmartArt support in the future this is a first step to organize imported SmartArt Data in a way that will allow to re-layout loaded SmartArts, under re-usage of the oox::Theme (held available). It is designed to work without holding available the original XML snippets defining the imported Diagram in any way, also for performance reasons. It tries to re-use some of the already basically added functionality, including the systematic layouting using the generic layout algorithm, plus some already available text extraction. Before being sure that the former state can be completely replaced this is optoinal and used when SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff is already done but e.g. the redefined reLayout method will not (yet) be triggered. It works and reliably produces a re-layouted identical version, also preserving transformations. Change-Id: I08cfbae04afa663d0589530aae549216d853128d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-02-21cid#1500465 Dereference after null checkCaolán McNamara
Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17sd theme: add doc model for shape fill colorMiklos Vajna
In preparation of adding UNO API for this. Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130050 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-15add typed GetWhich operationsNoel Grandin
to reduce boilerplate at call sites Change-Id: I290c2bf60ad5e6ddb000aa26cf543830ed39120a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-14sw: prefix members of ConditionEdit, SwView, SwXFilterOptions and ...Miklos Vajna
... SwXViewSettings See tdf#94879 for motivation. Change-Id: I68f647d13edf156cfc471a54f247ac686cd6cd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129893 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-14cui: show image pixel size below logic sizeTomaž Vajngerl
Change-Id: If919d1fade2ed85aec7437b429a648ca658e2c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129885 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-14cui: prefix member variables of SvxGrfCropPage classTomaž Vajngerl
Change-Id: If6f4a32df97c352d30958fb27dc90ffec5bbf44d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129884 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-10add more TypedWhichIdNoel Grandin
Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-06Simplify sequence of PropertyValue in cui/editeng/extensionsJulien Nabet
Change-Id: I0c8f46d2671f3623ff3dd1ee6ec84cde7db41003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129580 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-06Simplify sequence in cuiJulien Nabet
Change-Id: I47e6e6bd2743a380bb316612230bd1e968ed7084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129568 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-04use some more add toId/fromIdCaolán McNamara
Change-Id: I3a21e2aa5a2c482c0bac1d4c9bf84f8b56261408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04add toId/fromId to tidy up some ugly castingCaolán McNamara
Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton valuesCaolán McNamara
for these cases where draw wants to massively scale the units the underlying "metric conversion" are already using sal_Int64 anyway Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-03tools::Long -> sal_Int32Noel Grandin
Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29used TypedWhichId in the constructor of various svx *Item classesNoel Grandin
to act as an extra check that we have the association of Item and TypedWhichId annotations correct. (*) requires that I add an upcasting constructor to TypedWhichId (*) Make the field dialog stuff in writer use a new item id FN_FIELD_DIALOG_DOC_PROPS instead of abusing the existing SID_DOCINFO Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-28no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic4f1b13e1f35f7e67195a12c727ea2f088f8ddc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemEntryInfo stuff in the pool) Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27add some more TypeWhichId annotationsNoel Grandin
and update the idl compiler to cope with namespaced class names Change-Id: I7b5242f872e358bc3c5584f543767719172aac83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27Resolves tdf#128258 - Draw a dotted line before hidden columns/rowsHeiko Tietze
Color and on/off configurable via Tools > Options > Application Colors Change-Id: Ia4b1e1c86f36d1b0f508a5b3e866a79418f16c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128553 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-24gtk4: adapt to window_[g|s]et_default_widgetCaolán McNamara
Change-Id: I916e5db05f8ea10ecc8b319cc77a671ca7cbcb93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128859 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20Move credits link to configSamuel Mehrbrodt
as all other related URLs and replace with a hub link, see https://redmine.documentfoundation.org/issues/3569 Change-Id: Ic30f2a5980ae17b5dfff184ead391b21cff7ab7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128660 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18tdf#146612 Drop confirmation question when applying new doc hyperlinkGabor Kelemen
To be consistent with other tabs of the dialog where Apply does not show a similar question Change-Id: Id3bced8ec861b7166974da5ad223513dbfec25c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128424 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-18Use "smart" INetURLObject ctor for user input right awayMike Kaganski
... instead of trying to process it strict, falling back to smart processing on error. Similar change was implemented to SvxHyperlinkInternetTp in commit 6b973753d407d66dfa5fda86547246c486ab7087. Trying to parse it strict initially there resulted in wrong detection of "generic" protocol in incomplete URLs missing scheme and having port. This change simply unifies the code, no specific behavior change intended. Change-Id: I48ba4187a27644f42f3fd5a3b6cd77e55038cb0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-14tdf#146703 Rework previous fix to query extension metadataGabor Kelemen
to limit its error potential by encoding only the category string Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-13Recheck modules [a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-12tdf#142564 Localize extension category namesGabor Kelemen
Change-Id: I57ca7cb194bd325f621841edc24e3af9ef7c3b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128305 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12tdf#146703 Fix URL encoding when querying extensionsGabor Kelemen
so that extension information files are properly downloaded such as: https://extensions.libreoffice.org/api/v0/Color Palette.json Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-11tdf#145919 Localize strings in Graphics Test dialogGabor Kelemen
but not in the saved log file Change-Id: I65c580e7b8762b654f1812c96bc53841b882a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128087 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-10cui: no need to fetch the property from the map twiceTomaž Vajngerl
Change-Id: I7597c352b2ae166657f1e431e3405fc690520afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128206 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-08fix Options->LibreOffice->View->Visibility->Menu on Windows,Noel Grandin
impossible to set to Hide, regression from commit 131759a3db51140c21594308ed99c71aa7aba43a Date: Sun Jul 25 16:21:39 2021 +0200 use officecfg for menu options Change-Id: I5312be2963d15ab85c267ece073e52984b1a34de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07tdf#146423 don't set a size-request during a size-allocCaolán McNamara
and use a better width calculation Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128051 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07Drop unused define CLASSPATH_DELIMITERGabor Kelemen
since commit 200cc2d20a21ceb5d176604f9c384f15c6a87570 (2014) Change-Id: Idf0eb7b484eff26be6b341cbb217572eb8da7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127809 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-04changed CuiResId into SvxResId.Kiyotaka Nishibori
though some translation entries for tooltip for border preset images were in svx.mo, cui/source/tabpages/border.cxx referred the entries to cui.mo with CuiResId route, and the translations was not gotten. this commit is alternative change. Change-Id: Ica7a7ea71f7afe7044104b9d953f1b3edf9c2503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-03loplugin:unusedmethodsNoel Grandin
Change-Id: I922778e8ced0ad922d90a153b0eda47abbec94ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-31fix ubsan --disable-extensions error seen in oss-fuzz buildCaolán McNamara
i.e. instdir/program/libcuilo.a(dlgfact.o): error: undefined reference to 'typeinfo for AdditionsDialog' Change-Id: I6445632d81ca9d87b44cf9b0be59358ccd8f57ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127791 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-30tdf#145538 Use range based loopsAnkur Khandelwal
* Use range based loops in cui/source/tabpages/swpossizetabpage.cxx + Goal: Better readability of the code Change-Id: I8df81be6d6d628d4f3366bc2de4b3e44adbc430f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123871 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-12-24Recheck include/[s-x]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Iaebddd648c52c175da17d2a55a1e8de82c213f4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127330 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-21tdf#109390 Warn about empty New Document only on Apply, not OKGabor Kelemen
Creating new document type hyperlink shows a warning about empty file name only when pressing Apply, and closes silently on OK Change-Id: I00e7b20a12df8e35e154e3cf532067cbad72c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127010 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
generated by cgit (git 2.34.1) at 2024-12-26 07:35:59 +0000