summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)Author
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17Resolves: tdf#130045 dial control frame not hidden along with the controlCaolán McNamara
Change-Id: Idcdf3d748849fbe1ba1a6cce278373e349ba1e5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17show degree symbol in DialControl linked spinbuttonsCaolán McNamara
Change-Id: I792755f043109173606a78e947d5dc01f78c6849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14move [G|S]etGetSpecialCharsFunction into its own headerCaolán McNamara
so the whole of edit.hxx doesn't need to be included just to set that detail Change-Id: I467add023ca59c1ffdccbafb21843cb153ba6a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13rename NumValueSet back to SvxNumValueSetCaolán McNamara
Change-Id: I05cd8e336f818e80de40abb40cf739a7cbb540d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-11Resolves: tdf#127417 delete-all tabs doesn't workCaolán McNamara
since... commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Date: Thu Apr 18 19:25:06 2019 +0200 WIP: Further preparations for deeper Item changes because since then aNewTabs is cloned, but on delete-all aNewTabs is reset to a SvxTabStopItem with a 0 WhichId so its clones are useless Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-10Resolves: tdf#129904 use the current page as the page for helpCaolán McNamara
in the options dialog which has a non-standard organization for its contents vs an ordinary dialog Change-Id: I6a50652f5ae3fe2e8b4d32933bec6dc0217cbec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86576 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-07Fix SfxPoolItem use-after-freeStephan Bergmann
...as observed with -fsanitize=address in Draw, after drawing some rectangle (so that there is at least one marked object) doing "Format - Area... - Area - Bitmap": > ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8 > READ of size 4 at 0x6030004aca50 thread T0 > #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42 > #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124 > #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 > #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42 [...] > 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21 > #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13 > #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42 > #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9 > #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec "tdf#104615: there's no mpView when opening odc directly". Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-06Add include guards - follow-up for 0c4033a9c69da439b97378b0dc61e867953649ebMike Kaganski
Change-Id: I2910ac7e063b785c845723a2eb265cce96c94ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Fix Windows build with HAVE_FEATURE_BREAKPADMike Kaganski
This partially reverts commit ed1ece19d4983ea47b296086aaa0ea91fe11935d Change-Id: Ie945676f0618f80c3258f041fea9b91ee01031d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86263 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Removed redundant semicolonsAndrea Gelmini
Change-Id: Ife14b8c3f7d121deb390deb5f405dd42d3016acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-06tdf#42949 Fix IWYU warnings in cui/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I41ae36eb535cc64f4c4fa73333dbc8aa728865b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85791 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-02weld SlideBackgroundCaolán McNamara
Change-Id: I6f8792d8212807b4be4a24885e237290e298dfa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-01weld PageStylesPanelCaolán McNamara
Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-31tdf#108458 related: Make command tooltip show in tooltipJim Raykowski
Make Customize > Keyboard > Function TreeView show command tooltip in the tooltip. Change-Id: I5d2ca7090e00d7c18d792da73c567cdfd6895da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85776 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-30rename SvxDialControl back to DialControlCaolán McNamara
Change-Id: I4dcf12b6eccf18a0659c5d5f9cd58bd104c4dc6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-29tdf#124176 Use pragma once instead of header guarderto
Change-Id: I904c2b37a51c03d51503c0b460201392ec8894a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85628 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedmethodsNoel Grandin
Change-Id: Iad97bdbcbec4cbbccf3df9b9d682e744b0c1982e Reviewed-on: https://gerrit.libreoffice.org/85709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedfieldsNoel Grandin
Change-Id: Ib2314f23efe953398ed0a5e88305842c812e18bb Reviewed-on: https://gerrit.libreoffice.org/85708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20tdf#124176: Use pragma once instead of include guardsSıla Genç
Change-Id: I88d5517d42b6c5b6809f062a789e7dd85394f6db Reviewed-on: https://gerrit.libreoffice.org/85601 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#124176: Use pragma once instead of include guardsSelim Şeker
Change-Id: I626d4a08161a6c81b4bb014d847f0c05d90fda35 Reviewed-on: https://gerrit.libreoffice.org/85449 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-20tdf#108458 Show tooltips in CuiConfigFunctionListBoxJim Raykowski
Change-Id: I6644e939c644c827e2b3ad019b975a3845585063 Reviewed-on: https://gerrit.libreoffice.org/84555 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-19tdf#124176: Use pragma once instead of header guardBatuhan Görkem Benzer
Change-Id: I720508aa4bfd77f15b5d713e4d948b06af0be4c2 Reviewed-on: https://gerrit.libreoffice.org/85414 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsMesut Çifci
Change-Id: I377809c01053ebaf2fe004478e144509adbbdd1f Reviewed-on: https://gerrit.libreoffice.org/85416 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsTolunay Dündar
Change-Id: I47be8a0488b7ff7ce176f10aaf90b8be6913cc8a Reviewed-on: https://gerrit.libreoffice.org/85412 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-19tdf#124176: Use pragma once instead of include guardsOnur Yilmaz
Change-Id: I2f58499164254eab1d2f628b3b64710e1d2efbeb Reviewed-on: https://gerrit.libreoffice.org/85415 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsDesmin Alpaslan
Change-Id: Ib14b28a9508b28460a6063f7ddd322869823b49a Reviewed-on: https://gerrit.libreoffice.org/85413 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsKemal Ayhan
Change-Id: I8f8641d41a3c394c494d0e5f6cd5a06949e22fa6 Reviewed-on: https://gerrit.libreoffice.org/85410 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: I1f6d66a0d4a06338671579e9be2dbdc5cd673d50 Reviewed-on: https://gerrit.libreoffice.org/85411 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18tdf#124176: Use pragma once instead of include guardsMuhammet Kara
Change-Id: I3df73c321efa7fa3e8a87608c3c7189f7d839ac8 Reviewed-on: https://gerrit.libreoffice.org/85384 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-18sal_Char->char in cppcanvas..cuiNoel Grandin
Change-Id: I7e9fa7011f1e0bf143f86055718c772caebf8ee6 Reviewed-on: https://gerrit.libreoffice.org/85397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18tdf#127294 Remove spaces; follow design guidelines for tips-of-the-daySeth Chaiklin
- converted to design guidelines all quotes all menus items apostrophe (U+2019) em-dash (U+2014) minus (U+2212) expanded contractions - Corrected spelling and grammar mistakes. - Simplified wording in some tips - tried to clarify uri explanation in relation to help Change-Id: Ic9984fdc09813d2b43324a104d5c30420671c6b9 Reviewed-on: https://gerrit.libreoffice.org/85228 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-17Fix macro security UI usability problemsJan-Marek Glogowski
* Don't hide the option dialogs "Macro security" push button. I don't see any reason, why these settings should be hidden, if macros are disabled or settings locked. At least a user can now check, what is going on (still nothing shows disabled macros for a document in the UI AFAIK). * Don't scale the lock icons of the trusted list boxes. This just uses the same alignments, which the macro security level lock image uses, otherwise the image is scaled to fit the whole space of its layout cell. * Don't disable the trusted list boxes. If the setting is locked, it's sufficient to disable all the buttons, which allow modification (so View can stay enabled). This way you can still scroll the list. Correct button handling is already implemented and works for me. * Catch exceptions of broken certificate data. If your config contains certificates, which can't be correctly decoded, the NSS backend will throw an exception, which kills the dialog, but not the nested loop, resulting in a locked LO. Also show an error dialog with the broken base64-encoded data. Change-Id: I79002e0ce85cf9a9017caf858407f2f635a3a074 Reviewed-on: https://gerrit.libreoffice.org/85056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-17ui: show wait mouse pointer on operations in Expert ConfigurationVasily Melenchuk
Expert Configuration is loading, resetting and searching values very slowly, so will be great to indicate busy status to user. Change-Id: Ic0d428d01a9f71ff899979162e1b307cd7cd7401 Reviewed-on: https://gerrit.libreoffice.org/85242 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-16Related tdf#105225: Remove old background tab page codeJim Raykowski
All uses of SvxBackgroundTabPage have been replaced by a new background tab page derived from the SvxAreaTabPage. This patch removes the SvxBackgroundTabPage code and code used only by it. Change-Id: I83a2a04c0bf908cdc630fa091cd5ccdfb5d9381d Reviewed-on: https://gerrit.libreoffice.org/85194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-13size group is ignoring hidden widgets, leading to labels overlapping entriesCaolán McNamara
https://developer.gnome.org/gtk3/stable/GtkSizeGroup.html#gtk-size-group-set-ignore-hidden "Measuring the size of hidden widgets ... they will report a size of 0 nowadays, and thus, their size will not affect the other size group members" Which is unfortunate. So before we hide any labels, take the size group width and set it as explicit preferred size. Change-Id: If7c0f1ebd9f03914c74fde85b876549de76853c2 Reviewed-on: https://gerrit.libreoffice.org/85097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13loplugin:expandablemethodsNoel Grandin
Change-Id: I333d91ea5ce78c82e9bb107f934614efc7bfb8f7 Reviewed-on: https://gerrit.libreoffice.org/85078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12theChild->getName() already available as uiNameCaolán McNamara
Change-Id: I2792b2ac4f0d17dfc2fe68eeacb4dee2173fe5d2 Reviewed-on: https://gerrit.libreoffice.org/85068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12children[n] already available as theChildCaolán McNamara
Change-Id: I3eeb072ff393033fb681956b4ac7fe1c71745a0d Reviewed-on: https://gerrit.libreoffice.org/85067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12use covariant return type for SfxPoolItem::CloneCaolán McNamara
and can then remove some casting Change-Id: Id821c32ca2cbcdb7f57ef7a5fa1960042e630ffc Reviewed-on: https://gerrit.libreoffice.org/85022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12tdf#105225 New UNO and Writer Web background tab pagesJim Raykowski
Change-Id: Id3e7d1c24d086624f053085e3134792b95188c23 Reviewed-on: https://gerrit.libreoffice.org/64991 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-11Related: tdf#129300 clear properties that are set back to their original stateCaolán McNamara
Change-Id: Ic957afbdcf6decef07d15fa10a560e560de5795a Reviewed-on: https://gerrit.libreoffice.org/84951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScIndentItem to provide a descriptionCaolán McNamara
Change-Id: Ieb1a12f35cf8974c557c6e52eac0cd9fb7f80914 Reviewed-on: https://gerrit.libreoffice.org/84945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScHyphenateCell to provide a descriptionCaolán McNamara
Change-Id: If00a50a36cf2bb5c9b775a4ca1000af5c5be7bf4 Reviewed-on: https://gerrit.libreoffice.org/84892 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScLineBreakCell to provide a descriptionCaolán McNamara
Change-Id: Ief739616163c68e0e30d6287fdac90c1bcc9d13f Reviewed-on: https://gerrit.libreoffice.org/84879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 add ScVerticalStackCell to provide a descriptionCaolán McNamara
Change-Id: I8ed99f19ff6f4751c0867147fc1a60ac917f083b Reviewed-on: https://gerrit.libreoffice.org/84876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11Related: tdf#129300 make Automatic/Distributed state what is automaticCaolán McNamara
Change-Id: Ib246479761556858e92052edf86a18753d44c583 Reviewed-on: https://gerrit.libreoffice.org/84893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-11tdf#129300 If it would create no change, don't force itCaolán McNamara
otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-28 22:29:54 +0000