summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2015-06-29sal_uLong->sal_Int32 in SvtIconChoiceCtrlNoel Grandin
and drop the pass-by-reference param from GetSelected, nothing uses it Change-Id: I6d616a2b147912af9305410625af6e7afae34e59 Reviewed-on: https://gerrit.libreoffice.org/16312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-26-fsanitize=vptr: SID_ATTR_*LANGUAGE are of type SvxLanguageItemStephan Bergmann
Change-Id: If00273e3836aeb70adee36f49f0ef502b6a7aebb
2015-06-26-fsanitize=vptr: wrong, unnecessary downcastsStephan Bergmann
(and the pXPool members are not even necessary) Change-Id: I321f06387ca1f1e98d8f731ec2b070212c82c28a
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: I89536204943c0bb86ad9a7cf11050d040650078d
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I0749564ce91cb6ad5ca58cc6432ff3cd4b2f579b
2015-06-23Options: “TSAs” button now has the same size as its neighborsAdolfo Jayme Barrientos
Change-Id: I19f01148c3d8af2b5aa574cacb098415eeeea38f
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-22loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ibba2d7322a3708bce186bb6f8de44ffa18c5146e
2015-06-22Review Expert Configuration dialog's tree view.Mihály Palenik
In Expert configuration dialog's tree view didn't work correctly. Now I followed the old pattern. Additionaly the entries' name are shorter. Change-Id: Ib7ecd065f02c8f3bbef94daf7f32cb68ab676ee8 Reviewed-on: https://gerrit.libreoffice.org/16411 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-20callcatcher: update unused codeCaolán McNamara
Change-Id: I29b3f1408b814a1424d8bab232e9ac618901b4c2
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-19Use explicit OUString::copy(0, 1) rather than odd OUString::getCharStephan Bergmann
...on a string potentially of length > 1 Change-Id: Ibdb8c3bb6e1630883069ff7dd17161014548ee76
2015-06-19cui: prefix remaining svx::DbRegistrationOptionsPage membersMiklos Vajna
Change-Id: If6786c2df54d7ccad61c00fddf28b0a00372dab2
2015-06-18coverity#1307697 Dereference null return valueCaolán McNamara
Change-Id: I48bf70689153b83bd1da7ff1553a4a3ec823d1b2
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17loplugin:staticcallStephan Bergmann
Change-Id: I3ae7d03f7c08608f97a1a9ded72d0de31cc625a9
2015-06-17tdf#91748 fix preview of special charactersTomaž Vajngerl
Change-Id: Icf18e8be2ec07bb4bcd6edce3e41a6e88ecefca7
2015-06-16Change table to tree view in Expert Configuration dialog.Mihály Palenik
Expert Configuration dialog was too slow when accessibility was used. Therefore the table was changed to tree view. In tree view the children of entries is loaded dynamically. Change-Id: I267833e46005058fdfedb6f012afe2f9b390636b Reviewed-on: https://gerrit.libreoffice.org/16307 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15more untranslatable UI stringsAndras Timar
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I2b5fba9cdd950349a8e8d22bbd7bb6e17f008920
2015-06-14Make this string localizableZolnai Tamás
Change-Id: I074ae2866a67cf90637cd229c717aa999f718558
2015-06-14Paragraph related part of Background Tab is unused nowZolnai Tamás
For paragraphs Area Tab is used for setting background. Change-Id: I83859a1b2125374b81c084cfa45487a42adcd5a6
2015-06-14Search By Format: Background -> HighlightingZolnai Tamás
Change-Id: I58cda2c6f6f38cca3fe8fecf89722be09d43059b
2015-06-14Handle highlighting case inside SvxBackgroundPage classZolnai Tamás
... instead of converting attributes. Change-Id: I3e45c0641389a7b6bdecb5141646aa13ee5c0aa5
2015-06-14Options: Background -> HighlightingZolnai Tamás
Change-Id: Id65f748ab32e119465444d02fa6584752b514047
2015-06-14tdf#89830: Ambiguous naming of character backgroundZolnai Tamás
Use 'Highlighting' also on Character Dialog. Change-Id: Ie81d25651e5998a35b4e2646089b8f2c590cfb98
2015-06-14Transparency part of Background Tab is unused nowZolnai Tamás
It was used for frames, but on Frame Dialog Background Tab was replaced with Area Tab. Change-Id: I69774c7321a210094f6e139a5b3d4d5819947ceb
2015-06-10coverity#1302618 deref of NULLCaolán McNamara
on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
2015-06-08add (and call before dtor) Commit to SvtSearchOptionsCaolán McNamara
i.e. follow up to commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Author: Michael Stahl <mstahl@redhat.com> Date: Wed Mar 11 16:39:24 2015 +0100 do not call virtual Commit() from dtors of utl::ConfigItem subclasses ~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not invoking its subclasses' ImplCommit() but its own. to avoid assert in SvtSearchOptions dtor Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Ieecc2f050499823e131504ecd487edc0fe3ea30a
2015-06-08tdf#90804 remove SfxFieldUnit enumAndras Timar
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit and FieldUnit. In fact SfxFieldUnit was redundant. Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31 Reviewed-on: https://gerrit.libreoffice.org/16150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-08Resolves: tdf#91932 enable CaseMap property in impress/drawCaolán McNamara
I don't see why this was explicitly disabled, works fine out of the box for me, import/export already hooked up in odf Change-Id: I5e6bdbc6a4f3cbcd97330c7d9fb33589489afee2
2015-06-07Resolves: tdf#89905 don't copy palettes from shared to userCaolán McNamara
make this a multi-path element with a shared read-only location and a user read/write location and don't copy the presets, instead just keep them in the shared location Now an admin can copy extra palettes into the shared location and they magically appear in the user deployments Change-Id: I7585789c0c59941094f6128368df94b834d3c2a2
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-02sal_uInt16 to sal_Int16Matteo Casalin
Change-Id: I0791354f79017ac8100920568519f5a8bcb398f2
2015-06-02Data members are already accessible by member functionsMatteo Casalin
Change-Id: Ia56f23b0fca318131b8a985964c79a193c38f4e2
2015-06-01Avoid temporary OUStringsMatteo Casalin
Change-Id: If82d849f15e4218d8848a6fcdd507f0ef50d3edc
2015-06-01Prefix data membersMatteo Casalin
Change-Id: I8b0fa3e95a5e3ed357bd5daa290e2309e86272e6
2015-06-01This member can be constMatteo Casalin
Change-Id: I53c63bd5734635540ff9c4edfb698c16ac4fca17
2015-06-01Use initialization listMatteo Casalin
Change-Id: Ibaddbd1dfc11382ead2f5ad4ed369bb0cc750fd7
2015-06-01Fix typos in commentsMatteo Casalin
Change-Id: I2b8c08ee1a1e45347158f77ff25bee6adbaace94
2015-06-01sal_uInt16 to sal_Int32, and use -1 as a special caseMatteo Casalin
Change-Id: Iaf90f96665781d3aa43f1f71802538f54409bd4a
2015-05-29dispose SfxControllerItem objects correctlyLászló Németh
Change-Id: Id5f80e06e5609b4e85f3d6db7bc37aabe6ef0dac
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-15 00:20:27 +0000