summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2023-05-02tdf#155049 Revert "tdf#115884 PDF signing should mentionIlmari Lauhakangas
it only works with x509 certificates" This reverts commit a1146fd95022196636f8c41f7322a7257955cef4. Reason for revert: needs special case for PDFs as this dialog is also used when signing ODF files Change-Id: I8b9a007816732066746b790ee03654f4b5b2904d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151273 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-05-01tdf#154940 change label from "Variable" -> "Custom"Seth Chaiklin
Change-Id: I24db05dc26742513c1b6225d5c601ee19078ab87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151117 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-28tdf#90496 - Remember last used view in hyperlink dialogAndreas Heinisch
Change-Id: I500e9e58c84486307c50f4ccb878ad0340412246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151039 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-27tdf#145925: Add DOI recognitionBaole Fang
Detect DOI string in the form of "doi:10.*" and add hyperlink to it. It works the same way as url recognition. Change-Id: I3c4e78a110fd81ad7e727d5e9acee7e51127466a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150954 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-27Resolves tdf#155039 - Color name not displayed with GTK3Heiko Tietze
Change-Id: I317a935c1e99c20f09cba8c24085d3a173d64dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151090 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-27Resolves tdf#155038 - Application Color is disabled with GTK3Heiko Tietze
Change-Id: If820e765f3477f4b5ec8609f2781f8f0ed06cd09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151093 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25Resolves tdf#154080 - Allow customization of comment indicator colorHeiko Tietze
* New application color added * Border color depending on cell/sheet background * Comments color set to light magenta to align with similar tools Change-Id: I782e8359632c5a319e61f5d5ac3deb4614bd7e79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150970 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25Resolves: tdf#154958 add an empty spin button to use for the unused caseCaolán McNamara
instead of reusing the percentage one, which will set its min value under gtk Change-Id: I342f8f0588574c45c5752964b95232e419f752ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24Resolves: tdf#153441 use a TriStateEnabled helperCaolán McNamara
Change-Id: I976e4271a072bfb53c676091509e1d4ef7dbcccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24resave with latest gladeCaolán McNamara
Change-Id: I8db5ddfa271ab3729d069486f9f4b05263fbe9b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24tdf#154884: do not stop if the first pair is not what we looked forMike Kaganski
The same character can be added later with a different font, so keep searching Change-Id: I7b83438ca476ffab23ca08268cf957045d75f6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150937 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-24tdf#147503 don't use SfxObjectShellLock for new xml forms documentCaolán McNamara
because in the hidden case the document is unexpectedly closed on leaving NewXForms Change-Id: I00ea0b8de6c10ff141584cefe3768b7071138393 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150891 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-21tdf#154731: Hide Zoom & View Layout dialogBaole Fang
Change-Id: I49f86a858826da39f9dd08580d5ab7796bc397a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150667 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-21Combine com.sun.star.cui.[Asynchronous]ColorPicker implementation declsStephan Bergmann
f54ccf09a5073b6e544c976da68de0c9fc0bdf6c "Make Custom Color Picker dialog async" had added the additional com.sun.star.cui.AsyncColorPicker implementation entry (later renamed to com.sun.star.cui.AsynchronousColorPicker) for the same actual C++ implementation, presumably out of confusion. (The implementation name "com.sun.star.cui.AsynchronousColorPicker" appears to not be mentioned anywhere else than in this .component file, so it shouldn't matter to drop it.) Change-Id: I80cc4f474d71493fb5bc125d9137595184cc6e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150644 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-20Typo: GetCurentItemData->GetCurrentItemData (in cui)Julien Nabet
Change-Id: I5adaa6193482ef722396206269aaea57224502a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150686 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-20Run clang-tidy with misc-unused-using-decls on modules [a-c]*Gabor Kelemen
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: I95871cc0ae6f22a9684bae9d14ef0475aea17abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150608 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-19MCGR: 2nd corrections/adaptions to MCGRArmin Le Grand (allotropia)
Adapted handling of 'border' argument from our gradients for oox export, so that it looks the same. Also added quite some cases to peserve in-between GradientStops for current UI implementations to be able to edit the gradients as usual without losing the in-between GradientStops. While we will not be able to modify these, we are at least able to modify all the other gradient attributes, including start/endColor. Done this for TransparencyGradients, too. Also moved more stuff to the gradient tooling in basegfx. Change-Id: I6e94011bbf3715baa1401ab97e5b59811298342f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150577 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-16Resolves: tdf#153958 Hyphenation crashes with -Alte...Caolán McNamara
nPos2 is 0 due to the -, so aLeft is empty, nPos is set to 0 then incremented to 1, aLeft.replaceFirst is run after its end pos so crashes/asserts. Presumably we can do nothing meaningful here so skip if nPos2 is 0 Change-Id: I09754c4b2567fe5c1b4c36de0b36ee99f575244d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-15Fix number decimal separator in text tags in ui several filesJulien Nabet
Change-Id: I55b5fe4fdd89f9383c6ce646780cce846639736f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150420 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-14Fix number decimal separator in cui/editmodulesdialog.uiJulien Nabet
Change-Id: Ie10f061f5feb97ce5e251aba03c5a0d21d7c0f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150390 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-04-14[API CHANGE] Related tdf#154080 - Allow customization of comment indicator colorHeiko Tietze
* Calc > View option replaced by a new application color * Border not only in highcontrast mode but always shown * Border color depending on cell/sheet background The previous option TextOverflow in Calc.xcs was replaced by CalcTextOverflow in UI.xcs in order to combine color and on/off with the accepted drawback of incompatibility. The alternative, keeping the color separate from the toggle, would separate the options and was rejected therefore. Change-Id: Ie3e469163485d8eb1cffc7022e1518ad20e8e54e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150340 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-13tdf#154451 uitest: use more oneprocess modeMiklos Vajna
Execution time changes: - UITest_writerperfect_epubexport: 20,023 -> 6,083s - UITest_svx_table: 15,214s -> 14,378s - UITest_cui_tabpages: 13,561s -> 12,503s - UITest_math_demo: 19,737s -> 13,578s Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-12Remove duplicated includeAndrea Gelmini
Change-Id: Iff23fcd5d88ce33d66f5f7255d0967c695b91f84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150247 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-11officecfg,cui,sw: add Common::Load::ViewPositionForAnyUserMichael Stahl
Add setting Office::Common::Load::ViewPositionForAnyUser which if enabled skips the user name matching against meta.xml that sw does before restoring a view position stored as ViewTop/ViewLeft/etc. in settings.xml in an ODF file. This is particularly useful if the user disables the "ApplyUserData" in Document->Properties->General, which made restoring view position impossible. Change-Id: Ie3ced3c4ad20a35eb8453ad1521c787b0b0c8458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150113 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-10tdf#154740: Assert: Changing Paper tray propertyJulien Nabet
Related to tdf#152950: Calc sort crashes after changing from default language to a different one In brief "don't set_active while frozen" bt here: https://bugs.documentfoundation.org/attachment.cgi?id=186560 5 0x00007f9a75653df2 in __GI___assert_fail (assertion=0x7f9a6393ad87 "gtk_tree_view_get_model(m_pTreeView) && \"don't set_active when frozen, set_active after thaw. Note selection doesn't survive a freeze\"", file=0x7f9a639265f6 "/home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx", line=21759, function=0x7f9a63936b44 "void (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru(int, bool)") at ./assert/assert.c:101 6 0x00007f9a63b026fa in (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru(int, bool) (this=0x562278124580, pos=0, bInteractive=false) at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:21759 7 0x00007f9a63af904c in (anonymous namespace)::GtkInstanceComboBox::set_active(int) (this=0x562278124580, pos=0) at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:22173 8 0x00007f9a357153ee in weld::ComboBox::set_active_text(rtl::OUString const&) (this=0x5622781249d8, rStr="[D'après les paramètres de l'imprimante]") at include/vcl/weld.hxx:786 9 0x00007f9a35ad761f in SvxPageDescPage::PaperBinHdl_Impl(weld::Widget&) (this=0x5622774108e0) at /home/julien/lo/libreoffice/cui/source/tabpages/page.cxx:924 Change-Id: Ib13c3e8e472fdcc8f285993f39a69775537bb238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150176 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-08tdf#154677: fix crash when clicking on Tools-Options-Language Settings-DeepLJulien Nabet
Change-Id: Iaf24dae303edbeeaf8e19a4ca3d19232083a71bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150158 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-06Make SvxNameDialog publicSamuel Mehrbrodt
Useful as a generic text input dialog Change-Id: Ibc6ff0c25a790da8f1226fff7244e50ed3a1cf04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150002 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-04-03Hyphenate this compound adjectiveAdolfo Jayme Barrientos
Change-Id: I7e19c90fd0106f59398205579d7b5d60cbf4a07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149945 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#153806 a11y: Insert special char + close dialog on return keyMichael Weghorn
As discussed in tdf#153806, insert the currently selected character from the special characters dialog and close the dialog when the return key is pressed on the table of characters (either showing all characters or just the search result). Something similar should probably be done when the return key is pressed with one of the recent characters or favorite characters in the dialog having focus, but that needs to be handled separately, possibly along with the other remaining suggestions to improve keyboard handling in the special characters dialog as discussed in tdf#153806. Change-Id: Iccc19e4808ddf6f15c32710f9bea931e46b046bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149920 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03tdf#153806 cui: Deduplicate code for special char dialog handlersMichael Weghorn
Various handlers for `m_xShowSet` and `m_xSearchSet` are the same, except that they operate on the different objects. However, since a pointer to the `SvxShowCharSet`/`SvxSearchCharSet` is passed as an argument to the handler, use that and reuse the existing handlers instead of duplicating them. Also extract a `SvxCharacterMap::insertSelectedCharacter` method from the `CharDoubleClickHdl`, since that will be reused elsewhere in a follow-up commit for tdf#153806. Change-Id: I14e8e7fd7add33f86fa0246c65927ceb88bb7899 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149919 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03jsdialog: keep button under content in SpellCheck OptionsSzymon Kłos
Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149825 Tested-by: Jenkins
2023-04-03jsdialog: enable spelling options dialogSzymon Kłos
and make it async Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824 Tested-by: Jenkins
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-01gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failedCaolán McNamara
Change-Id: Ia8070c3c8102bc6bfb72531be450abd9fe47a1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-29Resolves tdf#152184 - Application color should follow system colorHeiko Tietze
This patch reverts the previously added "LibreOffice Dark" application color set and adds it to the automatic colors. Switching between light and dark changes the Automatic color accordingly instead switching to another color scheme. The added System Theme option makes Light/Dark follow the actual OS appearance. Reverts 6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06 (Introduce dark color set), 546ad5d17d3e363b75337c336cfb2b2f8acc55e3 (color scheme translatable), 9f0cf00d29298ed55737928ec4dddc50ac850cd8 (Update view options string based on theme) Change-Id: Ibf491f2e510fac5f1d27a7166560c4ec281d98d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149059 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-29tdf#154115 use correct column for searchCaolán McNamara
Change-Id: Iaa390e63d269221b7273fe15362cfbdf20f235da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-28Simplify OfaTreeOptionsDialog ctors by delegationMike Kaganski
Change-Id: Iea1487bde1c5a15934c5678a53648f3597df5cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149643 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-28resave with latest gladeCaolán McNamara
Change-Id: Ib75edfa79a2beffcb1d5b4222901a7f2fd61d44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-25tdf#154294 Fix customize notebook bar regressionJim Raykowski
caused by commit e79741488cc740f49ebd4426c40b45e7139ff663 Change-Id: I04fe66124af831c73834b7f695458e1667198ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-03-24add 6px to Skia children optionsSeth Chaiklin
Change-Id: Ic7d3a63516aae263aaffec9fba9d9673469bede4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149445 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-24loplugin:stringadd in c*Noel Grandin
after my patch to merge the bufferadd loplugin into stringadd Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-23tdf#135769 a11y: Set a11y name and tooltip for buttons in hyphenation dialogMichael Weghorn
Set accessible name and tooltip "Left" and "Right" for the left and right arrow buttons, as suggested in tdf#135769 comment 6. Change-Id: I233d7f9028b2336130475ce50a4161df0629a835 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149355 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-23Resave cui/uiconfig/ui/hyphenate.ui with glade 3.40.0Michael Weghorn
.. before doing any changes for tdf#135769 Change-Id: If9ae28a979c4d4c12120711b90a9361b2e90b6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149421 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-22tdf#153808 Fix numbering preview in dark modeRafael Lima
This patch fixes the color used for numbers and bullets in the preview of the Bullets and Numbering dialog in Impress. Currently the implementation causes the bullets and numbers to be rendered in white over a white background when using dark mode. The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of FieldColor and FieldTextColor. Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-21cid#1524485 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I3a4dfb0e35db481c94a1f5cb56f078cc9e060a73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-20tdf#147469 remove mouse "Positioning" from options pageCaolán McNamara
Change-Id: I929c62189e3e31358fe95c804457fcbcba85e4b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-20tdf#154071 UI rename gradient back to 'Rectangular'...Regina Henschel
Commit e97e62a4707e09739f9c00f8fc4a943f0123a9cf had wrongly changed 'Rectangular' to 'Square' (API RECT, ODF rectangle) and 'Square' to 'Quadratic' (API SQUARE, ODF square). This patch reverts 'Square' to 'Rectangular' and 'Quadratic' to 'Square (Quadratic)'. It uses 'Square (Quadratic)' instead of simple 'Square' to help users to find the correct type. In addition, use of the wrong type names in comments is fixed. Change-Id: Ibbd90be2cceb65c9857e473cb74c39df1b9530f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149004 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-03-20tdf#152898 remove "show context menu shortcuts" from options pageCaolán McNamara
Change-Id: I44acae51ca72ece735f264e826f8d254e85be8f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-19MCGR: Model data changes for ColorStepsArmin Le Grand (allotropia)
Added tooling replaceStart/EndColor to allow simple transition for code that does not immediately adapt to multi color gradients. Also added createColorStepsFromStartEndColor for the same purpose. Adapted XGradient to no longer have Start/EndColor at all, but only use ColorSteps. Adapted all usages of XGradient to no longer use Get/Set/Start/EndColor, but access the ColorSteps instead. Replaced quite some XGradient constructors that used XGradient() as Start/EndColor since this is already the default. Adapted ColorBlending to black AKA Start/EndIntens in XGradient to work now on all ColorSteps in the required linearly-scaled manner. UNO API changes: Added com::sun::star::awt::ColorStep as basic data element that holds a pair of Offset and Color. Added com::sun::star::awt::ColorStepSequence to handle an array of sorted entries. Added com::sun::star::awt::Gradient2 derived from com::sun::star::awt::Gradient, extended by the needed com::sun::star::awt::ColorStepSequence. Added MID_GRADIENT_COLORSTEPSEQUENCE to UNO API to provide access to ColorSteps directly. Adapted XFillGradientItem::QueryValue/PutValue to make use of new UNO API data structures. To do so, added tooling methods for data transition: - fillColorStepSequenceFromColorSteps - fillGradient2FromXGradient - fillColorStepsFromAny - fillXGradientFromAny and adapted - case '0' (all data) - MID_FILLGRADIENT - MID_GRADIENT_COLORSTEPSEQUENCE - MID_GRADIENT_START/ENDCOLOR to make use of these. Tested usage of these in the office. Renamed from GradientStep to GradientStop after discussions with members on the list to make this closer related to other norms/definitions. Also renamed classes and class members to better reflect to GradientStop, so grepping/finding will be easier (e.g. 'Color' just exists pretty often, but 'StopColor' is more precise). Changed the used UNO API class for reprsenting the Color to better reflect to ranges [0.0 .. 1.0] and usage of RGB. Change-Id: I1eeb3e97e81d6785967615d1ff256551fc3b882d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148849 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-03-18loplugin:stringadd use more O[U]StringCharNoel Grandin
Change-Id: I196e4539ad430a39415eff9d7170b33df7228230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-18 05:24:20 +0000