summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-08-20Enable subset filter when not in search modeAkshay Deep
Change-Id: If8bb1471cb09599d514ca2fef963249309d6563a Reviewed-on: https://gerrit.libreoffice.org/41357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-20Fix 'make translations' runGabor Kelemen
Recent commits introduced strings in .ui files without context which makes 'make translations' fail with: [build POT] pot.done Traceback (most recent call last): File "/home/gabor/src/core/solenv/bin/uiex", line 30, in <module> keyid = entry.msgctxt + '|' + entry.msgid TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' Affected commits are: e74be9ad773c7769c5d8765bb2ac234967e420ec 213a83ce46edf1b81f2285fd59f1d04935760caa Change-Id: If7afc4bb157a6406cabba141d375e9b0dab5f3de Reviewed-on: https://gerrit.libreoffice.org/41322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-20drop unused SfxSpellCheckItemJochen Nitschke
last getter went with commit 215207f480258b37864a88e1b831055e148adf65 Date: Thu Mar 6 16:42:24 2014 +0000 coverity#708784 Unused pointer value don't put the item in any item sets anymore. delete SID_ATTR_SPELL and adjust SfxItemSet ranges. narrow ranges in OfaTreeOptionsDialog::CreateItemSet to actually used items. Change-Id: Ia5cc91fc62a0fccf87b2fd380e6bb2bef1f6f3e7 Reviewed-on: https://gerrit.libreoffice.org/41335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19drop unused SfxSizeItemJochen Nitschke
unused since commit 48bf5e855ae02fd1bea87938978f29ee6147285c Date: Thu Nov 16 14:30:58 2000 +0000 Remove tests for INET_PROT_FILE Change-Id: I2dc134f529675204caad78c7e50417adb55e8e4f Reviewed-on: https://gerrit.libreoffice.org/41320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19tdf#103275 Rename 'Spacing to Content' to 'Padding'Gabor Kelemen
Change-Id: Ib4bdc594f34761c5957e9fb803218946b54e23f7 Reviewed-on: https://gerrit.libreoffice.org/41306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-19convert to WB_SAVEAS to flags on SfxAcceleratorConfigPage::StartFileDialogNoel Grandin
Change-Id: I52ff0b4ba892a74d1dad9ce8c6c7638e3463affe Reviewed-on: https://gerrit.libreoffice.org/41303 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-16convert dialog result methods from long->sal_Int32Noel Grandin
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c Reviewed-on: https://gerrit.libreoffice.org/41206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16tdf#111797 Fix alignment of 'For the current document only' checkboxGabor Kelemen
Change-Id: Ie7cc004e02e3bb1ac8d52a9c0b67b9fa9f946c8c Reviewed-on: https://gerrit.libreoffice.org/41167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-15Disable subset LB when search mode is enabledAkshay Deep
Change-Id: Ic8fa88f1e471fe3eab965e5f0106de0348e62ec0 Reviewed-on: https://gerrit.libreoffice.org/41161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-15tdf#111337 - Introduce alternative workflows at the special characters dialogAkshay Deep
Change-Id: I6a8fe2476adc5c4379c76dfaef090d1b5cd81ea0 Reviewed-on: https://gerrit.libreoffice.org/41170 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-15tdf#109217 - State of the favorite button is not updated immediatelyAkshay Deep
Change-Id: Ibc93277c71e51709d56345e8934f045c60d322ca Reviewed-on: https://gerrit.libreoffice.org/40914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-13move the SvxBackgroundColorItem<->SvxBrushItem conversionCaolán McNamara
into the dialog itself Change-Id: I83db9f02145a4927257dd5691f82dad1a11eaea6 Reviewed-on: https://gerrit.libreoffice.org/41029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-12tdf#105966 Solved Increment:Automatic checkbox problem in Area->Gradient tabpv2k
Change-Id: I7025b63df830853867b1b6dd17b7985ec16be83b Reviewed-on: https://gerrit.libreoffice.org/38882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-11vcl: use default copy-ctor for TextAttribJochen Nitschke
Type of TextAttrib (mnWhich) never changes, const it up. Derived classes can use implicit default copy-ctor. No need to explicitly delete default-ctor if there is a user provided ctor. And no need to define a default override dtor here either. Change-Id: I7a0d1896f659801319dc5fa74844df94c5888a7b Reviewed-on: https://gerrit.libreoffice.org/41022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11Revert "Build with kde5, first stab"Katarina Behrens
this was meant to go to a feature branch *sigh it must be Friday
2017-08-11Build with kde5, first stabKatarina Behrens
this is largely based on jmux's work Change-Id: I5897f3ecb90f83a29e0824bfe7a0ea875347e360
2017-08-11Remove useless if checkMuhammet Kara
And the return in the default case, which could cause the UI element to stop updating Change-Id: I29d35818b015f71890f615a02ea215034c048326 Reviewed-on: https://gerrit.libreoffice.org/41020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-11improve scoping a littleCaolán McNamara
Change-Id: Ie2e86852f7c4754070d3eb7e8981d674f04a6d80
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11tdf#109216 - Alignment/spacing at the new controls in the special charactersAkshay Deep
Change-Id: I7c07750e131060fb8ba796e7dcdc5f5bafcb1d74 Reviewed-on: https://gerrit.libreoffice.org/40916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-10Search feature for Special CharactersAkshay Deep
1. Name data stored in map 2. Retrive the data to compare with search string 3. create search control 4. populate search results 5. Read-only subset listbox meanwhile Change-Id: I689bbee0dd9a226261c37a5824af7f83a510167d Reviewed-on: https://gerrit.libreoffice.org/40563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-09Resolves: tdf#111416 missing draw/impress optionsCaolán McNamara
Change-Id: I2dc3627e754670b9fa4c799a6728bdb16b3dc983 Reviewed-on: https://gerrit.libreoffice.org/40910 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-07Rename “Basic IDE Options” to just “Basic IDE”Adolfo Jayme Barrientos
None of the other Options/Preferences pages have the word “Options” in their names, because: a) it’s obvious that they’re options, and b) having that word repeated there contravenes the macOS convention of calling the options “preferences”. Change-Id: I7349d20eefc50d5a92d6442a256249f64db688e7
2017-08-06tdf#109863: use SID_PATTERN_LIST after bitmap tab convertingJulien Nabet
instead of SID_BITMAP_LIST Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I880ca149d5865ed5b80c57d7c5b390cc5606d66c Reviewed-on: https://gerrit.libreoffice.org/40798 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-04rename SIP_SA_EDGELINEDELTAANZ->SIP_SA_EDGELINEDELTACOUNTNoel Grandin
and SIP_SA_EDGELINEDELTAANZ->SIP_SA_EDGELINEDELTACOUNT Change-Id: Ib6c370025a56586df1cdf7abcab2f0dfe599a64a Reviewed-on: https://gerrit.libreoffice.org/40738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02split out VclBuilder static methodsCaolán McNamara
Change-Id: Ic94b39351c9a6131fb61883a98ae9e3ee60ad119
2017-08-02tdf#110448: Remove "Memory" page from Options dialogMike Kaganski
The relevant caches settings are still available under Expert Configuration: /org.openoffice.Office.Common/Cache/GraphicManager/TotalCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectReleaseTime /org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects /org.openoffice.Office.Common/Cache/Writer/OLE_Objects Change-Id: I7692fd94a873ba7220a21d51ff8a943598c6a9fc Reviewed-on: https://gerrit.libreoffice.org/40640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:constparams in cuiNoel Grandin
Change-Id: I5f3e4ba8d953bbce22c3c359bb1c3ae2ac47eb1d Reviewed-on: https://gerrit.libreoffice.org/40593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31Resolves: tdf#109007 SvxCharView is in sfx2 not cuiCaolán McNamara
Change-Id: I54f19f61161f3473cbdf2b1bfdc04e9354cc39a8
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28add comment on max char name lengthCaolán McNamara
Change-Id: I9e542f6e131de1a05dd54a84a260453ea2edcb62
2017-07-28merge duplicate blocksCaolán McNamara
Change-Id: I62e021b2ec7ac9df122389fd128f7a7770317a43
2017-07-28check that u_charName was successfulCaolán McNamara
Change-Id: I55896eb939a864c3437e3f3c5b13c272966e4b85
2017-07-28replace snprintf with our own convertersCaolán McNamara
Change-Id: I27b0b82ac5be631c0d47f486603e241026dcabd9
2017-07-28pass char code directly rather than as-textCaolán McNamara
and then turning it back into the code again Change-Id: Iae9cddb18a6bdad4b1ba8c2af81f3d29a7f26725
2017-07-28declare at init pointCaolán McNamara
Change-Id: I986352cd2db4a9bd794ec25fbef9168be08a70ce
2017-07-28Unicode Character Names Integration using ICUAkshay Deep
Change-Id: I0624690f8af05adb2466219a4e508e634c490ef1 Reviewed-on: https://gerrit.libreoffice.org/40436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-27Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumerCaolán McNamara
inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected Change-Id: Ifccb1657d2565005e6f9e239c6118f2e5ae7970c
2017-07-26tdf#36747 add sort to match format list in file dialogsJames Raykowski
Change-Id: Ia2883bfe4c020b5c9664eef3001fc90a99c82981 Reviewed-on: https://gerrit.libreoffice.org/38375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25Clear Recent View and Fav view using Right ClickAkshay Deep
Conflicts: sfx2/inc/doc.hrc sfx2/source/doc/doc.src Change-Id: I0aa2919815a3fa63ee180b808834a8aa760af649 Reviewed-on: https://gerrit.libreoffice.org/40234 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>