summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23should use DialogController hereCaolán McNamara
Change-Id: Ie0ad42e98d574d15172c6ed3a58714c3f87593cd Reviewed-on: https://gerrit.libreoffice.org/79355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23Resolves tdf#127400 - Allow to show tip of the day againHeiko Tietze
* UNO command TipOfTheDay and slot SID_TIPOFTHEDAY introduced and added to help menus * Tip ID introduced to keep the current tip over the day * Tip ID updates after 24h * Randomization of tips replaced by sequential order * Tip ID added to the dialog title Change-Id: I69b72b80d6d6afa25a1c4f01fa05bc60b5741db8 Reviewed-on: https://gerrit.libreoffice.org/78693 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-21set wait on the dialog, not the page parentCaolán McNamara
Change-Id: If782e774fee91a427d4bda575b2f404fd636f534 Reviewed-on: https://gerrit.libreoffice.org/79319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-21tdf#126527 Fix widow and orphan lines being added to searchJim Raykowski
Change-Id: I36d627b64fab3d42f7cf583e6f639745527b1b7f Reviewed-on: https://gerrit.libreoffice.org/79265 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-09-20weld OfaTreeOptionsDialogCaolán McNamara
including ability to host a vcl::Window based XWindow hierarchy inside a native widget, e.g. the dictionary extensions have option pages Change-Id: I17d933bac12679e10164214a9045b677291a6557 Reviewed-on: https://gerrit.libreoffice.org/79070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld Application Colors pageCaolán McNamara
Change-Id: Ib074afdb9cf57decb435bb6ec3867af5989019ef Reviewed-on: https://gerrit.libreoffice.org/79225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20tdf#109158 improve sorting when loading large autocorrect fileNoel Grandin
reduces time from 2.0s to 1.7s reduce work by (*) reserving some arrays (*) pre-sorting with a cheaper comparator (*) don't copy when returning result, just return a const& (*) flattening the data-structures to reduce pointer-chasing Change-Id: I972bd7ffdbf2121c2d38c24aca9618ca708e920c Reviewed-on: https://gerrit.libreoffice.org/79119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-19use an explicit id for the default currencyCaolán McNamara
Change-Id: I437966b55226805d6de83b17221318eb1f0279b8 Reviewed-on: https://gerrit.libreoffice.org/79116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18fix some incorrect column idsCaolán McNamara
Change-Id: I17575fb6b24e5e09791dbd3f15c6cda662fefe65 Reviewed-on: https://gerrit.libreoffice.org/79087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18cui: infinite loop in SentenceEditWindow_Impl::MarkNextError()Michael Stahl
Looks like previously the aCursor never moved backwards so try to ensure the same for nCursor. (regression from 5261417cbb3051b812164838d19c0f748573df45) Change-Id: I7d2f04bbc6d1274ec4feff57927494f2eb5d665c Reviewed-on: https://gerrit.libreoffice.org/79071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-18column should be CairoSurfaceCaolán McNamara
Change-Id: Iaccc60edbb5729121b8258416a17345df2475f50 Reviewed-on: https://gerrit.libreoffice.org/79082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17weld DirectSQLDialogCaolán McNamara
Change-Id: I8f97068bb38a1fb888d60251f8f25506044c8451 Reviewed-on: https://gerrit.libreoffice.org/78970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-13Revert "Resolves tdf#127317 - Make text of tips of the day selectable"Heiko Tietze
Selectable text makes the GtkLabel unwrap; revert is needed until the control works properly This reverts commit 54a3044ebd7f946235ba1d0a8af11ad94872afb7. Change-Id: I7b63e0e29a22f3feddac99ac42735a1880a9b1c2 Reviewed-on: https://gerrit.libreoffice.org/78864 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-13Resolves tdf#127436 - Display issues of TotD on macOSHeiko Tietze
Dialog resizing blocked Change-Id: Ie61880d2d08adabf64a60e97a9bf00c02247f1ce Reviewed-on: https://gerrit.libreoffice.org/78761 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-13add missing model to treeviewCaolán McNamara
Change-Id: Idf268ea30da1b80d9418419b2336979685d7cf8c Reviewed-on: https://gerrit.libreoffice.org/78858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-07Fix typosAndrea Gelmini
Change-Id: Ia6760e685e7f38458a8c78e6304d06d0e7222805 Reviewed-on: https://gerrit.libreoffice.org/78740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06use unique_ptr in DoConvertToPolyObjNoel Grandin
Change-Id: Ia7f9ff4d8f7b9834b6634e5c126bd65014dacf19 Reviewed-on: https://gerrit.libreoffice.org/78684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-06Resolves tdf#127317 - Make text of tips of the day selectableHeiko Tietze
Change-Id: If0e0b04be8f7086d18fe3481c3bd8f65b48a0676 Reviewed-on: https://gerrit.libreoffice.org/78683 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-05Resolves: tdf#127033 use UI font for spell checking widgetCaolán McNamara
Change-Id: I18e0459bf16ee69860b7dcc8c5ecc75a7805fe13 Reviewed-on: https://gerrit.libreoffice.org/78632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-05loplugin:constmethod in cuiNoel Grandin
Change-Id: I06ffacbb02f3e9088e9c1a51e0e3e0d65d356f62 Reviewed-on: https://gerrit.libreoffice.org/78602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Ensure that VCL builder entry points use proper function typeMike Kaganski
This removes duplicating typedefs from NotebookBarAddonsMerger, and removes dependency of include/vcl/builder.hxx on include/vcl/NotebookBarAddonsMerger.hxx. Change-Id: Ica5787c934d1b8ce21623f28ce155337637fdf54 Reviewed-on: https://gerrit.libreoffice.org/78549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03Resolves: tdf#127120 double selection in B&N dialogCaolán McNamara
because the list wants to ensure that at least one thing is selected and the multiselect is implemented with two events of deselect-all followed by select. post a user event on getting either deselect or select and process it once when the dust has settled Change-Id: I553bf23d7a8c4625a8706fb2df4b169d91b7ad32 Reviewed-on: https://gerrit.libreoffice.org/78541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Parent reference should be const in VCL builder entry pointsMike Kaganski
Change-Id: I2331e19f5e23e0dde8edd22befc7287515adf37e Reviewed-on: https://gerrit.libreoffice.org/78536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara
move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02Related: tdf#126935 rearrange spell dialog for expected tab traversalCaolán McNamara
so tabbing through goes in visual left to right top to bottom direction Change-Id: I6ad13b7989464af805aa5ed8a080effe04b9b4c0 Reviewed-on: https://gerrit.libreoffice.org/78389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-02SmartArt edit UI: add new nodeGrzegorz Araminowicz
First approach to adding new node. Currently it's possible only to add top-level node to the end of diagram. Change-Id: Icd9530ab2fb8987a1690ffc96c244cc845b72eba Reviewed-on: https://gerrit.libreoffice.org/78286 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: I1abef2c2318e83aa8045d2b4763e74f45b4755e5 Reviewed-on: https://gerrit.libreoffice.org/78347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31Removed duplicated includeAndrea Gelmini
Change-Id: I540faa16148dfa3870cc97c7f339f3d8fafb1a08 Reviewed-on: https://gerrit.libreoffice.org/78339 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-30Hide macro selector button in kit mode.George Wood
Change-Id: If068d23a5aeb9be6d8e1736543c002bf2e68dacb Reviewed-on: https://gerrit.libreoffice.org/78321 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30tdf#127233: QR-code generator, use UTF-8 encodingJulien Nabet
Thank you Mike Kaganski for reference here: https://bugs.documentfoundation.org/show_bug.cgi?id=127233#c4 Change-Id: I01bbc408df8bc87cf4e8be52143efb9fc3fa1e38 Reviewed-on: https://gerrit.libreoffice.org/78304 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-29tdf#42949 Fix IWYU warnings in cui/source/{options,tabpages}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b6fda67ef7de65cc7b468dded862cd47dfd4269 Reviewed-on: https://gerrit.libreoffice.org/78078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27SmartArt edit UI: change plain text widget to tree viewGrzegorz Araminowicz
Added getChildren() data interface method, so that it's possible to recursively fill tree view with (id, text) pairs Change-Id: Ic100ded3a3e125bf79f5caa421cd8f91e5210954 Reviewed-on: https://gerrit.libreoffice.org/78169 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27Use osl::FileBase::getSystemPathFromFileURLStephan Bergmann
...instead of INetURLObject FSysStyle::Detect guesswork (with the hope of eventually phasing out use of the latter). (In each of the three places where a filesystem pathname would need to be converted back to a URL with osl::FileBase::getFileURLFromSystemPath, failure is rather harmless, so they don't check error returns and are marked as "best effort".) Change-Id: Ia312b49b20543cdd83aff5609bb054e0fc1dc194 Reviewed-on: https://gerrit.libreoffice.org/78165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Proof-read and fixes of Tip of the day stringsHeiko Tietze
Change-Id: Ib33ab6c7b72164b61b21255f240b26ae5fb75a9e Author: Mike Saunders Reviewed-on: https://gerrit.libreoffice.org/78164 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-26Directly compare filesystem pathanmes in SvxJavaClassPathDlg::IsPathDuplicateStephan Bergmann
...instead of going back and forth between filesystem pathnames and file URLs Change-Id: I9afb00a48b4de907af31ebd571891dc6be0a0f49 Reviewed-on: https://gerrit.libreoffice.org/78158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26Fix: Allow border in QR-code-generator to take zero as a input.Shubham Goyal
Change-Id: I742980f2e221afc5aff5eb666e69f63f2f990e84 Reviewed-on: https://gerrit.libreoffice.org/78050 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-24loplugin:returnconstval in connectivity..cuiNoel Grandin
Change-Id: Ie6444713088c14d1821640f6eb219cee3d6ee542 Reviewed-on: https://gerrit.libreoffice.org/78056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24Fix typoAndrea Gelmini
See: https://bugs.documentfoundation.org/show_bug.cgi?id=127103 Thanks a lot to Emil Tanev (e m o _ a s s e n o v at y a h o o dot c o m) Change-Id: I39fb0f3457383d07c0a48fdf52631ab11e510c02 Reviewed-on: https://gerrit.libreoffice.org/78005 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-23Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#126720 Fixing label length fix UI breakShubham Goyal
Change-Id: I4fefc4fcb64388fb3c3ca35b73a7264b381d4e6f Reviewed-on: https://gerrit.libreoffice.org/77751 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2019-08-23SmartArt: add Edit Diagram dialogGrzegorz Araminowicz
Currently it displays only text representation of diagram. Change-Id: I3ff12c4abf2ed32f68ea9d7437905afc13279e62 Reviewed-on: https://gerrit.libreoffice.org/77873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-22weld ODbTypeWizDialogSetupCaolán McNamara
split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22QR Code : ODF import/exportShubham Goyal
Change-Id: I6c1ae63a89d5ed34d2fa245279d4552949bb64a7 Reviewed-on: https://gerrit.libreoffice.org/74853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22Reduce default border value in the QRCode DialogShubham Goyal
Change-Id: Ie821f1762bbe941caedd58db330e84950e83f8be Reviewed-on: https://gerrit.libreoffice.org/77868 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-21Avoid extra calls to INetURLObject::decodeStephan Bergmann
Change-Id: I700c4093213395a12342534fb7685969b5e5b220 Reviewed-on: https://gerrit.libreoffice.org/77891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-21Resolves tdf#126805 - Alignment of Tip-of-the-day labelHeiko Tietze
Change-Id: Ic4845dd87325ec952b8b987b69eedd8530b1cf02 Reviewed-on: https://gerrit.libreoffice.org/77703 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-20Fix libreoffice version for links in tipofthedayChristophe JAILLET
tipoftheday.hrc has some URL with fixed LibreOffice version (6.0 and 6.2) Use %PRODUCTVERSION instead and perform the convertion to the correct version at run-time. Note, this can have the drawback to point to dead links if a newer version of the online doc removes a page or changes its path. 'en-US' could also certainly be handled the same way. Finaly the 'uiResId(aLink.toUtf8().getStr()' to get it converted is certainly a hack that should be implemented in a better way. So consider this patch as a PoC :) Change-Id: Ibdcaedde631f1a243e0ec54cdec6c488c04b8f29 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/75971 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>