summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert MESS_BTN to scoped enumNoel Grandin
Change-Id: I9332216f58268b20b3b8e9488471279d70c519ad
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-09fix windows and android buildNoel Grandin
Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-07tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh
Removed "suggested" from categories label. Fixed URL checking. Change-Id: Ifbea40cf724c91f6af72c485d9ae7eb599afff65 Reviewed-on: https://gerrit.libreoffice.org/24716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-06tdf#70998 Termchange: Graphic->ImageSamuel Mehrbrodt
Change-Id: I561a4d81a4fa8d5a6cc5f92b11ed480e833dadcc Reviewed-on: https://gerrit.libreoffice.org/24697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05SvxIconSelectorDialog was never destructedMaxim Monastirsky
Change-Id: I6cc9bd70f3e3f4266af0eddfff8be406021a1d66
2016-05-04loplugin:staticmethodsStephan Bergmann
Change-Id: I679fd93c409035ce87101f7fe150822c2214765e
2016-05-04tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh
Persona Dialog modified. Search supports Firefox Theme URL. Added display of installed theme on personalization dialog. Fixed category buttons. Added SOLID as category. Removed invalid/duplicate results. Change-Id: I603c0c292fe5c3e380553b9a2eaab6f4bc0683e1 Reviewed-on: https://gerrit.libreoffice.org/23385 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any ctor from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens to work in environments where sizeof (bool) == 1. The simpler alternative is to use the Any ctor template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: I0f72c73a088ef96e069c3ed8c78546b16d89b50a
2016-05-03tdf#99211 Use the restart dialog for notifications about restartirem
Change-Id: I2093e99d7b377285f6b3248a90072f0dea12f732 Reviewed-on: https://gerrit.libreoffice.org/24556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-29Refactoring transparence tab codeRishabh Kumar
Move transparence tab code out from Area tab code. Change-Id: Ia7276aa3b1c438b6c8cff89ab5ca3752ff6bcc0e Reviewed-on: https://gerrit.libreoffice.org/24368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-28tdf#97087 Give comprehensible, unique names to idlesMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101 Reviewed-on: https://gerrit.libreoffice.org/24388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-26tdf#89953: put zero kerning if item state has been invalidOliver Specht
Change-Id: I96d81ed7654dc310df68a7ff376bbcd2e1d5810b Reviewed-on: https://gerrit.libreoffice.org/24361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22tdf#89953 Character spacing: Increment by 0.1, not by 1Samuel Mehrbrodt
and adjust the page size to 1 instead of 10 Change-Id: Ia6d964b8bb057ef8161890d36dd059922bbcbe9a Reviewed-on: https://gerrit.libreoffice.org/24302 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-22tdf#89953 Character spacing: Allow to enter negative valuesSamuel Mehrbrodt
without selecting from a condensed/expanded listbox first. Change-Id: I1111e6f1d7cdc6c0bc79d542f49c58f1022ad739 Reviewed-on: https://gerrit.libreoffice.org/24301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I263603fb81d368ebc8450b2d8cc01752fcd3f29d
2016-04-22Related tdf#88502 a better implementation than the one in...Giuseppe Castagno
...commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1. This commit reverts previous implementation in commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1 and makes use of a dedicated interaction wrapper instead. See comphelper::SimpleFileAccessInteraction for details. Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf Reviewed-on: https://gerrit.libreoffice.org/24275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-21loplugin:rangedforcopyStephan Bergmann
Change-Id: I227aa955417385da7cd43cc3641342e66e62ed96
2016-04-21fix windows buildNoel Grandin
after my commit e1af7f0c438bc242e4562aa0286c99787b5ad544 "clang-tidy modernize-loop-convert in c*" Change-Id: Icbc8c30186b0ea33933365951718dfad3fd7c4e2
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I0953cecd363dd75e6a4438d34d47035f53f334a6
2016-04-20SvxNumberFormat::SetIncludeUpperLevels takes a sal_uInt8, not a sal_BoolStephan Bergmann
Change-Id: Ifc86437140bae3223238fa8e5aaf5a4d57537b32
2016-04-20tdf#99361 Separate checkbox in Number dialogLaurent Balland-Poirier
"Thousands Separator" and "Engineering notation" used the same checkbox, so help tips texts were the same. This commit creates a second checkbox which is hiden/shown according to category selected Change-Id: I94913e63e47b760deb747ce7cd3d74ab4c109599 Reviewed-on: https://gerrit.libreoffice.org/24224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18cppcheck: silence known condition warning in cuiJochen Nitschke
Change-Id: I8dfe3aa3c133ebb8ab6de058ae8335513bfb3f3b Reviewed-on: https://gerrit.libreoffice.org/24199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18postit dialog is too tallCaolán McNamara
the initial size hack has come unstuck, do it the now-standard way or explicitly setting an initial size in code Change-Id: I89c73e433b1974514fa2a68eb9bd5373142c313a
2016-04-18cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Iee9d28c9630a144e4da8e46e58f01a4be99aa961
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in cuiNoel Grandin
Change-Id: I13c2956ad5012373a41c8e6c2af70583fa18c339
2016-04-12Move clew/clew.h into external, tooStephan Bergmann
For consistency with what 38cd1d9a5f00dc69ba0d60e2fe6957090c7a26d1 "clew: move this foreign code to external/clew" did for clew.c. Library_scfilt depends on clew/clew.h, simply make it depend on the full clew external. Change-Id: Idcbf56a69084e108832c8970507ebea0f7ff400b Reviewed-on: https://gerrit.libreoffice.org/24035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-12tdf#99104 Checkbox in User Data page isn’t aligned to anything in the sectionAdolfo Jayme Barrientos
See comment 6. Change-Id: I492b8fa9a0e018ded46a6ebe290088898bdfe3d9
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I7d5eec4c8bcfc79edb3c0ea37cf73b4249f44f46
2016-04-12Remove empty scriptdlg.hrcStephan Bergmann
Change-Id: I4a4bf1aa1d6afe819c22288474be302fe95740d1
2016-04-12clang-tidy performance-unnecessary-value-param in cuiNoel Grandin
Change-Id: I93a09bf8e475ec1aa2ebf7754c7048c81696922b
2016-04-11RID_SVXSTR_LANGUAGE_RESTART is not needed any more.Jan Holesovsky
Change-Id: I426026938c4cf0e6af22be11dca8e68f991004c0
2016-04-11tdf#79656 Restart now window for language changeBerk Gureken
When you change the UI language and click OK, Restart Now window opens instead of warning window. Change-Id: Ic503bf4536a855891456f48745b748786857200f Reviewed-on: https://gerrit.libreoffice.org/23421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>