summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
8 daystdf#96787 AutoCorrect: find item with ".*" and between :colons:László Németh
It was very hard to disable autocorrection of (c)->© and other AutoCorrect items, because the searched Replace string "(c)" etc. didn't jump the list cursor to the corresponding ".*(c)" item. Now skip ".*" pattern matching marks, also colon (emoji replacement) characters, so the list cursor jumps to the line ".*(c)"->© typing only "(c" etc., allowing users to press Delete to disable its autocorrection without knowing about the special AutoCorrect patterns. Follow-up to commit 50be3fa1f0f3b8870af5bda88b65f835ef37d77e "tdf#141773 AutoCorrect: fix broken [All] dictionaries". Change-Id: I72be1ecb2fdc5ae67c72727ce7fbd70b28a4125b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169714 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e5507c8a003328f629ae924fbba14155c13e7a12) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169734 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-10tdf#159375: remove initialization on Tools>OptionsBayram Çiçek
- Initializing some dialogs at the startup of Options makes it opening very slow on some low-power systems. - This patch removes this initialization. This means, all dialogs will be initialized at the time of search. Therefore, we should wait a bit longer when typing on the search bar to get the results... - remove the default parameter "nNumberOfNode" from initializeFirstNDialog() - rename initializeFirstNDialog() to initializeAllDialogs() Change-Id: I4fd9c5673f7edecfe6a6621b6018d5d405f112a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167023 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Moritz Duge <moritz.duge@allotropia.de> (cherry picked from commit dd3953f705cc19aad4b0fcec7fd2961246b659e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167450 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-05-09make object name dialog asyncNoel Grandin
Change-Id: Icf81810297dc5767cedd051cf8ccdfbb101f35ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167361 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-05-08Resolves tdf#141778 - Size issues on view options UIHeiko Tietze
Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166894 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 77be21b5bd0bd339b2e629f5ec5ee00887033781)
2024-05-08tdf#159625: fix "allow to split paragraph"Julien Nabet
2 pbs here: 1) bug described in the bugtracker, the uncheck isn't kept => just remove all the buggy GetOldItem stuff 2) after unchecked the option then saving the file and reloading the file, the option is still checked => change the buggy rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_FALSE, _nWhich ) ); to rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_TRUE, _nWhich ) ); In fact, I just mimicked the code used for "keep paragraphs" which works well. Also change the QA test since "allow to split paragraph" is checked by default so if the QA simulates a click on it, we expect the value to be false when dialog is opened again Change-Id: I947feb02e0c282304621a252ad5e4c168c1d295a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166774 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 83236587bfca52513515b0b7a7dbfa18eed11503) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166725 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit cf370be03dfc6eb2cd4643548f2f25ad3bfc6612)
2024-05-06tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/Miklos Vajna
The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the anchor paragraph is RTL, so swapped the "from left" label to a "from right" label. Don't do this when the compat option is enabled, so not only we render correctly but the UI now correctly explains why we came up with the correct position. (cherry picked from commit 0f410680461d7ba5f70dd65b2a8263dec15ac357) Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167183 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-04-22tdf#159395-LanguageTool use correct default URL when username/APIkey setLeonid Ryzhov
Change-Id: I31e1c2f1dfd96d87f60b6be1e5abce4837827a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 155a6af93a8ac90cab15968f5dd499ab77ad9f72) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166097 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-07Resolves: tdf#160159 update spellchecking area colors when style changesCaolán McNamara
so for the case of using "automatic" for the document background the spelling checking textbox background area updates to match Change-Id: I8723afb946176596b0a5fa43aa3bb3c036dee12c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165476 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-03-14Hide "Add and resize" button from numbering and bullets dialog for ONLINEDarshan11
- Image tab had "Add and resize" option for numbering and bullets dialog - which is not need in online - so we will just hide that browseBtn for online Change-Id: Ib87f1e7ae7e6df5256ab77122b477695a45cf441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164587 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 08a5c1352f4d65c180995cdfca5c981f88035901) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164818
2024-02-09tdf#159572 select font according to recent settingsOliver Specht
selection of a recently inserted special character applies the stored font to make sure the character is not inserted wit a font that doesn't contain the symbol Change-Id: Id61bfac3a2ff22dbdae8a5b83f000d3f0c3e992b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163004 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163128 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-06tdf#159128 UI: Open Security settings option directlyBalazs Varga
Open Security Option Setting page directly from Security pop up warning infobar. Follow up of 1f440348eb0892fd2c9597806d87b5fe9d60d49a (tdf#157482 UI: Turn Security Warnings popup windows into infobars) cherry-pick from commit: 2c16ea16b305dc546164e28cf6b212ebccc44ec4 Change-Id: Iac116677801bdb13a9680bcfdf532ec3d874ce0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162393 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162491 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-06tdf#151352 keep a reference to the parentCaolán McNamara
and use that in the dtor instead of a pointer. FWIW the XWindow isn't actually a vcl::Window in the Gtk case, so VCLUnoHelper::GetWindow doesn't do anything there. But using an XWindow gives a safe view wrt life cycle. Change-Id: I4d0fd707ea931a76d6f87f434f7ece8df066785c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162720 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-01-29invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
since: commit fe946f86ad6586fa810cae5c0f246389a285e172 Date: Wed Nov 29 15:25:06 2023 +0100 Bump Glade version Change-Id: Ide86220f260dac40395389530e7221ea8de8f092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162611 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-01-17tdf#159186 Use changed value when editing string-list a second timeSamuel Mehrbrodt
Change-Id: I0e26a053b3b5fb04abf87894bcfebccea8bdd26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162074 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 76ce6466b814bb9ff119f4f83795a2aeefc28793) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162097 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-01-15[cp] Rename UI Variant from Standard Toolbar to CompactPedro Pinto Silva
To be more in-tune with COnline options Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I38c4d1639dbf7d726fb8c3d784a298cd01a97201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136743 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-01-15[cp] About: Darkmode: Use different about imagePedro Pinto Silva
Fixes the use of the same about.svg even on darkmode The way we are loading the svgs makes, when in presence of dark mode, the rendering of svgs very very poor on those dialogs. It adds artifacts , doesn't render gradients properly (at least when compared to light mode) and adds white outlines everywhere. Fix this by providing a simpler and more legible svgs to be use in dark mode and load them only in that mode. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ib1a95f7d7a2be62b9b001b4c811c22104cc01b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117663 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-01-15[cp] Collabora Office brandingAndras Timar
Change-Id: I694d9a6c508853d2d980f76cc259ce1e39149da4
2024-01-12Resolves: tdf#159138 don't expand dialog to fit excessively long urlsCaolán McNamara
this widget is the one that ends up controlling the insert hyperlink dialog width Change-Id: I09aaa32e96c4ddcc3e608cb24e67a669d376120f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161961 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-01-11Resolves: tdf#159086 add sensitive model<->treeview mappings for checkboxesCaolán McNamara
These are basically implicit in vcl. For gtk if they are used they have to exist in the .ui, and to keep in sync with vcl there is basically just the one pattern that is allowed. Change-Id: I0f5603239569e9d39379515313a35d82d9266480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit d6996f399b82fb0482850829349a4bf1647529b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161868 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-01-05Resolves: tdf#158965 Find Record: Similarities dialog doesn't appearCaolán McNamara
and assert in DBG_UTIL mode regression since: commit 36343165c251e30c700360cc5c4266f576d4ac00 Date: Wed Jan 25 11:07:28 2023 +0000 cui: Make SimilaritySearch dialog async and enable use for jsdialog Change-Id: Iee2071874836ccf8a1ab10fbc6d6b3c491fd04ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161631 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-26tdf#158837 hyphenation crash in: int rtl::str::indexOfStr_WithLengthNoel Grandin
the code was already dodgy, passing in an invalid nPos, which triggers an assert. However, it appears that previously that dodginess was ignored, until commit 5ebccaa07589383653dbd65e58204a82dd3cde09 author Noel Grandin Sat Apr 10 17:27:08 2021 +0200 use std lib for O[U]String indexOfStr which turned it into a crash. Add a check to avoid the crash, no idea what the right fix would look like. Change-Id: I826b9af0b2d9c7c297214ce2d54c664fb573edd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a89a42e55f2b154c8b276fe08fcf02c4b9fc0945) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161310
2023-12-22Remove DeleteItemOnIdlexArmin Le Grand (allotropia)
There are some CrashReports in 7.6 which have DeleteItemOnIdle on the stack, but there is nothing reproducable. So I took a look... I first thought it's a MCGR regression, due to classes on the stack. But the Item involved is just random, can happen with any Item. Then I thought it may have to do with ITEM refactorings, but it happens with DeleteItemOnIdle involved, so also not the case. I already saw DeleteItemOnIdle when doing these and qualified as 'hack' in the way. already It is only on Windows and DeleteItemOnIdle is involved. This again (took a deeper look now) is an old hack to keep an SfxPoolItem 'alive' for some 'time'. For that, it triggers an async reschedule which then deletes the Item when being called. If the Item will be used after that is pure coincidence - seems to work in most cases. It seems as if for Windows the timing slightly changed for some scenarios, so a reschedule is too early. This can happen with this hack anytime. DeleteItemOnIdle is used in scenarios where SfxPoolItem* is e.g. returned, but is *not* anchored, so e.g. not member of an SfxItemSet. Or in short: Lifetime is not safe. DeleteItemOnIdle exists since 1st import, but was changed to AsyncEvent ca. 4 months ago (see 57145acf9ec47c23e307b7a5c0029d21d937cc35), so that may have caused it. It is possible that these errors happen on Windows since then. Before something more complicated was used to delete it late, but surely also not really safe. Due to ITEM refactor I have the knowledge/tooling to solve this. It will not be a 1-5 lines fix, but it is a hack and in the way for further ITEM refactor anyways. What we have nowadays is a SfxPoolItemHolder -> it's like an SfxItemSet for a single Item. It safely holds/ controls the lifetime of an SfxPoolItem. It is already used in quite some places. It helps to solve many hacks, also the ones putting Items directly to the Pool - due to there never was an alternative for that. In principle the ItemPool/ItemSet/Item paradigm was never complete without SfxPoolItemHolder. Thus I started to fix that (and remove that hack for good, sooo many changes over the years, sigh), but as said is not straightforward. Will have to change retvals of involved stuff to SfxPoolItemHolder - it's just two pointers and designed to be copied (one is a Pool, needed to cleanup when destructing). CopyConstruct/destroy just counts the RefCnt up/down, so cheap. 1st version compiling, let's check on gerrit... Corrected one error in QueryState for securitypage, also added some security features/asserts. Change-Id: Ida49fd35ca88ead84b11d93e18b978cb9e395090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161083 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 789a737ac92c4f2b0eb9820b99c43cc8253c8b29) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161158 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-22tdf#156820 Fix crash in custom color pickerNoel Grandin
which requires (*) keeping ColorPicker alive during the runAsync in ColorPicker::startExecuteModal (*) keeping the PaletteManager alive during the ExecuteAsync in PaletteManager::PopupCOlorPicker Noting that MattK debugged the cause of this. Change-Id: I07efe8e6514f8882b1347c79c6150578c234bb9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161054 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 78ccae0d42d168f845ddbd7cb694d80dfb04f84d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161161 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-19Hide --enable-online-updaet-mar GUI behind ExperimentalMode for nowStephan Bergmann
(and rename SvxOnlineUpdateTabPage's is...OnlineUpdateEnabled predicates to is...OnlineUpdaetAvailable, to avoid the overloaded term "enabled" here) Change-Id: I639ac72a17b98c883ff3082747b8576099299867 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160975 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 7efdb261bdb11e669e80d62834985d04cb90bde9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160947
2023-12-18tdf#158720 Fix crash when searching expert config with gen vcl pluginSamuel Mehrbrodt
Change-Id: Ida2f17c8dfb638bb6791dba32ae3b190b06254de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160920 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 9e02641932992cad3f8d4e363414b2756f0f8e52) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160931
2023-12-15Fix placement for --enable-online-update-mar UIMichael Weghorn
* Resave with glade 3.40, which did all the changes to the .ui file * to be safe, explicitly hide the UI in the C++ code when building without `--enable-online-update-mar` (UI wasn't shown in a quick test with qt6 even without that, but better be safe) Addresses this issue mentioned in [1]: > - Online Update". (For non-GTK VCL backends, there's still a bug that > the "Automatic Update" section on that options page is mixed into the > traditional --enable-online-update options at the top of the page, > instead of down at the bottom; fixing of > cui/uiconfig/ui/optonlineupdatepage.ui welcome...) [1] https://lists.freedesktop.org/archives/libreoffice/2023-December/091309.html Change-Id: I2fadbb3b93206834b8c2c17cb540fb0b0687742b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160830 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins (cherry picked from commit 42637c62c314aaed7587fb1ece2841f644bb7149) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160851 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-07GUI to en-/disable the --enable-online-update-mar feature at runtimeStephan Bergmann
...sharing the existing option tab page for the traditional --enable-online-update feature Change-Id: Ic7b04bf15bf841a46a96d62cf5a857deaa399428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160430 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07simplify and modernise ScopedBitmapAccessNoel Grandin
(*) Make all of it use a "Scoped" paradigm (*) pass by value, no need to allocate on heap (*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods. (*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places. Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-07tdf#157432 Expert config: Allow filtering by changed valuesSamuel Mehrbrodt
Change-Id: Ib8bbb7fc9e8014a9367278f3fa640f53af46dd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159986 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-04cid#1546021 Using invalid iteratorJulien Nabet
and : cid#1545983 Using invalid iterator cid#1545969 Using invalid iterator cid#1545949 Using invalid iterator cid#1545929 Using invalid iterator cid#1545911 Using invalid iterator cid#1545910 Using invalid iterator cid#1545886 Using invalid iterator cid#1545870 Using invalid iterator cid#1545813 Using invalid iterator Change-Id: I2ad10c2a9affd348050a4abe0917a90927a52547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160317 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04tdf#155676 Properly support editing string listsSamuel Mehrbrodt
Change-Id: I721e30aca03ddadd3a08e092e75accbd279bbec5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160315 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-04tdf#157402: translate personasJulien Nabet
Change-Id: I6b2bc6f8fa76ddb669a71d0858a43c62bf51d58d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160240 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04tdf#158457 Use proper parentSamuel Mehrbrodt
Change-Id: Ic7bd3a2ae4dd0e21186df30bf221cf14c3511ac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160161 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-04Expert config: Allow editing settings without default valueSamuel Mehrbrodt
Fix fallout from 700ac29771ccec2d66934f66b45a33a48a5ac3f1 Change-Id: I194912d59e65c3b1245e5f9d107e4d2e8324e731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160294 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-04cid#1546422 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546416 COPY_INSTEAD_OF_MOVE cid#1546415 COPY_INSTEAD_OF_MOVE cid#1546391 COPY_INSTEAD_OF_MOVE cid#1546390 COPY_INSTEAD_OF_MOVE cid#1546317 COPY_INSTEAD_OF_MOVE cid#1546252 COPY_INSTEAD_OF_MOVE cid#1546251 COPY_INSTEAD_OF_MOVE cid#1546249 COPY_INSTEAD_OF_MOVE cid#1546243 COPY_INSTEAD_OF_MOVE cid#1546195 COPY_INSTEAD_OF_MOVE cid#1546193 COPY_INSTEAD_OF_MOVE cid#1546137 COPY_INSTEAD_OF_MOVE cid#1545738 COPY_INSTEAD_OF_MOVE cid#1545782 COPY_INSTEAD_OF_MOVE Change-Id: I10d5091aa72b682371764b8a18cc5062e272c031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160285 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-04cid#1546483 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I41c2d42e64d25c7333f66b21bf294862bb04483a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160275 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03cid#1546503 Using invalid iteratorCaolán McNamara
and: cid#1546480 Using invalid iterator cid#1546479 Using invalid iterator cid#1546454 Using invalid iterator cid#1546419 Using invalid iterator cid#1546410 Using invalid iterator cid#1546150 Using invalid iterator cid#1546039 Using invalid iterator cid#1545831 Using invalid iterator cid#1545736 Using invalid iterator cid#1545701 Using invalid iterator cid#1545630 Using invalid iterator cid#1545381 Using invalid iterator Change-Id: I9e151b623f751ee1e982b5da0011ff08ab0ad5e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160270 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-30Bump Glade versionHeiko Tietze
Change-Id: If440010790e170fa1c88b8cbdef5f7eaa3efd686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160108 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-11-28-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Ide7172c567f595fb7e44f19c8d96ab8d6b751491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160007 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-11-27Move a cui header inside the moduleJulien Nabet
+ fix building issues about "cuidllapi.h" + remove #include <cui/dlgname.hxx> in some cxx since their corresponding hxx already contains the include Change-Id: I2396104fbcbca2e1aca29cdb2324ae0f4daf63cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159996 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-27tdf#157438 Make int/double lists editable in expert configSamuel Mehrbrodt
Change-Id: I4334917e8ac6ae4deb5b15de326b083a4a1c1a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159863 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-25tdf#158357: UI simplify Hyperlink dialog by removing Hyperlink type radiobuttonJulien Nabet
+ rename "Hyperlink Type" into "Hyperlink Settings" + remove "Protocol" since ther's only 1 now Change-Id: I9435606c6ac6eca87afc4c259fb1121f65638c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159947 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-24tdf#158345: Opening Hyperlink dialog leads to crashJulien Nabet
terminate called after throwing an instance of 'com::sun::star::datatransfer::UnsupportedFlavorException' relevant part of bt from this exception: 0 0x00007f34fd6b0231 in __cxa_throw () at /lib/x86_64-linux-gnu/libstdc++.so.6 1 0x00007f34e9d8207d in x11::X11Transferable::getTransferData(com::sun::star::datatransfer::DataFlavor const&) (this=0x562594fc9af0, rFlavor=...) at /home/julien/lo/libreoffice/vcl/unx/generic/dtrans/X11_transferable.cxx:58 2 0x00007f34e9d825ec in non-virtual thunk to x11::X11Transferable::getTransferData(com::sun::star::datatransfer::DataFlavor const&) () at /home/julien/lo/libreoffice/instdir/program/libvclplug_genlo.so 3 0x00007f34e15589f2 in SvxHyperlinkTabPageBase::Reset(SfxItemSet const&) (this=0x5625958378f0, rItemSet=SfxItemSet of pool 0x562591482920 with parent 0x0 and Which ranges: [(10361, 10362)] = {...}) at /home/julien/lo/libreoffice/cui/source/dialogs/hltpbase.cxx:468 See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=191029 Regression from: 89d3735e05b98223a49a387421386fd736fc3de6^! tdf#146576 - Propose clipboard content when inserting a hyperlink Change-Id: Ic111b8348f2288c4e9e6760fe6f7f48faadec582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159939 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-24Bump Glade versionHeiko Tietze
Change-Id: Icea5b88e0e8281803a5deb09619476cccff3b39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159866 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-11-20Use existing types, instead of stringsSamuel Mehrbrodt
as suggested in https://gerrit.libreoffice.org/c/core/+/158028/comments/b7a803f4_7e5899ca Change-Id: I7d4c46b24307922b51e463bacdfacfca85956b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159524 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-20Extended loplugin:ostr: cuiStephan Bergmann
Change-Id: I2cdd90f8eafab4900c42c706da2abc38077f6103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159720 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-20tdf#157438 Make string lists editable in expert configSamuel Mehrbrodt
Change-Id: Ia8b8553d547e760c18624c5c599951523b74ac82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159523 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-18tdf#157716 - Rename "Language settings" to "Languages and Locales"t-aswath
Change-Id: Idd31b18c87998b03d884e7aa17197c459241abf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159315 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-11-18Related tdf#49895: Mark strings as translatableTaichi Haradaguchi
...and add context strings Change-Id: I2531fc9e24db7e99b440b8042b8a502a2faaa2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159567 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-11-17tdf#154543 - Paragraph dialog: reset snap to grid to parent settingAndreas Heinisch
Added the SID_ATTR_PARA_SNAPTOGRID to the alignment ranges in order to reset the snap to grid option to the corresponding parent setting. Without this parameter, the main dialog does not have any knowledge about this option. Change-Id: Ib090fae0919be54dd41674d129f5355c3566a90c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159565 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
generated by cgit (git 2.34.1) at 2024-07-11 23:03:51 +0000