summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-13tdf#92700 Add extended help tip about searching for combinationGabor Kelemen
by pressing the searched combo. Also add new tips for widgets that were missing one while at it. Change-Id: I6c4c1900557d231625061fd0555ce1f990e11aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108882 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-13fix indents to be consistentCaolán McNamara
git show -w is empty on this commit Change-Id: Ifc139cf4557ae9c2664057d2ed87e020330d17c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12transparency->alpha in tools::ColorNoel
this just changes the Get/Set methods, the constructor and internal representation of Color is not changed. Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12tdf#83618 Make line spacing values agree crash fixJim Raykowski
The intent of this patch is to fix the crash reported at https:// bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to cui/source/tabpages/paragraph.cxx in commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1 and changing the change made to svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the already available pointer to the current SfxViewFrame instead of calling the SfxViewFrame::Current function again. Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109152 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10add newline to end of .ui files that lack themCaolán McNamara
so all the .ui files are homogenous to simplify mass conversions Change-Id: I01336fd579025a8464f0d4d5c46dec3f65895b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09fix coverity parse errorsCaolán McNamara
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-08replace deprecated gtk-go-up, gtk-go-down, gtk-save and gtk-open labelsCaolán McNamara
Change-Id: Iaced32a6810b1a510dc300458a8860b7994226f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-08use more IsTransparentNoel Grandin
Change-Id: I3ef18a2601a51d56614b5da9b56e871bd33ec79e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-07replace deprecated stock labels used <= twiceCaolán McNamara
replace single use of deprecated gtk-paste replace single use of deprecated gtk-play replace single use of deprecated gtk-stop replace only two uses of deprecated gtk-clear replace only two uses of deprecated gtk-find replace only two uses of deprecated gtk-media-next replace only two uses of deprecated gtk-media-previous Change-Id: Ia749c03ad5887f7919b1d0dc2facf8ae7e5fb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07Use o3tl::temporary in calls to OUString::iterateCodePointsStephan Bergmann
...that are not interested in the updated *indexUtf16 value Change-Id: Iaaa0fe45dcb54c4a8a347bcdb6fca6041218d009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108941 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-07one gtk-delete stock id with contextCaolán McNamara
no other use-stock has a context Change-Id: I6092cf82ca34b3a9cbf7b0609649c23298e0c0d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for cui part c git show -w is recommended to view these changesets Change-Id: I8c37b4904b528b5afe01c26b83c8df27b251909f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108688 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06Drop comphelper::string::equals; compare OUString to OUStringCharMike Kaganski
In cui/source/tabpages/autocdlg.cxx, use code point-based methods for comparison with sal_UCS4 values in SvxSwAutoFormatFlags. Change-Id: If34c981393774d1b8db649f0c29870e1ca6bdfe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-05tdf#96678 Add accelerators to Font Effects tab pageGabor Kelemen
and remove some unnecessary mnemonic_widget associations Change-Id: I7bb8060598d4b76d0de6fef9a5dd8bf3d293bf89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-04Removed duplicated includeAndrea Gelmini
Change-Id: I42aa81e60d9db8252428ec26999bcb1840b2c9e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-01-04drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for cui part b including removal of strange empty "align12" which shared cell of "shadows" in borderpage.ui Change-Id: I9ed043367a0e3474a215b5dc0af3dd1bd296e54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-04tdf#133718 Add accelerator keys to Hyperlink dialog tabsGabor Kelemen
Also change an accelerator on the Internet tab to avoid clashing with the new one for Mail tab Change-Id: I24a03647ccba6901b1865f5ca4228e54d686d662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-04tdf#138654 Number format preview uses dark background and fontprincesinghtomar
Change-Id: I5f2ad87f017159191e39a4a1ce665c01d3223e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108400 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-03drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for cui part a Change-Id: I70eabdd50c2cf9370ebc25c915b0c474e9d39679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-03Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-02introduce Degree100 strong_int typeNoel
Change-Id: I78f837a1340be0ca5c49097f543a481b7b43a632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108367 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-01use SdrAngleItem for SID_ATTR_TRANSFORM_SHEARNoel Grandin
Change-Id: I418614978e41ef965c8651ee5d97c658e5315227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-28tdf#127611 Hardcode mnemonic key for "Hidden" checkboxMing Hua
In "Font Effects" tab of the welded Character Format dialog, all mnemonics (keyboard accelerators) are automatically generated, except the four buttons "Help", "Reset", "OK", and "Cancle" at the bottom. Unfortunately the current mnemonic generation mechanism doesn't consider these buttons and assign H for "_Hidden", and clashes with "_Help" which also uses H. Ideally the mnemonic generation mechanism should be fixed to consider other parts of a welded UI. Meanwhile this commit provides a workaround by hardcoding "Hi_dden" to use D as mnemonic. Change-Id: Ib59b7ba338be405908f349a22dd8d36ea4ee490b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106670 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-28use SdrAngleItem for SID_ATTR_TRANSFORM_ANGLENoel Grandin
as a precursor to introdcing a strong_int type for hundredths of a degree Change-Id: Ie2d7ad3b48d01defb43bf2e11e6494c4b999de0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-27replace margin-left with margin-startCaolán McNamara
and restore assert to not use margin-left/right anymore Change-Id: I05d2a4cc829ed9de3cca73d987f5a66e0582eaa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-27Drop some unnecessary HDL macrosGabor Kelemen
Change-Id: I48586a9648183df2ecd18f15a596a23c36aa15f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-24custom literal for Degree10Noel Grandin
Change-Id: Id13869138a622e62d9ffebf2c89bddccda6aff01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23Rename sorted_vector::erase(size_t) to erase_atJan-Marek Glogowski
emscripten clang fails with: sc/source/core/data/attarray.cxx:378:44: \ error: call to member function 'erase' is ambiguous aNewCondFormatData.erase(nIndex); ~~~~~~~~~~~~~~~~~~~^~~~~ include/o3tl/sorted_vector.hxx:86:15: note: candidate function size_type erase( const Value& x ) ^ include/o3tl/sorted_vector.hxx:97:10: note: candidate function void erase( size_t index ) This looks like a compiler error, but if the vector contained size_t values, this would also be ambiguous to begin with. So this just renames erase(size_t) to erase_at. And instead of a 2nd find in the failing code, after copying the vector, it mow uses std::distance to remove the item. Change-Id: I7d03ff32352a1890cc01ca241452c0f00d6a9302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-23tdf#127401 Fix release notes URL for simplified Chinese (zh-CN) UIMing Hua
Use getBcp47() instead of getLanguage() to construct release notes URL for About dialog, just like what commit 787647b488d02be2acbbad4fa7873508dcb926c2 did for WhatsNew infobar. Should also affect other locales using ll-CC style wiki notation with both language and country codes, like pt-BR. Change-Id: Ic4698946f500b5901eb0c519f1fd4e3a4b8456cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108147 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-22use small-button style to remove GtkLinkButton left marginCaolán McNamara
Change-Id: I21a2c97a2d60390f97f84b15a42e2f14edd6d59e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated 'rules-hint'Caolán McNamara
Change-Id: I8b41ca34d6b751a8086a4a1879a42520dcd9b6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace deprecated xpad/ypadCaolán McNamara
drop entirely suspicious xpad/ypad which are probably accidental Change-Id: Ie80d93502359373e38cc61f63cd5bec962f5d193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-20No longer need to worry about ambiguous operator== in loplugin:stringviewparamStephan Bergmann
...after 46c5de832868d2812448b2caace3eeaa9237b9f6 "make *String(string_view) constructors explicit" Change-Id: I6e884c762a2fc91f5dd6fbb197a596fd60f17cae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-19don't mention VclBuilder in the dialog tests docsCaolán McNamara
Change-Id: Id18a25e3d3310342887757fe417769f4213b8a3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-19make *String(string_view) constructors explicitNoel Grandin
to make it more obvious when we are constructing heap OUStrings code and potentially inadvertently throwing away performance. And fix a handful of places so revealed. Change-Id: I0cf390f78026f8a670aaab53424cd31510633051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-18lok: run async the Macro Selector DialogHenry Castro
Required to be called by the client side Change-Id: I9c9d22dd249839009bdc6a701553f3b9d776347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107246 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-18tdf#138865 don't set ColumnToggleType::CheckJan-Marek Glogowski
We don't want any hidden, magic checkbox for this table, as the user explicitly has to toggle the desired replacement modes, which isn't in any way related to a row selection. Change-Id: I3f9a73d41cc8727aa6380172221ea07068ef74c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107920 Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org>
2020-12-17tdf#138976 change "Cancel" button to "Close" in Template Manager dialogSeth Chaiklin
Change-Id: I3e8cbdb70f70002f1fe2b873e899f25a72463358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-15update pchesCaolán McNamara
Change-Id: I280dea8fe5f346a5555f4bf479896877579d63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-14tdf#129961 cui: start UI for table shadow as direct formatMiklos Vajna
It reads from the doc model and shows it, but doesn't write it back yet. Change-Id: I6611229e71d0a49f09576ca452b901958c33db58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107682 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-14tdf#138874 restore sort on first column of paths treeviewCaolán McNamara
Change-Id: I7cd831de30523a61631be5cc2f1f3b8a001d9e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-13tdf#138857 fix font replacement table GUIJan-Marek Glogowski
- fix the get_text calls missed in tdf#136534, so combo box entry and table selection are synced again - unselect the table row, if the combo box entry doesn't match anymore the selected table row. - empty the combo box entries on multiple selection (allowd for mass delete only) - move the "apply replacement table" checkbox before the table - also change the comboboxes's sensitivity when toggling the "apply replacement table" checkbox. Change-Id: Ib509e46e3a468ece6ab20e6be41c04caec3265ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107642 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>