summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-01-31SvxNumberFormat::SetAbsLSpace takes shortStephan Bergmann
...so there appears to be no good reason to cast from long to sal_uInt16 first Change-Id: I5baf699fbf043eae6a20e2055b53aef10103f591 Reviewed-on: https://gerrit.libreoffice.org/48952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30No apparent reason to limit nTextXPos to sal_uInt16 instead of longStephan Bergmann
Change-Id: I7142252aa6c42c74c7f2d7407db1cb243090195e
2018-01-30No apparent reason to limit nFirstLineOffset to sal_uInt16 instead of longStephan Bergmann
Change-Id: I988614d5fbdbb439516627aa93327a1d2198e52a
2018-01-30No apparent reason to limit nXStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I19e846905bda86bb00826d337ee681b121c67407
2018-01-30No apparent reason to limit nLineHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6431da3ff753feadead8f59119f502b54669fdc3
2018-01-30No apparent reason to limit nFontHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: Id2cf2c667871e551082e00424d36aef481f5819c
2018-01-30No apparent reason to limit nYStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: I31ce86926d01e641f517beba3b3a784402ddaa1c
2018-01-30No apparent reason to limit nXStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: Iee74da2f6e58fa809b068675c250c0445d9adf58
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I58958b7c7eae9f764cd88d3c1e3ca175af9fc370
2018-01-30No apparent reason to limit nXStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6775c36c9b0eb3b1e56968b4ca212fcd43a3be1b
2018-01-30No apparent reason to limit nYStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I471eca407cb45daba62d679c8c43fb37d98dd762
2018-01-30No apparent reason to limit nWidthRelation to sal_uInt16 instead of longStephan Bergmann
Change-Id: I946e2a74ac5f03132791132e8d5b07d573cb76c5
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I3c1d082c99af94078a0a1505d3e69368aa5070ab
2018-01-30No apparent reason to limit nNumberXPos to sal_uInt16 instead of longStephan Bergmann
Change-Id: Ic46fbb6ca905cc93943927117aa8c70beebee5a4
2018-01-30No apparent reason to limit nTextOffset to sal_uInt16 instead of longStephan Bergmann
Change-Id: Idbd4e4aae63441537aff243d852272739b73f78e
2018-01-30No apparent reason to limit nBulletWidth to sal_uInt16 instead of longStephan Bergmann
Change-Id: I7ce0705e9edd5cff4e6c6977909d7e903f6e1765
2018-01-30Move long vs. sal_uInt16 mismatch out of lcl_Draw{Graphic,Bullet}Stephan Bergmann
...in preparation of getting rid of the mismatch Change-Id: I650a94ec043c4ce2763070a3441f08c0a77e7c73
2018-01-29Removed valueless lines of commentstagezi
Additionally, some lines are converted to a format of 110 characters Change-Id: I7c3fe97f7ebb2530eeb62d0522cd8a8b1c7269e1 Reviewed-on: https://gerrit.libreoffice.org/47121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29Improve code checking for a valid port numberStephan Bergmann
Change-Id: If827ffaee9a2aa861a0746353bdbfd5df1049303 Reviewed-on: https://gerrit.libreoffice.org/48716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-26Fix typosAndrea Gelmini
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad Reviewed-on: https://gerrit.libreoffice.org/48546 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-26tdf#107567 et al. Paragraph dialog preview windows fixesJim Raykowski
tdf#107567 tdf#98211 tdf#98212 tdf#113275 Change-Id: I6d11cb809283eee4fa79acae9aa32baaab558833 Reviewed-on: https://gerrit.libreoffice.org/45273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25tdf#115129 Add function on double click in Customize DialogJim Raykowski
Change-Id: I21a7f8b4fc05d55d1539a3fd148e5870899b1596 Reviewed-on: https://gerrit.libreoffice.org/48555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-24tdf#115129 change customize function tree expand collapse behaviorJim Raykowski
Change-Id: I6c20957fe3f95a8e63b30e5c733b99f71c193972 Reviewed-on: https://gerrit.libreoffice.org/48290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-01-22remove some sal_Bool remnantsNoel Grandin
Change-Id: I0a9637aca523a73fbdbbd22f9ad735d6d1ba6898 Reviewed-on: https://gerrit.libreoffice.org/48273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-21more ScopedVclPtr for dialogsNoel Grandin
Change-Id: I0f19a0c1e312843bee0ee5c9939831918ddc2da7 Reviewed-on: https://gerrit.libreoffice.org/48198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19tdf#111747 Enabled position protection immediately after protection is checkedKshitij Pathania
Change-Id: I10409fe9e6eb7b932496346224952a7c4012cb38 Reviewed-on: https://gerrit.libreoffice.org/46192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Position and Size... to async exec.Jan Holesovsky
Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Reviewed-on: https://gerrit.libreoffice.org/48055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16svx: chain up correctly for SvxCharacterMap::Execute()Pranav Kant
Change-Id: I2ff70f7b2ade8e2aad96cff31bd313822779094c
2018-01-15More loplugin:cstylecast: cuiStephan Bergmann
Change-Id: I5bbdd0b65111c65850652f2ddc93379954498073
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: cuiStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I04b0e0c0268cbcc1c7e7ff2174c5125785e09a07
2018-01-12show something for the link name if there is no link bodyCaolán McNamara
Change-Id: I9a445bed6072a48c2eca67ee403218e749ff3feb Reviewed-on: https://gerrit.libreoffice.org/47800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11loplugin:redundantcast: cuiStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: I3742417cde8a35653b336cc2801dc43a06cfb45e
2018-01-11Use more unique_ptr in treeopt (cui)Julien Nabet
Change-Id: I2041bf8c5d0ddcc0fb62978055381280a64094c4 Reviewed-on: https://gerrit.libreoffice.org/47187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11tdf#114701 Missing widget labels in Customization dialogheiko tietze
Labels placed above controls Change-Id: If05d54a172a3d4f98231fc7a3fb30d097e4e216e Reviewed-on: https://gerrit.libreoffice.org/47391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-06tdf#114818 hold the mutex before executing the error dialogXisco Fauli
Also add an assert to ErrorBox to ensure the mutex is acquired Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018 Reviewed-on: https://gerrit.libreoffice.org/47388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04drop FrameDirListBox typedefNoel Grandin
and rename FrameDirListBoxWrapper->FrameDirectionListBoxWrapper Change-Id: I201ab2caeff0a3219efe8ee86024bc48b8701f7e Reviewed-on: https://gerrit.libreoffice.org/47346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03tdf#113357 cui: fix duplicate 'Formatted text [Richtext]' paste optionMiklos Vajna
Prefer RTF when we have both RICHTEXT and RTF. Change-Id: Ib4133ae4fdecc32429d89b56b0c9466dd3451522 Reviewed-on: https://gerrit.libreoffice.org/47316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01Fix typosbansan85
Change-Id: Idcc291dba5cb6d86e29d00f6b34905f6693f7540 Reviewed-on: https://gerrit.libreoffice.org/47207 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-01-01Bump copyright year to 2018Adolfo Jayme Barrientos
Change-Id: Iabd06fbda15d2f83f6ee0cdd37b268910d380476
2017-12-31Fix indentbansan85
Change-Id: Ie92d9f6cafd0b0af7db9cdb846073762bd4ba7b9 Reviewed-on: https://gerrit.libreoffice.org/47204 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-30loplugin:passstuffbyref improved return in cui,dbaccessNoel Grandin
Change-Id: I1193ff91ccd548acf9492d9701b6411a24d6763e Reviewed-on: https://gerrit.libreoffice.org/47194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for VectorOfNodes (cui/treeopt)Julien Nabet
Change-Id: I318128452fc6d76038c0ed41fcb0a5e7999952c4 Reviewed-on: https://gerrit.libreoffice.org/47146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for m_aLeaves/m_aGroupedLeaves (cui)Julien Nabet
and perhaps avoid memory leaks (see https://bugs.documentfoundation.org/show_bug.cgi?id=114457) Change-Id: Ib413b0bf6cc65a2696e3429965a67899b7b72d73 Reviewed-on: https://gerrit.libreoffice.org/47094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>