summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-01-17Resolves: tdf#122786 use weld::SpinButton::set_value() instead of set_text()Eike Rathke
... otherwise get_value() returns 0. Change-Id: I345d31e888e40f1fc191cef7dac802eb860a824f Reviewed-on: https://gerrit.libreoffice.org/66539 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-17Resolves: tdf#122346 get font features to stick in entry properlyCaolán McNamara
Change-Id: I56058a2069600a4c8acba861a38e7e5d84f44d81 Reviewed-on: https://gerrit.libreoffice.org/66499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-16Resolves: tdf#122509 we have a second list with generated currency formatsEike Rathke
... which kicks in if SvxNumberFormatShell::FindEntry() determined a format index of NUMBERFORMAT_ENTRY_NEW_CURRENCY instead of a real existing index. Regression from commit e607f1da329a2d4dd91904053d7ff86ac05c77bf CommitDate: Thu Oct 4 15:02:13 2018 +0200 Select the current format if multiple instead of first matching format code The old (now removed as unused) SvxNumberFormatShell::GetListPos4Entry(const OUString&) used before took care of that, add the functionality back but combine into the existing GetListPos4Entry() function, the additional FindEntry() call wasn't necessary anyway because it was just called before in the caller. The actual crash happened elsewhere in SvNumberFormatter::GenerateFormat() because no format exists for the then determined entry, which should be changed independently to prevent such abuses. Change-Id: Id42efa152693119fbde82b234f367679f818cfab Reviewed-on: https://gerrit.libreoffice.org/66472 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-16Resolves: tdf#122458 not enough values savedCaolán McNamara
Change-Id: Id71db408e756b273f8a90b15f86c76285cc2b1e1 Reviewed-on: https://gerrit.libreoffice.org/66432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-15Related: tdf#122627 auto detect of toggle column doesn't workCaolán McNamara
so remove it and explicitly state what column contains the toggle Change-Id: I58fb12a4b8fa9eeb9c038f796e48b0aeaa0b2404 Reviewed-on: https://gerrit.libreoffice.org/66379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-14Resolves: tdf#122627 be explicit about what column to checkCaolán McNamara
Change-Id: Icdd1cef6b0bc9d8dd61c309dc9de66021fc9422d Reviewed-on: https://gerrit.libreoffice.org/66286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-14Resolves: tdf#122701 opengl settings don't affect gtk3Caolán McNamara
Change-Id: Iffcf9b6ea8d191a509c2ca451f2ce4a249fde922 Reviewed-on: https://gerrit.libreoffice.org/66285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-11Drop o3tl/clamp.hxx, use C++17 std::clamp insteadStephan Bergmann
Change-Id: I5043c787dcc3b78bc7fdff130564801194e39f46 Reviewed-on: https://gerrit.libreoffice.org/66177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10o3tl::string_view -> std::string_view (in cui)Stephan Bergmann
Change-Id: I7899802f09d16cfa2c8821782feed4fdfa653dd0 Reviewed-on: https://gerrit.libreoffice.org/66114 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-10Resolves: tdf#122356 on row-activate click ok buttonCaolán McNamara
instead of proceeding directy to the ok response. Because there is an additional handler installed in the okbutton to do extra stuff that is needed to make this work Change-Id: I9646ea6978533084c6c9c48b03806e46eaa49c33 Reviewed-on: https://gerrit.libreoffice.org/66046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-08tdf#122527 dot symbols in chart menubutton not workingCaolán McNamara
a few problems here *) each symbol was drawn on top of the previous one instead of clearing it *) some spurious placeholder text in the menu entry *) m_nSymbolType not set correctly on activation of a submenu entry *) under gtk3 adding entries to the submenus didn't inform the menubutton of their addition *) we can drop m_xMenu because set_item_sensitive can be used instead, which didn't exist at the initial time of writing Change-Id: Id339992c4192f3782fddfd56cb3e9b67cfcbe2a2 Reviewed-on: https://gerrit.libreoffice.org/65977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08Removed executable permission on data filesAndrea Gelmini
Change-Id: I20aa503bb011d7222ecc29cb87bb72c0f3ee7539 Reviewed-on: https://gerrit.libreoffice.org/65949 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-06tdf#120195 tab focus removed Aditya
Change-Id: Ifda610ecf80fbecefc86e097cf40330a6cd3343b Reviewed-on: https://gerrit.libreoffice.org/65867 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-03Avoid getTokenCountMatteo Casalin
Change-Id: Ib5fb26de4d51a348ed44987bac0131d18eaed921 Reviewed-on: https://gerrit.libreoffice.org/65675 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-02Resolves tdf#122383 and tdf#122410Muhammet Kara
Add some null pointer checks Change-Id: I905c6dd46a5019e66d9c2e59374cc7d1ce83397b Reviewed-on: https://gerrit.libreoffice.org/65789 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-01tdf#105225 Add palette selection to options charts default colorsJim Raykowski
Change-Id: I42d1f155238213e41b8a57ce47b70cfeb2408b26 Reviewed-on: https://gerrit.libreoffice.org/64980 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-01-01Bump copyright year to 2019Adolfo Jayme Barrientos
Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd
2018-12-31tdf#120565: Fix scale bug in Bitmap Area dialogPatrik Vas
Change-Id: Id8886b7972e707698b539ad5787a26d6a64198ca Reviewed-on: https://gerrit.libreoffice.org/65771 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-29Use indexed getTokenMatteo Casalin
Change-Id: I3f30a68653212c9d019c9799961f41e4e54595b3 Reviewed-on: https://gerrit.libreoffice.org/65677 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-28Use indexed getTokenMatteo Casalin
Change-Id: I4eec0cf92ca0ff4af00b5db4c039db072d8cba39 Reviewed-on: https://gerrit.libreoffice.org/65676 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-28Avoid indexed getToken for single callMatteo Casalin
Change-Id: I3e8e413d2a1e7a0b95e972246d86182156118488 Reviewed-on: https://gerrit.libreoffice.org/65674 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-28Reduce scope of variableMatteo Casalin
Change-Id: Ieabc790ec03470b77440bc10396b07b18441384b Reviewed-on: https://gerrit.libreoffice.org/65656 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2018-12-23tdf#120743: Rename the 'Select Theme' button to clarifyMuhammet Kara
Change-Id: Ib4516d0e184c81d666442e956bf7e6dffffb1dbd Reviewed-on: https://gerrit.libreoffice.org/65578 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2018-12-20tdf#120562 , Selection of favorite character is not applied.Sumit Chauhan
We need to do rView->GrabFocus() , before calling any other function. Change-Id: I95a64f44c40070caa0064c3e73fb5d7b04b3bf4b Reviewed-on: https://gerrit.libreoffice.org/65437 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20use unique_ptr in SvxOnlineUpdateTabPageNoel Grandin
Change-Id: I7f93f686438c1922797a10f2510db71dc4a06ff1 Reviewed-on: https://gerrit.libreoffice.org/65442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19tdf#122119 make fontfeature dialog size unlimitedCaolán McNamara
Change-Id: Iacfcce9ec3a71f43fb5ce491d23184691c269944 Reviewed-on: https://gerrit.libreoffice.org/65417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19set explicit color for font feature preview bgCaolán McNamara
Change-Id: Ia7e8e6e6d7b8297063798aaf63111490f356c5c9 Reviewed-on: https://gerrit.libreoffice.org/65411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4af38dbe7c54e01c3a9c0d11300a8492d68c64b5 Reviewed-on: https://gerrit.libreoffice.org/65388 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19don't delete out param from GetOutputStringNoel Grandin
we don't own this memory, belongs to svl module Change-Id: Ief12408e4254ab3fc2069a8490ecf062a728b3d3 Reviewed-on: https://gerrit.libreoffice.org/65349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-19simplify HangulHanjaEditDictDialog::m_vElementsNoel Grandin
no need to store a ref-counted thing like OUString using the heap Change-Id: I372417f1a60d120e867f4f4b3b9335b73693accb Reviewed-on: https://gerrit.libreoffice.org/65348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18Resolves: tdf#122168 width/height transposedCaolán McNamara
don't need it anyway, the width req is already set by SvxNumberPreview::SetDrawingArea Change-Id: Ic5b03a13a98c76c5ce927b13fc295510b6d8686d Reviewed-on: https://gerrit.libreoffice.org/65353 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18stray fprintfCaolán McNamara
Change-Id: I1bb4ee9354914db21d0440f83c156069a5efd9f9 Reviewed-on: https://gerrit.libreoffice.org/65355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-17Related: tdf#122120 left align text if preview won't fitCaolán McNamara
in the number format page Change-Id: Ic398e5302ee54dfd437e07fdf892269e6eefd8fa Reviewed-on: https://gerrit.libreoffice.org/65284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-17kde5: remove older kde/tde plugins, and references to thatThorsten Behrens
KDE4 is out of maintenance upstream since Nov. 2014, and binaries provided by TDF have switched to KDE5 as the official backend. Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9 Reviewed-on: https://gerrit.libreoffice.org/60014 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-16tdf#122136: select first element if there's at least oneJulien Nabet
See bt from https://bugs.documentfoundation.org/attachment.cgi?id=147594 Change-Id: Ibf031b8024aa4952e2d3263a445cafdb3c031390 Reviewed-on: https://gerrit.libreoffice.org/65220 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-13tdf#121180: close Options dialog when restart is confirmedMike Kaganski
Change-Id: Ieb6e62ca83921abed6b6432d70c6717dadfaaa34 Reviewed-on: https://gerrit.libreoffice.org/65090 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-13Resolves: tdf#120481 gradient subpage 12 pixels too shortCaolán McNamara
because the max preferred-size of the subpages is taken and applied as the size-request of the container parent. But the container parent as a 6px border, so the subpages end up hosted in a parent which allocates them 12px less than they hoped for. As they are instantiated in the parent to measure them, measure their parent instead and that calculates in the parent's border to end up with what they wanted Change-Id: Ib270b90f9c2fed7f8bd042cc66d0d10ad3c6f183 Reviewed-on: https://gerrit.libreoffice.org/65058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-13loplugin:constantparamNoel Grandin
Change-Id: I389f98d06058ba65a8c2d4df2bf7d4e5102659ad Reviewed-on: https://gerrit.libreoffice.org/65017 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-12tdf#104277 follow-up: use svtools::executeRestartDialogMike Kaganski
This harmonizes this setting's prompt with other places asking for restart. Related obsolete strings are removed. Change-Id: I2da63585747056714eb688681194acd35550e1c7 Reviewed-on: https://gerrit.libreoffice.org/65022 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-10lok: shape scaling reworkMarco Cecchetti
Now shape scaling is handled through the transform dialog instead of simulating a drag and drop event in core. For Impress the unit used for length is '100th mm' instead of twips, so we need to transform positions and size from twips to '100th mm'. Anyway since we don't know in SetGeoAttrToMarked if the new data is due to a mouse event or by entering a new value in the transormation dialog or in the side pane, for Impress we need to convert the new values sent by the dialogs from '100th mm' to twips which are converted back in SetGeoAttrToMarked. For performing a uniform scaling when the shape/image is rotated we need to inform the client about the rotation angle for the selected graphic object that has been achieved but appending an angle argument to the graphic selection callback. Now it is also possible to reverse shapes/images through negative scaling. Change-Id: I8a32f3e4b28f36e884a59c59b7e1351e85ef4489 Reviewed-on: https://gerrit.libreoffice.org/64696 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-12-10loplugin:unusedfieldsNoel Grandin
Change-Id: I03e8814407fd8e345cb07ac433db4230b4d96e10 Reviewed-on: https://gerrit.libreoffice.org/64822 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10Bin also leftover commentTor Lillqvist
Change-Id: I7cb9168843d6b8996d32d37b46330656ffe9cb25
2018-12-09loplugin:unusedmethodsNoel Grandin
Change-Id: I4f2635d468c9ad83b3ac93733529e01a4d03f38e Reviewed-on: https://gerrit.libreoffice.org/64805 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-08use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-12-08Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann
...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-23 01:23:56 +0000