summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-04-03tdf#124155 fix slider for border and angle in gradient tab pageTomaž Vajngerl
This is the consequence of the previous change, where the sliders didn't respond to input when welded. Change-Id: Ifec7fd913435a6ec51b93872c7a40d6815807397 Reviewed-on: https://gerrit.libreoffice.org/70198 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#124155 change "gradient tab page" - increment & angle sliderTomaž Vajngerl
Remove slider for increments as the increments should better be left to "auto" and rarely modified (setting a value means it will use a limitied amount of increments, but auto effectively means as much as it is needed and can use the native backend for drawing). OTOH use a slider for setting the "angle" as it is already present in hatch tab page. Angle needs a slider as it is usually one of the main properties of a gradient (especially linear). Increase the tab pages a bit (10px on every side) to have a bit of breating space for all the widgets. Change-Id: I66167fe2c97b53bc3627237279332bdd59fb03d7 Reviewed-on: https://gerrit.libreoffice.org/70175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-02drop some unneeded includesCaolán McNamara
Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02tdf#124361 hide Add / Import button in OnlineAndras Timar
Change-Id: I6c8fb30fc1b8e0e6467a428f65838084fc08ca1e Reviewed-on: https://gerrit.libreoffice.org/69967 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-31tdf#124362 hide Addressbook button in OnlineAndras Timar
Change-Id: If066c4440c7add08836fa3ebb569ffc36969072e Reviewed-on: https://gerrit.libreoffice.org/69966 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-30Fix typoAndrea Gelmini
Change-Id: I67e15931dbf4d7e7045395698030c7ae01435be7 Reviewed-on: https://gerrit.libreoffice.org/69944 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-29tdf#124149 add bigger 32px icons for border line and shadowTomaž Vajngerl
Change-Id: I7ea382f3ba648657d2a6d009bf90dcc3be879c63 Reviewed-on: https://gerrit.libreoffice.org/69925 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29Resolves: tdf#124410 crash cell border page with diagonal bordersCaolán McNamara
Change-Id: I0fd8738d42ad33f029381dae0ec9f41e7912b72c Reviewed-on: https://gerrit.libreoffice.org/69918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-27move LineListBox beside last consumerCaolán McNamara
Change-Id: Ie683784a9f4ecfb0015bf7ae79769238719a6376 Reviewed-on: https://gerrit.libreoffice.org/69841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-27tdf#60242 remember horizontal/vertical choice in split cells dialogMartin van Zijl
Change-Id: I25f6b7c8ff6aa678b597bbede0dd1492468f2f62 Reviewed-on: https://gerrit.libreoffice.org/65606 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-27Remove unused using declarations in directories [a-d]*Gabor Kelemen
Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-27Resolves: tdf#123291 set hex input to overwrite by defaultCaolán McNamara
and ensure the modify arrives after the input text has been filtered Change-Id: I16c0bd095700e7d9858e3e74884b5a1ad3eb7e4c Reviewed-on: https://gerrit.libreoffice.org/69764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26Generate MSO lock files when the related MSO compat. option is setTamás Zolnai
Added a new compatibility option to the Tools -> Load / Save -> Microsoft. When this option is set on the UI or or set in the configuration files LO generates lock files for MSO supported file formats, similar to the lock files MSO generates itself. Change-Id: I2f882723841162add01be9d3f7285a5162a60331 Reviewed-on: https://gerrit.libreoffice.org/69678 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-26weld URLDlgCaolán McNamara
Change-Id: I3dd002a97d7c90e62c09f65bfc0333892bbd817c Reviewed-on: https://gerrit.libreoffice.org/69718 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-26loplugin:unusedmethodsNoel Grandin
Change-Id: I8bbf439d69a330a9ad28ff52cc49a9fec2c12500 Reviewed-on: https://gerrit.libreoffice.org/69684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26Fix typoAndrea Gelmini
Change-Id: I4fb3395a1052b20f4c83aa9e3708615c6ab9de0e Reviewed-on: https://gerrit.libreoffice.org/69725 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-26Allow irregular feature value structures in feature dialogMartin Hosken
Change-Id: I92df2d47bebb0b0af38f3527881ac65a11d1bb98 Reviewed-on: https://gerrit.libreoffice.org/69643 Tested-by: Jenkins Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2019-03-25Resolves: tdf#123550 allow returning to TRISTATE_INDETCaolán McNamara
Change-Id: I3e4b18c0b3217e010c80fbddccebd547ee29253a Reviewed-on: https://gerrit.libreoffice.org/69674 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-24Make some .ui strings translatable / not translatableGabor Kelemen
Found with bin/ui-translatable.sh Change-Id: I63d613a946c32821c836aaeda897b9713cc681f7 Reviewed-on: https://gerrit.libreoffice.org/69595 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-22Related: tdf#124196 fix parent-wait crash in customize dialogCaolán McNamara
always within welded dialogs now Change-Id: If3d7adc54e8c65e164c9edce0a2f1dddd3d63e8f Reviewed-on: https://gerrit.libreoffice.org/69550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-21Resolves: tdf#122804 make bitmap page 'add' dialog title localizedCaolán McNamara
Change-Id: I0c4f6775b8bc9fae8dc81f07fec2e21218e36037 Reviewed-on: https://gerrit.libreoffice.org/69520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-21Resolves: tdf#122803 make gallery 'add' dialog title localizedCaolán McNamara
Change-Id: Iaa2ee6c982c8fd5d5cf1b9b09a835b917217d85c Reviewed-on: https://gerrit.libreoffice.org/69516 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-21Make SvxChartColorTableItem more constArmin Le Grand
SvxChartColorTableItem has non-const members (aka modifiers) which is bad for SfxItems in general, see comments in change. Adapt SvxChartColorTableItem and it's usage in SvxDefaultColorOptPage as needed. This is also preparation for possible SfxItem refactoring Change-Id: Ia7982b4e7bbfa736229223e55ce63e02143b8cf7 Reviewed-on: https://gerrit.libreoffice.org/69499 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-03-20tdf#124226 do fill-on-demand hack only on first visitCaolán McNamara
disconnect focus handler after the fill Change-Id: I77bffe4fa4c516452c36ddb2d816cd5844000c1b Reviewed-on: https://gerrit.libreoffice.org/69479 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20tdf#124153 fix cut-off radio buttonTomaž Vajngerl
Change-Id: I8e07a8c49a9dc47cb8b75b61450125d449a45d1e Reviewed-on: https://gerrit.libreoffice.org/69467 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-20weld SwFieldEditDlgCaolán McNamara
Change-Id: I786944a4bf8979526f0ccae5b00fb42ad5016a66 Reviewed-on: https://gerrit.libreoffice.org/69463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-20tdf#122943 Don't add properties to style when Highlighting and AreaJim Raykowski
...tab pages are simply visited Change-Id: I490275bf7e27160d312bb5b6ad7001298549f7e8 Reviewed-on: https://gerrit.libreoffice.org/69455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-19Resolves: tdf#124196 impossible to customize keyboard shortcutsCaolán McNamara
Change-Id: Idae750fe2e648d5ae15a691c02a53985d88f90f3 Reviewed-on: https://gerrit.libreoffice.org/69423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-18weld SwFieldRefPageCaolán McNamara
Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3 Reviewed-on: https://gerrit.libreoffice.org/69373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-18Fix typoAndrea Gelmini
Change-Id: I616b3ffabd808b890aff09e31262a9dda3b9bdbe Reviewed-on: https://gerrit.libreoffice.org/69375 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-17don't need m_aColorSizeCaolán McNamara
Change-Id: I27740ae0bff0d1676799ddfba76eab5e7a299f66 Reviewed-on: https://gerrit.libreoffice.org/69354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-17Resolves: tdf#124058 factor bitmap page into size req when its toggled onCaolán McNamara
post ctor time Change-Id: I8257c8ffdfc4dab9893ab7d2d67e218dd3f8097c Reviewed-on: https://gerrit.libreoffice.org/69353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-17Resolves: tdf#123650 explicitly grab focus after modificationCaolán McNamara
of the widget after gaining focus, otherwise gtk loses track of where the focus should be Change-Id: I90d9f36acf807aec8687c7f563449ef16d5eb574 Reviewed-on: https://gerrit.libreoffice.org/69355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-14Hide the font preview on iOSTor Lillqvist
There are enough problems making the dialogs look and work sanely in the iOS app without the preview being placed completely wrongly and covering other controls. Note that I am not actually able to test this here in the master branch, as the iOS app does not work when built from the master branch of the online repo (and this master branch of core). The corresponding change to the cp-6.0 branch of core did work as expected (with the online bits of the app built from the collabora-online-4 branch). Change-Id: I383ae6b1fcacb41b20f97e17436aa26531e13c69
2019-03-14loplugin:unusedfieldsNoel Grandin
Change-Id: Id6792f0955a25533d33f6da6ed8c3e993f578c3f Reviewed-on: https://gerrit.libreoffice.org/69170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-13Resolves: tdf#124028 dangling "completion" entries block responsesCaolán McNamara
so e.g. math font dialog doesn't react to button clicks. since... commit ab8e0f5832fa910f8b1abd36d7cb3929cbac2395 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 18 17:08:58 2019 +0000 Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect remove the entrycompletions but left the reference to them Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22 Reviewed-on: https://gerrit.libreoffice.org/69208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13add renderer for lock iconCaolán McNamara
Change-Id: I88e2a7ee44523482cf36099281c0f632fae7eac0 Reviewed-on: https://gerrit.libreoffice.org/69177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13weld DatabaseRegistrationDialogCaolán McNamara
Change-Id: I739785daef892ac16d2a41a98268f18670daeedb Reviewed-on: https://gerrit.libreoffice.org/69136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13weld DbRegistrationOptionsPageCaolán McNamara
Change-Id: I88c1129f50d9f9cbef9970f1a9453641fc87e8fd Reviewed-on: https://gerrit.libreoffice.org/69135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13“Large” LibreOffice icons are 24 × 24 pixel, as you’d expectAdolfo Jayme Barrientos
The Galaxy theme was the only odd duck to use 26 × 26 pixel icons. We’ve removed it, but the Change Icon dialog was still reporting this misleading value. Spotted by Rizal Muttaqin. Change-Id: I4f82727b93239a32f7eab5473baa3b8705abde29 Reviewed-on: https://gerrit.libreoffice.org/69148 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-12insert an intermediate class to inherit fromCaolán McNamara
Change-Id: I77cc250197658fed57175b775976a3194050c0da Reviewed-on: https://gerrit.libreoffice.org/69117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12select first entry initiallyCaolán McNamara
Change-Id: Ib4591197b17811a37b3a33f943fff03f1efd9550 Reviewed-on: https://gerrit.libreoffice.org/69114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12weld SpellOptionsDialogCaolán McNamara
Change-Id: I813b166a8c4658e08b185a43a464b6b370b62c66 Reviewed-on: https://gerrit.libreoffice.org/69099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>