summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-04-28Resolves: tdf#125002 toggling on radio button generates click on anotherCaolán McNamara
so use toggle and ignore toggle offs Change-Id: Id6a9f3a7a9cf02d62ede00e4c246629406f9a64b Reviewed-on: https://gerrit.libreoffice.org/71481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28Resolves: tdf#124931 key stroke in shortcut keys not selecting the key comboCaolán McNamara
Change-Id: Ife3e99e0cf00d7d320eb8e403743d42fb8274df8 Reviewed-on: https://gerrit.libreoffice.org/71483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-27tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac Reviewed-on: https://gerrit.libreoffice.org/71430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xsetit.hxxGabor Kelemen
Change-Id: Id750f663389be36c669756e4bdd1e4e01be48199 Reviewed-on: https://gerrit.libreoffice.org/71327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26tdf#124658 - Improve text for the tip-of-the-dayheiko tietze
All strings reviewed Change-Id: I7c9b2460b86576c67221c874bd9f99ea43db17d4 Reviewed-on: https://gerrit.libreoffice.org/71365 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-25Resolves: tdf#124804 border considered changed when it isn'tCaolán McNamara
Change-Id: Ib4b6031b31500a8a2086721124b5b8f554f7c1c5 Reviewed-on: https://gerrit.libreoffice.org/71296 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Resolves: tdf#124932 fix Shortcut Keys etc tab traversalCaolán McNamara
Change-Id: I9d0204161a0efe91ebcddaf5b2931ab156221b79 Reviewed-on: https://gerrit.libreoffice.org/71283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-24tdf#124893 Validity check on new dialog creation.Rtch90
Change-Id: I5f94c8204a4c35470e891eb89cfbe74aad852bf4 Reviewed-on: https://gerrit.libreoffice.org/71084 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-23tdf#42949 Fix IWYU warnings in include/editeng/[f-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic14d2e66434817bcb7bd1e2b707f81d720d596b6 Reviewed-on: https://gerrit.libreoffice.org/71007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23tdf#123228: Disable Firefox theme searchMuhammet Kara
We can't use the MOZ API anymore. Let's disable it instead of showing a broken search window. Then we can spend some time on moving on instead of answering the -This is not working!- bug reports. Change-Id: Ice10bde804d1d9a7a13cd4781813fc794b1b0967 Reviewed-on: https://gerrit.libreoffice.org/67917 Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-04-22tdf#124846 Make main menu items really move when movedJim Raykowski
This patch also fixes the Move Menu dialog move up button being enabled when dialog is created. Change-Id: I8432bd8d582e8a9ef449bce1d5cba703b2404c75 Reviewed-on: https://gerrit.libreoffice.org/71001 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I1cc008b08f4a11e9869f55a48ae5bf79ac026130 Reviewed-on: https://gerrit.libreoffice.org/71055 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: If8dc4a7bb2a58ade394752104a94394d5361fd17 Reviewed-on: https://gerrit.libreoffice.org/71054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: If2e6cced51130ae7fa47f2510538345db548c546 Reviewed-on: https://gerrit.libreoffice.org/70992 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19drop some unneeded includesCaolán McNamara
Change-Id: Idde1f747f500d94b3191a97e7d502794cc2b8450 Reviewed-on: https://gerrit.libreoffice.org/70972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19optimise find/insert patternNoel Grandin
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19tdf#42949 Fix IWYU warnings in comphelperGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also re-evaluate some blacklisted headers and recheck include/comphelper/ Change-Id: Ib7eea5951e849c07cea2e2782be4e8945f71ad96 Reviewed-on: https://gerrit.libreoffice.org/70899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19drop some includesCaolán McNamara
Change-Id: I6f9765208e807da336146e55f0f1cbcb46316d4c Reviewed-on: https://gerrit.libreoffice.org/70935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Related: tdf#124809 cannot assume that icon size is same as checkbox sizeCaolán McNamara
cause can be using large icon size Change-Id: I4661199b658ff0d2013a7bbd7159b1c134ade043 Reviewed-on: https://gerrit.libreoffice.org/70942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Resolves: tdf#124809 spacing ignored unless WB_ITEMBORDER is setCaolán McNamara
Change-Id: I29d63926c605d3f143c242337e31388123f22cff Reviewed-on: https://gerrit.libreoffice.org/70939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-16Resolves: tdf#124743 - Tip of the Day randomizationheiko tietze
srand() added, image file name part of the hrc definition now Change-Id: Ib697f64406ab6b11468eb837c71d57398a0533b5 Reviewed-on: https://gerrit.libreoffice.org/70767 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-15ensure gtk creates a default label widget for the MenuButtonsCaolán McNamara
Change-Id: Id8b6f11b4429c8029cacfc26592767625efb9674 Reviewed-on: https://gerrit.libreoffice.org/70798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-15improve loplugin simplifyconstructNoel Grandin
to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-12loplugin:sequentialassign in comphelper..cuiNoel Grandin
Change-Id: I1a08f3684b785e31535adcfb4220ded267a77c3b Reviewed-on: https://gerrit.libreoffice.org/70643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I8afb1f6e6fbde1b1d9339913e2eb67122f8930be Reviewed-on: https://gerrit.libreoffice.org/70633 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Ia88380a9699e74eb93c0a093ff87e4437d084515 Reviewed-on: https://gerrit.libreoffice.org/70629 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I368c0127d679e8c6e2d8f0bc979828c4f4795fda Reviewed-on: https://gerrit.libreoffice.org/70630 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I1fc7426f93d0c2e73450377c8bd5c3d847fe5218 Reviewed-on: https://gerrit.libreoffice.org/70625 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Id09373f15389f241b56a73c406b4c88e334ab505 Reviewed-on: https://gerrit.libreoffice.org/70619 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I578e3801aa7ddc424d9e4e9c6da7ff7231f49ee6 Reviewed-on: https://gerrit.libreoffice.org/70626 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I34c4ff8ba4c68190e8c59253b0f2e6f3a5729794 Reviewed-on: https://gerrit.libreoffice.org/70627 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I8e9d540dfb8e1f800386226aa68ae2e789c3ba36 Reviewed-on: https://gerrit.libreoffice.org/70618 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Ifd0ea4fedad84820b91913a29bab68c0534a1f5b Reviewed-on: https://gerrit.libreoffice.org/70620 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I27fc9c47563ed791511915d50d83f87ebb712d8a Reviewed-on: https://gerrit.libreoffice.org/70624 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I099e59ba1e1d880b3903ff8d7e9c0f8c9ca0bdf3 Reviewed-on: https://gerrit.libreoffice.org/70622 Reviewed-by: himajin100000 <himajin100000@gmail.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I1873cea1a3205f28aa6106924c0df5b63d64d7ab Reviewed-on: https://gerrit.libreoffice.org/70621 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Ie30b67859b3494a7cad17398c2edb377499725c1 Reviewed-on: https://gerrit.libreoffice.org/70623 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10tdf#124238 - Show a Tip-Of-The-Day dialog on startupheiko tietze
New dialog Change-Id: If1e501de26eb5a9c20a59e621f9e805c3b5e2cf8 Reviewed-on: https://gerrit.libreoffice.org/69498 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-09drop unneeded forward declareCaolán McNamara
Change-Id: I6a748d76bb24661404d280236f4c850a9136bb30 Reviewed-on: https://gerrit.libreoffice.org/70430 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09drop some unneeded includesCaolán McNamara
Change-Id: I8e41e28313a22148033c566edce50f5bfa58d065 Reviewed-on: https://gerrit.libreoffice.org/70452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09remove some usages of BitmapColor outside of VCLTomaž Vajngerl
You get BitmapColor only from reading pixels from a Bitmap and we want to avoid usage of Bitmap outside of VCL (and use BitmapEx as the alternative which will eventually replace Bitmap). Change-Id: Iddfa3ef739bfdd4dce5fb47fd9f67a5a36f3388b Reviewed-on: https://gerrit.libreoffice.org/70447 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-08tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-05respect read-only config item: CreateMSOLockFilesAndras Timar
Change-Id: I6b264a2f2e2995e880169f6224c60f023584469d Reviewed-on: https://gerrit.libreoffice.org/70270 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-04-03various cleanups - no behavior changeTomaž Vajngerl
Change-Id: I28749d31ba272f26df9b79201cb106911692f6f7 Reviewed-on: https://gerrit.libreoffice.org/70199 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>