summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-18missing resourceCaolán McNamara
this is missing since abad15bc31e99d554a68c6806a3ebb5f592dabbd "small improvement of Insert -> Hyperlink -> Internet dialog". I can only assume that removing the target button was intentional. Change-Id: I71147394bcab348ed1d9e1e19e32b5ebdddc8c0e
2013-11-17missing translatable="yes" attributesAndras Timar
Change-Id: I138c8f245e4bfb2f23dd4cd8a629d8e5e3aac56b
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14SvxBrushItem: Improve Referer from member to GetGraphic[Object] parameterStephan Bergmann
Change-Id: I034132c315b74d0ea5e03b7d5f7cc225a6c8164e
2013-11-14make l10n buildable separatelyBjoern Michaelsen
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14Add "block untrusted referer links" switchStephan Bergmann
Change-Id: Id2f2a3dafc3bb7ec6fada6bfda5843348dfac5a1
2013-11-13On Mac OS X LibreOffice cannot use native print dialog at allAndras Timar
Change-Id: I37d36ba175362dedffbbabb561a11033a0454110
2013-11-13fdo#59256 hide this option when experimental features are disabledAndras Timar
GTK print dialog is experimental, the checkbox has no effect, if experimental features are disabled. Change-Id: I664a5520ed8fd0740c381af3d38fc5252c020548
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11remove unnecessary use of OUString constructorNoel Grandin
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11remove unnecessary use of OUString constructor in CUI moduleNoel Grandin
Change-Id: Ib6cc0f089e9b3cbcfee67c6a780527e148f3c382
2013-11-08fdo#67401 set AntiAliasing for SVG logoAndras Timar
Change-Id: I90aae11aca84c9c5445f58bdf76d65f0213a334c
2013-11-08Make INetURLObject-from-OUString ctor explicitStephan Bergmann
...and clean up call sites. Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-07xub_Strlen to sal_Int32Andras Timar
Change-Id: I5cf06c6d9648f8f447b7669edfab8436e6f948ab
2013-11-06convert xub_StrLen to sal_Int32Noel Grandin
convert for loops using xub_StrLen to use sal_Int32 Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-05convert xub_StrLen to sal_Int32Noel Grandin
Convert code like: xub_StrLen nLen = aStr.getLength(); into sal_Int32 nLen = aStr.getLength(); Change-Id: Ib0af6b747068257478918fd1cc93e4925f32ac47
2013-11-05Resolves: i123564 corrected some aspects when working with bitmaps...Armin Le Grand
with low color depth or small size (cherry picked from commit ba54ce4fc788605fc96235f432b455311faee406) Conflicts: cui/source/tabpages/tpbitmap.cxx Change-Id: I10677414ab7d1904dbb29cd395a0c0334e0faa03
2013-11-05convert xub_StrLen to sal_Int32Noel Grandin
Converts code that calls comphelper::string::getTokenCount() to use sal_Int32 to store the return value. Change-Id: I439605a39d29b1309649e30f3ff40dfa412efcde
2013-11-05update pchThomas Arnhold
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
2013-11-04cui: remove unused .map fileMatúš Kukan
Change-Id: Ib7a040c48d8f35e8bd68a30e7b5219a7499ec8da
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03cppcheck: Clarify expression with parenthesisJulien Nabet
boolean result used in bitwise operation Change-Id: I581b681a6f3ba682c7b743928d1b6f397ecf960c
2013-10-31convert new/move menu to .uiCaolán McNamara
Change-Id: I77e46382cae6da03c3a972c9838afb3f8698c9a3
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-29fdo#70049 Expert Config page cannot save booleanEfe Gürkan YALAMAN
This patch fixes unsaveable booleans. Also fix the problem occurs when there is multiple changes on page. Page was commiting only last added one, now commits all. Change-Id: Id1a15634e95d5ca9d54e7a90fa1bbbaf874e3f08 Reviewed-on: https://gerrit.libreoffice.org/6457 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-28fixincludeguards.sh: cuiThomas Arnhold
Change-Id: I0a9f69b8c2129329f742f18e7749484b6f3e5bf7
2013-10-28Resolves: #i123497# corrected modify implementations for bitmap...Armin Le Grand
lineend and color (cherry picked from commit 03fa6020a862b1b6faf69f33274022cb871e8f4b) Conflicts: cui/source/tabpages/tpbitmap.cxx cui/source/tabpages/tpcolor.cxx cui/source/tabpages/tplneend.cxx Change-Id: Ib99e8f0a59fb611972133bab1e864d59d019457b
2013-10-28windows: warning 4355 is disabled globally in com_MSC_defs.mkThomas Arnhold
So there is no need to do this locally, too. Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-27HIG: different rules for message boxesCaolán McNamara
Change-Id: I67a5457fa2f39b1d6ab0a635d9bdf78ffa90caea
2013-10-24Bin ASCII graphics and superfluous vertical whitescapeTor Lillqvist
Change-Id: I68110e2ff632d0446c127e428623fecb62aa14c5
2013-10-23Solve fdo#69926 Wrong default notation for galaxy icon themeJoren De Cuyper
Galaxy is our 'underlying' icon theme we use in LibreOffice. If an user choose to have another theme, Galaxy icons will be overlapped by that other theme. So in general the 'default' template _is_ galaxy, but not for the end user. Different OS have different default theme and are marked with '<themename>(automatic)'. To avoid misunderstandings I delete the term 'default'. Change-Id: If6a1ac781cb68eeb690edf1408c7ce4c62f2ec8e Reviewed-on: https://gerrit.libreoffice.org/6321 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-21drop StringCompare from cuiCaolán McNamara
Change-Id: Iec7a797581ab899e93ad6cebb06c3622ca2360b9
2013-10-21fdo#68849 add some header guardsThomas Arnhold
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f Reviewed-on: https://gerrit.libreoffice.org/6364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-21post String conversion cleanupThomas Arnhold
Change-Id: I9747817edc76973af4a4ffdbf542b8d1467d7f08
2013-10-20drop unnecessary tools/string includesCaolán McNamara
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20fdo#52622 - Reduce copy and paste codeJosé Guilherme Vanz
This commit removes copy and paste code, creating a constructor for it Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc Reviewed-on: https://gerrit.libreoffice.org/6356 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-17-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I635235896853693dd7687e0b72ccb3caf4febb89
2013-10-16remove SID_INTERNET_ONLINEThomas Arnhold
We have no online/offline concept for the office anymore. Change-Id: Id7e71d9c4383b47d3fae6f8cb5dc18ec22a55934
2013-10-16fdo#63271: Close hyperlink dialog after hyperlink is insertedThomas Arnhold
Also label it with "Ok" which reflects the new behavior better. Change-Id: If8adde315c2d822e3210a0dcae7055519e5e558d
2013-10-16Resolves: #i122759# Pass the Sequence by referenceAriel Constenla-Haile
Despite it's name, rProperties, the Sequence is not a reference in the function signature. Besides, some small improvements: - instead of compareToAscii, use operator==, which is optimized for performance (cherry picked from commit a17e221225915c140c7840904cb9b46d75731edc) Conflicts: cui/source/options/optsave.cxx Change-Id: Ifffd2b9014210c885f03ff8116ea97625b903cba
2013-10-16unotools: add menu option to enable/disable Smart-Art lockJacobo Aragunde Pérez
The point of this menu option is that locked Smart-Art shapes would preserve the original XML files attached so they could be exported back to docx with no loss. The new menu option is located at Options -> Load/Save -> MS Office -> SmartArt to LibreOffice shapes or reverse. Change-Id: I6aafc2eb83404ee2c0b8538b2f6fbbbd4363e7d3 Reviewed-on: https://gerrit.libreoffice.org/6138 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-10-16cui: allow lines in MS filter section to have independently enabled checkboxesJacobo Aragunde Pérez
An extra InsertEntry method is added with parameters to enable or disable the load and save checkboxes independently. Change-Id: I49233ce31e2eaf361310f89887dcede86dec0edc Reviewed-on: https://gerrit.libreoffice.org/6137 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>