summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Need <config_features.h> here, tooTor Lillqvist
Change-Id: I8bd752814994fedac17fe0d002b415902c276b20
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Resolves: tdf#100438 focus trapped in disabled toolbarCaolán McNamara
lets just leave the toolbar active the whole time, seems to make more sense anyway wrt being allowed to keyboard into it to paste/insert special character Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818
2017-02-01loplugin:stringconstant handle calls to constructors with one argNoel Grandin
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30convert toolbar config context menu to .uiCaolán McNamara
Change-Id: I8f8a9517680f02cb8efa3e6e46d3d4ebf7da1510
2017-01-30crash on exit from undisposed insert special character dialogCaolán McNamara
right click on style combobox in writer toolbar, insert character, esc, ctrl+f4 and crash Change-Id: I83c88584c6d772bf629121a2bcdc16076bee8003
2017-01-30tdf#103654: Make git hash clickable in the About dialogArnold Dumas
This doesn't affect the About Dialog if the build id is not a valid git hash. Change-Id: Ie44f455dbfd0191cf6953091f28a42bccb67a4cb Reviewed-on: https://gerrit.libreoffice.org/33652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-27use a define for invalid SfxPoolItemJochen Nitschke
and use helper function IsInvalidItem() more Change-Id: Ifd651a336a7bd4ef4f945219d765afb827465438 Reviewed-on: https://gerrit.libreoffice.org/33611 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27Compatibility options refactoring. Part 1Vitaliy Anderson
It relate to reduce the nubmer of copy-paste the same code and simplify adding compability options. Also using enum class instead enum can eliminate to occurrence an error relate to access to out of range an array. Change-Id: I07b862aac5f88da4a98e2273cb14daa09e70eacb Reviewed-on: https://gerrit.libreoffice.org/33543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-24Resolves: tdf#104552 table properties dialog drops previous border colorCaolán McNamara
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#704601 Dereference after null checkCaolán McNamara
Change-Id: Icfef8f4ded311790a90b61b37c08254592d979ab
2017-01-21coverity#704602 Dereference after null checkCaolán McNamara
Change-Id: I069716ad675a217ecd97aee6b07346cf838fd653
2017-01-21coverity#1399015 Logically dead codeCaolán McNamara
Change-Id: I4d5e2c7d2bbd4eba3eeb790d51a4a93c7ef40577
2017-01-21fix buildCaolán McNamara
Change-Id: I501edaf90794df2ba776241e73c8b844e205ca3c
2017-01-20warn about unused ImagesCaolán McNamara
Change-Id: I5502b28411282354019af51a09c860099c652006 Reviewed-on: https://gerrit.libreoffice.org/33348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-20restore missing RID_SVXBMP_LOCK graphicCaolán McNamara
wrong removed by commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Author: abdulmajeed ahmed <aalabdulrazzaq@kacst.edu.sa> Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Deleted the readonly images too,it was not used any where else and was just confusing. Change-Id: Ice8e59cffc3b3001216c7499da5cbefe74ce8d88
2017-01-19New loplugin:dynexcspec: Add @throws documentation, cuiStephan Bergmann
Change-Id: Ib4db87e67f39504f49b795e12476edbea5166800
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-16Convert RID_MENU_NOTEBOOKBAR to xmlMaxim Monastirsky
Brings a lot of features (icons, keyboard shortcuts, customization, context menu interception etc.) Other changes: - Make SfxDispatcher::ExecutePopup take PopupMenuFlags arg, to be able to pass NoMouseUpClose, so that the menu won't close on mouse-up under anything != gtk3. - Make .uno:OpenFromWriter and .uno:OpenFromCalc async slots, to avoid crash under gtk3 when recycling the current frame. - Don't show the menu in customization dialog, if experimental mode disabled. Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb Reviewed-on: https://gerrit.libreoffice.org/33101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-16SfxConfigGroupListBox leaks its resource containerCaolán McNamara
Change-Id: I02cf44bdc9032fdba9237083ef08da71b817e3af
2017-01-16drop an unused resourceCaolán McNamara
Change-Id: I062859bf5c03f2bf1ad7306b0ce2ab4164eae3bf
2017-01-16unwind resourceCaolán McNamara
Change-Id: I7a951548204745035bd69e4311e5fa1fe91b2d32
2017-01-16drop unused defineCaolán McNamara
Change-Id: I2c3bd011f91e79d3aed43a78e54f149f19909cc3
2017-01-16b*, c*: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16new loplugin: useuniqueptr: cuiNoel Grandin
Change-Id: I9a72b0d3ca999e2f84c615515fafa90bc7f8f2b6 Reviewed-on: https://gerrit.libreoffice.org/33150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14these bitmaps all have alpha channels, not replaceable magenta hackCaolán McNamara
Change-Id: I5e4a433262f17cf4b7e7966687561202960bafa4
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-13tdf#46552 fixing preview for bullets/numbering configurationpv2k
Change-Id: I959169428d4ed0498a2b78fc7a6ae0815e780648 Reviewed-on: https://gerrit.libreoffice.org/32816 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12tdf#103225 make AreaTab box fill to contentTomaž Vajngerl
Change-Id: I9900bab2bb4510352d191ee42c0fa83049d9cecc Reviewed-on: https://gerrit.libreoffice.org/33006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-09tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-08tdf#77115 Layout of options tab of bullet dialogheiko tietze
Alignment fixed, 'start at' moved under number Change-Id: Ib97243e12529bb5e667dea8224b579b91ce60a53 Reviewed-on: https://gerrit.libreoffice.org/32820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-01-05Clean up code after some easy hacksTamás Zolnai
See commits: c613b5dba883897c927f7b60c84830c62a79d0ea 610bc5aa161e726135feee0c7f64331df090475a Instead of adding new conditions or variables, here we need just to initialize nActNumLvl to a new default value. Change-Id: I7b5a559ab5fecdc2a060840a99479312fabbcb4b Reviewed-on: https://gerrit.libreoffice.org/32745 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-04tdf#89932 bullets and numbering position tab level-1pv2k
Fixed the problem of not showing the default values on level-1 Change-Id: I167694d090a6c4cd8064250837d290efabfad21c Reviewed-on: https://gerrit.libreoffice.org/32261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-02WaE: unused variableDavid Tardon
Change-Id: Ib701d3adf1e79554e2ddcefb5943092e3a886041
2017-01-01Bump copyright year to 2017Adolfo Jayme Barrientos
Change-Id: I26ddcdd7bb9616c0599eec9101603d4be1ea4147
2016-12-25Remove another user-visible “CTL”Khaled Hosny
What is the point of the acronym right after the expanded text? It is not like the UI is an article in some scientific journal. Change-Id: I3abcfb3fa8431e6c5b17309bf8b1677ca97eaedf Reviewed-on: https://gerrit.libreoffice.org/32346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-23tdf#70998 Change word "Graphic(s)" to "Image(s)"Huzaifa Iftikhar
There was an error in the previous patch inside the file embeddedobjectcontainer.cxx This is fixed in this patch. Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0 Reviewed-on: https://gerrit.libreoffice.org/32353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-23tdf#101442 - "hyperlink" to "link"Federico Bassini
changing other words "hyperlink" to "link!" Change-Id: I29d97bab7844183759bc34624a14c0216258ad8b
2016-12-22unwind RID_SVXIMGLIST_FMEXPL ImageListCaolán McNamara
Change-Id: If9d733c5242e2f2b9947b251cfe832d1c10bd4bd Reviewed-on: https://gerrit.libreoffice.org/32350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-22convert BmpFilter to scoped enumNoel Grandin
Change-Id: I22c5b49f108d4ce103dea5098a2a0dc9d6bc854c Reviewed-on: https://gerrit.libreoffice.org/32292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21convert VclButtonsType to scoped enumNoel Grandin
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
generated by cgit (git 2.34.1) at 2024-08-03 23:00:08 +0000