summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-08-13avoid invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
Change-Id: I6fbc991e288b150dcbcfb61018f97fdce69c90cd Reviewed-on: https://gerrit.libreoffice.org/77384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-13Fix overly restrictive limit checksStephan Bergmann
Change-Id: I7a67208e500e79f62dad1eee1b89f96e0958ccc3 Reviewed-on: https://gerrit.libreoffice.org/77380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-09Resolves: tdf#126736 change range on change of unitCaolán McNamara
and make the max % 800 instead of 500 while we're at it (0.15cm is considered 100% FWIW) when flipping from measurement unit to % Change-Id: Ia1b15559f3db0d1e11d4563ad7c6aacc3f9ba32d Reviewed-on: https://gerrit.libreoffice.org/77192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-08FIX: Error Correction in QR CodeShubham Goyal
Previously only Low Error Correction value was used to build the QR Code. This patch aims to fix this and make use of Error Correction what user selects. Is fix to the commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Patch also involves some beautification. Change-Id: Ib809569fdd7c1c7c6305c27552419c3e5e8d51b9 Reviewed-on: https://gerrit.libreoffice.org/76958 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-07Resolves: tdf#126691 width/height considered changed, but it didn'tCaolán McNamara
regression from... commit c4041a3b6c703254ee3977eef1a989992506772b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon May 28 14:33:42 2018 +0100 weld SvxSwPosSizeTabPage Change-Id: Ib8a5359a1aee9ac7b645621b9de9311cd56449f5 Reviewed-on: https://gerrit.libreoffice.org/77121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07Resolves: tdf#125483 locale separator label needs to be derived from originalCaolán McNamara
regression from... commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Change-Id: I940269d14a0a84768c4f8e62c153cfac51cf577f Reviewed-on: https://gerrit.libreoffice.org/77086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07tdf#61076 string validation on creation of new dictionary.Rtch90
Prevent having '/' or '\' within the dictionary name to prevent data loss. Change-Id: I392832c748effcdbbe58983a788ba6b38764628c Reviewed-on: https://gerrit.libreoffice.org/71059 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2019-08-07Fix wrong method in SAL_WARN (cui/optinet2.cxx)Julien Nabet
Change-Id: Ifb56d6d6c767b8f5d40e396638470be822355d6d Reviewed-on: https://gerrit.libreoffice.org/77075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-06ofz#16191 fix build failureCaolán McNamara
Change-Id: Iaa4e14e102374951ba8ab99507367556ff5920fd Reviewed-on: https://gerrit.libreoffice.org/77017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-06tdf#107471 Add checkbox to enable/disable sending crash reports to TDFGabor Kelemen
Also hide it when compiled with --disable-breakpad i.e. most Linux distributions Change-Id: I5d392e22410614550aa9602d0c30b0b81ec22ea0 Reviewed-on: https://gerrit.libreoffice.org/76771 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Fix Border feature QR CodeShubham Goyal
The change is in addition to the change 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Change-Id: I4fce9260d9276799f7c3fa089d23695c8419afd4 Reviewed-on: https://gerrit.libreoffice.org/76953 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAGMike Kaganski
... because RES_CHRATR_GRABBAG value may be later reset by initial value read from char format, when it's present there. OTOH, RES_PARATR_GRABBAG shouldn't be present in character format, so it should be safe to pass the grabbag item there. Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e. Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2 Reviewed-on: https://gerrit.libreoffice.org/76981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-05Make generated QR Code as a perfect squareShubham Goyal
Fix drawbacks of commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Change-Id: I94503900250c2d8a10f5930c539bdc2f7da5cfd4 Reviewed-on: https://gerrit.libreoffice.org/76954 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-02Revert "fix some accessibility warnings"Noel Grandin
This reverts commit 885ae69174cf717edd00526e5cf8f1585c505c95. <caolan> noel_grandin, wrt the accessibility labelled-by and label-for. If the label really is a GtkLabel then setting its mnemonic target (in glade, general tab, and use underline and select a target) is the most straight forward thing to do and implies those a11y relations <caolan> the painful manual a11y labelled-by/label-for are typically for using something weird, like a checkbutton, as a label for something Change-Id: I13db8ec65d10248aa46cb6b01398ec302dd06b59 Reviewed-on: https://gerrit.libreoffice.org/76837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02fix some accessibility warningsNoel Grandin
Change-Id: I18f9a71ac4e2ef5c159e13bc3cb0e36cf7c550a5 Reviewed-on: https://gerrit.libreoffice.org/76834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02tdf#126643: avoid unnecessary asking for JRE in script organizer dialogMike Kaganski
Use two-pass search for the needed language node; if it fails with Java interaction disabled, only then repeat the search with it enabled, like in commit f3ce30ec75a4d7116b9cd4d7b21d9aaa0e237eeb. Change-Id: Icde5dbeb552a6837af02182f7b8cbbc90765c5a5 Reviewed-on: https://gerrit.libreoffice.org/76831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01weld SvxDefaultColorOptPageCaolán McNamara
Change-Id: I5741ee4d0df724e9f1df72ce668f9f2e53541280 Reviewed-on: https://gerrit.libreoffice.org/76802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01drop newly unused OptHeaderTabListBoxCaolán McNamara
Change-Id: I08926e91a61e7bdd4de4ac96083e970268801d6f Reviewed-on: https://gerrit.libreoffice.org/76789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld SvxPathTabPageCaolán McNamara
Change-Id: If9b982d9e73adbb55e940ae12e5d894dd803f7f3 Reviewed-on: https://gerrit.libreoffice.org/76788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01should toggle all others to false, not trueCaolán McNamara
regression since... commit 5c32ba63163d9556ff89782a8074924cdf9dc554 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 4 14:30:03 2019 +0100 weld OTableSubscriptionPage Change-Id: Iec3bec1b49af3e60b80301665ff3834f24f72222 Reviewed-on: https://gerrit.libreoffice.org/76787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31weld ConnectionPoolOptionsPageCaolán McNamara
Change-Id: I7a772fd441304eaa1f08c1474b28a471cf33af5a Reviewed-on: https://gerrit.libreoffice.org/76756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31weld SvxFontSubstTabPageCaolán McNamara
Change-Id: If24e80da4042ea37ea2613a6c62e015d0d925dc8 Reviewed-on: https://gerrit.libreoffice.org/76753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): cuiStephan Bergmann
Change-Id: If2a86e570cd8225acb27e9c37377078b7a246449 Reviewed-on: https://gerrit.libreoffice.org/76687 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31weld OfaMSFilterTabPage2Caolán McNamara
Change-Id: I799eaffc808a7e41434fb76c877f4d1e8d4e1c3b Reviewed-on: https://gerrit.libreoffice.org/76707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31tdf#42949 Fix IWYU warnings in cui/source/{c-f}*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie5e070d13b771cf3e114c2454d49d77d95934160 Reviewed-on: https://gerrit.libreoffice.org/76506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30bFirst means 1st vs 2nd column, and needs to alternate on each loopCaolán McNamara
this went wrong at... commit f423ac2d3bdba4263f1f41e31e7e2b7715afdd6e Date: Tue Mar 5 15:16:16 2019 +0200 remove sal_IntPtr in OfaMSFilterTabPage2 and just use a scoped enum Change-Id: I74bcca9ffee9faf4600da64b3c409dbf19a1290e Reviewed-on: https://gerrit.libreoffice.org/76619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#125642 Fix layout issues for Bullet dialog.Gülşah Köse
Change-Id: Ieacd060a8bfe4e2123e6973e30789e029ab02ca6 Reviewed-on: https://gerrit.libreoffice.org/76587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-30drop newly unused SvxRadioButtonListBoxCaolán McNamara
Change-Id: Idb80fa73fad6e4bb2a1eaa3d55d7fe90e86c8965 Reviewed-on: https://gerrit.libreoffice.org/76605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxPersonalizationTabPageCaolán McNamara
Change-Id: I5240fc4237d8b471b2c23a8bc776cffa46a53285 Reviewed-on: https://gerrit.libreoffice.org/76607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxJavaOptionsPageCaolán McNamara
Change-Id: Ib37f6f554a890bd6397ae7b6c56f1615cd12b6b1 Reviewed-on: https://gerrit.libreoffice.org/76604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld OfaLanguagesTabPageCaolán McNamara
Change-Id: Ib0938f0c9d810c0f851dd0180093aabb4babdc19 Reviewed-on: https://gerrit.libreoffice.org/76594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxSecurityTabPageCaolán McNamara
Change-Id: I4cace9417f1f036921b3e95d946f431ec072ce3a Reviewed-on: https://gerrit.libreoffice.org/76586 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxProxyTabPageCaolán McNamara
Change-Id: I34651fc7c56da5205b349a83276d5efa536c4301 Reviewed-on: https://gerrit.libreoffice.org/76582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld OfaMSFilterTabPageCaolán McNamara
Change-Id: Ie711d8624995027578f79389972c6fa26b3189a2 Reviewed-on: https://gerrit.libreoffice.org/76569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxOnlineUpdateTabPageCaolán McNamara
Change-Id: I0043ba0b088f0b9ae8e5716c64e424419993cb96 Reviewed-on: https://gerrit.libreoffice.org/76568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxEMailTabPageCaolán McNamara
Change-Id: I039564a53fe4b9c20f34efcb9e59f57528a1f5da Reviewed-on: https://gerrit.libreoffice.org/76561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwRedlineOptionsTabPageCaolán McNamara
Change-Id: Ic901356d399e8d758747f0fea07d3656fbf89aab Reviewed-on: https://gerrit.libreoffice.org/76559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld OfaViewTabPageCaolán McNamara
Change-Id: I259e10ad8bdf3d1630ab1d24590c43919a351a86 Reviewed-on: https://gerrit.libreoffice.org/76567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxCTLOptionsPageCaolán McNamara
Change-Id: I7b891e1a1d0ffc52cfd91a33fd01b3ec8ac2cd65 Reviewed-on: https://gerrit.libreoffice.org/76562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126485 remove max limitCaolán McNamara
Change-Id: Ieda7b500c1c08d169bfbfa995b42d3761d2427d7 Reviewed-on: https://gerrit.libreoffice.org/76526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126510 - Expander sections are bad UXHeiko Tietze
GtkExpander replaced by GtkFrames Change-Id: I07130f7f070e45bf60ffb4fc26605b79556534b3 Reviewed-on: https://gerrit.libreoffice.org/76219 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-29Add qrcodegen ui file to make fileShubham Goyal
The qrcodegen.ui file in https://gerrit.libreoffice.org/#/c/74167/ was forgetfully not added to make file, so here it is. Change-Id: If60cf8f4aa3ed670da026f7631199e82d9b5a3d4 Reviewed-on: https://gerrit.libreoffice.org/76376 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:oncevarNoel Grandin
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb Reviewed-on: https://gerrit.libreoffice.org/76495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-27weld SvxSaveTabPageCaolán McNamara
Change-Id: I89b81ff408d2dc855fe7b780a62e85f3a2a06215 Reviewed-on: https://gerrit.libreoffice.org/76472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27weld OfaHtmlTabPageCaolán McNamara
Change-Id: I10ee46d19047da9a3e3d8b0f99866568a12aa0f1 Reviewed-on: https://gerrit.libreoffice.org/76471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27weld SvxBasicIDEOptionsPageCaolán McNamara
Change-Id: I3f5a7fe106075194e90e0da6f6538882024adec1 Reviewed-on: https://gerrit.libreoffice.org/76454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-27weld SvxAsianLayoutPageCaolán McNamara
Change-Id: I0bea0026177dcb056edd073cdd9c51e76273d169 Reviewed-on: https://gerrit.libreoffice.org/76456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>