summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-02-20do not localize Collabora Office URLAndras Timar
Change-Id: I1eb33d3ce649ff8ca1158e96fe6c6bc1a3ab75ea (cherry picked from commit 9189450fa042526ee5380a2b9004b8a1a32a9e48) (cherry picked from commit b36267edb632577ca5e6deb219d5da4d5b8e9bef)
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-02-17respect read-only config items in Basic IDE Options dialogAndras Timar
Change-Id: I4a23b347c5fed948045427bc440e7a821b95b63c Reviewed-on: https://gerrit.libreoffice.org/31242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d5be8dddc43e8a880d546fb9a6e8fbb45278eeca)
2017-02-10tdf#98993 cui: Paragraph dialog: decimals in Line Spacing spinboxMichael Stahl
For whatever reason, this also makes the +/- buttons increment by 1pt instead of the previous 10pt, which is also an improvement. (presumably regression from 324141f21bf2280d7613c4056ee8cd997ea345f9) Change-Id: If47dd768b2faea760d9967a73453d3f714c65fe3 (cherry picked from commit d22377ab55675135776d94213ef06f608b71669e) Reviewed-on: https://gerrit.libreoffice.org/34108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-02Resolves: tdf#100438 focus trapped in disabled toolbarCaolán McNamara
lets just leave the toolbar active the whole time, seems to make more sense anyway wrt being allowed to keyboard into it to paste/insert special character Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818 (cherry picked from commit 4bd53cd880ecfa9af27735344bf57fb45de20c25) Reviewed-on: https://gerrit.libreoffice.org/33785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-01crash on exit from undisposed insert special character dialogCaolán McNamara
right click on style combobox in writer toolbar, insert character, esc, ctrl+f4 and crash Change-Id: I83c88584c6d772bf629121a2bcdc16076bee8003 (cherry picked from commit cfdfe1be91101654456bdf1f16d92461e1e5dbfa) Reviewed-on: https://gerrit.libreoffice.org/33700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-26Resolves: tdf#104552 table properties dialog drops previous border colorCaolán McNamara
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f (cherry picked from commit e2eaaa8a578fff5770a99e3f8ee2a7c95c460891) Reviewed-on: https://gerrit.libreoffice.org/33502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-18tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit ce0f9962d1d1d5a4f6301be18c23b2d14efd9d6b) Reviewed-on: https://gerrit.libreoffice.org/33246 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e6d7d737522124350a17a3cfdee055f03200a274) Reviewed-on: https://gerrit.libreoffice.org/33048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-01-11Bump copyright year to 2017Adolfo Jayme Barrientos
Change-Id: I26ddcdd7bb9616c0599eec9101603d4be1ea4147 (cherry picked from commit e5da108ef01872f460c176b6a9173e346e1d59a4) Reviewed-on: https://gerrit.libreoffice.org/32597 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-01-10tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 62a94dcf0c750e335d6ce272d8a5df9813910d5a) Reviewed-on: https://gerrit.libreoffice.org/32913 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-01-03WaE: unused variableDavid Tardon
Change-Id: Ib701d3adf1e79554e2ddcefb5943092e3a886041 (cherry picked from commit 99f3f180034b78900e9ff6953b9866fde3da01d6) Reviewed-on: https://gerrit.libreoffice.org/32694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-19tdf#104221: Make up for non-existent FillItemSetKatarina Behrens
for fill:none option Change-Id: I12ada9276a613f157976650148f2389126d16f08 Reviewed-on: https://gerrit.libreoffice.org/32050 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4c5079791f5d985151ebc090c5a07705e76a728e) Reviewed-on: https://gerrit.libreoffice.org/32053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-16coverity#1397204 Dereference null return valueCaolán McNamara
Change-Id: Ief4b455b316b55ebf012a8650c96da037df0135c (cherry picked from commit f74cad45681cc0ea5706a112a0e17f14a3197e39)
2016-12-14tdf#104615: there's no mpView when opening odc directlyJulien Nabet
2 parts changed for these bts: 0 SdrEditView::GetGeoAttrFromMarked (this=0x0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdedtv1.cxx:1278 1 0x00002aaadf70ae97 in SvxBitmapTabPage::Reset (this=0x55555b2eb8b0, rAttrs=0x55555afa0310) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:278 See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c1 0 SdrPaintView::GetModel (this=0x0) at /home/julien/lo/libreoffice/include/svx/svdpntv.hxx:256 1 0x00002aaadf90ba0f in SvxBitmapTabPage::ModifyBitmapHdl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:526 2 0x00002aaadf90bcc7 in SvxBitmapTabPage::ClickBitmapHdl_Impl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:457 3 0x00002aaadf90c9d8 in SvxBitmapTabPage::Reset (this=0x55555b2e7950, rAttrs=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:441 See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c2 Thank you to Katarina Behrens for her help on this. See http://nabble.documentfoundation.org/About-opening-odc-file-and-mpView-null-td4202317.html Change-Id: Ibbca868f33ca3292e0d3f787df87876bc9464e0b Reviewed-on: https://gerrit.libreoffice.org/31924 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit d543d66a4ee34d3b0088f45951b56c150f7206ec) Reviewed-on: https://gerrit.libreoffice.org/32008 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-13Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-upEike Rathke
Comparing colors to determine whether to set one in the result item set does not work if the color previously was set before SaveValue() was called unconditionally even for the "undetermined" color state. Actually we want to know whether the user selected a color instead. Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d (cherry picked from commit 429be969b39867d6d9f36978c9ac15b601e78ba6) Reviewed-on: https://gerrit.libreoffice.org/31922 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-27Handle cases where last-used palette disappearedStephan Bergmann
...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set PaletteManager::mnCurrentPalette to 65535, and PaletteManager::GetSelectedPalettePath would do out-of-bounds access into PaletteManage::m_Palettes. That the last-used palette (as stored under in the configuration under /org.openoffice.Office.Common/UserColors/PaletteName) may become more common with pending changes like <https://gerrit.libreoffice.org/#/c/31199/> "tdf#104047 Remove dispensable palettes". Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281 (cherry picked from commit 8b718e3774f1ffb69f9aad565216556c798e95f4) Reviewed-on: https://gerrit.libreoffice.org/31209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-26respect read-only config items in Options - Load/Save - General dialogAndras Timar
Change-Id: I110e8eb2b858c8b86b01d46bec40873939ae53d8 Reviewed-on: https://gerrit.libreoffice.org/31237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-22loplugin:countusersofdefaultparams in include/sfx2Noel Grandin
Change-Id: I8b5e3ebbfb715d0b6aec2c4137f0ff524b63227e Reviewed-on: https://gerrit.libreoffice.org/31065 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22remove redundant space in stringStanislav Horacek
Change-Id: I7fbfe0ac11ef5dbe23b0fa3864c647682d1a73a7 Reviewed-on: https://gerrit.libreoffice.org/30938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21add missing resource depDavid Tardon
Change-Id: If71616f2a8f1bcd42bd89a9192ec0e1d3fdaba0e
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21Re-apply "split cui screenshot test in manageable pieces""Norbert Thiebaud
Change-Id: I22f99f830a3b4b6ba50514b7db076ea1a41478de Reviewed-on: https://gerrit.libreoffice.org/31032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-20Revert "split cui screenshot test in manageable pieces"Julien Nabet
This reverts commit c3c0557801d8713fb99216bea37443471affc1f6. Hopefully make TBs green again Change-Id: Ifb574175fd3bbdce1520aea7953dd8fb95bed30b Reviewed-on: https://gerrit.libreoffice.org/31018 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-20split cui screenshot test in manageable piecesNorbert Thiebaud
Change-Id: I7aa6e7afecc841aecbc1acaf1a7c14ba92c089ba Reviewed-on: https://gerrit.libreoffice.org/30981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-18svx: assert SfxPoolItem::operator==Michael Stahl
Change-Id: I7a5898f0dffb4d25b6e1bb916b3c6b36374f9912
2016-11-16screenshotannotation: Trim the textfield, add scrollbarKatarina Behrens
to prevent it from growing too large and thus distorting the dialog Change-Id: Iaa27d3085ec314246565cae79ab7d627a94a3bff Reviewed-on: https://gerrit.libreoffice.org/30898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16screenshotannotation: Fix bookmark snippetsKatarina Behrens
Change-Id: I245000b48775955dcf72f362829df7594e8b637b Reviewed-on: https://gerrit.libreoffice.org/30880 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16loplugin:countusersofdefaultparams in include/svx..unotoolsNoel Grandin
Change-Id: I02e933da66241e99e3b81d90d679f1502bab3fef Reviewed-on: https://gerrit.libreoffice.org/30866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15screenshotannotation: include image size in XML markupKatarina Behrens
Change-Id: I1c02055280b929ddd3ad12e6f6562c95bfe2a48a Reviewed-on: https://gerrit.libreoffice.org/30870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15tdf#34467 - FitToFrame: stretch text to fill drawing objJustin Luth
Help for Fit To Frame says "Resizes the text to fit the entire area of the drawing or text object". reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef and partially addresses the problem of "Shrink font automatically when text overflows" by treating text as "Autofit" while it is being edited. It's not WYSIWYG, but good enough, and maybe better. Since that part of the change prevents any way of setting ::Autofit, I also changed the default setting to Autofit instead of NONE, since there is no good reason why text should be allowed to spill outside of a textbox. For those who REALLY want that odd behaviour, they can use .uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none". Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9 Reviewed-on: https://gerrit.libreoffice.org/30727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-14Avoid unnecessary, wrong downcastStephan Bergmann
...as reported by -fsanitize=vptr when doing "Format - Paragraph... - Area - Color" in Writer: > cui/source/tabpages/tpcolor.cxx:65:19: runtime error: downcast of address 0x6030009782b0 which does not point to an object of type 'XOutdevItemPool' > 0x6030009782b0: note: object is of type 'SwAttrPool' > 20 01 80 1c 50 e8 e9 85 4d 7f 00 00 e0 28 48 86 4d 7f 00 00 c0 d7 11 00 30 61 00 00 80 29 54 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwAttrPool' > #0 0x7f4b047cfd3a in SvxColorTabPage::SvxColorTabPage(vcl::Window*, SfxItemSet const&) cui/source/tabpages/tpcolor.cxx:65:19 > #1 0x7f4b0480ec04 in VclPtr<SvxColorTabPage> VclPtr<SvxColorTabPage>::Create<vcl::Window*&, SfxItemSet const&>(vcl::Window*&, SfxItemSet const&) include/vcl/vclptr.hxx:138:46 > #2 0x7f4b047f8567 in SvxColorTabPage::Create(vcl::Window*, SfxItemSet const*) cui/source/tabpages/tpcolor.cxx:326:12 > #3 0x7f4b0472132a in CreateFillStyleTabPage(unsigned short, vcl::Window*, SfxItemSet const&) cui/source/tabpages/tparea.cxx:319:42 > #4 0x7f4b0471ef8b in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:330:41 > #5 0x7f4b047114b3 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, Button*) cui/source/tabpages/tparea.cxx:323:1 > #6 0x7f4df3eac737 in Link<Button*, void>::Call(Button*) const include/tools/link.hxx:84:45 > #7 0x7f4df3e93bb6 in Button::Click()::$_0::operator()() const vcl/source/control/button.cxx:127:85 Change-Id: I6259b100c535fa81b9f7452db84c22d5b10acb1e
2016-11-14Avoid -fsanitize=nullStephan Bergmann
...when doing "Format - Page..." in Writer (and eFillType is TRANSPARENT): > cui/source/tabpages/tparea.cxx:331:33: runtime error: reference binding to null pointer of type 'SfxTabPage' > #0 0x7f9f053e936f in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:331:9 > #1 0x7f9f053e548c in SvxAreaTabPage::ActivatePage(SfxItemSet const&) cui/source/tabpages/tparea.cxx:157:13 > #2 0x7fa21be01676 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1126:19 > #3 0x7fa21bdf70e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #4 0x7fa1f5efff37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #5 0x7fa1f5ebbcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I279f507038ab4bae1be4f02b6537e6d1aab76348
2016-11-14Avoid -fsanitize=enumStephan Bergmann
...when doing "Format - Page..." in Writer: > cui/source/tabpages/tparea.cxx:268:12: runtime error: load of value 4294967295, which is not a valid value for type 'FillType' > #0 0x7f89ff653a41 in SvxAreaTabPage::Reset(SfxItemSet const*) cui/source/tabpages/tparea.cxx:268:12 > #1 0x7f8d15524560 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1117:19 > #2 0x7f8d1551b0e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #3 0x7f8cef623f37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #4 0x7f8cef5dfcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I19dd3ed9d362132daa3f3be9fb0e9702a62bdeb0
2016-11-14tdf#103228: Remember fill type when switching between tabsKatarina Behrens
This page used not to have exchange support, but it needs it now since it contains all the fill type subtabs Change-Id: Ibeefc0ae832b4d53727711a169f1765d28350ec1 Reviewed-on: https://gerrit.libreoffice.org/30843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-13coverity#1371441 Uninitialized pointer fieldCaolán McNamara
Change-Id: Icabed9a27be9e34552531997818afd202f31114c
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10loplugin:expandablemethods in cuiNoel Grandin
Change-Id: I3dae1d142874c767ec1e32401acba0bbca95df5f Reviewed-on: https://gerrit.libreoffice.org/30716 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Change new colour only, keep active one on the initial valueKatarina Behrens
Change-Id: Icfda455d275d0449725867fd7bf4ea3060e7dc26 Reviewed-on: https://gerrit.libreoffice.org/30691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07style fix for cppcheck duplicateBreakJochen Nitschke
Change-Id: I42d4763db5a87741baa6b6d5ec58ea136394bf7a Reviewed-on: https://gerrit.libreoffice.org/30670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
generated by cgit (git 2.34.1) at 2024-08-08 08:23:05 +0000