summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-05-12regenerate PCH headersLuboš Luňák
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-11Fix typoAndrea Gelmini
Change-Id: I18654893dc0454708619e1c021c84a56d5ad950e Reviewed-on: https://gerrit.libreoffice.org/71952 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09avoid copying when placing items into SfxItemSetNoel Grandin
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-08improve tip to indicate its only writer, and the text cursor editing positionCaolán McNamara
Change-Id: I66db4b9f800eb2e3e0b81d4e8f9c2b7f742d23cf Reviewed-on: https://gerrit.libreoffice.org/71953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08merge duplicated TriStateEnabled classCaolán McNamara
Change-Id: I1c10010eb7fd33a03f477af0cba03ae74859b174 Reviewed-on: https://gerrit.libreoffice.org/71959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-08Typo in tip of the dayStephan Bergmann
Change-Id: I344300807b0bfce0b779b2d64337dad96eee86c9 Reviewed-on: https://gerrit.libreoffice.org/71945 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-05-07Resolves tdf#124978 - Tip-of-the-day referencesheiko tietze
* LibreOffice changed into %PRODUCTNAME * std::pair made into std::tuple and hyperlinks separated from strings * tip about donation / getinvolved added * "Use an array formula to repeat a calculation with different values..." removed * "%PRODUCTNAME supports 110 languages"->"%PRODUCTNAME supports over 150 languages" * code added to open offline help * online hyperlinks converted into offline links, if available * Ctrl, Shift, Alt uppercased * › replace by > * ellipsis removed Change-Id: Ic35257d0a6d6e77750716254fb9d1f6983a54af1 Reviewed-on: https://gerrit.libreoffice.org/71760 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-07tdf#62699 Drop pass-through header file include/svx/xattr.hxxGabor Kelemen
Change-Id: I8db9a4de494fbd045a0f4da810c3887ce62dd350 Reviewed-on: https://gerrit.libreoffice.org/71595 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-03Resolves: tdf#125080 crashing adding a ref to a non-VclPtrCaolán McNamara
Change-Id: I72a0deaab3d86ac0772092ab5f60bcace7632847 Reviewed-on: https://gerrit.libreoffice.org/71729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-30tdf#62699 Drop pass-through header file include/svx/xlineit.hxxGabor Kelemen
Change-Id: I3ae76558f476934dffc2b43b19af848b5ad5015e Reviewed-on: https://gerrit.libreoffice.org/71454 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-29tdf#62699 Drop pass-through header file include/svx/xfillit.hxxGabor Kelemen
Change-Id: I6598d81b166486f3c48b119cc136b9f6e6c2a12c Reviewed-on: https://gerrit.libreoffice.org/71336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-28Resolves: tdf#125002 toggling on radio button generates click on anotherCaolán McNamara
so use toggle and ignore toggle offs Change-Id: Id6a9f3a7a9cf02d62ede00e4c246629406f9a64b Reviewed-on: https://gerrit.libreoffice.org/71481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28Resolves: tdf#124931 key stroke in shortcut keys not selecting the key comboCaolán McNamara
Change-Id: Ife3e99e0cf00d7d320eb8e403743d42fb8274df8 Reviewed-on: https://gerrit.libreoffice.org/71483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-27tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac Reviewed-on: https://gerrit.libreoffice.org/71430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xsetit.hxxGabor Kelemen
Change-Id: Id750f663389be36c669756e4bdd1e4e01be48199 Reviewed-on: https://gerrit.libreoffice.org/71327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26tdf#124658 - Improve text for the tip-of-the-dayheiko tietze
All strings reviewed Change-Id: I7c9b2460b86576c67221c874bd9f99ea43db17d4 Reviewed-on: https://gerrit.libreoffice.org/71365 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-25Resolves: tdf#124804 border considered changed when it isn'tCaolán McNamara
Change-Id: Ib4b6031b31500a8a2086721124b5b8f554f7c1c5 Reviewed-on: https://gerrit.libreoffice.org/71296 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-25Resolves: tdf#124932 fix Shortcut Keys etc tab traversalCaolán McNamara
Change-Id: I9d0204161a0efe91ebcddaf5b2931ab156221b79 Reviewed-on: https://gerrit.libreoffice.org/71283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-24tdf#124893 Validity check on new dialog creation.Rtch90
Change-Id: I5f94c8204a4c35470e891eb89cfbe74aad852bf4 Reviewed-on: https://gerrit.libreoffice.org/71084 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-23tdf#42949 Fix IWYU warnings in include/editeng/[f-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic14d2e66434817bcb7bd1e2b707f81d720d596b6 Reviewed-on: https://gerrit.libreoffice.org/71007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23tdf#123228: Disable Firefox theme searchMuhammet Kara
We can't use the MOZ API anymore. Let's disable it instead of showing a broken search window. Then we can spend some time on moving on instead of answering the -This is not working!- bug reports. Change-Id: Ice10bde804d1d9a7a13cd4781813fc794b1b0967 Reviewed-on: https://gerrit.libreoffice.org/67917 Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-04-22tdf#124846 Make main menu items really move when movedJim Raykowski
This patch also fixes the Move Menu dialog move up button being enabled when dialog is created. Change-Id: I8432bd8d582e8a9ef449bce1d5cba703b2404c75 Reviewed-on: https://gerrit.libreoffice.org/71001 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-04-22Fix typoAndrea Gelmini
Change-Id: I1cc008b08f4a11e9869f55a48ae5bf79ac026130 Reviewed-on: https://gerrit.libreoffice.org/71055 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22Fix typoAndrea Gelmini
Change-Id: If8dc4a7bb2a58ade394752104a94394d5361fd17 Reviewed-on: https://gerrit.libreoffice.org/71054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20Fix typoAndrea Gelmini
Change-Id: If2e6cced51130ae7fa47f2510538345db548c546 Reviewed-on: https://gerrit.libreoffice.org/70992 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-19drop some unneeded includesCaolán McNamara
Change-Id: Idde1f747f500d94b3191a97e7d502794cc2b8450 Reviewed-on: https://gerrit.libreoffice.org/70972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19optimise find/insert patternNoel Grandin
if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-19tdf#42949 Fix IWYU warnings in comphelperGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also re-evaluate some blacklisted headers and recheck include/comphelper/ Change-Id: Ib7eea5951e849c07cea2e2782be4e8945f71ad96 Reviewed-on: https://gerrit.libreoffice.org/70899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19drop some includesCaolán McNamara
Change-Id: I6f9765208e807da336146e55f0f1cbcb46316d4c Reviewed-on: https://gerrit.libreoffice.org/70935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Related: tdf#124809 cannot assume that icon size is same as checkbox sizeCaolán McNamara
cause can be using large icon size Change-Id: I4661199b658ff0d2013a7bbd7159b1c134ade043 Reviewed-on: https://gerrit.libreoffice.org/70942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Resolves: tdf#124809 spacing ignored unless WB_ITEMBORDER is setCaolán McNamara
Change-Id: I29d63926c605d3f143c242337e31388123f22cff Reviewed-on: https://gerrit.libreoffice.org/70939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-16Resolves: tdf#124743 - Tip of the Day randomizationheiko tietze
srand() added, image file name part of the hrc definition now Change-Id: Ib697f64406ab6b11468eb837c71d57398a0533b5 Reviewed-on: https://gerrit.libreoffice.org/70767 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-15ensure gtk creates a default label widget for the MenuButtonsCaolán McNamara
Change-Id: Id8b6f11b4429c8029cacfc26592767625efb9674 Reviewed-on: https://gerrit.libreoffice.org/70798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-15improve loplugin simplifyconstructNoel Grandin
to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-12loplugin:sequentialassign in comphelper..cuiNoel Grandin
Change-Id: I1a08f3684b785e31535adcfb4220ded267a77c3b Reviewed-on: https://gerrit.libreoffice.org/70643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I8afb1f6e6fbde1b1d9339913e2eb67122f8930be Reviewed-on: https://gerrit.libreoffice.org/70633 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Ia88380a9699e74eb93c0a093ff87e4437d084515 Reviewed-on: https://gerrit.libreoffice.org/70629 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I368c0127d679e8c6e2d8f0bc979828c4f4795fda Reviewed-on: https://gerrit.libreoffice.org/70630 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I1fc7426f93d0c2e73450377c8bd5c3d847fe5218 Reviewed-on: https://gerrit.libreoffice.org/70625 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: Id09373f15389f241b56a73c406b4c88e334ab505 Reviewed-on: https://gerrit.libreoffice.org/70619 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-12Fix typoAndrea Gelmini
Change-Id: I578e3801aa7ddc424d9e4e9c6da7ff7231f49ee6 Reviewed-on: https://gerrit.libreoffice.org/70626 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>