summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-13tdf#101976 cui: fix crash when setting AutoCheckEnabled and it is read-onlyMiklos Vajna
With instdir/share/registry/data/registrymodifications.xcu being: <?xml version="1.0" encoding="UTF-8"?> <oor:items xmlns:oor="http://openoffice.org/2001/registry" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> <item oor:path="/org.openoffice.Office.Jobs/Jobs/org.openoffice.Office.Jobs:Job['UpdateCheck']/Arguments"> <prop oor:name="AutoCheckEnabled" oor:op="fuse" oor:type="xs:boolean" oor:finalized="true"> <value>false</value> </prop> </item> </oor:items> and then trying to set 'Check for updates automatically' in Tools -> Options -> LibreOffice -> Online Update. Change-Id: Ifb196b6351c8a9182dfcf2ddf0a1e0555bcccedd Reviewed-on: https://gerrit.libreoffice.org/28856 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-10check for read-only state of OpenCL settingsAndras Timar
Change-Id: Ia3695d5e4901e527ef847a86e737f6c7eba5085f Reviewed-on: https://gerrit.libreoffice.org/28730 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-09loplugin:constantparam in sfx2Noel Grandin
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09handle read-only state of collect usage information settingAndras Timar
Change-Id: I0f612cc39636dd3e2a829b7a6c8dc2a0a5a4b530 Reviewed-on: https://gerrit.libreoffice.org/28763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-09loplugin:constantparam in svxNoel Grandin
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa Reviewed-on: https://gerrit.libreoffice.org/28746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-07Adjust labels in the bullets and numbering dialogYousuf Philips
Change-Id: If8892446dcabd8dc51d1193fe1fcccd64fa07bac Reviewed-on: https://gerrit.libreoffice.org/28706 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07tdf#82840 Add 'Add Separator' button to toolbar customizationMuhammet Kara
Add 'Add Separator' button to the 'Customize' dialog's 'Menus', 'Context Menus', and 'Toolbars' tabs. And remove the 'Add Separator' item from the 'Modify' menu. In the following commits, more widgets will be added and moved around to achieve the suggested appearance and functionality in the related bug report. Change-Id: I1961e2ebeb326eca69d8f967b2b636793200aba0 Reviewed-on: https://gerrit.libreoffice.org/28681 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07wrong ScopedVclPtrInstance creationCaolán McNamara
Change-Id: I524f507bc5720704460d94bb52f99cb7792703e9
2016-09-07loplugin:constantparam in vclNoel Grandin
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-06a11y: fix missing labels in sw paragraph dialog textflow tabYousuf Philips
Change-Id: I3173cf240131788013345aa864156286affa476d Reviewed-on: https://gerrit.libreoffice.org/28657 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-06a11y: Labels for fill characters options in paragraph dialogYousuf Philips
Change-Id: Ied1bbc4350da2de3df0e3e695eee7baaeb46499b Reviewed-on: https://gerrit.libreoffice.org/28659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-05tdf#82840 Add 'Reset' button to toolbar customizationMuhammet Kara
Add 'Reset' button to the toolbar customization dialog, and remove the 'Restore Default Settings' item from the 'Toolbar' menu. Note that this 'Reset' button does not only reset the selected item but also restores the selected top-level toolbar to default settings. Since there is no 'Restore Default Settings' option in the other tabs of the config dialog, the button is disabled and hidded in the parent class ctor, then made visible again in the child class ctor. In the following commits, more widgets will be added and moved around to achieve the suggested appearance and functionality in the related bug report. Change-Id: I028c082daf423761e3511101069a0dc842743e3b Reviewed-on: https://gerrit.libreoffice.org/28621 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-05convert Orientation to scoped enumNoel Grandin
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert ToolBoxButtonSize to scoped enumNoel Grandin
Change-Id: I365b0e34361eb339b04e5f4792f54eff5bf582a5
2016-09-05convert ExtTimeFieldFormat to scoped enumNoel Grandin
Change-Id: I6cb4e057f7a5b83edb51048f24372d19fbf48177
2016-09-05convert RasterOp to scoped enumNoel Grandin
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-04cppcheck: redundantIfRemoveJulien Nabet
Change-Id: I8576c5042265399de6d9c72ffd67bce0fb256923 Reviewed-on: https://gerrit.libreoffice.org/28661 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-03Resolves: tdf#101795 restore hiding on end of Gtk fpicker executeCaolán McNamara
but don't hide it at the end of every RunDialog::run so that the dialog still exists and is visible if the "sure you want to overwrite" dialog needs to be displayed and restore the cui options stuff to its original state as well, undoing the earlier efforts of... commit c1bd3156cf66318023f36d81ce809a38072588e4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 21 21:44:06 2016 +0100 Resolves: tdf#101054 crash on options->path with non-native file picker and commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker Change-Id: I5d6bcee9fb0a73a95cc29e8f3f2ee2aea91a135a
2016-09-02boost::intrusive_ptr->tools::SvRefCaolán McNamara
Change-Id: I4c913dc62efe3f3747e78670f4efb0216d95c4ad Reviewed-on: https://gerrit.libreoffice.org/28585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-02Revert "tdf#101629: fix https://addons.mozilla.org/ case"Julien Nabet
This reverts commit 454e1ebcfc589ce82c8c2d5585e22bea1ea5fc79. Change-Id: Id296e622dc8e14bd20549325d890196d8d36b1a5 Reviewed-on: https://gerrit.libreoffice.org/28605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-01loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: Ifc9cdbda77048791203e89350c2efa9a6c34c4a5 Reviewed-on: https://gerrit.libreoffice.org/28555 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01Gallery submenu was missing from native menusMaxim Monastirsky
... for both OS X and gtk3. The reason is that it was filled in item highlight handler, which isn't implemented for native menus. For now use the menu activation handler, like for the similar button in SvxLineTabPage. Change-Id: I437fd6536dbd9e6ba51282eaacc8b43c3a2d6cbf
2016-08-31tdf#93333 in AutoCorrectDialog list also CJK languages if enabledSophie Su
Change-Id: If203511e6645848544895d2f0813f3f362a8e336 Reviewed-on: https://gerrit.libreoffice.org/28437 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-08-31loplugin:stringconstantStephan Bergmann
Change-Id: Ia4b69d90b2cbeb9aeed9514c12a71abe5e4bd6d5
2016-08-31Resolves: tdf#98097 no tooltip for colors in "Recent" colors areaCaolán McNamara
cause the tip is the color name and that's not stored, so store the name when we have one, generate a #rrggbb if there isn't one and on loading the names, "repair" the names if the names didnt't exist because this option didn't exist when the colors were last saved Change-Id: I33d373081e8a5a46ac585bc55fe449dba0519f99
2016-08-30Resolves: tdf#97055 hyphenation claims its already active after closingCaolán McNamara
cancel button works, hyphen all works, but closing it via wm close skips the cancel callback. simplest thing seems to be to call SpellEnd when necessary, flagging that its not necessary by disabling the close button on the RET_OK case Change-Id: Ib0a67c4395e9d20941e735ebb14f6bd7f7ddb66c
2016-08-30Translate some German comments and messagesMaarten Bosmans
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577 Reviewed-on: https://gerrit.libreoffice.org/28493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (cui)Stephan Bergmann
Change-Id: I75013800fca4475ff2cb93a1f5c34cd37b93bc6e
2016-08-30convert RECT_POINT to scoped enumNoel Grandin
Change-Id: I3f0304d69d5d638230b64135c73497192dc00cb3
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29TypoStephan Bergmann
...(ever since c5bcf0e5e7a467b41c955a5f13affbccd23004eb "convert sw pos/size page to .ui"), leading to out-of-bounds reads, but which should be harmless, as all they could do is add bad StringIds inot aFrames, but the only use of those IDs in SvxSwFramePosString::GetString (svx/source/dialog/swframeposstrings.cxx) guards against bad IDs. Change-Id: I7a50230c12bcf8a197f787201442c503fe5974e7
2016-08-29loplugin:vclwidgetsStephan Bergmann
Change-Id: Icce2f463d9263de4c0e40b38600677dbe74d83b3
2016-08-29loplugin:unreffunStephan Bergmann
Change-Id: If65f8ef5accad8d6317b07938ec97c7b129763b5
2016-08-28loplugin:salboolJochen Nitschke
Change-Id: Icfc96f978a0fd73ceadbe3a4d57b9758e244ff2b Reviewed-on: https://gerrit.libreoffice.org/28436 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28loplugin:implicitboolconversionJochen Nitschke
Change-Id: I6fa51f65e75ca84f746ff5d1c7dcf97a5225d2d2 Reviewed-on: https://gerrit.libreoffice.org/28435 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28coverity#1242829 Uninitialized scalar fieldCaolán McNamara
Change-Id: Icd847c620610b23e28daa58145bf333b7a9a10a3
2016-08-28loplugin:defaultparamsJochen Nitschke
Change-Id: I9e6b81855e421186af92e53c71f5ba9bd8005319 Reviewed-on: https://gerrit.libreoffice.org/28433 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28screenshot: fixup some details for screenshot dlgArmin Le Grand
Edge-rounding and linewidth for selection/cursor, default filename for save dialog. Code cosmetics. Change-Id: I8a76d68f4f3070458ec4ba51a81bb046057218ab
2016-08-28screenshot: added functionality to dialogArmin Le Grand
Moved code to cui, added abstraction for AbstractDialog, adapted rendering, changed selection, added better selection visualization, added save ressources and dialog, creating pure screenshot with annotation display Change-Id: I533d9f559ee17cd46105b934bcf4beef87b96168
2016-08-26[GSoC] Remove popup confirmation dialog in fill style tabsRishabh Kumar
Enable users to apply custom values without adding it to the preset list Change-Id: Ida00c6eeb06e717a8aed30f4d230ab616c5b03dd Reviewed-on: https://gerrit.libreoffice.org/28333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-26convert SV_ITEM_ID_LBOX defines to scoped enumJochen Nitschke
and remove unused SV_ITEM_ID_EXTENDRLBOXSTRING Change-Id: Ic84d9341d0225b01b9ef46814483c66b1af307b5 Reviewed-on: https://gerrit.libreoffice.org/28397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25[GSoC]Remove Colors entry from Options dialogRishabh Kumar
Change-Id: I6865bd159659d2386bf32876f5c65ac533522fbc Reviewed-on: https://gerrit.libreoffice.org/28330 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-25convert SvxAnchorIds to scoped enumNoel Grandin
Change-Id: I4375fa07eb6ac81b21b904e965e4c2f9600ca99a
2016-08-25convert SvxDistributeHorizontal to scoped enumNoel Grandin
Change-Id: I7f3592ac8ef90686954624f37394a6e8f047ca44
2016-08-25convert SvxDistributeVertical to scoped enumNoel Grandin
Change-Id: I1797b9cd0164f8fcee2fb768a1db08ae17457534
2016-08-25convert SvxNumValCategory to scoped enumNoel Grandin
and fix bug in NumFormatListBox::GetDefValue in SW Change-Id: I459b7d5bd181235daa5d128315604f1ed1259ed4
2016-08-25convert FmSearchProgress::State to scoped enumNoel Grandin
Change-Id: I7ca1afedd6ca9b626c1e61322bffc66016ec7d58
generated by cgit (git 2.34.1) at 2024-06-29 00:38:51 +0000