summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2021-02-17loplugin:referencecasting in cuiNoel
Change-Id: Id73971bdd986101eeb53bf0b140ef6a7c72191a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-15tdf#119931 Fix accessibility warningshomeboy445
Change-Id: I897cc51f6c338e82896591d79b6e167f27189122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15use GetPopupParent for editeng transient dialogsCaolán McNamara
Change-Id: Ie799643b68ea41b4c4d0d0493755d09d3983d9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-14Move unit conversion code to o3tl, and unify on that in more placesMike Kaganski
This also allows to easily add more units, both of length and for other unit categories. The conversion for "Line" unit (312 twip) is questionable. Corresponding entries in aImplFactor in vcl/source/control/field.cxx were inconsistent (45/11 in; 10/13 pc; 156/10 pt). They were added without explanation in commit c85db626029fd8a5e0dfcb312937279df32339a0. I haven't found a spec of the unit (https://en.wikipedia.org/wiki/Line_(unit) is not specific). I used the definition based on "by pt", "by mm/100", "by char" (they all were consistent); "by pc" seems inverted; "by twip" was half as much. This accepted conversion makes unit test for tdf#79236 pass. Change-Id: Iae5a21d915fa8e934a1f47f8ba9f6df03b79a9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110839 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-13tdf#137779 Add info about Jumbo sheets status into About dialogdipanshu124
Since Jumbo sheets is an experimental feature, user enabling it might get problems. It will be good to specify Jumbo sheets status (if enabled) in the About Dialog. Change-Id: I1238d15ea8e32a418754b4323ba9771b63337301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110800 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-11add tooltip about merge paragraph to Borders tab in Paragraph dialogsSeth Chaiklin
Change-Id: Ic6d4c349698854e737075c7e0e855bccd688a435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110295 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-11fix spelling AppendBlanc->AppendBlankNoel Grandin
Change-Id: I6b5a6fcb1893a02751ff06bb3584c35065777513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10tdf#139667 modify tooltips that include "numbering style"Seth Chaiklin
This patch is part of a general effort to eliminate the use of the phrase "numbering style" in the UI. Most of the changes here are to use "numbering scheme" instead of "numbering style" And explicit mention of "character style" instead of "formatting" Change-Id: Ie3ca434133a1d04f074b68d16bd9394c1e05516a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110149 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08update pchesCaolán McNamara
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-08tdf#91920 sw page gutter margin, from top: add UIMiklos Vajna
- read from sw::DocumentSettingManager::mbGutterAtTop - improve the preview widget to take gutter position into account - also change it when the gutter position widget changes - write it back to sw::DocumentSettingManager::mbGutterAtTop on modification - always check if the dialog's input item set has SID_ATTR_CHAR_GRABBAG, otherwise do nothing to keep Calc/Impress unchanged Change-Id: I05ef864bf7ac18f4c6829d78312044560e6402d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110488 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-04tdf#91920 sw page gutter margin: add UIMiklos Vajna
Also update the preview widget and hide the new UI in Calc/Impress. Change-Id: Ic5c0ba100f6e886651d83c04961e9f0566a4202c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110414 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-04Fix ToD links pointing to extensions siteGabor Kelemen
so that they filter the dictionaries and templates Change-Id: I7807f5df2e468685f6862949d4ca20139f1be79f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110250 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-02change duplicated object idSeth Chaiklin
Change-Id: Ia5bf54a44e4318f0a70355897806aad1bed62f72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-01Change ToD links to httpsGabor Kelemen
and point the certicication one to the overview page with text Change-Id: I1cb2233d67511dc6ca3c8b787a47d88d410b2359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110249 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-01related redmine #3457 Fix ToD link to documentation portalGabor Kelemen
See https://redmine.documentfoundation.org/issues/3457 Change-Id: I066bfe4ed01a4a607c336d35eec51993fe4565eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-31add missing tooltip_text to contextSeth Chaiklin
Change-Id: I46fcad1dac38c15389f70d890df6bb0809aec901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110212 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-29tdf#75923 "Always Correct" to "Add to AutoCorrect" in Spelling dialogSeth Chaiklin
* improve choices for accelerator keys + add tooltip for "Add to AutoCorrect" + add missing extended tip for "Add to Dictionary" * change "Always correct to" to "Always AutoCorrect to" in Spelling context menu. + add tooltip for "Always AutoCorrect to" Change-Id: I54428fcd03ed7205a503935c77a7e08f9682bb1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109809 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-28add string_view variants of methods to O[U]StringBufferNoel
and update the stringview loplugin to detect cases where we can use these new methods. Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-27tdf#115884 PDF signing should mention it only works with x509 certificatesVishwas
Change-Id: Ide93b5153824362ff3e3d16bea51c69e0dea1eb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108805 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-01-26loplugin:passstuffbyrefNoel
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25avoid some ref-countingNoel Grandin
can just return a pointer here, instead of VclPtr. Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25Revert "tdf#138865 don't set ColumnToggleType::Check"László Németh
This reverts commit 4cabfc30bf2db873930cef4f7f1b0243ae2fde28 because the clean-up in commit 3d2a431da1126f4924f6cd7e5abac6488cd480e7 (tdf#139115 vcl tree list: add new toggle behaviors). Change-Id: Ieb57c035837e7740d105fa688fdf2b1bffcb88d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-22fix typos and reword UI descriptions for clarityStéphane Guillou
Change-Id: I105af83c1f490ab49e0ba061b08069787ebaa49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109776 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-21remove deprecated [x|y]align property for CheckBoxes and RadioButtonsCaolán McNamara
the gtk default is left aligned, change the vcl one to match and drop the deprecated and unnecessary [x|y]align Unfortunately on load glade's inline preview shows centered alignment, though its "true" preview tool shows left alignment and unsetting and resetting draw-indicator will update the preview to show the alignment which will be used: https://gitlab.gnome.org/GNOME/glade/-/issues/502 See https://gitlab.gnome.org/GNOME/glade/-/merge_requests/110 for my stab at making glade do the right thing. Change-Id: If454e9ce8462e6b271d2423fe7e8a55788e01fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20weld the dialog parent for best cleanupCaolán McNamara
Change-Id: I4e43a7e891077ab257419d57093383c07311bd5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19add --disable-librelogo to disable LibreLogo at build timeMichael Stahl
Annoyingly the packinfo_*.txt don't support conditionals but we can work-around that with a little duplication. Change-Id: Id00a6831effcc63a917fc21d2cd201474fdb559d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109569 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-19Resolves tdf#138051 - UI picker text blocks buttonsHeiko Tietze
All images have a height of 125px now Change-Id: I64bb9d51c7a5edb4f0cfd38ac48473f11755061d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109545 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-18tdf#139332 reduce height of expert config dialogCaolán McNamara
to about the height of help, options Change-Id: Icf2bebb2f2cc5aabea3e1f702d7095de8c31d726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-18Revert "Try to fix Windows TB"Julien Nabet
Try to apply Stephan's suggestion in https://gerrit.libreoffice.org/c/core/+/109464: "Instead of explicitly specifying the std::min template argument, it would be better to cast the '300L' to the appropriate type. (And do not change the std::max at all, which should be working fine?) That way, if the type of Height() should ever change to a type larger than tools::Long, the std::min call wouldn't silently truncate the first argument." This reverts commit 648edf96cde392545749923dc0c748e0bb31b5f6. Change-Id: I1e3cb70750d979468556ced7e7942abcb17fca98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109544 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-18tdf#139691: fixed wrong extend-tips in areatabpage.ui.Kiyotaka Nishibori
Change-Id: Ic99ef0a543098cd469db30474d1f8fcd466f2a2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109461 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-17Try to fix Windows TBJulien Nabet
by using std::max<tools::Long> and std::min<tools::Long> Change-Id: I07c93227cf040f159d1977ca94988169ecd6dc14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109464 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-17Resolves tdf#139501 - About screen exceptional widthHeiko Tietze
All strings wrap now Change-Id: If810e67e55eb23685ab4e14da9d5da1864229833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109330 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-16drop only remaining CheckBox yalignCaolán McNamara
Change-Id: If387c518090c81cb6bd3ba0d18cf612ebdc51792 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16remove unusual 0.5 align from "Asian layout mode"Caolán McNamara
its sibling doesn't have it and they should both be the same Change-Id: I4a0e4c3c04c7014537462221a40b0bef9c646f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16snap near 0.5 align values to 0.5Caolán McNamara
Change-Id: Idcedba97e1738f097a36845614a17f143c20c7c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16replace near-zero xalign values that should be zeroCaolán McNamara
Change-Id: I10c7d542064cffd44b1cd50972775db51f0f7e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109388 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16make the Color constructors explicitly specify transparencyNoel
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-16tdf#139533 re-word a tip of the daySeth Chaiklin
Change-Id: I897a5906eb2e2669a3924872695ee2a52bf189c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109342 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-15tdf#128176 Add a vertical scrollwindow to fontfeaturesdialogdiwanshu885
Change-Id: Id58b3888069fd0136f5620cb5f82c8649a0dfd76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107435 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-13tdf#92700 Add extended help tip about searching for combinationGabor Kelemen
by pressing the searched combo. Also add new tips for widgets that were missing one while at it. Change-Id: I6c4c1900557d231625061fd0555ce1f990e11aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108882 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-13fix indents to be consistentCaolán McNamara
git show -w is empty on this commit Change-Id: Ifc139cf4557ae9c2664057d2ed87e020330d17c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12transparency->alpha in tools::ColorNoel
this just changes the Get/Set methods, the constructor and internal representation of Color is not changed. Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12tdf#83618 Make line spacing values agree crash fixJim Raykowski
The intent of this patch is to fix the crash reported at https:// bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to cui/source/tabpages/paragraph.cxx in commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1 and changing the change made to svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the already available pointer to the current SfxViewFrame instead of calling the SfxViewFrame::Current function again. Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109152 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10add newline to end of .ui files that lack themCaolán McNamara
so all the .ui files are homogenous to simplify mass conversions Change-Id: I01336fd579025a8464f0d4d5c46dec3f65895b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-03 14:28:15 +0000