summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-11-01tdf#126128 Reduce page properties dialog's height.Gülşah Köse
Change-Id: Ie35c9cb4c9b134a94f3a125dd800936b7160950c Reviewed-on: https://gerrit.libreoffice.org/81910 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-10-31fix position page alignmentCaolán McNamara
Change-Id: I6f48661172c652b14c703f35edae3b8962f7ec09 Reviewed-on: https://gerrit.libreoffice.org/81771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31remove some stray random propertiesCaolán McNamara
Change-Id: I0f20e057b97bcb3ab120ae6b211729ea60937bd8 Reviewed-on: https://gerrit.libreoffice.org/81769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31fix label alignmentCaolán McNamara
Change-Id: Ic2fa0432d5bbba6f1e520e36cada4743dcd8e4af Reviewed-on: https://gerrit.libreoffice.org/81770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31tdf#84257: Consistent 'slide' naming in Impress UIMuhammet Kara
Change-Id: I6af0f6d79e145a4a0497cd72f960ee21d595b311 Reviewed-on: https://gerrit.libreoffice.org/81796 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-29tdf#127927 Character Dialog effect tab updateandreas kainz
Change-Id: I46ad6a54ae86ab010c1747808bdf77b1da243efa Reviewed-on: https://gerrit.libreoffice.org/81052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-29tdf#127994 stabilize tip of the day widthCaolán McNamara
Change-Id: I26bdb7bc3fc7ad2037438f4fceba51388e4121eb Reviewed-on: https://gerrit.libreoffice.org/81685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29use activate-link instead of clickedCaolán McNamara
so we can return true to consume the event and not continue to the default url dispatch handler Change-Id: I66400363a57d528a25d68a7f9314a8bc7d95876e Reviewed-on: https://gerrit.libreoffice.org/81555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29weld fpicker clusterCaolán McNamara
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-28Improve the way %PRODUCTVERSION is expanded in 'tipoftheday'Christophe JAILLET
Expand %PRODUCTVERSION in a much cleaner way. Follow up to commit 0ed7f9dab2ec03e168f2013e57c21637f7700736 Change-Id: If3d03cba19f89849c930d6dc3f1e07a65115e4e0 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/77862 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-26tdf#127927 Character dialog update position tabandreas kainz
Change-Id: I336f7457ad92d505755abe8dca8bbc1ca813ce4c Reviewed-on: https://gerrit.libreoffice.org/81040 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-25remove unnecessary .uis 'require' on lib=LibreOfficeCaolán McNamara
Change-Id: I3d953f63bb3c97105de31bcdad26b3cf0d1322e6 Reviewed-on: https://gerrit.libreoffice.org/81493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23tdf#127909 follow the NSSInitializer selectionJan-Marek Glogowski
NSSInitializer contains the copy of the algorithm used in the certificate path selection dialog, but with commit aceab9cbf104 ("tdf#127909 don't always select the first entry") these were desynced, as the first default profile should be selected not the last one. Change-Id: I07816c74eb1184df17e4d251f27ff0bee715e82d Reviewed-on: https://gerrit.libreoffice.org/81367 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23tdf#127909 save manually selected certificate pathJan-Marek Glogowski
Saves the value of the manual selection, independent from the real active certificate path, to restore the setting for the dialog. Change-Id: I5c423c594f38b1e2b25caa650b3ca2862cf49d82 Reviewed-on: https://gerrit.libreoffice.org/79979 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23tdf#127909 list all mozilla profilesJan-Marek Glogowski
If there isn't an already selected profile, it'll select the default one. Change-Id: I66e39dbe1c3ce4d9436857c716d93e603582e3d1 Reviewed-on: https://gerrit.libreoffice.org/79978 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23tdf#127909 don't always select the first entryJan-Marek Glogowski
Change-Id: Ic65667c748a62d989a4f38113155ba2715830629 Reviewed-on: https://gerrit.libreoffice.org/79977 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23tdf#127909 refactoring of the cert path dialogJan-Marek Glogowski
* Drop some unused memeber variables * Rename some member variables * Add a few const Change-Id: Iea3018f03ab855a357d27b93902323197077ea04 Reviewed-on: https://gerrit.libreoffice.org/79976 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-23tdf#127909 rename cert path dialogs' Add buttonJan-Marek Glogowski
This dialog just allows to manually override the NSS path. Currently it'll even lose this path, if the user select something else during a LO run, which is a usability nuisance. Change-Id: I75fadfbbd5006998a9f0e5cf70cb34566db701d8 Reviewed-on: https://gerrit.libreoffice.org/79975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22tdf#128239 Paragraph Dialog: Update Alignment tabandreas kainz
Change-Id: Ia2649902e4ad8c2990ffef5fd0c22df32484fcd7 Reviewed-on: https://gerrit.libreoffice.org/81113 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-22tdf#128239 Paragraph Dialog: Update Tabs tabandreas kainz
Change-Id: I6985c15df7a65bd38b66e50ddee2221bfdff5f01 Reviewed-on: https://gerrit.libreoffice.org/81099 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-22Avoid C++20 operator overloading ambiguityStephan Bergmann
...which is reported now by Clang 10 trunk with -std=c++2a: > cui/source/tabpages/tpline.cxx:481:80: error: use of overloaded operator '==' is ambiguous (with operand types 'const XLineEndItem' and 'XLineStartItem') > if( pItem && ( !pOld || !( *static_cast<const XLineEndItem*>(pOld) == *pItem ) ) ) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~ > include/svx/xlnstit.hxx:43:29: note: candidate function (with reversed parameter order) > virtual bool operator==(const SfxPoolItem& rItem) const override; > ^ > include/svx/xlnedit.hxx:43:29: note: candidate function > virtual bool operator==(const SfxPoolItem& rItem) const override; > ^ But the base SfxPoolItem::operator == is virtual anyway, so no need to cast pOld to a derived type. And once the expression is changed to !( *pOld == *pItem ) loplugin:simplifybool would kick in, but only with old compilers. So update loplugin:simplifybool to also kick in on that with latest Clang trunk with -std=c++2a, and simplify the expression accordingly. Change-Id: I3de9175b30d8645ed7a52f87cfac320144576cc8 Reviewed-on: https://gerrit.libreoffice.org/81203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-22loplugin:constantparamNoel Grandin
Change-Id: Ibfe70492683ff3ec208cee95d8a11155ec54f690 Reviewed-on: https://gerrit.libreoffice.org/81314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21tdf#127773 AutoCorrect Dialog Exceptions tab updateandreas kainz
Change-Id: I7ba9fde84a32d01f110f08f7d277079b2594e96d Reviewed-on: https://gerrit.libreoffice.org/81007 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-21loplugin:virtualdead unused param in CreateSvxFormatCellsDialogNoel Grandin
Change-Id: I8455c10d62ae8c3c3e6e543301f8c69a1189456a Reviewed-on: https://gerrit.libreoffice.org/81179 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21tdf#127773 AutoCorrect Dialog Localized Tabandreas kainz
Change-Id: I7a54bd963447e98b13760b52938b0f46df5a90c1 Reviewed-on: https://gerrit.libreoffice.org/81188 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-21tdf#127773 AutoCorrect Dialog Wordcomplete Tab sizegroup fixandreas kainz
Change-Id: Iae6958172a5f7943cc5032845a29d258c3ffd79f Reviewed-on: https://gerrit.libreoffice.org/81189 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-20Don't need an explicit width_request hereCaolán McNamara
I suspect the fix of autocorrect dialog width grows on change of new to replace commit f6a2b24ce17293043f7ddbed0bc218264be6487d Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Sep 30 14:18:29 2019 +0100 negates the need for the explicit arbitrary width_request added in tdf#127773 AutoCorrect Dialog AutoCorrect Tab update commit f5bdc014192f92d06ad278ac4ccbdb52c4958b6a Author: andreas kainz <kainz.a@gmail.com> Date: Wed Oct 2 23:54:46 2019 +0200 Change-Id: I538e98928e50874e5d3c382e454f68c2ac61f0b0 Reviewed-on: https://gerrit.libreoffice.org/81174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19Replace some uses of OUStringChar with string literalsStephan Bergmann
Change-Id: I763f9a3f57efcd47643ca4651e2454e95c6921c9 Reviewed-on: https://gerrit.libreoffice.org/81127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-19loplugin:unusedmethodsNoel Grandin
Change-Id: I95e63105654952d12c1dfd62f51593de114be569 Reviewed-on: https://gerrit.libreoffice.org/81077 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18Simplify MediaWindow::getMediaFiltersStephan Bergmann
Change-Id: I6c2ed432d2d5472ec984ea6e48aa3435c464067f Reviewed-on: https://gerrit.libreoffice.org/81053 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-18tdf#127773 AutoCorrect Dialog AutoCorrect Tab updateandreas kainz
Change-Id: I9d3cde19d77e09b483765e0b0cd248a6f4ec8e94 Reviewed-on: https://gerrit.libreoffice.org/80090 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-18tdf#127934 Make Cell Format Align Dialog HIG conformandreas kainz
Change-Id: I14986e50c31655737be42afbdf28078c7e6fb9ad Reviewed-on: https://gerrit.libreoffice.org/80572 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-18tdf#127773 AutoCorrect Dialog Word Completion Tab updateandreas kainz
Change-Id: I05d8563a0fb18a77c6d6b8bf37f8d9201775be5b Reviewed-on: https://gerrit.libreoffice.org/81006 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-18Line Style Tab Page alignment improvementandreas kainz
Change-Id: Ia546a6bc72f133af9bba704741ed47c1f30bb0f5 Reviewed-on: https://gerrit.libreoffice.org/79512 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-17rename LanguageBox back to SvxLanguageBoxCaolán McNamara
Change-Id: I9bd29b7377fdf0e1ba36cc021e7e78f83bb1c12c Reviewed-on: https://gerrit.libreoffice.org/80960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17rename TextEncodingBox back to SvxTextEncodingBoxCaolán McNamara
Change-Id: I466a56a3b3204f960b9c6ce2dac836879112f5ab Reviewed-on: https://gerrit.libreoffice.org/80945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17tdf#125508 remove border frame from shadows and presetsCaolán McNamara
Change-Id: I022f64188e49553bd7bef38cdd51620dfa0b90cd Reviewed-on: https://gerrit.libreoffice.org/80883 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-17Resolves tdf#127994 - Totd dialog get resized horizontallyHeiko Tietze
Width request set to 350 Change-Id: Ib974417282c76b4cede1b4773159b1fa748ddbfb Reviewed-on: https://gerrit.libreoffice.org/80887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15database options page too tallCaolán McNamara
Change-Id: I79ce30e2254980994e64764525efc307c1a79db1 Reviewed-on: https://gerrit.libreoffice.org/80852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15move HAVE_FEATURE_DESKTOP/OPENCL to their dedicated headersLuboš Luňák
HAVE_FEATURE_OPENCL is included by a common Calc header and HAVE_FEATURE_DESKTOP is included by a common Writer header, causing pretty much their full rebuilds if any feature changes. Change-Id: If29bf78bd4fd70b37981e0826a577777fd255c89 Reviewed-on: https://gerrit.libreoffice.org/80776 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-14SvxLanguageComboBox is unusedCaolán McNamara
Change-Id: I8f5fc0a80e84dc4aa79f7488591fb4904e5f5338 Reviewed-on: https://gerrit.libreoffice.org/80763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Resolves: tdf#128132 language page not openedCaolán McNamara
Change-Id: I1936840b89963ddc74fa8d7509855fb566e62404 Reviewed-on: https://gerrit.libreoffice.org/80761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-13move ToolBoxButtonSize into vclenumCaolán McNamara
Change-Id: I684d192296642bc507a6f75dd52a5ce72b028157 Reviewed-on: https://gerrit.libreoffice.org/80721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13rename FontPrevWindow back to SvxFontPrevWindowCaolán McNamara
Change-Id: Ife6f7bbc64f397e502d50c629769a8b637a591c8 Reviewed-on: https://gerrit.libreoffice.org/80718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-03-01 06:20:19 +0000