summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-04-03coverity#1403734 Mixing enum typesCaolán McNamara
Change-Id: I46a9a85e7f70502f703ee9fb0f94abd83952d120
2017-04-02Typo: TopToBotton -> TopToBottomTamás Zolnai
Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655 Reviewed-on: https://gerrit.libreoffice.org/36014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-02Hide useless label for adjacent cells on border tabpageTamás Zolnai
This adjacent cell settings is used only for Calc documents. Check box was hidden, but label was not. Change-Id: I6dcf3bb4ee316c9f3d653fc4f8f9dbcaf393e416 Reviewed-on: https://gerrit.libreoffice.org/36013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-31Related: tdf#106515 show OpenSymbol if unavailable StarSymbol requestedCaolán McNamara
Change-Id: I442df1c44839642bd1f91afedee577214032466b
2017-03-31const these upCaolán McNamara
Change-Id: If79187b8e2624da132ed47f5baf374211cc6e449
2017-03-31Resolves: tdf#106515 use OpenSymbol, not StarSymbol as the default bullet fontCaolán McNamara
For choosing a bullet from a real font it matters while otherwise its a synonym. Of course we have this code duplicated three times. Change-Id: I2428b9a23d997925de3e731b8afe9fb8cf18ed54
2017-03-31tdf#105922: Apply custom gradient/hatch even if not saved as presetKatarina Behrens
Change-Id: Ide35eb2c186d1ef5daaf96b1bd6d52448dfe69f9 Reviewed-on: https://gerrit.libreoffice.org/35961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-31use actual UNO enums in svxNoel Grandin
Change-Id: I00f53260667861ca2595892b5605479da3401adb Reviewed-on: https://gerrit.libreoffice.org/35913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30Related: tdf#106080 support a 'none' color in search by formatCaolán McNamara
so we can show the initial no-color selected state differently than the automatic color default color Change-Id: Ib3020e507b1555cb446c2b501f60b67222dc115c Reviewed-on: https://gerrit.libreoffice.org/35863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-29tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in cui/ Change-Id: I119ec4e5d87a4db300c5cf53ebdb13f297824940 Reviewed-on: https://gerrit.libreoffice.org/35821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-29Resolves: tdf#106080 fix explicitly setting automatic in search by formatCaolán McNamara
this is still somewhat broken in that what you see is not what you get if you don't explicitly set automatic, but clears the regression part of things in that the old broken behavior is restored instead of the new broken behavior Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a
2017-03-29expand these unhelpful macrosCaolán McNamara
Change-Id: I38b5948d4782f97f6de62057a42b414dd0db8512
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29convert EViewType to scoped enumNoel Grandin
Change-Id: I5b10aada64408897a56a5932aa28486d7562d617 Reviewed-on: https://gerrit.libreoffice.org/35822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29tdf#105281 Rearrange a few things for l10n-friendlinessAdolfo Jayme Barrientos
With the Notebookbar addition, no care was taken to update this UI bearing in mind that there *might* be a few languages suffering in consequence. Change-Id: I78c4a1846e192c4c7a64328b730517d42aff979f
2017-03-28tdf#42949: clean up includes in include/svx/[a-c]* with iwyuJorenz Paragas
Change-Id: I7768f4dbe9892c4264cb16eed87497894aa7494e Reviewed-on: https://gerrit.libreoffice.org/26582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-27Use hub link for git logSamuel Mehrbrodt
Change-Id: Ie8c6cafe9322466c7403bc3ebfd6cd3b73847bff Reviewed-on: https://gerrit.libreoffice.org/35655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I56e429ff1b8ee55ccb8df16002b509770762172c Reviewed-on: https://gerrit.libreoffice.org/35618 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23“Hyperlink” is NOT a dated word, it’s just a precise oneAdolfo Jayme Barrientos
We should always be clear and precise, given that LibreOffice handles various kinds of links. Nobody at L10n wanted this change, but they were ignored. This should fix tdf#103093, which was a consequence of the introduced ambiguity. This reverts commit a1297fc2df243d765ffb14f18bbdde158459b9f4. Change-Id: I29232c7a8384c3fa501c61aab26e061ebcb1a0d8
2017-03-22Use rtl::isAscii* instead of ctype.h is* with sal_Unicode argStephan Bergmann
Change-Id: Ifcc531df2b780e446dd4c2cccf74fa902ab4a259
2017-03-22loplugin:redundantcast find redundant c-style enum castsNoel Grandin
Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349 Reviewed-on: https://gerrit.libreoffice.org/35467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22create SfxDisableFlags enumNoel Grandin
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f Reviewed-on: https://gerrit.libreoffice.org/35514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18remove EE_RESSTR preprocessor abuseBjoern Michaelsen
Change-Id: I83b35c4e2d4275ac76a36bec03807be69a605c58 Reviewed-on: https://gerrit.libreoffice.org/35370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-17cleanup itempool includesJochen Nitschke
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10 Reviewed-on: https://gerrit.libreoffice.org/35313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16remove unused defines from HRC files in cuiNoel Grandin
Change-Id: I170dfc5970896365322dedf4fb797478653578a0 Reviewed-on: https://gerrit.libreoffice.org/35250 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16drop GetId() from SfxUndoActionNoel Grandin
mostly so that the subclasses can use proper enum types for their own IDs. It turns out that nothing at the svl/sfx2 level needs an ID anyhow. Change-Id: I3c020aeafb812fa30d896216d4e3bc1a82cbfeab Reviewed-on: https://gerrit.libreoffice.org/35222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15remove useless castsJochen Nitschke
Change-Id: I900b72372a56d341d18091b0d4721d31002d147f Reviewed-on: https://gerrit.libreoffice.org/35223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15replace creative empty string checkJochen Nitschke
Change-Id: I2e7c6fe0e3da4ab879486300a6e424b671322ad1 Reviewed-on: https://gerrit.libreoffice.org/35221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-15convert SvxFrameDirection to scoped enumNoel Grandin
Based on the casts in chart2/source/view/main/ChartView.cxx and the similarity of naming of values, I conclude that this enum was intended to abstract over css::text::WritingMode2. Added a comment to that effect. Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57 Reviewed-on: https://gerrit.libreoffice.org/35164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14use SvxLanguageBoxBase::SetLanguageList()Eike Rathke
... to benefit from whatever replacements and tweaks known. Change-Id: Ic19400bc4664fcdd5d7b8e5bf07c2dfacdb5e18f
2017-03-14remove unused RID constantsNoel Grandin
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14change SvxFrameDirectionItem base to SfxEnumItemJochen Nitschke
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091 Reviewed-on: https://gerrit.libreoffice.org/35160 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-11Fix typosAndrea Gelmini
Change-Id: Ic54e808956e5cf4e8079942c0ff799f802cd4b6c Reviewed-on: https://gerrit.libreoffice.org/35053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-10cid#1402150: Try to silence false positive reportStephan Bergmann
Change-Id: Ied2b1a8b0eb0aa9e7e48d1445677c8536f6388c8
2017-03-09Remove newlines at end of fileSamuel Mehrbrodt
Change-Id: I538bff61cbbd69c17f871698cf983b275dd68761 Reviewed-on: https://gerrit.libreoffice.org/35025 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-09convert SvxCellHorJustify to scoped enumNoel Grandin
Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33 Reviewed-on: https://gerrit.libreoffice.org/34968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxShadowLocation to scoped enumNoel Grandin
Change-Id: Ie51995579312328538263172cd3173641df89bca Reviewed-on: https://gerrit.libreoffice.org/34965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxCaseMap to scoped enumNoel Grandin
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd Reviewed-on: https://gerrit.libreoffice.org/34963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-08convert SvxAdjust to scoped enumNoel Grandin
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639 Reviewed-on: https://gerrit.libreoffice.org/34941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-07loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ica7a45456a979af62206f4fff0209f326e613aed
2017-03-06tdf#103847: Pass also XFillStyleItem to subtabsKatarina Behrens
this resolves the issue of non-preset gradient and hatch values not being shown. Bitmap is still broken (beyond repair) Change-Id: Ifad8f3a56b534e26def69c0b0bb2ed55de53bcda Reviewed-on: https://gerrit.libreoffice.org/34908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-06convert SdrTextAniKind to scoped enumNoel Grandin
Change-Id: Ie79aaf96a0d89c96c4ecd4ee8ccb0eabd3456bd0 Reviewed-on: https://gerrit.libreoffice.org/34916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert ScrollingMode to scoped enumNoel Grandin
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06make use of the SfxItemSet::GetItem<T> methodNoel Grandin
Change-Id: I8201429993129b019a6dd51c203a9f8dcbb2253e Reviewed-on: https://gerrit.libreoffice.org/34867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>