summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2021-06-18move the explanatory image outside the RadioButtonCaolán McNamara
Change-Id: I90425bec7418a26959241b670f63a5f4a4bb0fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117460 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18resave with latest gladeCaolán McNamara
Change-Id: I4c576eb1bdd8476f5bd4de4c5cd0be0af3817fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117459 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-17stray always-show-image properties in random checkboxesCaolán McNamara
Change-Id: Ida0132cba449fb098415b26e59ee31643518af0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-17remove 'relief' from CheckButtonsCaolán McNamara
Change-Id: I8a17c36489946327113e63f80b952525ae4201a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-17there is no such thing as a 'margin' propertyCaolán McNamara
added in: commit e97bccdba42b464e2df8d5996d4cdc9b03b6c243 Date: Wed Dec 9 00:44:10 2020 +0530 tdf#128176 Add a vertical scrollwindow to fontfeaturesdialog there is a deprecated 'border' property and various margin-start/margin-end/margin-top/margin-button properties Change-Id: I4528106a6cd51a9feede471cd8a47b81cf0df49a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117372 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-17use string_view in the Translate APINoel Grandin
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-16remove SpinButton input-purpose propertiesCaolán McNamara
Change-Id: I68629d4350c43c80fdd00f9fcb8af3733753fe43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117327 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16stray unwanted 'relief' property on random checkboxCaolán McNamara
Change-Id: Id942f88780d4f697df44433180343ca3c763ed67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117321 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16Resolves: tdf#142874 missing translation propertyCaolán McNamara
since... commit 15664117ef4db51bdcabb46b7990573509da0d73 Date: Thu Jul 25 21:40:48 2019 +0300 tdf#125923 Fix reset button. Change-Id: Ib589aa32221eaa33a13a17a00c2edb51866a5daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117315 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16resave with latest gladeCaolán McNamara
Change-Id: I1fac93fc43c80fb986e5b09b497c644be6852b52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117314 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16both children are at position 0Caolán McNamara
instead of one at 0 and the other at 1 Change-Id: I1943d2e68f39fb463d76237d6eb0bffe800a6b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16replace deprecated GtkButtonBoxCaolán McNamara
replace the ones outside action-area of dialogs Change-Id: Iec0edfc675057f994c188e12dbacbb0f2126dbd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-16resave with latest gladeCaolán McNamara
Change-Id: I53a401a096e171b0955303396eccda18e1b8002a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15move unique use of primary-icon-tooltip-text to tooltip-textCaolán McNamara
there are no "secondary" or "primary" icons for the tip to be relevant to. I imagine this should be for the whole widget. Change-Id: I3509000ae3d8a9ce3eca3549a76b0fe9222fb319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117265 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15call close button "close"Caolán McNamara
Change-Id: Iefa08a1c1887e3d5148d8925cefcd9451eea5d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15be consistent wrt help with 'secondary' packingCaolán McNamara
Change-Id: I442d29123f286795744e767c2d020532993643f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117195 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15resave with latest gladeCaolán McNamara
Change-Id: I0c62277013afd4e6ba8ac09776420a359a5ac399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxxChris Sherlock
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-14we don't put images into these checkboxes anymoreCaolán McNamara
Change-Id: I9bf0ba8dabdd6bbff2a88191f87452a213b39178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14remove unexplained caps_lock_warning/shadow_type ComboBox Entry propertiesCaolán McNamara
Change-Id: Id1b0ff8845c03d95651aece905459609edfa090b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14only one of the radiobuttons in a group should be activeCaolán McNamara
Change-Id: I0475bdd0633b54a644e205628577fac18a3af974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14if active is set group shouldn't be setCaolán McNamara
Change-Id: I26db5a96f176df7bd2ef6ef83c40150856845383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14group leader should be activeCaolán McNamara
Change-Id: I79cc2032c8641288ec6def4aaee32cb67e2da915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117140 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-14move comment to the line above the referenced lineCaolán McNamara
so pretty-printing doesn't afterwards change this file Change-Id: Id581d837013973045a0984484deea22a27db09a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117138 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-12Fix typosAndrea Gelmini
Change-Id: Ibd4f8ac232eddad2b8a6c970999f0adf61a07acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117077 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2021-06-11Add extended tips to bulletandposition.ui dialogOlivier Hallot
Change-Id: Ibb6c4013c587cc89b1438c264554d9e356467680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117060 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-10tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
In this case, avoid single, re-used local variable. It gets newly processed at locations used anyways. Change-Id: I89463736cbc28925adc304adb4624ab2740bdfbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116936 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-09tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
See task, slowly trying to reduce usages of that flag Change-Id: I50dc8e21e2f5e82e21bf335d63d07cee1ee18d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116913 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-08tdf#109388: Mouseover effect added to palettes in the Area tabBayram Çiçek
In 'Format > Page Style... > Area' Tab, Mouseover effect added to the palettes on Color, Gradient, Bitmap, Pattern and Hatch sections. Change-Id: Idf036adc01b6b2ef6d62d2dd670ed6fb432bfbf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116395 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-06-08Simplify Sequences initializations (cui)Julien Nabet
Change-Id: Iaf6a27f3a8dd156e91751a2fe242e8388f8d6b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116829 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08Addendum to: Remove SfxItemState::READONLYArmin Le Grand (Allotropia)
unfortunately forgot to remove some of the out-commented lines in f3b737ab76efaf1a70dfb22c6b60b08b340cf343, thanks to Julien for hinting me to that. So this is no semantic change at all, just syntax. Change-Id: If45b0cf1aeed870723914c2c02f6060d8f1bbfb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116838 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08editengine-columns: Create document model and dialog pageMike Kaganski
Change-Id: I056aad9474ca18134d1f1686a53618cc9ab3d525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08Remove SfxItemState::READONLYArmin Le Grand
As I experimented with redesigning the whole Item/ItemSet/ItemPool paradigm, I alredy checked that SfxItemState::READONLY is not used (and no one really knows what it should do or stands for). Since a removal of complexity is needed to get forward with that redesign and I already made some experiences in branch item_refactor2, I propose to remove this state. It is not really used (gets never set). It is mirrored/used in the UNO API in css::frame::status::ItemState as 'READ_ONLY', but also not used in the office's code. ItenmState itself is used in three places, but all set the Item involved by using a SfxVoidItem to state SfxItemState::DISABLED, which I described in ItemState.idl. This means that no state of READ_ONLY in UNO API is ever imported to office code as DISABLED state at all, so not used. I also marked it as deprecated in the *.idl file. I think - including the experimenting in the mentioned branch - that this is safe for now. I already run a full 'make check' on the changed stuff. Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-06enforce indicator consistencyCaolán McNamara
so there is either a standard indicator shown or one of a small subset of named icons a) adds an indicator to show the MenuButton provides a dropdown to the spelling dialog when there are multiple user dictionaries the word could be added to b) use open-menu-symbolic instead of gear icon for the sidebar menu Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic where sfx2/res/menu.png was previously usedCaolán McNamara
Change-Id: I5030afe7d370b49b24f6a590bf9ce6e2a7a428e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic for menubutton gear menusCaolán McNamara
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03no need to allocate these on the heapNoel Grandin
Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-02only one of the group should be activeCaolán McNamara
Change-Id: Ibbd8d5e3a1ca78c632997e1372eb0c88ff0cd954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02resave with latest gladeCaolán McNamara
Change-Id: Ia623b9bd51aad6772f3c109eb22e8388c5ca1cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02tdf#115282 Add KEY_QUOTELEFT entries to the Shortcut keys listGabor Kelemen
Change-Id: Id9667a8191c3ccaaad5b1a2f72f0a1f57721bec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116563 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-02tdf#116491: Customize: Add indication for experimental commandsMuhammet Kara
Change-Id: Id485f86598aa89cbce6d742c0207c178e5208ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116014 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-31GtkLabel:track-visited-links was removedCaolán McNamara
but we have some uses of it, which all look accidental Change-Id: Iccb12d904e8dc7410205735e49526b73bb81083e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need for always-show-image if there is just an image and no textCaolán McNamara
and reenable hyperlink dialog for gtk4 Change-Id: Id7e487dd64e102af80bb90279682a0636b887f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need to allocate SvxNumRule separately in SvxNumBulletItemNoel Grandin
Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no-zxing: Unused GenerateQRCode functionJan-Marek Glogowski
... and while at it fix (new?) [loplugin:stringviewparam]. Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-30Drop GtkSalPrinter bits from option dialogJan-Marek Glogowski
After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop never completed GtkSalPrinter"), there is still the experimental option left, depending on ENABLE_GTK3. We can't drop the whole PrinterCapType::ExternalDialog, because the osx code actually uses it. Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30tdf#136292: Fix crash on invalid JSON from the extensions APIMuhammet Kara
Change-Id: I91ed555f93173dee10e87025b231560693be50b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116390 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-05-28image-position set, but there are no images for this buttonCaolán McNamara
Change-Id: Ida66830d992d4b779994b745def0c380d02263da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-28 23:18:50 +0000