summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-08-15SvxNumberFormat::nAbsLSpace should have a larger typeStephan Bergmann
...as is seen when executing CppunitTest_sd_filters_test with Clang's new -fsanitize=implicit-conversion (see below). The next larger natural choice after short is sal_Int32, and some of the code calling GetAbsLSpace actually already supported the value to be as wide (but not wider than) sal_Int32; code calling GetAbsLSpace that expected the value to be no wider than short has either been adapted or at least been marked with a TODO. (Other choices could have been sal_Int64 or long.) Some dependent function's parameter types have also been changed accordingly. > Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-10.ppt: [...] > filter/source/msfilter/svdfppt.cxx:3792:33: runtime error: implicit conversion from type 'sal_uInt32' (aka 'unsigned int') of value 144780 (32-bit, unsigned) to type 'short' changed the value to 13708 (16-bit, signed) > #0 in PPTNumberFormatCreator::ImplGetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&) at filter/source/msfilter/svdfppt.cxx:3792:33 (instdir/program/libmsfilterlo.so +0x7992cc) > #1 in PPTNumberFormatCreator::GetNumberFormat(SdrPowerPointImport const&, SvxNumberFormat&, unsigned int, PPTParaLevel const&, PPTCharLevel const&, TSS_Type) at filter/source/msfilter/svdfppt.cxx:3674:5 (instdir/program/libmsfilterlo.so +0x797c6d) > #2 in PPTStyleSheet::PPTStyleSheet(DffRecordHeader const&, SvStream&, SdrPowerPointImport&, PPTTextParagraphStyleAtomInterpreter const&, PPTTextSpecInfo const&) at filter/source/msfilter/svdfppt.cxx:4395:13 (instdir/program/libmsfilterlo.so +0x7ac38d) > #3 in SdrPowerPointImport::SdrPowerPointImport(PowerPointImportParam&, rtl::OUString const&) at filter/source/msfilter/svdfppt.cxx:1618:59 (instdir/program/libmsfilterlo.so +0x74762f) > #4 in ImplSdPPTImport::ImplSdPPTImport(SdDrawDocument*, SotStorage&, SfxMedium&, PowerPointImportParam&) at sd/source/filter/ppt/pptin.cxx:175:7 (instdir/program/libsdfiltlo.so +0x5f2be8) > #5 in SdPPTImport::SdPPTImport(SdDrawDocument*, SvStream&, SotStorage&, SfxMedium&) at sd/source/filter/ppt/pptin.cxx:162:23 (instdir/program/libsdfiltlo.so +0x5ce2bb) > #6 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2760:47 (instdir/program/libsdfiltlo.so +0x617c79) > #7 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2878413) > #8 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e165bc) > #9 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8cb12) > #10 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771) > #11 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c) > #12 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9) > #13 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d) Change-Id: Ifa298a51bb62b7cbee9249b8289963f3427721f5 Reviewed-on: https://gerrit.libreoffice.org/59116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-15loplugin:useuniqueptr in IconChoiceDialogNoel Grandin
Change-Id: I3c39782cdbb332627e33ecb85c8d447a40ea0fea Reviewed-on: https://gerrit.libreoffice.org/59026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-14tdf#119231: Add missing help response idXisco Fauli
Change-Id: I2c89e44e5d78377666bacb2393b26323f1e0a904 Reviewed-on: https://gerrit.libreoffice.org/58919 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-12Fix typosAndrea Gelmini
Change-Id: I673b9121968ff79e6313e4019bc02a3364b4737f Reviewed-on: https://gerrit.libreoffice.org/58901 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2018-08-10Translate German variable namesJohnny_M
This is a follow-up to commit 48806ad275b0c4c8fa3eb1637684092266ec6a0d for the rest of the variables in the same files. Change-Id: I2d95f73be4cf3d91315ed4f7fac80484a7cb29b0 Reviewed-on: https://gerrit.libreoffice.org/58698 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-10tdf#113853 fix keeping visible selected items jumping by tabU-Vladimir\Vadim
Calc range of window, check if item is inside that range, calc scroll offset Change-Id: I5ce7c95b167fe18e20f81bb4656093c15309d1c7 Reviewed-on: https://gerrit.libreoffice.org/58633 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-08-10unnecessary null check before dynamic_cast, in variousNoel Grandin
Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b Reviewed-on: https://gerrit.libreoffice.org/58774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09remove Calc's software interpreterLuboš Luňák
- it's in practice never used nowadays, group threading has higher priority in the code and since SwInterpreter's allowed opcodes are a subset of group threading's, there should be no formula where control flow gets as far as using SwInterpreter - the only opcodes SwInterpreter allows are ocAdd, ocSub, ocMul, ocDiv, ocSum and ocProduct, which is a rather limited set and group threading should handle all that as well - if SwInterpreter performs anything better than group threading, there shouldn't be a problem doing the same for group threading - it's yet another code path that should be handled, tested, etc. and the added complexity is not worth it - it shares some code with OpenCL handling, which is both added hassle in case OpenCL code needs changes, and it also causes confusion such as people thinking SwInterpreter has something to do with OpenCL Change-Id: I99052862b60b6266c70dd436d1d7938177dc6bd9 Reviewed-on: https://gerrit.libreoffice.org/58643 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-08-08Resolves: tdf#118281 control positions always in cmCaolán McNamara
Change-Id: I7803f673e835bd4575616d4e4b465ca144e282c8 Reviewed-on: https://gerrit.libreoffice.org/58720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-08tdf#118731 delay on showing dialogs that create SdrModelsCaolán McNamara
for their preview widgets. since... commit 4be44a7a6f2f480e55255d7cdd119f3d6577d085 Date: Thu May 24 19:09:44 2018 +0200 SOSAW080: Cleanup of SdrModel Change-Id: I102b64bdacc56a41091bbe60e932c2915f20323f Reviewed-on: https://gerrit.libreoffice.org/58693 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-07Translate German variable namesJohnny_M
This is not a literal translation. Rather, it follows the notions used in the UI, as introduced in commit 79283929ac9b8e56516b70c8381e0c31f1c68645 - see https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=cui/source/tabpages/labdlg.cxx;h=41bc3d72ea50e94d31aab369ea5dcdedbb00ddac;hb=79283929ac9b8e56516b70c8381e0c31f1c68645#l86 . This seem to be the legacy callouts described in https://help.libreoffice.org/Common/Callout . Further similar translations in the same files will be done separately later. Change-Id: Iac5f1e34f28f12cd24001c488d35ae3ba3996aea Reviewed-on: https://gerrit.libreoffice.org/58584 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-05cppcheck: knownConditionTrueFalseJochen Nitschke
Change-Id: I7aa3e47db67072c06f4de4c219710325cfdb748e Reviewed-on: https://gerrit.libreoffice.org/58613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-02loplugin:returnconstant in cui,desktopNoel Grandin
Change-Id: Ieec9e3d9e2e18add9a1bc7e0e15bb8435ea51954 Reviewed-on: https://gerrit.libreoffice.org/58428 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-01add operator+=(OUStringBuffer) method to OUStringNoel Grandin
to reduce needless object creation and copying some more And fix what looks like a bug in CSS hex color parsing at line 609 in sw/../parcss1.cxx that has been there since commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import" Change-Id: Ibad42b23721a56493bd1edcd7165e6104494a5c3 Reviewed-on: https://gerrit.libreoffice.org/58357 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31Font features: Use Graphite instead of HarfBuzz if availableTomaž Vajngerl
When searching for font features, use Graphtie if it is available instead of HarfBuzz, because HarfBuzz will only give a subset of OpenType features in a Graphite font, but will ignore additional features specific to Graphite. Change-Id: I00c8790ee4d1e1ab906928f649d2a3e54163557f Reviewed-on: https://gerrit.libreoffice.org/58306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31tdf#118976 Make area pattern tab page display pattern previewJim Raykowski
Change-Id: If30b83ec93897b85784d66c699ece377f47f68d4 Reviewed-on: https://gerrit.libreoffice.org/58265 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31tdf#117892 Blue Area/Background Bitmap tabpage Preview fixJim Raykowski
Change-Id: Iaef3651407d1df85b1cb221821d47c33e111016e Reviewed-on: https://gerrit.libreoffice.org/58206 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-31loplugin:returnconstant in svxNoel Grandin
Change-Id: I0cc0c32afa0d735738c6744873f3518a2763821e Reviewed-on: https://gerrit.libreoffice.org/58334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29Merge identical switch cases in SvxCaptionTabPageMuhammet Kara
Change-Id: I515c64191d7a9defc3e175c18d8be1f198e03160 Reviewed-on: https://gerrit.libreoffice.org/58267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29Merge identical switch cases in SvxTransparenceTabPageMuhammet Kara
Change-Id: I463a947de16fee3b361a429c7dc3ef69bd507617 Reviewed-on: https://gerrit.libreoffice.org/58268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28loplugin:stringloop cui,dbaccessNoel Grandin
Change-Id: I32b63d2435d36b869823ea022ebd7f8347a46ea0 Reviewed-on: https://gerrit.libreoffice.org/58211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28Remove unnecessary theUICommandDescription.hpp includesMuhammet Kara
from the Customize dialog Change-Id: Ie7e87872b2427d0dda3de5a8333129cba492b26e Reviewed-on: https://gerrit.libreoffice.org/58189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Merge identical conditional branches in ViewLayoutUserHdlMuhammet Kara
Change-Id: I7e4d92dd12b00fa4d60cd667af780201b3246312 Reviewed-on: https://gerrit.libreoffice.org/58200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-26It doesn't make sense to have document links in the online version.George Wood
Change-Id: I893845570e4bd2961797fa1c2dd3e5316c9d262d Reviewed-on: https://gerrit.libreoffice.org/58008 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-25tdf#118777 cui: use right XText in SignatureLineDialogMichael Stahl
Writer has multiple nested XText and we have to call insertTextContent on the one that corresponds to the xCursor, so use the convenient getText() instead of hard-coding the body text. Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36 Reviewed-on: https://gerrit.libreoffice.org/57969 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-23Fix typosAndrea Gelmini
Change-Id: I4bb060a6a65ca27bba8d16c268660bedef8b0ed5 Reviewed-on: https://gerrit.libreoffice.org/57821 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Set can_focus true for Area tab page Bitmap listboxJim Raykowski
can_focus property needs to be true for tab navigation to stop here Change-Id: If9ed0cefc652369243d623a311ba92e2941bd43f Reviewed-on: https://gerrit.libreoffice.org/57834 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-22coverity#703935 Unchecked return valueCaolán McNamara
Change-Id: I31ce141955a3beadb60368fc8238bfe0507b1566 Reviewed-on: https://gerrit.libreoffice.org/57782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-22Fix typosAndrea Gelmini
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-19tdf#118304 reselect current glyph on changing fontCaolán McNamara
preview glyph will rerender the glyph if its there, or the glyph description changes to "missing glyph" if its not there anymore. Don't auto select first entry of the subset when font changes, leave it as unselected and let the glyph determine what's ends up there Change-Id: I33d7dd3a071100175ac9bc7c7e9d44684a1aff28 Reviewed-on: https://gerrit.libreoffice.org/57724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19tdf#117038 set button width to max possible content widthCaolán McNamara
Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba Reviewed-on: https://gerrit.libreoffice.org/57717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19tdf#118816 recover initial intent of enabled possibility of tristate as a flagCaolán McNamara
Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6 Reviewed-on: https://gerrit.libreoffice.org/57712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-19Resolves: tdf#118115 add missing help response idCaolán McNamara
Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c Reviewed-on: https://gerrit.libreoffice.org/57715 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tdf#104277 - Added restart buttons to OpenCL restart dialogNickson Thanda
Change-Id: Icf31d0516deb7844c8be1003219cbacae1cdc5ec Reviewed-on: https://gerrit.libreoffice.org/57537 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-17Related: tdf#118681 use a case insensitive compare for hex digitsCaolán McNamara
Change-Id: I7b177d2772a86cada37c20056794bc1d8ab50991 Reviewed-on: https://gerrit.libreoffice.org/57563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17loplugin:useuniqueptr in SvxAsianLayoutPage_ImplNoel Grandin
Change-Id: I6380ccceabb9ce9c3c7c187e913e7384d8854b5b Reviewed-on: https://gerrit.libreoffice.org/57516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16tdf#118681 make sure we're using the right font char mapCaolán McNamara
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16tdf#118549 crash on dialog teardownCaolán McNamara
only an issue for the current partially complete interim case Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20 Reviewed-on: https://gerrit.libreoffice.org/57501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12SvTreeListBox::DoubleClickHdl: DbRegistrationOptionsPage more, tdf#115950 rel.Eike Rathke
Change-Id: I820ce28a4df108f17cbb65210834acae6b0f8946
2018-07-11font feat: prioritize Graphite descriptions, use UI lang., fixesTomaž Vajngerl
When collecting font feature description do prioritize Graphite collected descriptions over OT. This is important for descriptions for ssxx and cvxx only contain general description and not what exactly they do. When collecting for Graphite use the UI language for descriptions. Fix gathering the descriptions with graphite to include all of the descriptions available. Change-Id: I6b3b92eb160fc3fd70214edf0d37095865f9c563 Reviewed-on: https://gerrit.libreoffice.org/57250 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08loplugin:passstuffbyrefNoel Grandin
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed-on: https://gerrit.libreoffice.org/57088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt
Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06tdf#117903 Add signature line feature to calcSamuel Mehrbrodt
Change-Id: I4e9121803a26cba1f40f8f1c673c7809543ef2ec Reviewed-on: https://gerrit.libreoffice.org/57015 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29Clean up SvxChartColorTableStephan Bergmann
* nNextElementNumber is unused since d57dfa29c2ba47293eb12a853cdccf4196565ef7 "Improvement of adding and removing color charts". * There appears to be no compelling reason to store sDefaultNamePre-/Postfix as members (but which are not even copied by the copy ctor). Just compute them whenever they are needed in getDefaultName (which is understood to not be a hot code path). * With those changes, the user-provided default and copy ctor can be left implicitly-declared, which avoids -Wdeprecated-copy (because the copy assignment op was implicitly-declared while the copy ctor was not) with GCC trunk towards GCC 9. Change-Id: I2bfa5f19c967e24407bf5b79adaf171200822f45 Reviewed-on: https://gerrit.libreoffice.org/56666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#117866 cui personalization: fix a possible raceMiklos Vajna
The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. Change-Id: I494c123a6225da60407391771622208c055ae49b Reviewed-on: https://gerrit.libreoffice.org/56585 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-28 11:16:30 +0000