summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-09-28fix disable qrcodegen optionCaolán McNamara
Change-Id: Ic554f01125653022987c70d03c8c9d86fe3f547a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103204 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-23add an explicit --disable-qrcodegen configure optionCaolán McNamara
Change-Id: If8e965fa955aecdb9e7011bdddc690de9cad0c4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103158 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16rhbz#1878275 should use value_changed for spinbutton changesCaolán McNamara
Change-Id: I8d042eb9c288e9db69a49cb9e097b23cf765aae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102678 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-10Always display highlighted JRE's locationStephan Bergmann
...when opening the Advanced options page and after adding a new JRE via the "Add..." button, not only after highlighting another JRE line. (I suspect this broke with 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03 "weld SvxJavaOptionsPage" towards LO 6.4.) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit f7fe1e93da753d74485a13d46fe15fb198411932) Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102286 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-05Resolves: tdf#136189 don't try and sort until treeview is filledCaolán McNamara
Change-Id: Ic5ac71d88bab7627e14220912f4b9c935f2f1f26 and... Related: tdf#136189 don't assert on unsetting non-existing previous sort column Change-Id: If2330cc83ace9ec0133b99eec8c2f0be3919013e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit c52ac477beefc46802148033adbca9edb9970ac1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101967 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26tdf#127802 support tristate for hidden/unhidden textCaolán McNamara
Change-Id: I9a8ad72ae3ee45ac2521e662b17d3d22d98aa055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#133958 only move the selection to the error if its not already thereCaolán McNamara
Change-Id: I3046c842cc6c8bcc867c79989a8978d382b08269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99607 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-07-13tdf#133600 Only one button selected by default in QR code dialogGabor Kelemen
Change-Id: I10a5f04492cf23caeb89cb119f91c578e5d57413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95540 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98245 (cherry picked from commit 654f5316015a38b5c720a93305d21f63aa9697eb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98460
2020-06-30tdf#132822 close open undo group before clearing undo stackCaolán McNamara
when changing paragraph. previous para undo info needs to be discarded, but that cannot be done properly if there is an open undo group. So pass the optional undo group guard down to GetNextSentence_Impl which can close it before it needs to set the new paragraph. Change-Id: I595c3598b15b6b1fdace045c3879617ecfea3faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96398 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11Resolves: tdf#133862 crash in customize toolbar in embedded mathCaolán McNamara
Change-Id: I2fc7f3620145e48516c3ca73c0a5d08dce11d78a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-09Resolves: tdf#125981 use original label, not current labelCaolán McNamara
Change-Id: Iddc1d3e38e70d91d60947d9867dcfb03cb5128d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95678 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-06-08crash on double-clicking an entry in Available language modulesCaolán McNamara
tools, options, language settings, writing aids, entry in Available language modules Change-Id: I0146a313cfae206bc9399c964a746dd00cba0fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95564 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-05-19tdf#133036 notebookbar customize uses a special combobox idCaolán McNamara
in all other cases the m_xSaveInListBox id contains a SaveInData pointer but not the notebookbar case for some reason, we're already checking for this special id in one case, extend to check in the other too Change-Id: I460afa165ee2f6baa6deb1a15b0257df274a4c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94269 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-03Resolves: tdf#129702 take text from correct model columnCaolán McNamara
Change-Id: If9af51348e5a254a0c5ab621fa162cdda4565e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93138 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-29tdf#131733 Show only CN part of X.509 subject infocp-6.4-branch-pointGabor Kelemen
The problem was that the whole Subject info was returned from X.509 certs if they did not start with one of "CN", "OU", "O", "E" Instead of extending this list with random keys, pass the type of cert and only return the whole Subject info if it's an OpenGPG one, and process the info unconditionally if it's X.509 like before the OpenGPG integration Change-Id: I1aa5d7285e48b0f4a769a073cdfb7732e482792c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92675 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit bedba76adb9b1421a7d939cfef44b8194e987888) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93129
2020-04-29Resolves: tdf#132288 don't merge adjacent properties for spell checkingCaolán McNamara
spell checking relies on each attribute chunk being unmerged with identical adjacent chunks squash includes... nStartPosition and nEndPosition are always the same and tdf#132288 preservation of footnote depends on reverse iteration like TextCharAttribList::FindAttrib does which spell checking used before commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog converted to use an EditEngine instead of a TextEngine in order to be able to host it in a native widget Change-Id: Ia835fa054cad0dee4304f16724b9eb0c29b46102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-03Fix crash with Tools > Customize... in Master DocumentMaxim Monastirsky
Need to compare by full module id here, as otherwise Master Document is detected as Writer, causing crash as the notebookbar tab isn't prepared to handle the Master Document variant. Change-Id: I872255c42517b4223fb31e2074e4d5d083c76e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88344 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 0ad3558a0c84e97306dfd6d235680ed6e053711b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89775 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-17Resolves: tdf#130123 let the expert config columns be resizableCaolán McNamara
Change-Id: I08572bfe92c99d6e2e6b8ea27856817a6dddf1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88795 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-15Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara
Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88688 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Resolves: tdf#130486 setting distributed results that justified cannot be setCaolán McNamara
Change-Id: If80c935b7e33b5c7146eb562daf2303688160653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88274 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11Resolves: tdf#130548 click is sent to the other member of the groupCaolán McNamara
when toggling one the other gets a click signal, but its too early and the page size isn't set yet, making the dialog thing the margins won't fit in the page Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88386 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-07Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88048 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07fix "Use data for document properties" checkbuttonCaolán McNamara
regression since... commit 3a15c034be9f557f350d0ba1f3a842151066eaae Date: Tue Mar 12 09:59:35 2019 +0000 weld SvxGeneralTabPage Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88109 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-05Related: tdf#130143 freeze/thaw around bulk insertCaolán McNamara
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87864 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04Revert "Add ODF 1.3 strings to Save options page"Michael Stahl
This reverts commit ef39938dea14666a5835b6ae85091c1010f8ae8d. Reason for revert: Nasty side effects if the user actually selects the new values because the dialog code isn't adapted, see https://gerrit.libreoffice.org/c/core/+/87900 Change-Id: Ie220974dcf58b23401b21e5fa43e7d2f5d7978ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87901 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-02-04Resolves: tdf#130364 let font treeview fit to available dialog spaceCaolán McNamara
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 49d8e5fb744534f4af7e5c7f08dee7a95bcc6ed5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-03Resolves: tdf#130061 numbering dialog adjustments missingCaolán McNamara
since... commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5 Date: Sun Oct 20 00:44:05 2019 +0200 tdf#128257 Bullet Dialog update so spinbuttons were disabled Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87879 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-29Resolves: tdf#130164 background/border dialog should be modalCaolán McNamara
Change-Id: I763cc054b23d4f72e1dec175861f3062d6bda6fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87346 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27Resolves: tdf#130143 crash in sorted font replacement tableCaolán McNamara
it was always sorted historically, just without showing the sort indicator. Fix that inconsistency which led to the error causing the crash, and use iterators when appending to the sorted list instead of indexes which is the crashing part. Change-Id: I4ea3028a334129bdeb8e1a1aa79f4ead8a0243e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87344 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-18gallery theme dialog should be modalCaolán McNamara
Change-Id: I3c32851cda40254c73b0040f92466eedb7427d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87028 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-12Resolves: tdf#129904 use the current page as the page for helpCaolán McNamara
in the options dialog which has a non-standard organization for its contents vs an ordinary dialog Change-Id: I6a50652f5ae3fe2e8b4d32933bec6dc0217cbec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86577 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-11Resolves: tdf#127417 delete-all tabs doesn't workCaolán McNamara
since... commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Date: Thu Apr 18 19:25:06 2019 +0200 WIP: Further preparations for deeper Item changes because since then aNewTabs is cloned, but on delete-all aNewTabs is reset to a SvxTabStopItem with a 0 WhichId so its clones are useless Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86579 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08Resolves tdf#129622 - Layout problem in Options-LibreOffice-ViewHeiko Tietze
horizontal fill set for the questionable controls Change-Id: Iab194709ec3ad4881ace36a605ebb4a0d37fe8a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit beed7183ac6323eb052e7c586d6a807fcb32eb1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86427
2020-01-08Fix SfxPoolItem use-after-freeStephan Bergmann
...as observed with -fsanitize=address in Draw, after drawing some rectangle (so that there is at least one marked object) doing "Format - Area... - Area - Bitmap": > ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8 > READ of size 4 at 0x6030004aca50 thread T0 > #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42 > #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124 > #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 > #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42 [...] > 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21 > #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13 > #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42 > #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9 > #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec "tdf#104615: there's no mpView when opening odc directly". Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4d59436258702251a881a007ccc52ffd5a3eeb38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86423 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08Bump copyright year to 2020Adolfo Jayme Barrientos
Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a526e85a0d6371781482a9b7de4e05b8b2578de2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86093 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-01-07halign 'Start'->'start'Caolán McNamara
Change-Id: Ia8547ffd08cc60ec8e6f791fcccaab35784de9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86333 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-02missing previews in line comboboxesCaolán McNamara
since... commit 6cdc0dbfadfcbfa4f53a3c21a494ab225ba5d955 Date: Tue Nov 5 01:53:23 2019 +0100 linetab dialog page update and similar Change-Id: Iafb2933434d76472bab7297962e0803a6568e61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86077 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-17Fix macro security UI usability problemsJan-Marek Glogowski
* Don't hide the option dialogs "Macro security" push button. I don't see any reason, why these settings should be hidden, if macros are disabled or settings locked. At least a user can now check, what is going on (still nothing shows disabled macros for a document in the UI AFAIK). * Don't scale the lock icons of the trusted list boxes. This just uses the same alignments, which the macro security level lock image uses, otherwise the image is scaled to fit the whole space of its layout cell. * Don't disable the trusted list boxes. If the setting is locked, it's sufficient to disable all the buttons, which allow modification (so View can stay enabled). This way you can still scroll the list. Correct button handling is already implemented and works for me. * Catch exceptions of broken certificate data. If your config contains certificates, which can't be correctly decoded, the NSS backend will throw an exception, which kills the dialog, but not the nested loop, resulting in a locked LO. Also show an error dialog with the broken base64-encoded data. Change-Id: I79002e0ce85cf9a9017caf858407f2f635a3a074 Reviewed-on: https://gerrit.libreoffice.org/85056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b3348ce498b3d54b3e5e6518954ad9d5e917b8f2) Reviewed-on: https://gerrit.libreoffice.org/85282
2019-12-17ui: show wait mouse pointer on operations in Expert ConfigurationVasily Melenchuk
Expert Configuration is loading, resetting and searching values very slowly, so will be great to indicate busy status to user. Change-Id: Ic0d428d01a9f71ff899979162e1b307cd7cd7401 Reviewed-on: https://gerrit.libreoffice.org/85242 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 99783d0edc2405f351322dfa2479c7fb36527878) Reviewed-on: https://gerrit.libreoffice.org/85272
2019-12-16tdf#127294 replace one section tip of the day with 4 new section tipsSeth Chaiklin
Also adjusted wording on another section tip. Change-Id: I8e24656f2cbf86a5da3bc2b8e204b2bc8d29b33c Reviewed-on: https://gerrit.libreoffice.org/84965 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6c844f9bbc76f615d9a49526670538f045d82e0b) Reviewed-on: https://gerrit.libreoffice.org/85216 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-14size group is ignoring hidden widgets, leading to labels overlapping entriesCaolán McNamara
https://developer.gnome.org/gtk3/stable/GtkSizeGroup.html#gtk-size-group-set-ignore-hidden "Measuring the size of hidden widgets ... they will report a size of 0 nowadays, and thus, their size will not affect the other size group members" Which is unfortunate. So before we hide any labels, take the size group width and set it as explicit preferred size. Change-Id: If7c0f1ebd9f03914c74fde85b876549de76853c2 Reviewed-on: https://gerrit.libreoffice.org/85098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12tdf#127294 one new tip of the day; clarification of three existing tipsSeth Chaiklin
1. It seems that inserting images in shapes only works in Writer, so added correction to make this tip Writer-specific. 2. Added a tip about how to insert images and photos to shapes in Draw and Impress. 3. Small wording adjustment in two other tips Change-Id: Ife6d7164af294803ca0ec50487b1e2d7b6a9d75a Reviewed-on: https://gerrit.libreoffice.org/84830 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit d115fabdc6927bfcc48e7e7be5bad546c66b11ad) Reviewed-on: https://gerrit.libreoffice.org/84958 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-11tdf#129300 If it would create no change, don't force itCaolán McNamara
otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-10tdf#127294 five new tips Seth Chaiklin
including one from comment #20 and one from comment #34 Change-Id: I7d3ded6d986a548d7a9c88f0036e734b4b5ccb87 Reviewed-on: https://gerrit.libreoffice.org/84604 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 55204db25234e22ea00d9bef2fc1a062e942e84d) Reviewed-on: https://gerrit.libreoffice.org/84804
2019-12-09Resolves: tdf#129243 check return to see if results validCaolán McNamara
Change-Id: Ia4169cda3c1a596ceedd074dd0e59898f9c72ff9 Reviewed-on: https://gerrit.libreoffice.org/84696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-07tdf#127305 display selected text in URL field QR Code Dialogshubham goyal
Change-Id: Ic0d36225cc2c509c706a4599d45b92c6b9fea40e Reviewed-on: https://gerrit.libreoffice.org/78879 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 704a558b8689beb1a83a3e2d21481e0ea118e134) Reviewed-on: https://gerrit.libreoffice.org/84613 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-07Resolves: tdf#128923 should be able to change attributes of multiple lines...Caolán McNamara
without changing color Change-Id: I76cf21af4611afc11bf1861abe7d0b903362e798 Reviewed-on: https://gerrit.libreoffice.org/84638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-07tdf#121658 Add option to not hyphenate words in CAPSSamuel Mehrbrodt
* Add checkbox to pagraph dialog * Store property in paragraph model * Move docx import/export from grabbag to paragraph model * Add ODF import/export * Add ODF unit test * Add layout test Change-Id: Id4e7c5a0ad145c042f862995d227c31ae2aa0abd Reviewed-on: https://gerrit.libreoffice.org/83979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69) Reviewed-on: https://gerrit.libreoffice.org/84620
2019-12-06tdf#128712 clarification and addition of Draw tipsSeth Chaiklin
Split one tip into two different tips. Added two more Draw tips Change-Id: Idbb9b5ba0c136a8cb110eb8b7ed8f8d2855c9221 Reviewed-on: https://gerrit.libreoffice.org/84161 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6e70a98b15c97ad2a3714aae5a5bfa22d307f236) Reviewed-on: https://gerrit.libreoffice.org/84594 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>