summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-14[GSoC] Avoid reload of preset list in hatch tabRishabh Kumar
Change-Id: If2acb6df3c046de63b6b4069474e19fb87222a11 Reviewed-on: https://gerrit.libreoffice.org/27167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-13Remove wrong, needless downcastStephan Bergmann
...from SaveInData (which has a virtual dtor) to MenuSaveInData, while the data could also be ContextMenuSaveInData (not derived from MenuSavaInData). Change-Id: I4928fa97ed7738516699f8e57f354ef0f334c4f1
2016-07-13make sure that the thread has joined before disposing UI elementsMarkus Mohrhard
See e.g. http://crashreport.libreoffice.org/stats/crash_details/80884848-16e7-4512-be4a-74c53bfce34b#allthreads The thread can run while the UI elements have already been disposed. The StopExecute call is not enough to prevent that from happening. Change-Id: Iab4209776e1403a6520c106f3521476ee50848a4 Reviewed-on: https://gerrit.libreoffice.org/27087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-13no need to create temporary OUString for comparisonNoel Grandin
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2 Reviewed-on: https://gerrit.libreoffice.org/27171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11removed deprecated FileDialogHelper::SetDisplayDirectoryNoel Grandin
and convert usage of it Change-Id: I2e3a71ec94492e5482bdf720d256e67adaf3f095 Reviewed-on: https://gerrit.libreoffice.org/26951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11rename variable to reflect that it is not a referenceMarkus Mohrhard
Change-Id: Ifcc15e2a500bdc77dd21e96eea3873c3e78e7e55 Reviewed-on: https://gerrit.libreoffice.org/27086 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-10Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-10ditch the font/screen-scaling thingCaolán McNamara
its of limited utility wrt the vcl layout work and optimal size widgets, and its confuses people looking for hidpi settings Change-Id: I37d21b480446f9fe2845b3a2d9fd59cdeddf1a93
2016-07-08SvxGetOrCreatePosDic parameter is unusedStephan Bergmann
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-08loplugin:redundantcast: redundant static_casts in cuiStephan Bergmann
Change-Id: I97385a4fade4794f5aebd0b65eaf4c92ed06bd66
2016-07-08Use PageNumberListBox in cuiSusobhan Ghosh
Change-Id: Id7e71ade1946b5f33701a71073f1cc5a7870af6a Reviewed-on: https://gerrit.libreoffice.org/26564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I51957af512cae8ec838fd9b14bd576356edd2611
2016-07-06Reload the preset list after deletionRishabh Kumar
ValueSet assign Ids to entries when the list is loaded. Ids are not changed after deleting entries. Change-Id: Ia4442992561bf2cd82ff325abef8e34715851e1d Reviewed-on: https://gerrit.libreoffice.org/26986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-06Redesign of Hatch tabRishabh Kumar
1. New Hatch Listbox for presets. 2. Context menu for rename and delete. 3. Rearrangement of controls. 4. Remove Save and Load Buttons. Change-Id: Iad2479bc418f7a257a410df7f11c23ed8dd7734c Reviewed-on: https://gerrit.libreoffice.org/26869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-06loplugin:vclwidgetsNoel Grandin
Change-Id: Id276128a249aeac98ac3374b975bf1cd946d5aa7
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05when disposing popup menus, don't leave dangling pointersNoel Grandin
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf Reviewed-on: https://gerrit.libreoffice.org/26960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05cui: add calculation mode to Help->About.Michael Meeks
Change-Id: I4765436bed8a58c5097afcf7dce768d3ec325015 Reviewed-on: https://gerrit.libreoffice.org/26964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05Resolves: rhbz#1352835 path options doesn't promptly destroy folder pickerCaolán McNamara
Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-03tdf#57950: Replace chained OUStringBuffer::append() with operator+Arnold Dumas
Change-Id: I5e6cb493a5e742232cd312014d4b5b2820cf8314 Reviewed-on: https://gerrit.libreoffice.org/26878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-02tdf#100728: Crash when area dialog is openedRishabh Kumar
Change-Id: I2246c5bf3a1d33e7a08fa9062e568a4c95fef571 Reviewed-on: https://gerrit.libreoffice.org/26875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-01tdf#90336 - further cleanup of OpenCL options page.Michael Meeks
Still problematic; since we only show OpenCL as being available if it has already been initialized and used. Change-Id: I5e82a3f778f4f2025408330b6d9da51402d01e79 Reviewed-on: https://gerrit.libreoffice.org/26866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-01Remove unused controls in Pattern tabRishabh Kumar
Change-Id: Ie53dbbe652413c1ce098d1690d68ae8acc491ca4 Reviewed-on: https://gerrit.libreoffice.org/26858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-07-01Mention that this is about *toolbar* icon sizeSamuel Mehrbrodt
Change-Id: Id48edf2677d6adc31983ca21e248447af9a58a23 Reviewed-on: https://gerrit.libreoffice.org/26859 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-01GSoC possibility to change icon size in the SidebarToolBoxSzymon Kłos
+ Added registy entry to store icon size + Added UI to change settings: Tools -> Options... -> View + Loading last settings in the SidebarToolBox + Settings update listener Update icon code from: framework/source/uielement/toolbarmanager.cxx Change-Id: I1d713c50fccfc19e1c8ea82eba68556ddb76cd3c Reviewed-on: https://gerrit.libreoffice.org/26362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30Minor changes for Pattern tabRishabh Kumar
Change-Id: Ibc10b24c2367fd7a6ca068ee61fd4098d2f66bdb Reviewed-on: https://gerrit.libreoffice.org/26825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-06-29loplugin:staticmethodsStephan Bergmann
Change-Id: I506f1e79a7500ab79dd0f199150949face091931
2016-06-29tdf#90336, make it visible in options, if openCL will be usedJBurant
I tried to hide the black and white list settings and to add the info, whether OpenCL will be used. Change-Id: Ida7d34078bdb6fc2597376a61138cf9ec0c8eeaa Reviewed-on: https://gerrit.libreoffice.org/23847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-29tdf#100413 Use same default values for preview string and format listLaurent Balland-Poirier
Add specific default values for: - scientific: to distinguish engineering notation - fraction: to have quarter format understandable Change-Id: I73b74713a4bc502e9967b8d2c9983cfc6244912e Reviewed-on: https://gerrit.libreoffice.org/26391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29Move accessibility relations to .ui files, Part 12: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations have been moved to .ui files other than a few exceptions. Change-Id: Ic9dffdde414d245c13f13ee08543f90884991222 Reviewed-on: https://gerrit.libreoffice.org/26707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-28Convert Bitmap tab to Pattern tabRishabh Kumar
Change-Id: I5cf02f1889090539f7adb826483c91a1ef3c3925 Reviewed-on: https://gerrit.libreoffice.org/26015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-27tdf#100222: Show the dialog just once even if both toggles were changedTor Lillqvist
Change-Id: If6058d68f80ebc3e235f0a681cfe3240985e2429
2016-06-27loplugin:singlevalfields in cuiNoel Grandin
Change-Id: Iead1e3130779566661eccf91556816724afcaa66 Reviewed-on: https://gerrit.libreoffice.org/26635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-26Resolves: tdf#100619 vclptr assert with menu set to menubuttonCaolán McNamara
Change-Id: I2e621567e3bbc01d6f52844014dba9e46fe79f41
2016-06-23tdf#100222: Inform user that a restart is needed after toggling OpenCL useTor Lillqvist
Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17cui: fix loplugin:passstuffbyref warningsMiklos Vajna
Change-Id: Ic756db3decb4b4bfde345bc0adc092907622287e
2016-06-17Reduce duplicate code and remove DBG_ASSERTRishabh Kumar
Change-Id: I2abf050bd6627cda993ff03bdf1d1867e209bda5 Reviewed-on: https://gerrit.libreoffice.org/26392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-16tdf#85949 Add 1.15 line spacing in the paragraph dialog alsoSamuel Mehrbrodt
Change-Id: I55a6028d1db2f2ebbdf0ed4a91e2db88098899fc Reviewed-on: https://gerrit.libreoffice.org/26370 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-16loplugin:passstuffbyrefStephan Bergmann
Change-Id: I3388ca4e484a567ed6f00d7ed177a1e45c8af706
2016-06-16Remove color name field from color tabRishabh Kumar
Click on 'Modify' button to change the color name Change-Id: I90397ae81edc3a9b5368f9fc2a9f2811a1e774e0 Reviewed-on: https://gerrit.libreoffice.org/26090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-15Move accessibility relations to .ui files, Part 9: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I52e3f2a16519aee13b06f0efc6beb3385bcb0f1c Reviewed-on: https://gerrit.libreoffice.org/26066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-14Related: tdf#90480 explain in the font color dialog why colors aren't used...Caolán McNamara
if the a11y option "Use automatic font color for screen display" is active. I guess we could go to town and have a button to zoom to that option or to directly disable it, but I've never encountered this problem before so surely it isn't that common that we need to immediately do that. Change-Id: Id19cac56591829f5644a8ac66c3d873c77e152f8
2016-06-14tdf#89329: use unique_ptr for m_pImpl in chardlgArnold Dumas
Change-Id: Ic7ac35ebdab7143d75a9f2c8d0e6f99796ffb0e3 Reviewed-on: https://gerrit.libreoffice.org/26232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14Minor bugfix for the Color tabRishabh Kumar
Bugs fixed: 1. Allow resizing of SvxColorValueSet on Addition and deletion of colors. 2. Refresh color in SvxColorValueSet on modifying the color. 3. Select the second last color on deleting the last color. Change-Id: Id01a1347683ea183dfb9fbc5c14a4e101eeef9aa Reviewed-on: https://gerrit.libreoffice.org/26084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>