Age | Commit message (Collapse) | Author |
|
For more info and explanation including state of process
information and discussion(s) see task please.
Adding corrections for gerrit build
Change-Id: Ie10fb8093a86459dee80db5ab4355b47e46c1f8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88130
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I2886b6da85043218505ff9f3e40a8e28289c6f37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88152
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
regression since...
commit 3a15c034be9f557f350d0ba1f3a842151066eaae
Date: Tue Mar 12 09:59:35 2019 +0000
weld SvxGeneralTabPage
Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88108
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88047
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia6229e8cc04c88e6740a12648c50cf5efca3bbd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2ec0c6dd376f3a192a62dc97f7454af946e2a5ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88065
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8a84ce74888e1d3c468251ddd3633aedf6339a11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88064
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
to avoid potential future wrong code
Change-Id: Ib5a10039ce95ed5d9bf6f5905bc58af5182d5c0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87995
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Id294458e0b380ceedc199a9c642f29ecfbeef10e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87920
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: Ib963dccf0f803534c741eacc31a44dc5c90889fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87958
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
It's possible to remove seven usages in align.cxx
which cannot happen due to AlignmentTabPage forcing
used ItemIDs to be member of the used ItemSet.
Checked that in the debugger. Safe, is all set and
ceated when the Dialog and the TabPage gets created
(see AlignmentTabPage::GetRange())
Change-Id: If8e7285b46792fb9035555a4fcd2ac6ec94a45ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87975
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: Ie83747b90b420c6de677d243665d7a22290236a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87959
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaeb3c17fe157dec82cd70991122c08ee1e215752
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5
Date: Sun Oct 20 00:44:05 2019 +0200
tdf#128257 Bullet Dialog update
so spinbuttons were disabled
Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87878
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87862
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
tweak plugin with the name of another clone method
Change-Id: I47193d31f53f48297c9e773da375c7255ddde282
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87852
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I709f100541964b8740a7d0639a58214b1553458f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87836
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iadac47f83aae0f7403f3391e3dd45bef52ad347a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87832
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
With --enable-pch=full there's not much difference between a "public"
header in <module>/inc and a private one in <module>/src/somewhere/inc .
And since the script searches recursively, this apparently helps to
find even more headers for lower pch levels.
Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I00055ffd7b79d2e5637b69390ca516f11b0cffd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87801
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: I8ddf92d9b349ed8884c971e08c124dba1efc4142
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85792
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
- change "Title" to "Capitalize Every Word"
- change "Lowercase" to "lowercase"
- change "Capitals" to "UPPERCASE"
Change-Id: I67145a384b0220924184b8bc279fb702d8c9f379
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87684
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Somewhat surprisingly the test passed without the fix, i.e. the uitest
operated happily on a hidden widget; so explicitly assert that it's
visible.
Change-Id: I321c7e0e3cb2d67a07724523c885d50577a116a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87656
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87149
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
found by my new loplugin:unusedvariableplus
Change-Id: Ic3f55f492d43a53d8850a97d44059ff127fd69a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87573
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
"Find explicit casts from signed to unsigned integer in comparison against
unsigned integer, where the cast is presumably used to avoid warnings about
signed vs. unsigned comparisons, and could thus be replaced with
o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx)
o3tl::make_unsigned requires its argument to be non-negative, and there is a
chance that some original code like
static_cast<sal_uInt32>(n) >= c
used the explicit cast to actually force a (potentially negative) value of
sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the
cast to avoid a false "signed vs. unsigned comparison" warning in a case where
n is known to be non-negative. It appears that restricting this plugin to non-
equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=)
is a useful heuristic to avoid such false positives. The only remainging false
positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast
from sal_Int32 to sal_uInt32".
But which of course does not mean that there were no further false positivies
that I missed. So this commit may accidentally introduce some false hits of the
assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan
--enable-dbgutil) `make check && make screenshot`.
It is by design that o3tl::make_unsigned only accepts signed integer parameter
types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses
which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in
include/oox/helper/helper.hxx is used with both signed and unsigned types, so
needs a little oox::detail::make_unsigned helper function for now. (The
ultimate fix being to get rid of the macro in the first place.)
Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0db2e3e5c2566ae4dc59ff49f677eab8daa930be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87465
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
it was always sorted historically, just without showing the sort indicator. Fix
that inconsistency which led to the error causing the crash, and use iterators
when appending to the sorted list instead of indexes which is the crashing part.
Change-Id: I4ea3028a334129bdeb8e1a1aa79f4ead8a0243e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87343
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I445753ad1eb4d441e5a5e909ae450bda6013a6b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87352
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I62ed118ba862a164b6cbd21ad5757b7d3731cd44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87348
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I763cc054b23d4f72e1dec175861f3062d6bda6fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit 0a64b33617299ece871a947828855b16e2482706. Let's
revert this till it's clear how to fix UITest_writer_tests2 to not hang
with these changes.
Change-Id: I9b40b101ecdad0ccac9a0b52b6a2ef19bd47a38c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87333
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
|
|
Change-Id: I45b7381f665a749b86302be07fa095a30842428f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
property to 5.
In mobile view, touch spin button should increment by 5
Change-Id: Ib3c8966443d053ab0588fa0c124f0daae31b7ed8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86844
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86854
Tested-by: Henry Castro <hcastro@collabora.com>
|
|
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0c63fb9a2c1d4f0cbcfd7a573a05c4fbf726ecb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87049
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I3c32851cda40254c73b0040f92466eedb7427d6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idcdf3d748849fbe1ba1a6cce278373e349ba1e5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86967
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I792755f043109173606a78e947d5dc01f78c6849
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86982
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
so the whole of edit.hxx doesn't need to be included just to set that
detail
Change-Id: I467add023ca59c1ffdccbafb21843cb153ba6a40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86769
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I05cd8e336f818e80de40abb40cf739a7cbb540d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86665
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46
Date: Thu Apr 18 19:25:06 2019 +0200
WIP: Further preparations for deeper Item changes
because since then aNewTabs is cloned, but on delete-all
aNewTabs is reset to a SvxTabStopItem with a 0 WhichId
so its clones are useless
Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86578
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
in the options dialog which has a non-standard organization for its
contents vs an ordinary dialog
Change-Id: I6a50652f5ae3fe2e8b4d32933bec6dc0217cbec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86576
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
found using 'git grep', I tried using clang-tidy, but it only
successfully found a tiny fraction of these
Change-Id: I61c7d85105ff7a911722750e759d6641d578da33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
added GtkFrame to include label with Preview Window in Customize tab
added label in Position tab
Change-Id: Id37a2c696832ebe9dcd3cb4910a7bc3292cb0143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86320
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I63c3c28dedf82bfc8e28c0a323aaa8c26b4c82d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86316
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
...as observed with -fsanitize=address in Draw, after drawing some rectangle (so
that there is at least one marked object) doing "Format - Area... - Area -
Bitmap":
> ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8
> READ of size 4 at 0x6030004aca50 thread T0
> #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42
> #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124
> #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21
> #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9
> #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5
> #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1
> #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45
> #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42
[...]
> 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58)
> freed by thread T0 here:
> #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3
> #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21
> #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13
> #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42
> #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9
> #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21
> #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9
> #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5
> #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1
> #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45
This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec
"tdf#104615: there's no mpView when opening odc directly".
Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|