summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19cui: remove dead codeChris Sherlock
Change-Id: I3f27d1b502512a5603110445da7b0c50a5339198 Reviewed-on: https://gerrit.libreoffice.org/47486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-19use std::array in createHistorical8x8FromArrayNoel Grandin
to make the assumption about the size of the array obvious in the code. Change-Id: I7ebe0b037e3be38f7e33c0160742f829288bb474 Reviewed-on: https://gerrit.libreoffice.org/49938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use VirtualDevice in createHistorical8x8FromArrayNoel Grandin
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I8b3aa2fdd3c26db0e48b228640cd31b0bd31543c Reviewed-on: https://gerrit.libreoffice.org/49937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16Revert "loplugin:changetoolsgen in canvas..cui" and reapplyNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit f841dada1a5018897cce29ccf972da33ece4738c. Change-Id: Iff19e1fc99812c086b0a39b71a3f67b98e2f9c8f Reviewed-on: https://gerrit.libreoffice.org/49841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in canvas..cuiNoel Grandin
Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a Reviewed-on: https://gerrit.libreoffice.org/49642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-10lokdialog: Handle dialog items' invalidation in generalTamás Zolnai
Change-Id: Ib7b178fe97964bc5fd6ac173a143ba8ba089e237 Reviewed-on: https://gerrit.libreoffice.org/49240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-10use VirtualDevice in ColorFieldControlNoel Grandin
as part of moving use of BitmapWriteAccess inside of vcl/ Change-Id: Ia092eee7d56a6c6a6485555f470de10f31be8ed1 Reviewed-on: https://gerrit.libreoffice.org/49415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-09fix "replace Bitmap usage with VirtualDevice in ColorSliderControl"Noel Grandin
commit 7116b9cc2f3ee28b4444540d0c14183b9bd17968 Change-Id: I40d7f88fa76c620abd8838a0dd525e67eeeb747b
2018-02-08replace Bitmap usage with VirtualDevice in ColorSliderControlNoel Grandin
So we can move more Bitmap*Access stuff inside vcl/. Change-Id: I3520f61483f84ac30ffd9059ed4112c9c074f195 Reviewed-on: https://gerrit.libreoffice.org/49405 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-08tdf#115506: Crash when trying to set pattern fill for tables in ImpressTamás Zolnai
Setting pattern list was missed in this specific dialog. Change-Id: I9f47e9e0dd4f99bf5403c70685508b0f14a5bd61 Reviewed-on: https://gerrit.libreoffice.org/49361 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-07Don't inherit from ModalDialog for a random UI elementMarkus Mohrhard
Change-Id: I2f734b1f034eaa4203a21968bc8eca455afa7f72 Reviewed-on: https://gerrit.libreoffice.org/49312 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-06tdf#114731: persona html can contain &quot; instead of &#34;Julien Nabet
So let's replace all &quot; with &#34 in the retrieved html Change-Id: I4a90ecc51e7ce6d1e080e6c1b17b82fe9a29d65e Reviewed-on: https://gerrit.libreoffice.org/49179 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-06convert SetPixel->SetPixelOnDataNoel Grandin
by extracting out the Y scanline computation from the innermost loop. Inspired by commit 078d01c1b6cb9bbd80aeadc49a71cc817413164c. Change-Id: Ic3c1827c01ed3aec629975749a551c7a68ae4a5e Reviewed-on: https://gerrit.libreoffice.org/48926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06tdf#112239: Add icons to customize dialog function treeJim Raykowski
Change-Id: I68e908664d24c52657b3a073aae1c8cc41c3ce3e Reviewed-on: https://gerrit.libreoffice.org/48556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-05vcl: remove BitmapColor Color() operatorChris Sherlock
BitmapColor has a Color() operator. However, this is confusing and tends to hide that the two classes aren't the same. I have converted this to GetColor(). Change-Id: I0be2dcb3fc420e7be9c8d04330e7a3fe69a5412a Reviewed-on: https://gerrit.libreoffice.org/48245 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-03more TypedWhichId in SfxShell and SfxTabDialogNoel Grandin
and remove some unnecessary local copies of pool items Change-Id: Ifdac8d84658fd4b803267038592d7da370e23a0d Reviewed-on: https://gerrit.libreoffice.org/49138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03Resolves: tdf#115369 wrong cell shadow iconsCaolán McNamara
regression from... commit 910f91a3e5228f26f0692f870a3fd3919835eb27 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 21 13:04:30 2016 +0000 unwind IL_SDW_BITMAPS ImageList Change-Id: I9ecb5c45c240af0214666c56401abb07eb99e5f1 Reviewed-on: https://gerrit.libreoffice.org/49166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-02lokdialog: Color/font picker in dialogs don't show previewTamás Zolnai
Invalidation needs to be passed upward to the right parent window. It should work similar to other dialog items, but this preview class is not derived from the Control class. Change-Id: I5fb2b6438b8be92d55609c8d3c25110b49d0e6d7 Reviewed-on: https://gerrit.libreoffice.org/49101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-01tdf#42949 Remove unneeded helpids.h headers (1/3)Gabor Kelemen
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directories b* - e*. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I221d22f68584115d71660a97c4f108595625d12c Reviewed-on: https://gerrit.libreoffice.org/46868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-31SvxNumberFormat::SetAbsLSpace takes shortStephan Bergmann
...so there appears to be no good reason to cast from long to sal_uInt16 first Change-Id: I5baf699fbf043eae6a20e2055b53aef10103f591 Reviewed-on: https://gerrit.libreoffice.org/48952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-30No apparent reason to limit nTextXPos to sal_uInt16 instead of longStephan Bergmann
Change-Id: I7142252aa6c42c74c7f2d7407db1cb243090195e
2018-01-30No apparent reason to limit nFirstLineOffset to sal_uInt16 instead of longStephan Bergmann
Change-Id: I988614d5fbdbb439516627aa93327a1d2198e52a
2018-01-30No apparent reason to limit nXStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I19e846905bda86bb00826d337ee681b121c67407
2018-01-30No apparent reason to limit nLineHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6431da3ff753feadead8f59119f502b54669fdc3
2018-01-30No apparent reason to limit nFontHeight to sal_uInt16 instead of longStephan Bergmann
Change-Id: Id2cf2c667871e551082e00424d36aef481f5819c
2018-01-30No apparent reason to limit nYStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: I31ce86926d01e641f517beba3b3a784402ddaa1c
2018-01-30No apparent reason to limit nXStep to sal_uInt16 instead of longStephan Bergmann
Change-Id: Iee74da2f6e58fa809b068675c250c0445d9adf58
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I58958b7c7eae9f764cd88d3c1e3ca175af9fc370
2018-01-30No apparent reason to limit nXStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I6775c36c9b0eb3b1e56968b4ca212fcd43a3be1b
2018-01-30No apparent reason to limit nYStart to sal_uInt16 instead of longStephan Bergmann
Change-Id: I471eca407cb45daba62d679c8c43fb37d98dd762
2018-01-30No apparent reason to limit nWidthRelation to sal_uInt16 instead of longStephan Bergmann
Change-Id: I946e2a74ac5f03132791132e8d5b07d573cb76c5
2018-01-30No apparent reason to limit nYMiddle to sal_uInt16 instead of longStephan Bergmann
Change-Id: I3c1d082c99af94078a0a1505d3e69368aa5070ab
2018-01-30No apparent reason to limit nNumberXPos to sal_uInt16 instead of longStephan Bergmann
Change-Id: Ic46fbb6ca905cc93943927117aa8c70beebee5a4
2018-01-30No apparent reason to limit nTextOffset to sal_uInt16 instead of longStephan Bergmann
Change-Id: Idbd4e4aae63441537aff243d852272739b73f78e
2018-01-30No apparent reason to limit nBulletWidth to sal_uInt16 instead of longStephan Bergmann
Change-Id: I7ce0705e9edd5cff4e6c6977909d7e903f6e1765
2018-01-30Move long vs. sal_uInt16 mismatch out of lcl_Draw{Graphic,Bullet}Stephan Bergmann
...in preparation of getting rid of the mismatch Change-Id: I650a94ec043c4ce2763070a3441f08c0a77e7c73
2018-01-29Removed valueless lines of commentstagezi
Additionally, some lines are converted to a format of 110 characters Change-Id: I7c3fe97f7ebb2530eeb62d0522cd8a8b1c7269e1 Reviewed-on: https://gerrit.libreoffice.org/47121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29Improve code checking for a valid port numberStephan Bergmann
Change-Id: If827ffaee9a2aa861a0746353bdbfd5df1049303 Reviewed-on: https://gerrit.libreoffice.org/48716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-26Fix typosAndrea Gelmini
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad Reviewed-on: https://gerrit.libreoffice.org/48546 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-26tdf#107567 et al. Paragraph dialog preview windows fixesJim Raykowski
tdf#107567 tdf#98211 tdf#98212 tdf#113275 Change-Id: I6d11cb809283eee4fa79acae9aa32baaab558833 Reviewed-on: https://gerrit.libreoffice.org/45273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25tdf#115129 Add function on double click in Customize DialogJim Raykowski
Change-Id: I21a7f8b4fc05d55d1539a3fd148e5870899b1596 Reviewed-on: https://gerrit.libreoffice.org/48555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-24tdf#115129 change customize function tree expand collapse behaviorJim Raykowski
Change-Id: I6c20957fe3f95a8e63b30e5c733b99f71c193972 Reviewed-on: https://gerrit.libreoffice.org/48290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-01-22remove some sal_Bool remnantsNoel Grandin
Change-Id: I0a9637aca523a73fbdbbd22f9ad735d6d1ba6898 Reviewed-on: https://gerrit.libreoffice.org/48273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-21more ScopedVclPtr for dialogsNoel Grandin
Change-Id: I0f19a0c1e312843bee0ee5c9939831918ddc2da7 Reviewed-on: https://gerrit.libreoffice.org/48198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-20loplugin:unusedmethodsNoel Grandin
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19tdf#111747 Enabled position protection immediately after protection is checkedKshitij Pathania
Change-Id: I10409fe9e6eb7b932496346224952a7c4012cb38 Reviewed-on: https://gerrit.libreoffice.org/46192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-18lokdialog: Convert the Format -> ... -> Position and Size... to async exec.Jan Holesovsky
Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Reviewed-on: https://gerrit.libreoffice.org/48055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16svx: chain up correctly for SvxCharacterMap::Execute()Pranav Kant
Change-Id: I2ff70f7b2ade8e2aad96cff31bd313822779094c