summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for VectorOfNodes (cui/treeopt)Julien Nabet
Change-Id: I318128452fc6d76038c0ed41fcb0a5e7999952c4 Reviewed-on: https://gerrit.libreoffice.org/47146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for m_aLeaves/m_aGroupedLeaves (cui)Julien Nabet
and perhaps avoid memory leaks (see https://bugs.documentfoundation.org/show_bug.cgi?id=114457) Change-Id: Ib413b0bf6cc65a2696e3429965a67899b7b72d73 Reviewed-on: https://gerrit.libreoffice.org/47094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27clang-tidy-modernize-use-equals-default in cuiJochen Nitschke
Change-Id: Ied4f0a548b303aac86052df58f9a81fddeab7b06 Reviewed-on: https://gerrit.libreoffice.org/47086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27Calling ActivatePage directly is unnecessaryTamás Zolnai
After this commit: b426b026b79a342c41f6f148bf17d5df66b22927 Change-Id: I15d491d4cf63db4436ad8d3db0320cd2e26bb3ea Reviewed-on: https://gerrit.libreoffice.org/47078 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-27tdf#111723 Fixed - Dialog does not remember the last opened tab pageekuiitr
Change-Id: Ife6d0eb9ea13d2a0534f316db001dbb3b6a716eb Reviewed-on: https://gerrit.libreoffice.org/47050 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-22lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22request installation of langpack via packagekitCaolán McNamara
if ui is set to track the locale automatically and the current locale has no match in installed resources but has a match in the list of languages that libreoffice was compiled to contain so e.g. de_AT locale shouldn't trigger the installation of anything if langpack-de is already installed and yue_HK shouldn't trigger install of anything cause that not supported (at time of writing) for libreoffice put Fedora/RHEL/Ubuntu naming schemes in here. I moved the lang code from svl to svtools so I could use the restart dialog to prompt to restart after the langpack is installed, but packagekit's blocking mode seems to be no longer blocking and control returns immediately which is a change since the last time I played with this stuff, so drop the restart thing for now. The lack of a blocking modal also makes the "run this on idle when there's a toplevel window up and running" a bit futile, but lets keep that for now anyway. caolanm->rene: I know you'd disable this anyway, so Debian is left out, there's also config key Office/Common/PackageKit/EnableLangpackInstallation to disable this too. Change-Id: Ice731be539850338ccdd8af87839e0b4d83f01e7 Reviewed-on: https://gerrit.libreoffice.org/46856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22Avoid crash without GPGTor Lillqvist
Change-Id: I5489012544fdf736784608b274359ea99f9ffe45
2017-12-21tdf#106784 Also handle automatic icon sizeMaxim Monastirsky
... like before b1426b5b502fd591402d666994e3f1fb3a8ad959 ("tdf#95014 initial support for 32 px icons in toolbar"). The original code used SvtMiscOptions::AreCurrentSymbolsLarge() which calls GetCurrentSymbolsSize() internally, thus properly resolves the icon size, when the current setting is "automatic". Change-Id: Iabcbbcff666eecc2e7534eb1533610f08ac28bf1 Reviewed-on: https://gerrit.libreoffice.org/46899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-21TypedWhichId in svx part 1Noel Grandin
and teach the idl compiler how to ignore the TypeWhichId<T1> part of the define Change-Id: I030f54080924d51e9f0ac09b19e14106648024db Reviewed-on: https://gerrit.libreoffice.org/46849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-20Fix typosAndrea Gelmini
Change-Id: I361b5283b092171eaaaf46fa3c1fb13faa53bd7a Reviewed-on: https://gerrit.libreoffice.org/46821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-20Revert "Related tdf#114457: fix leak in treeopt (cui)"Julien Nabet
According to Telesto's test, it's worse than before, so let's revert This reverts commit 41981d4cb48e66b6fdb32cdc3ae65632af9593dc. Change-Id: Iba2a364160816fe981de91e51487a78bd6ebe15c Reviewed-on: https://gerrit.libreoffice.org/46817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19sal_uLong->sal_Int32 for SfxAcceleratorConfigPageCaolán McNamara
Change-Id: I2ec647b140c6be6c5cb6727873cca4cad16a664e Reviewed-on: https://gerrit.libreoffice.org/46701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19fix bug in IconChoiceDialog::disposeNoel Grandin
after commit 12bb4bc980863d4338725cf5a5dcaf3acbfddc09 convert HyperLinkPageType to scoped enum Change-Id: Icb1afcdea38f231bf9b7119eb4c1bedbf7494962 Reviewed-on: https://gerrit.libreoffice.org/46707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Read/write 'encrypt to self' bitKatarina Behrens
use some template functions to avoid duplicate code Change-Id: Ia178ea3a0561e34e0431749262f5f8f1f49b4fe7 Reviewed-on: https://gerrit.libreoffice.org/46693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-19Read/write preferred GPG signing/encryption keysKatarina Behrens
Change-Id: I3e21469c5f4c4f199407bbe9faba2e2ddca531b3 Reviewed-on: https://gerrit.libreoffice.org/46692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-19List private GPG keys in crypto config dialogKatarina Behrens
Change-Id: I7cb6a14adcc5424b432589120c66deeddf86b652 Reviewed-on: https://gerrit.libreoffice.org/46691 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-18convert HyperLinkPageType to scoped enumNoel Grandin
Change-Id: I9554cdee56c7079ed8633ffb16074c99d5ab144e Reviewed-on: https://gerrit.libreoffice.org/46588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert ColorPickerMode to scoped enumNoel Grandin
and drop unused Add constant Change-Id: I4e4f0d35e4d081883b78e0205ffd7086c9cadf04 Reviewed-on: https://gerrit.libreoffice.org/46587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17tdf#98058 Respect menu:style="text" settingMaxim Monastirsky
It was implemented on the xml handling side, but ignored by the menubar code. In addition, make the menu:style attribute survive customization (similar to tdf#114261). Change-Id: I92a3517ee7ba2fe7a0782985d89fb5d0fdbac246 Reviewed-on: https://gerrit.libreoffice.org/46627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-17loplugin:unusedindex Remove useless outer loopMike Kaganski
Change-Id: I6e5e7162b1e0ea2b9f33866ea76e2614acdffb06 Reviewed-on: https://gerrit.libreoffice.org/46606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-16Related tdf#114457: fix leak in treeopt (cui)Julien Nabet
Change-Id: I28bd32d01bb3d90e68e816720b1b5af7d517760f Reviewed-on: https://gerrit.libreoffice.org/46602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15tdf#114484 - Make internal file and print dialogs obsoleteheiko tietze
Checkbox hidden in options dialog Change-Id: I918b328dec1a4fbb4ebbcc538ffa902160ee0b9b Reviewed-on: https://gerrit.libreoffice.org/46546 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-14Minor fix: unused local variableGergely Tarsoly
Change-Id: I42db2c6fd90686641cd6c2f7f45d960977557ab4 Reviewed-on: https://gerrit.libreoffice.org/46416 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-12tdf#113959 Use svxlo-FrameDirectionListBox instead of ListBoxGabor Kelemen
Final part. Here frmaddpage.ui is migrated, but to reuse the 2 other strings we need to shake up their original place in page.cxx Now all the stings are moved to svx and occur only once in the code base. Change-Id: I8b3942f96d43bf8d6f054c8410c3781bcefc3ccc Reviewed-on: https://gerrit.libreoffice.org/46189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-12sal_uIntPtr->sal_uInt32 in AbstractGalleryIdDialogNoel Grandin
to match the underlying call to SetId in GalleryTheme Change-Id: If862c1f7c2d7c05484347ef46a9d504e95686ec7 Reviewed-on: https://gerrit.libreoffice.org/46273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10tdf#114261 Retain toolbar:style after customizationMaxim Monastirsky
Change-Id: I50170a2433f5e20809dd5bca8cb764039e8e0d84 Reviewed-on: https://gerrit.libreoffice.org/46169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-09tdf#113959 Use svxlo-FrameDirectionListBox instead of ListBoxGabor Kelemen
To reduce the number of translatable stings Change-Id: I1aeea6767d3389dd24a5bf8b074817ef601502a7 Reviewed-on: https://gerrit.libreoffice.org/45823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08gpg4libre: rename GPGME_HAVE_GPGME to HAVE_FEATURE_GPGMEThorsten Behrens
Change-Id: I6f085b67c3477f427bd1efd96db93cbb89e20647 Reviewed-on: https://gerrit.libreoffice.org/46050 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-08Update recent characters only when the selected character is insertedTamás Zolnai
Change-Id: Ic8cd715553f995d8adc1e84381c00646c9c252af Reviewed-on: https://gerrit.libreoffice.org/46065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07lokdialog: Make hyperlink dialog workPranav Kant
Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76
2017-12-06tdf#114122 - Double click in special character dialog inserts a characterMark Vecsernyes
Change-Id: I8f8db851363344091294e2af43aba289ac160d98 Reviewed-on: https://gerrit.libreoffice.org/45952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06Restore GPG SEInitializer serviceKatarina Behrens
user config now needs it to collect user's private GPG keys Change-Id: Ia4ad4133b621160cf37281750cafa9f3c5c3c231 Reviewed-on: https://gerrit.libreoffice.org/45562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06loplugin:countusersofdefaultparams in cuiNoel Grandin
Change-Id: Id3258a664c2ea740419331877f7ce6af5e2559e7 Reviewed-on: https://gerrit.libreoffice.org/45922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05tdf#114091: Customize dialog: Rename 'All categories' to 'All commands'Muhammet Kara
And put a separator before the 'Macros' category. Change-Id: Ibcff6b6c6d3a4f72d5e06b519fe8245d9602ad3c Reviewed-on: https://gerrit.libreoffice.org/45843 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-12-04tdf#112207: Allow assigning macros to ui elementsMuhammet Kara
* Adds "Macros" category to the categories list * Search/filter feature now works also on the macros category * Since macros category has multiple trees and subtrees, and many leaf elements (macros). I chose to implement the behavior like this: If there is no filter/search term, the trees will be presented as in the old macro selector dialog (collapsed), but if user types a search term, then filtering happens: non-matching elements and empty containers/(sub)trees are removed and everything is expanded so that user easily sees what (s)he is looking for. Change-Id: I1a93f156a7293c7e61baac882a10ff631961e2af Reviewed-on: https://gerrit.libreoffice.org/44938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-04loplugin:singlevalfieldsNoel Grandin
Change-Id: I521d2efa641f3a14c48561e2e0f6d687e5807d93 Reviewed-on: https://gerrit.libreoffice.org/45662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-02tdf#98211 make last line default value language neutralYousuf Philips
Change-Id: Ieccb174debbfb00e8165c5928ea9786d55bffab3 Reviewed-on: https://gerrit.libreoffice.org/43224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-29Fix typosAndrea Gelmini
Change-Id: I543818f6176b22226683be9cc6c459eda0e53183 Reviewed-on: https://gerrit.libreoffice.org/45501 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-29Related tdf#111739: Don't insert special character into the documentTamás Zolnai
When it's only needed to be applied inside a dialog. Change-Id: I7d61cfb49f80ab43511c9fc6cc6733a990dcae55 Reviewed-on: https://gerrit.libreoffice.org/45436 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-29tdf#113859 Make it possible to select every widget with tabgeri1245
On the shadowtab page of a figure (eg. rectangle, ellipse) the widgets that modify the shadow can now be selected using the tab button. Removed an "invisible" alignment from the ui file that caused the problem. Change-Id: Id833302d42b9c1f2df640135473f159c0a3af4f7 Reviewed-on: https://gerrit.libreoffice.org/45444 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-29Use SfxModalDialog class as Hyperlink dialog's basePranav Kant
Change-Id: I1f592fdb5825896ad8fbe55c182936ed4ed98efc
2017-11-29loplugin:unusedmethodsNoel Grandin
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-28Add comment to translators of "Grammar By" text entry boxLászló Németh
Change-Id: Ifea74df8f113967c9df9703cf6582360ffdfa78d Reviewed-on: https://gerrit.libreoffice.org/45410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>