summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2021-09-02unused definesNoel Grandin
Change-Id: I494e64c69decb9fb3d5b13ffc2f18d99f6b7749f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I2fc0a1f5a637b3228d8f49ecd0e0769d6872cdc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-27Related tdf#119931 - Fix accessibility warningsHeiko Tietze
Change-Id: I69787778f11217a55daa1489c142561db5efce19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27these checkboxes are being used as labels for the menubuttonCaolán McNamara
so describe that a11y relationship Change-Id: Ia48d928222159399e1f0a3cdd977447b6c861294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27change the extra config colors to match the application onesCaolán McNamara
these extra ones are dynamically appended to the static set of the colorconfigwin.ui so adapt them to the changes of commit 2f706b1e91396cbe044c20fab79772dfc081a340 Date: Fri Aug 27 11:46:57 2021 +0200 Improve accessibility for application color settings Change-Id: I5a458ea509dfffc147b533d38458465df18869e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121174 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27these GtkMenuButtons need label propertiesCaolán McNamara
Change-Id: If8dc1112115aa6c2f3074d826a26ff1c87568173 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27Rename AsyncColorPicker -> AsynchronousColorPickerSzymon Kłos
Change-Id: If26865ea063df3052e6ba61642fe36f5a1a47929 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120735 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-27Improve accessibility for application color settingsHeiko Tietze
* Lengthy grid replaced by some frames * Order of sections updated to show less important on bottom * Accessibility suppressions removed and solved Change-Id: I150603d141961cf579c1853ea3e67499da81c596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121137 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-26backendtest: Intersecting Rectangles Drawing testhomeboy445
This test intends to test the even-odd filling rule by testing if the intersecting rectangles have been filled accordingly to the rule or not. Change-Id: I0fb7f115a25476cc38e8bec5cd02737aea3c0316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119098 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-23enable the UI option to enable Skia on Mac tooLuboš Luňák
Change-Id: I3b4d96a3defaa9d6fdfba54f1da4d8be246367e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120813 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-22don't store vcl::Font with unique_ptrNoel Grandin
it is already a COW object, so just use std::optional Change-Id: I5ced54dbf3dc222316d9bcf3581b36e0f6e6e270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20New loplugin:unusedcapturedefaultStephan Bergmann
In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20loplugin:unusedfieldsNoel Grandin
Change-Id: Ie27afe4c2438c44baece4b926572584c6695dc39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19Make Custom Color Picker dialog asyncSzymon Kłos
- now supports also XAsynchronousExecutableDialog - inherits from SfxDialogController to attach correct LOKNotifier Change-Id: Ic21db4057b8087d74a437b1c8ec95408ade5264d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119012 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120670 Tested-by: Jenkins
2021-08-19save LastTipOfTheDayShown when the dialog is shown not in its dtorCaolán McNamara
Otherwise if a tip dialog is left open then its considered not to be have be shown and new ones will constantly open on every new document. Especially problematic in impress if you leave the first one open and select a template to open from the template dialog then you get two of them in the same frame. Change-Id: I94cd34aa031e133d8c229a0de78582fda1dbdf4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18undo changes to TextAlignCaolán McNamara
revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 29 20:49:29 2021 +0100 convert TextAlign to scoped enum lets leave this as it always was Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17tdf#143858: sw: default value for nInclUpperLevels is 1Vasily Melenchuk
SvxNumberFormat::nInclUpperLevels (matches text:display-levels in ODF) bit incorrect in its name: is counts total amount of levels to display, including current level. So value "0" seems have no sense: display 0 levels in total? In UI you can't select less than 1 level and ODF standard (19.797) using 1 as a default. This looks plausable. Change-Id: I596386c7b3cc4370910cd0ff6e927e501179fbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120458 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-08-16Resolves: tdf#143785 save/restore SdrModel::IsChangedCaolán McNamara
Change-Id: I253915c359cf72f80b21e21ff34e0ee406e5b3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16Use o3tl::toTwips to define MINBODYMike Kaganski
This changes its value from 56 to the proper 57. See 9be17c52b7c565758088b8020a543d7b840e31a7, which had changed the previous 5-mm value to the incorrectly rounded 1-mm value; and cefce1a247a4674c5726a31b61571eab16328a0b, which had unified the other places mentioning i19922. Change-Id: I7186320b4c1a2a65a6f728ed8bafcbf0eb45c4cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-13let return in java param dialog entry 'add' when possibleCaolán McNamara
Change-Id: Idfa2283dde0596db5c7fe2b56e8db761a5c75fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-13split SvNumberFormatter into it's own headerNoel Grandin
so I can make changes without running into cyclic dependencies between header files Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-11convert some LogicToLogic calls to use o3tl::convert insteadTomaž Vajngerl
If a LogicToLogic uses fixed units, we can use o3tl::convert instead. We can also do the same for all other cases where LogicToLogic is used, but that needs additional investigation to determine if it is safe to do so. Note: MapUnit::Pixel is converted to o3tl::Length::pt because it assumed 72 PPI for a logical pixel, which corresponds with the conversion rate of a point (72 PPI). Today, 96 PPI is standard, which is also used for o3tl::Length:px. Change-Id: I29126df38bfcfda74b5d83d4cb880a378aecd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120230 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-10add some --disable-scripting fixesCaolán McNamara
Change-Id: I45f08bce8e067ead82f4c73c8150b7027c083172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02convert #defines to OUStringLiteralNoel Grandin
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-30convert TextAlign to scoped enumCaolán McNamara
Change-Id: Id2c466eacb44f0ea6adba75a0ac0be8be8e7ed4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-29Intialize the VCL test dialog directly instead of dispatching commandhomeboy445
Change-Id: Ia24c97b12266dac3a6f315993558f3cdac8a4652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118124 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-28use officecfg for SvtCJKOptionsNoel Grandin
and remove some unused options Change-Id: I487a233de4f7414012e5405f2c2e1f9c8b8fb4f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-27Added the feature to store VCL test results as a zip filehomeboy445
The results can now be downloaded as a zip file, which would consist of the test log and all the resultant bitmap images produced by the tests compressed as png stored in the user directory folder. Change-Id: I8a6098a7454a621bbb9cafa7b6f2cafaa5503522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117937 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27-Werror=maybe-uninitializedStephan Bergmann
(at least with recent GCC 12 trunk and --enable-dbgutil --enable-optimized; see the discussion starting in the comment at <https://gerrit.libreoffice.org/c/core/+/109930/11#message-4375e529ca6a843e3560facc591368bf2f36a755> "tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse" for the use of o3tl::doAccess here) Change-Id: I8ecc624488afa8825fe9c60bb07ca7079c398340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119547 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-27drop SvtLanguageOptions classNoel Grandin
since it is just a wrapper over SvtCJKOptions and SvtCTLOptions. Later I will replace those two with the equivalent officecfg calls Change-Id: I61c5667a05f75d42643175f2c28c29d7a590b15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-27Remove duplicated includesAndrea Gelmini
Change-Id: I545c74059e2af2308d981356a24382958105bc1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119519 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-26use officecfg for SvxHtmlOptionsNoel Grandin
Change-Id: Ie7db7d20509e45fd87d8460c7fae6c0131e0a1f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-26use officecfg for security optionsNoel Grandin
Change-Id: I9d91fd5b260b82e05aac6567143386742953ecf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-26use officecfg for default optionsNoel Grandin
Change-Id: I5241c21fa097c104f1131db61787191d019a5de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119485 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-26simplify SvtDynamicMenuOptionsNoel Grandin
Change-Id: I8892b8a51fcecd84ea1fedcd71b6d1a2febabee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-26use officecfg for menu optionsNoel Grandin
Change-Id: I94c9cf310ed6975f158548913439445faf6d178f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve OdfDefaultVersionNoel Grandin
Change-Id: Id54b98d978965e7ce304b83d5eff7d6c844a41d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg for drawing optionsNoel Grandin
Change-Id: Idba40d9816f29c0e4bc4a468b8c0a2cbb74d09d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119481 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve LoadUserSettingsNoel Grandin
Change-Id: I9680c02207ff2d21785a20061b784066ead07a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve UseUserDataNoel Grandin
Change-Id: Ic77555520f2451b12c01423179d3f201daad35b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve CreateBackupNoel Grandin
Change-Id: I4aeb1224f0d42dadd5a69dd49b8df9ee2f776b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve LoadDocumentPrinterNoel Grandin
Change-Id: Ie9c164fb9c95989035ef769d0dd539521400e38e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve WarnAlienFormatNoel Grandin
Change-Id: Id7ca2ffa237cb8fda58af60ee5d296f492c5a47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119462 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg for help optionsNoel Grandin
Change-Id: I2d19541cff07bf8159715d8f32d771cbf201ece4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve AutoSaveTimeNoel Grandin
Change-Id: I003be64cc46d6e781ab03d83bae0a3114ab6d56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25simplify SvFontSubstNoel Grandin
in the process, needed to expose some functionality in ConfigManager and ConfigItem, to avoid repeating code Change-Id: Ic0256a010070a79cd649dfd11267bec2f77e5221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg to retrieve UserAutoSaveNoel Grandin
Change-Id: I11f45c43bed9ea9a380026d84a91f48629dffac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-24use officecfg to retrieve AutoSaveNoel Grandin
Change-Id: I613ca68123cfd316cd4e6384f743aa6756d9291d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-24use officecfg to retrieve DocInfoSaveNoel Grandin
Change-Id: I0a9e8b21b0c5937567273155cd5b5f773fe26b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-10 02:25:35 +0000