summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2021-04-28use string_view in INetURLObject::encodeNoel Grandin
Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27tdf#137470 use a more proper URL for the extensionsChristian Lohmaier
also hide the download-count, since those numbers are completely made up by the script Change-Id: I15b53a8a023c34ecc6a544b88ad35800891e4327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114740 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-04-27tdf#138751 Localize items in Notebookbar customization dropdownsGabor Kelemen
Change-Id: Idb1483e083f7758acb83da6c3ca9403c40ac9a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114447 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27Related: tdf#130326 allow bulk_insert_for_each to insert under a nodeCaolán McNamara
Change-Id: Iad14638a33710ef0b790c702e7eab2283726f2fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114571 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-26AboutDialog: imgBrand: Fix alignmentPedro Pinto Silva
The imgBrand was "centered" aligned with the text bellow which was resulting in not only going against the dialog layout (2 sections) but was also appearing "false" centered aligned: - Left section: imgAbout - Right section: text left aligned - Right section: imgBrand was not left aligned and not centered aligned etheir (with the dialog) Fix: Left align imgBrand to be consistent with other elements in the same section. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I227f67863d5b6e951c498ee7acdfadc0fac75e6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114648 Tested-by: Jenkins
2021-04-23this Sequence can be a std::vectorNoel Grandin
Change-Id: I678db4ed598b3e1061857e942185b2307fbb9e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22Resolves: tdf#141721 text from 1st col not clipped if 2nd col is emptyCaolán McNamara
Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20use OUString::Concat here, not OUStringLiteralNoel Grandin
Change-Id: Ia2172bcab60f32c9d9d4f6ca0230484343eef69b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20don't need to have a blank title in a .ui to set it later from codeCaolán McNamara
Change-Id: I03c1f785f804b73df25829ad374aadbe648ffb20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114323 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20fix .ui indentationCaolán McNamara
Change-Id: I59785bcf81df775901f5bbb86561803709153286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19use more string_view in comphelper::stringNoel Grandin
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17update paraindentspacingandreas kainz
Change-Id: I35d0fcc2555ead62f890f2b66a75b3a6d646a95b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114230 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-04-16Remove description from mobile macro selectorSzymon Kłos
Change-Id: I76d9a73c65d0c7759b56a3d7b69aadf5b58d7da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112327 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114206 Tested-by: Jenkins
2021-04-16Remove unused code from Macro Selector dialogSzymon Kłos
Change-Id: I9930fd7eaf2410447f84aa4798478a10915ea738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114205 Tested-by: Jenkins
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13Macro Selector dialog: Remove extra padding and shadowPedro Pinto Silva
+ Remove extra left padding so everything is properly aligned - No need for extra padding to convey hierarchy we already have headings and vertical space to convey grouping + Description: Remove extra shadow from the scrolledwindow - To avoid giving the fall sense of interactivity since it's meant to be solely an element to display text and an outline around can suggest waiting for some input/selection (cherry picked from commit f9c40cad1eefb4f6329dfd229ba18507c8083649 with resolved conflicts, picking only relevant changes) Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: Ibbfac39cc46da9c9e91cdaca1a97c84d8a3cd8fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112203 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113893 Tested-by: Jenkins
2021-04-12update PCHsCaolán McNamara
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-12Tip-of-the-day: improve a tip and add link (related to tdf#139533)Ming Hua
This was changed in commit a182dea0413c467b834f206f9cb91dc3f56acd35 tdf#139533 re-word a tip of the day and "You can" was added to the beginning of all sentences that start with "Create...". However this particular one is phrased as a question, and "You can create...?" is obviously grammatically incorrect. Fix this by combining the two sentences of the tip into one, and drop the unnecessary and inaccurate note in parentheses. Also add a link to the help page about creating master document. Change-Id: Ib6e92b2a7772378e4b7b67e40bdd2e2791d4f07a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113392 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-04-09remove vcl/waitobj.hxxCaolán McNamara
create vcl/locktoplevels.hxx for the utility to set all toplevel windows modally locked Change-Id: I964484d238852e830e1e5c0b86b3bebb3b41a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09-Werror,-Wreorder-ctor (clang-cl)Stephan Bergmann
Change-Id: I3c5fd8e875c6c0d36e97d76b0c51308799eeb351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-09Recheck include/ with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07lok: async exception dialog messages for VBA macrosHenry Castro
Change-Id: Ia713343541f8102de85f7ac57202780afba3da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111855 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113686 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07lok: fix the empty script node type container without "+" symbol expanderHenry Castro
According to description in https://bz.apache.org/ooo/show_bug.cgi?id=30923 "In this case I think it's an acceptable solution to display a '+' symbol for all library nodes, and if a library has no children and the user clicks on the '+' symbol, the '+' will disappear". Unfortunately this behaviour is not well driven for final users' client side, so they misinterpret as a bug. After tracing the method hasChildNodes(), the log result indicates that this method does not load the libraries, but it is necessary to iterate applying the method getChildNodes(), which will cause to load all libraries and determine if the child has a script CONTAINER node type to assign the '+' symbol. Also, I have traced the loading libraries when the Macro Selector dialog pops up and the result it load once, so I do not think it is a problem loading a small finite number of libraries today. Change-Id: I4ae5395b6afa7b7d6ff2b2ec692771e93c46c529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112636 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113693 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06update pchesCaolán McNamara
Change-Id: I835c8fcc237ece5cf9d7a3b261645139d022e9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05Related: tdf#141499 don't grab focus during teardown of dialogCaolán McNamara
Change-Id: Ib55825294b4276cf36d7ce13562dc52b71f2a5bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-02vcl: remove GetBitCount and GetColorCount from Bitmap{Ex}Tomaž Vajngerl
We can cast the PixelFormat enum to int for the same information and we can use the enum to reduce ambiguity when possible. Change-Id: I6ea648139465568cdeb12e5f5f75c7b609365bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113188 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-01tdf#141333 use a vertical step increment of one row heightCaolán McNamara
for font feature scrolled window Change-Id: I000d53af7128377930644591a096c94366da281b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-01tdf#140343 sw page rtl gutter margin: add UIMiklos Vajna
And extend SwFrame::UpdateAttrFrame() so that the layout is updated when the UI mutates the doc model. Change-Id: I4112388981187226f97ec39f4c44ffb3cc1e5253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113440 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-31UI Selection dialog: reword UI descriptionMing Hua
The description of Groupedbar Compact variant starts with a general description about both Groupedbar UI variants (the compact variant and the full variant), then specify what is special about the compact variant. Therefore it should starts with "The Groupedbar interface provides...", just like the description of Groupedbar Full variant in the previous line. Change-Id: I98bec4efce996b7f17461a8bb1504e80d70279c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113393 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-30tdf#140839 - TotD image sizeHeiko Tietze
Previous size of 100x120 has shown to be too small for thumbnails so we agreed on 150x150 Change-Id: Ia43bc424a164024e8a4ecf851cad3fab4f342e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113343 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-25tdf#134734 svx,sd: BackgroundFullSizeMichael Stahl
There is already a boolean SdPage::mbBackgroundFullSize, UNO property and ODF import/export, but curiously no trace of it ever doing anything. There is some mystery handling of SID_ATTR_PAGE_EXT2 there but in the dialog that is only handled for SVX_PAGE_MODE_CENTER from Calc for a completely different purpose. Move mbBackgroundFullSize to base class SdrPage so that ViewContactOfMasterPageDescriptor can access it to paint. There's an oddity in the handling of the property where the dialog works on the master page and not on the current slide, not sure why it was implemented this way. Change-Id: If6e1329e3f77e0a1a7226d5e51ceb221ea86c401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112783 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-25tdf#134734 tdf#141059 tdf#122508 cui,sw,xmloff: BackgroundFullSizeMichael Stahl
* add BackgroundFullSize property to PageProperties * add a checkbox on the SvxPageDescPage * marshal the item via SfxGrabBagItem to avoid changing svxids.hrc * add RES_BACKGROUND_FULL_SIZE item, pool default is "true" which is appropriate for Word import filters * ODF export: remove hard-coded export in XMLPageMasterExportPropMapper::ContextFilter() * use it in SwFrame::PaintSwFrameBackground() * fix painting of bitmaps by also using the page frame area in SwFrame::GetBackgroundBrush(), which was the reason why f006b6339e20af6a3fbd60d97d21590d4ebf5021 painted things inconsistently * force repaint in lcl_DescSetAttr()/SwFrame::UpdateAttrFrame() Change-Id: I4cb64f87c01d17c051936e9b8128395fbb8b4fe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112594 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-24QR Code Dialog: Change term 'border' to 'margin'homeboy445
This adds a margin around the qr code (white space), not a border. Change-Id: If3e74dfe19dd7f9c063eaa6439810d617a99cb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112831 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-22tdf#137925: UI:Preferred user interface rearrangedAyhan Yalçınsoy
Change-Id: I9fe39064093a14917810aecaefdf8b75448f130f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112674 Tested-by: Jenkins Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Eyal Rozenberg <eyalroz1@gmx.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-21update pchesCaolán McNamara
Change-Id: I60e61133c305673bb305e41957f5414820c7c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21Fix GenerateQRCode when ENABLE_ZXING is not definedChristophe JAILLET
Since commit 562d7767f987, 'GenerateQRCode()' returns a OString, not a OUString. Fix the case where ENABLE_ZXING is not defined. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Change-Id: I29d9c559401b49caceb8a8941bbe9962b489e3f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-21Avoid OUString-to-OString conversion: just generate OStringMike Kaganski
Change-Id: Ied47aa0ca42a73715678482424d7d593d18d25aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-20tdf#139778 Switch to ZXing for generating QR codehomeboy445
Change-Id: Ief944266d5183bb862afe99ec6b0bdaca4956938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112534 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-20cid#1473926 Uninitialized scalar variableCaolán McNamara
Change-Id: I75911b7eff074b684a7f9c854fe8e63d102ae01a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112780 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-18tdf#139667 update Styles Inspector and tip of the day to "List Style"Seth Chaiklin
For Tip of the Day + add uri to Bullets and Numbering help page for tip about "Insert Unnumbered Entry" + adjust tip for applying List Style to tables, and add link to "List Style" help page. For Styles Inspector * change "Numbering Style" to "List Style" For Customize dialog ( sw/inc/strings.hrc ) * change "Numbering" to "List" for Style_Family Change-Id: Id43988490a61437d0068ea22a2bf3b0841b6ad42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110139 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-18Drop duplicate 'using namespace' directiveMike Kaganski
Change-Id: If235c37cf52cfbfd171a6d1784cf5940c162332a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112618 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-30 22:27:09 +0000