summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-08-25tdf#127802 support tristate for hidden/unhidden textCaolán McNamara
Change-Id: I9a8ad72ae3ee45ac2521e662b17d3d22d98aa055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25tdf#133026: Additions: Set label of install button for installed extensionsYusuf Keten
Change-Id: Ic45f5684c1b483e294179e151d6beec34de2e004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101297 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-25tdf#135997: properly check loop conditionMike Kaganski
It should break when any of iterators reaches end, not only when both. Introduced in commit 710a39414569995bd5a8631a948c939dc73bcef9. The crash dump from the bug report points to one of these lines; this is a blind fix, since I cannot reproduce myself. Change-Id: Ie7f6b827256cdb7061901dc9b2ae5ee8e0222a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-25Colorpicker Dialog fix spacing according to Dialog HIGandreas kainz
Change-Id: I9864aa8915b482596671957e686ef06c76b7712b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101295 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-08-24tdf#136067 left align GtkMenuButtons contentsCaolán McNamara
most already are, align the rest too and have for gtk "fill" the label widget Change-Id: I6f75c5c6ebaad0d2e3301854882aeaf3eab8580b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24restore translatable="no"Caolán McNamara
Change-Id: I42b46c0cada25703e8e9600533a220252796457e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24tdf#133026: Additions: Rating image implementationYusuf Keten
Change-Id: Id250f0e70490941743e0f3ca2b94897f69a9208f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101013 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-24Fix typosAndrea Gelmini
Change-Id: I9385704bea54ff504457f7ac1ec39ed98cfdaf97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101276 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-24tdf#133026: Additions: Install Extension FunctionYusuf Keten
Change-Id: Ifcad25a85533833c7d05e5be46ea763e1eeaa5d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100714 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-24cid#1466264 Dereference null return valueCaolán McNamara
Change-Id: Idb2543b811cc5081e34ab3d1cc3aaa44399162ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21Resolves: tdf#135128 should get the old attr, not the default attrCaolán McNamara
so we retain the original shadow distance if its not changed but the color is. Use GetOldAttr which is intended for that. Change-Id: I2d4b5a5b035c94cd8f2cc8f73bd239fab85b945f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21tdf#118148 All extended tips for shared/optionenOlivier Hallot
Extended tips extracted from <ahelp> in all remaining shared/optionen help pages Change-Id: Id35ce9d51ebf0f7fbe1b399ccabbf85a2c145f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99825 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-08-21tdf#118148 Extended tips for optfontpage.uiOlivier Hallot
Help file extracted: shared/optionen/01010700.xhp relevant translation hooks (parid's): -------8<---------- <?xml version="1.0" encoding="UTF-8"?> <nodes> <bookmark>cui/ui/optfontspage/OptFontsPage</bookmark> <bookmark>cui/ui/optfontspage/@@nowidget@@</bookmark> <nodeahelp> <parid>par_id3153665</parid> <hid>cui/ui/optfontspage/replacements</hid> <contents>Substitutes a font with a font of your choice. The substitution replaces a font only when it is displayed on screen, or on screen and when printing. The replacement does not change the font settings that are saved in the document.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/usetable</bookmark> <nodeahelp> <parid>par_id3159413</parid> <hid>cui/ui/optfontspage/usetable</hid> <contents>Enables the font replacement settings that you define.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/checklb</bookmark> <nodeahelp> <parid>par_id3154073</parid> <hid>cui/ui/optfontspage/checklb</hid> <contents>Lists the original font and the font that will replace it. Select Always to replace the font, even if the original font is installed on your system. Select Screen only to replace the screen font only and never replace the font for printing.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/font1</bookmark> <nodeahelp> <parid>par_id3151176</parid> <hid>cui/ui/optfontspage/font1</hid> <contents>Enter or select the name of the font that you want to replace.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/font2</bookmark> <nodeahelp> <parid>par_id3149560</parid> <hid>cui/ui/optfontspage/font2</hid> <contents>Enter or select the name of the replacement font.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/apply</bookmark> <nodeahelp> <parid>par_id3145750</parid> <hid>cui/ui/optfontspage/apply</hid> <contents>Applies the selected font replacement.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/delete</bookmark> <nodeahelp> <parid>par_id3148576</parid> <hid>cui/ui/optfontspage/delete</hid> <contents>Deletes the selected font replacement.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/fontname</bookmark> <nodeahelp> <parid>par_id3146990</parid> <hid>cui/ui/optfontspage/fontname</hid> <contents>Select the font for the display of HTML and Basic source code.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/nonpropfontonly</bookmark> <nodeahelp> <parid>par_id3154362</parid> <hid>cui/ui/optfontspage/nonpropfontonly</hid> <contents>Check to display only non-proportional fonts in the Fonts list box.</contents> </nodeahelp> <bookmark>cui/ui/optfontspage/fontheight</bookmark> <nodeahelp> <parid>par_id3150323</parid> <hid>cui/ui/optfontspage/fontheight</hid> <contents>Select a font size for the display of HTML and Basic source code.</contents> </nodeahelp> </nodes> --------8<------ Change-Id: I87d9accd265cf2f13401f0f6456b28070bfcec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99755 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-08-21tdf#118148 Extended tips for optgeneralpage.uiOlivier Hallot
help file extracted: shared/text/optionen/01010600.xhp relevant translation hooks (parid's): ------8< ------ <?xml version="1.0" encoding="UTF-8"?> <nodes> <bookmark>cui/ui/optgeneralpage/OptGeneralPage</bookmark> <bookmark>cui/ui/optgeneralpage/@@nowidget@@</bookmark> <nodeahelp> <parid>par_id3150085</parid> <hid>cui/ui/optgeneralpage/OptGeneralPage</hid> <contents>Specifies the general settings for %PRODUCTNAME.</contents> </nodeahelp> <bookmark>cui/ui/optgeneralpage/exthelp</bookmark> <nodeahelp> <parid>par_idN106FA</parid> <hid>cui/ui/optgeneralpage/exthelp</hid> <contents>Displays a help text when you rest the cursor on an icon, a menu command, or a control on a dialog.</contents> </nodeahelp> <bookmark>cui/ui/optgeneralpage/docstatus</bookmark> <nodeahelp> <parid>par_id3145800</parid> <hid>cui/ui/optgeneralpage/docstatus</hid> <contents>Specifies whether the printing of the document counts as a modification.</contents> </nodeahelp> <bookmark>cui/ui/optgeneralpage/year</bookmark> <nodeahelp> <parid>par_id3147530</parid> <hid>cui/ui/optgeneralpage/year</hid> <contents>Defines a date range, within which the system recognizes a two-digit year.</contents> </nodeahelp> <nodeahelp> <parid>par_id3167530</parid> <hid>cui/ui/optgeneralpage/collectusageinfo</hid> <contents>Send usage data to help The Document Foundation improve the software usability.</contents> </nodeahelp> </nodes> -------8<------- Change-Id: I83dfa9ed7e7905529bff317b2e4657ea2150a5b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99754 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-08-20Fix typo in codeAndrea Gelmini
Change-Id: I7c78c0fed4e92371ef7c6f4480227d4eca3a38fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101008 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-20Fix typo in codeAndrea Gelmini
Change-Id: Iebaf6a6d31a9819494205f7c838b78bcda1f7c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-19Make "Location" line stick to the bottom of the table of JREsStephan Bergmann
At least on Linux with SAL_USE_VCLPLUGIN=gtk3, this already happened to be laid out well, but e.g. on Linux with SAL_USE_VCLPLUGIN=gen and on macOS, there was blank space between the table and the "Location" line, and the latter was rather kept close to the following "Optional Features" section. (There still appears to be variance among the various backends how the two "Java Options" and "Optional Features" sections are spread out vertically when the dialog is resized.) Change-Id: I58ba9fc0e29916f0fa0efb7c3180da058ba72f0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100921 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-19tdf#135133: Don't try to read BuildVersionMike Kaganski
The option to set it was removed in 5fdf2009d21fa220dfee70ea755bd698c16257a7, and now the check is redundant - and even harmful until the remnants of the setting is dropped from bootstrap.ini. Currently the dummy value found there makes the About dialog miss the build id, and copying info to clipboard gives <buildversion> instead of proper build id. Previously the string was always empty in most builds (including TDF), which made the code proceed to buildid. Bootstrap::getBuildVersion got unused now, and is removed. Change-Id: If59e456655da29bb9421edc0e15d421829d0a02b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100957 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-18Remove code that has become nonsense over timeStephan Bergmann
The getToken call started out as > commit 6f9dff66ee12c3cf5874fd4a33b82dbb090fe124 > Author: Caolán McNamara <caolanm@redhat.com> > Date: Tue Jun 28 13:00:51 2011 +0100 > > break build id into multiple lines if using g log > > diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx > index 3157a9b48fd7..863bd90312fa 100644 > --- a/cui/source/dialogs/about.cxx > +++ b/cui/source/dialogs/about.cxx > @@ -72,13 +72,34 @@ Image SfxApplication::GetApplicationLogo() > return Image( aBitmap ); > } > > -/* intense magic to get strong version information */ > +/* get good version information */ > static String > GetBuildId() > { > rtl::OUString sDefault; > - String sBuildId( utl::Bootstrap::getBuildIdData( sDefault ) ); > - OSL_ENSURE( sBuildId.Len() > 0, "No BUILDID in bootstrap file" ); > + rtl::OUString sBuildId( utl::Bootstrap::getBuildIdData( sDefault ) ); > + //strip trailing - from ./g log > + if (!sBuildId.isEmpty() && sBuildId.getStr()[sBuildId.getLength()-1] == '-') > + { > + rtl::OUStringBuffer aBuffer; > + sal_Int32 nIndex = 0; > + do > + { > + rtl::OUString aToken = sBuildId.getToken( 0, '-', nIndex ); > + if (!aToken.isEmpty()) > + { > + aBuffer.append(aToken); > + if (nIndex % 5) > + aBuffer.append(static_cast<sal_Unicode>('-')); > + else > + aBuffer.append(static_cast<sal_Unicode>('\n')); > + } > + } > + while ( nIndex >= 0 ); > + sBuildId = aBuffer.makeStringAndClear(); > + } > + > + OSL_ENSURE( sBuildId.getLength() > 0, "No BUILDID in bootstrap file" ); > return sBuildId; > } > presumably at a time when utl::Bootstrap::getBuildIdData returned multiple git hashes for the split repositories back then, separated by dashes. Then > commit 8a3aae9b694deb2b41157509e84815a5b7fb7655 > Author: Andrew Higginson <at.higginsonAtgmail.com> > Date: Tue Apr 10 12:43:48 2012 +0100 > > Resolves: fdo#31022 about dialog is suboptimal > [...] > diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx > index 3ee3e8fad261..a4352e1dd396 100644 > --- a/cui/source/dialogs/about.cxx > +++ b/cui/source/dialogs/about.cxx [...] > +rtl::OUString AboutDialog::GetBuildId() > +{ > + rtl::OUString sDefault; > + rtl::OUString sBuildId(utl::Bootstrap::getBuildVersion(sDefault)); > + if (!sBuildId.isEmpty()) > + return sBuildId; > + > + sBuildId = utl::Bootstrap::getBuildIdData(sDefault); > + > + if (!sBuildId.isEmpty()) > + { > + sal_Int32 nIndex = 0; > + return sBuildId.getToken( 0, '-', nIndex ); > + } > + > + OSL_ENSURE( !sBuildId.isEmpty(), "No BUILDID in bootstrap file" ); > + return sBuildId; > +} [...] changed that to only use the first dash-separated part of utl::Bootstrap::getBuildIdData. The commit (and the corresponding <https://bugs.documentfoundation.org/show_bug.cgi?id=31022> "EasyHacks: 'About dialog' wording and layout are suboptimal") is vague on why it did that, but maybe the value returned by utl::Bootstrap::getBuildIdData had meanwhile been reduced to a single git monorepo hash value without any dashes anyway. Finally, > commit ab846145bbd56f4308c8657df8b1354a403edd74 > Author: Heiko Tietze <tietze.heiko@gmail.com> > Date: Wed Apr 29 11:39:57 2020 +0200 > > Resolves tdf#132322 - Link to Gerrit hash reintroduced > > Mulit-line label split, Build realized as link_button > > Required changes also solve tdf#132066 partially as many > localized strings are not anymore copied to clipboard > > Change-Id: I346fdc65cd1734f17854eccd587fe0b7e216e720 > Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93119 > Tested-by: Jenkins > Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> > [...] > diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx > index ed58d06acc1c..845ad5496a37 100644 > --- a/cui/source/dialogs/about.cxx > +++ b/cui/source/dialogs/about.cxx [...] > +OUString AboutDialog::GetBuildString() { > [...] > + OUString sDefault; > + OUString sBuildId(utl::Bootstrap::getBuildVersion(sDefault)); > + if (sBuildId.isEmpty()) > + sBuildId = utl::Bootstrap::getBuildIdData(sDefault); > + if (sBuildId.isEmpty()) { > + sBuildId = sBuildId.getToken(0, '-'); > + } > + OSL_ENSURE(!sBuildId.isEmpty(), "No BUILDID in bootstrap file"); > + > + OUString sBuildStr; > > if (!sBuildId.trim().isEmpty()) { [...] > + sBuildStr = CuiResId(RID_SVXSTR_ABOUT_BUILDID); > if (sBuildStr.indexOf("$BUILDID") == -1) { > SAL_WARN("cui.dialogs", "translated Build Id string in translations " > "doesn't contain $BUILDID placeholder"); > sBuildStr += " $BUILDID"; > } [...] > + sBuildStr = sBuildStr.replaceAll("$BUILDID", sBuildId); > } > + return sBuildStr; > +} apparently made two mistakes: For one, it dropped the early returns, so that cutting at the first dash would also be done for a non-empty value returned from utl::Bootstrap::getBuildVersion, and not only for the value returned from utl::Bootstrap::getBuildIdData. But for another, it lost the "!" negation, so that if (sBuildId.isEmpty()) { sBuildId = sBuildId.getToken(0, '-'); } is dead code now. The best solution for this mess is probably to just not attempt any kind of cutting at a first dash. Change-Id: Id801bb5995325e4d6cc6f8d257afe1af64ef12bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100961 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18loplugin:unusedvarsglobalNoel Grandin
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17Always display highlighted JRE's locationStephan Bergmann
...when opening the Advanced options page and after adding a new JRE via the "Add..." button, not only after highlighting another JRE line. (I suspect this broke with 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03 "weld SvxJavaOptionsPage" towards LO 6.4.) Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16tdf#133026: Additions: Set the maximum length for extension nameYusuf Keten
Change-Id: I52c6fe32e7737e1e0160cfd585d8616a035320c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100657 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-16tdf133275: Additions: Sorting menu ui implementationYusuf Keten
Change-Id: I41b0887d0bc6bf4618bd1cf9afd06f4b1ddbabb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100778 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13Remove some unused includesMiklos Vajna
Change-Id: Iea6b931b1f2328886354f70ad81a3e07367db717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-13tdf#133026: Additions: Install Button HandlerYusuf Keten
Change-Id: If4e9b192557b6c9f56bd04ccf9f6a5a8273d7515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100340 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-13loplugin:stringstatic also look for local staticsNoel Grandin
Add some API to O*StringLiteral, to make it easier to use in some places that were using O*String Change-Id: I1fb93bd47ac2065c9220d509aad3f4320326d99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12cleanup some unused leftoversCaolán McNamara
Change-Id: I5971ec431471c528c33b2f3a3f2353a3a825f286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12fix memory leaks in CuiConfigGroupListBoxJim Raykowski
Change-Id: I47dab54764de24bccc42513373b65657c241a8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-11tdf#135442 min supported version of gtk3 is 3.18 not 3.20Caolán McNamara
Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11tdf#135313: Crash on opening the tight integration dialogYusuf Keten
The crash problem in MacOS and Windows is fixed. Change-Id: I2968880b77f723f2caf6dc77f4904411392c4008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100449 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-10Resolves: tdf#135603 crash on rename item in customize dialogCaolán McNamara
Change-Id: Ib5b04ec8ce974c87646b6bf4989094c8334a0006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08Clean-up of abstdlgHeiko Tietze
Unnecessary functions regarding the about dialog removed Change-Id: I739a6b1383a0096ec46e2316da3c5327dafe1675 Follow-up to 39e83e2e4257c56adef13ed1dfeee013a4f45376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99985 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-07tdf#133071 DOCX import: fix vertical alignment to bottom page marginTibor Nagy
The relative vertical alignment (top, center and bottom) of bottom page margin wasn't handled. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ib41a8790f88ef004390787e3673a209dadd86457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100170 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-07tdf#133026: Additions: Disable install buttons of the existing extensionsYusuf Keten
If the extension exists, the install button will be disabled. Change-Id: Ide88faeabe86d9cdb6a3cb99257710d92e3b4769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99809 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-05tdf#135367 enable_toggle_buttons sets SvTreeFlags::CHKBTNCaolán McNamara
designating that the special auto-sized toggle column is in use Change-Id: I23aa927c56e706590f397d15ef7329d20e0b18a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100136 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04tdf#134420 select neighbour when deletedCaolán McNamara
Change-Id: I55c6135360d3d77b7b3d2e54012ad82e1a4813ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04loplugin:simplifybool a little more aggressiveNoel Grandin
with expressions like !(a && b) Change-Id: Id2acec2a8d0eaaa8e5e37dbd2cae7281be36572e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03correctly mark the "New menu" dialog as modalMarkus Mohrhard
The dialog is called from a modal dialog which means a modeless dialog does not make sense. Some of our internal dialog tracking code is confused by that case which confused the UI tests. Change-Id: I705877e8a751c55bfbd00ddeaf18ab86c95321c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99944 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03Clean-up of abstdlgHeiko Tietze
Unnecessary functions removed Change-Id: I32dab4b4c5fe8ff351277cbbd32e0b462443d031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99959 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-01Reliably set up controls of hyperlink dialog in constructorStephan Bergmann
The recently added test_insert_hyperlink in sw/qa/uitest/writer_tests3/hyperlinkdialog.py (UITest_writer_tests3) has often failed on slow builds like <https://ci.libreoffice.org/job/lo_ubsan/>, by hitting the assert in rtl_uString_newFromSubString as described at <https://lists.freedesktop.org/archives/libreoffice/2020-July/085594.html> "Race with SwEditWinUIObject::get_state during UITest_writer_tests3?" However, it turns out that the actual race is rather different from what was assumed there: The initial content of the dialog's controls like "target" and "indication" were only set during the first SvxHlinkCtrl::StateChanged(SID_HYERLINK_GETLINK), which is called from the SfxBindings machinery based on a timer. When that happens, any text that has already been typed into those controls by the user would be overwritten again. But in normal GUI operations, the timer fires so quickly that the user has not yet typed anything into those controls. On the other hand, for a typical (fast) execution of test_insert_hyperlink, the whole test has already been executed when the timer fires, so the overwriting is not noticed. But for a slow execution of the test, the timer may e.g. fire after the "indication" control's content ("link") has been typed in (which SvxHlinkCtrl::StateChanged will reset to the empty string) and before the dialog is closed (so instead of "link", the empty string will be added to the Writer document, and obtaining the text selection of length 4 will crash as described in the email). (Also, the two calls to wait_until_property_is_updated added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid any timing issue in test_insert_hyperlink" and 1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with test_insert_hyperlink" probably just address other symptoms caused by the same underlying issue, and should no longer be necessary with this fix. But cleaning that up is left for a follow-up commit.) The solution is to set up the controls' initial content already in the constructor, so when the SfxBindings timer fires for the first time, it no longer calls StateChanged because that state has already been recorded. However, that caused the focus no longer to be set to the "target" control when the dialog is opened, at least for the gen and svp VCL backends (which caused the .uno:HyperlinkDialog-related tests in desktop/qa/desktop_lib/test_desktop_lib.cxx, CppunitTest_desktop_lib, to fail because GetFocusControl returned null): The first call to SvxHlinkCtrl::StateChanged -> SvxHplinkDlg::SetPage now happens during the constructor, before the dialog is shown, so the request to grab the focus in SetInitFocus was ignored. The solution to that problem is to shift setting the initial focus to the first call of SvxHpLInkDlg::Activate, which is called whenever the dialog gains focus. Change-Id: Ib4d5e06dfc21014ccec546565426fa2d27e63ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99903 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-31Resolves tdf#132066 - Localization of special text in about windowHeiko Tietze
Copy all version infos in English Follow-up to 56b2214c3aa40c2e2522eba5584063fb34e003ba Change-Id: Id093305261ec957137c56f61048c660e80e5c795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99773 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-31tdf#135321: fix crash when right click empty in Command listJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=163797 Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d54202ff690e4e97e018461cc6dc3dfadd36a702 author Sarper Akdemir <q.sarperakdemir@gmail.com> 2020-02-14 13:17:46 +0300 committer Muhammet Kara <muhammet.kara@collabora.com> 2020-02-28 18:32:54 +0100 commit d54202ff690e4e97e018461cc6dc3dfadd36a702 (patch) tree 5f60f9c473b30e0f59bbf13a6f773595e1e4e759 parent 531f078f3371e909b03b358bc5c9d70df083555f (diff) tdf#112135: Provide controls through context menu in lists of Customize dialog Change-Id: I73031811257e1d128bb6bdc11c481f7a63bbc05e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99850 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-29replace and drop SvtExtendedSecurityOptions classCaolán McNamara
Change-Id: Ibe3443531c83eb44080217b61f5746be9cce9c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29replace and drop MiscCfgCaolán McNamara
Change-Id: I5ea9e3663fc5d30d725cf18757badb9b9802da18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29Removed duplicated includeAndrea Gelmini
Change-Id: Icb8d98103b40574f7120e2c93c03e4147cd9b5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-14 20:38:48 +0000