summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2023-11-18tdf#157716 - Rename "Language settings" to "Languages and Locales"t-aswath
Change-Id: Idd31b18c87998b03d884e7aa17197c459241abf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159315 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-11-18Related tdf#49895: Mark strings as translatableTaichi Haradaguchi
...and add context strings Change-Id: I2531fc9e24db7e99b440b8042b8a502a2faaa2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159567 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-11-17tdf#154543 - Paragraph dialog: reset snap to grid to parent settingAndreas Heinisch
Added the SID_ATTR_PARA_SNAPTOGRID to the alignment ranges in order to reset the snap to grid option to the corresponding parent setting. Without this parameter, the main dialog does not have any knowledge about this option. Change-Id: Ib090fae0919be54dd41674d129f5355c3566a90c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159565 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-11-16tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyNameMichael Stahl
* officecfg: deprecate Inet::Settings::ooInetFTPProxyName/Port * ucbhelper: stop handling these settings * sfx2: remove SID_INET_FTP_PROXY_NAME and SID_INET_FTP_PROXY_PORT and usage from SfxApplication::GetOptions() * shell: remove proxy config code from backends * stoc: the JavaVM would have its "ftp.proxyHost" properties set based on officecfg values; remove that * sysui,vcl: remove protocol from KDE desktop files and file picker Change-Id: Iba02676cf6e519e2fa60ba925209436d38e75f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159500 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16tdf#146386 cui,sc,sw: Office::Common::Filter::HTML::Export::LocalGraphicMichael Stahl
Adapt its usage to removal of FTP UCP; the target protocol check in sc and sw was particularly silly. Change-Id: Ib94501ebcc589e257e9b882a340e18ef1a791584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16Format optaboutconfig with clang-formatSamuel Mehrbrodt
Change-Id: Ia696e096f972fe722920238c3710d20a3f03b221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159374 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-16expert config: Proper editing support for numbersSamuel Mehrbrodt
Change-Id: Ib97e027cedfdf2c5bb3c956aeee75af25198e498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159355 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-15tdf#157992 update error position after modifying inputOliver Specht
a manual fix in the text changes the start/end position of the error that needs to be updateed to find the correct error text when applying the change Change-Id: I91b0801d5a08ee9e2508493cce03b8112c48a542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159449 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-15tdf#157518: add password strength meter to setmasterpassworddlgSarper Akdemir
Moves PasswordStrength bits that provide utility functions from cui to svl, merging them with PasswordHelper there. Adds password strength bar for the set master password dialog. (accessible via Tools -> Options -> LibreOffice -> Security -> Passwords for Web Connections) Change-Id: I8dc1090a041f8388c2e139beb1d0d9a0beb8acb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159370 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-11-15loplugin:unusedmethodsNoel Grandin
Change-Id: I1e125bbd388953491b3f869641484fea737d39ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-14loplugin:unusedfieldsNoel Grandin
Change-Id: I5869e9974c37b1b525d316367f1dc5051d8aa197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-13Related: tdf#157837 - UI: Part 3 - Unify lockdown behavior of OptionsBalazs Varga
dialog for View Page. Change-Id: I78239ce7ad7b133eaaa3d42a0f424ed0250cb47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159359 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-13Fix old TODO: Remove the parameter bCheckImmediately from SvxNameDialogSamuel Mehrbrodt
Change-Id: I47a6e82bab3306e8fddb8002740339dbb1965a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159213 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-13Use SvxNameDialog for editing config valuesSamuel Mehrbrodt
Instead of having a separate dialog which does the same. Change-Id: I3b20920fa1c68593b6787a01592621c7b02fa715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159209 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-13-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I6bc93f212c687c908e68b2fbbced03f19f40844e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-12Gtk-WARNING gtktreestore.c:1047: Invalid column number 6 added to iterCaolán McNamara
since: commit 985b404f208559b4a91f31eb31dafa9d0384fdaf Date: Wed Nov 8 21:34:41 2023 +0100 tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog for Language - Writing Aids Page. Change-Id: Iff9ab545a5d212d004b55f5ceab11d4c9f6dee5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159341 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12resave with latest gladeCaolán McNamara
Change-Id: If01a98195581399e92b31cfe7caa4782a0b246a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159340 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12resave with latest gladeCaolán McNamara
Change-Id: I18c9a7c7fc5e86ef7faebc7273ca3b33d54a340c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-12Gtk-WARNING Could not read property GtkBox:pack_type...Caolán McNamara
with value begin of type GtkPackType: Could not parse enum: 'begin' Change-Id: I27d74c4422eb4515c99a2ca834c62ef092ecf641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-11use more concrete type in ImpEditEngine::SetUndoManagerNoel Grandin
instead of dynamic_cast'ing to the type we want, and __ignoring__ the parameter if it is not, just adjust the type that we want, which luckily everything is already sending Change-Id: If083e11c9818cdcae199afc1261efbdb652e1c76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10loplugin:fieldcast in SvxNewTableDialogWrapperNoel Grandin
Change-Id: Ia3efee04b725162e4812f1e419cc9d8e11b6d8f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-10tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialogBalazs Varga
for Language - Writing Aids Page. Change-Id: I25723fb616544cd6ee7d894c3ca1aa6742748a73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159186 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-09tdf#146386 cui: remove FTP UI, SvxProxyTabPageMichael Stahl
Change-Id: I0831b1d99052c1fa8f0be38bee08eb712a168445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-09tdf#146386 cui: remove FTP UI, SvxHyperlinkInternetTpMichael Stahl
Change-Id: Ib55d6609e0bea4033533e3211c04888e52b86bb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-09Use proper type in expert config dialogSamuel Mehrbrodt
In preparation for proper editing support for the different types. Change-Id: I7044ff100c9bfcca5fa8894ff4525a1aac692796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158028 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-09tdf#157431 Show description for expert config itemsSamuel Mehrbrodt
Change-Id: I7d0257c2e06ed384f90ca3b51a6d2549044f2cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157148 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-08Related: tdf#158004 - UI: Part 20 - Unify lockdown behavior ofBalazs Varga
Options dialog for Databases Page. Change-Id: I573479df8048a9ff4d4aedc9780cbe0395900526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159074 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-07tdf#158004 - UI: Part 20 - Unify lockdown behavior of Options dialogBalazs Varga
for Connections Page. Change-Id: I76510a893bb35e03e6401aeeb03971969cc42ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158989 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-07ITEM: Get away from classic 'poolable' Item flagArmin Le Grand (allotropia)
To understand this, some look back in history will be needed to see why it is as it is today. In some (reworked) comments 'poolable' is described as flag to hold Items in the ItemPool, also always having only one incarnation of each possible Item. This is not the original intention, but a side-effect. The reason is what the binary format in the office did: To save a document, the Objects & the Pool were saved, *not* individual Items *together* with the objects. The Pool was completely (binary) saved (and loaded) in one run. Temporary IDs were used to represent at the objects in file which Items were referenced. This *required* to have only one incarnation per item to have a minimal binary file size, thus this high effort was put into this. At doc load, the pool was loaded, all Items were set to RefCount 5000, the references from the objects were restored and then for each Item the RefCount was lowered by 5000 again and - if being zero - deleted. Items for UI were marked 'non-poolable' to *not* safe them with the document, so poolable was a flag to decide if that Info/Item was to be saved with the document - or more direct: if it is Model Data. Items are small, so if we prefer runtime it is okay to no longer being strict with this, anyways does not happen often and has only marginal memory effects - compared to runtime effects/savings. Other problems which this caused: One example is that objects in the UNDO stack were still in the pool, so e.g. deleted pictures were saved with the document despite no longer being used (!). That is the reason we have an UndoItemPool and a method MigrateItemPool to move stuff to that Pool when objects go to the UNDO stack - all of this is also no longer needed. Cleaning this up means to ideally have all items in the SfxItemSet, no longer at the Pool. The Pool should be reduced to a 'Default-Item- Holder' and a 'Slot-to-whichId-mapper'. This needs thorough cleanups/removals, but will be worth it because that massive simplification(s) will increase safety an runtime and make migrating to the goal of completely type-based ItemSet stuff easier for the future. Hopefully only view code in the office working with items will have to be changed for this. In this 1st step I already found that some 'compromizes' will be needed: - There are still Items that have to be at the pool to make the Surrogate-stuff working. This gives back all Items in a Pool of a type and is used in ca. 80 cases. Each one looks at these Items *without* context (e.g. a SfxItemSet at an Object would be a context), so if e.g. a dialog is open that temporarily uses Items of that type you would also get these - without knowing about it... To make that work there is still a mechanism to have Items at the Pool, but now just *registering* (and un-reg) them without any sort/search/ remove needs. Also only for Items that need that, so I evaluated the GetItemSurrogates calls and added some asserts when GetItemSurrogates tries to access an unregistered item type which needs to be added. - Another caveat is that there are about 250 places that directly put Items to the Pool (not all remove these, that is done at pool deletion, so some kind of silent 'garbage-collection' is in place). To have an overview I renamed the accessing methods to separate them from the same functionality at the SfxItemSet, which had the same names. An implementation does still add these directly to the pool, there is no way to cleanup those usages for now. In principle all these should be changed to hold the data at an SfxItemSet. I am still hunting problems. But you can build the office, all apps work (including chart) and you can do speed comparisons already. There are test throwing errors, so I hunt these now. It is hard to give an estimation about how much more changes/corrections will be needed. Completed adaptions to new registered Items at Pool, that reduces the failing tests. Still many that I need to hunt. Added stuff to work around that 'compromize' in ScDocumentPool: It overloads ::PutImpl of the pool to implement special handling for a single Item in SC, the ScPatternAttr. In former code that method was used from SfxItemSet and ::PutImpl at the pool directly, so it was only used in one place. I am not sure if it was used from the SfxItemSet functionality, but better offer it for now. To not waste too much runtime the callbacks depend on the boolean 'NewItemCallback' at the SfxPoolItem, it gets set for that single Item in SC and only then the callbacks trigger. I hope to get rid of those again, e.g. newItem_UseDirect is only needed since we have no 'real' StaticPoolDefaults currently - another thing that needs to be cleaned up in a next step. Since usages of impl(Create|Cleanup)ItemEntry and Direct(Put|Remove)ItemInPoolImpl got more and more similar I decided to unify that: move impl(Create|Cleanup)ItemEntry to tooling, make it globally available in svl and use it also directly for Direct(Put|Remove)ItemInPoolImpl. This slightly increases the failing tests again, but only since in Direct(Put|Remove)ItemInPoolImpl that fallback (e.g. tryToGetEqualItem) was used before, thus this is the same class of errors (SfxPoolItem ptr-compare) as the others which I will need to find anyways. Also fixed some missing stuff. Have now idenified and redirected all SfxPoolItem ptr-compares to be able to debug these - one cause for the remaining errors is probably that before with bPoolable those often were sufficient, but are no longer. Used the [loplugin:itemcompare] and a local clang build to do so, see https://gerrit.libreoffice.org/c/core/+/157172 Stabilized Direct(Put|Remove)ItemInPoolImpl forwards, added parameter to implCreateItemEntry to signal that it gets called from DirectPool stuff - currently needed. Hopefully when getting rid of that DirectPool stuff we can remove that again Added two more debug functionalities: - Added a SerialNumber to allow targeted debugging for deterministic cases - Added registering & listing of still-allocated SfxPoolItems at office shutdown Found PtrComp error in thints.cxx - POC, thanks to areSfxPoolItemPtrsEqual. Will hopefully help more with other tests Found some wrong asserts/warnings where I was too careful and not finding something/succeeding is OK, fixes some UnitTests for SC For SC I now just tried to replace all areSfxPoolItemPtrsEqual with the full-ptr-content compare SfxPoolItem::areSame. I also needed to experiment/adapt the newItem_Callback solution but got it working. Did that replacement now for SW too, found some places where the direct ptr compare is OK. Continued for the rest of occurrences, now all 160 places evaluated. Also done some cleanups. Massive cleanups of stuff no longer needed with this paradigm change. Also decided to keep tryToGetEqualItem/ITEM_CLASSIC_MODE for now. It is used for *one* Item (ScPatternAttr/ATTR_PATTERN) in SC that already needs many exceptions. Also useful for testing if errors come up on this change to test if it is related to this. Added forwarding of target Pool for ::Clone in SvxSetItem and SvxSetItem, simplified SfxStateCache::SetState_Impl and returned to simple ptr compares in SfxPoolItem::areSame to not do the test in areSfxPoolItemPtrsEqual. Debugged through UITest_calc_tests9 and found that in tdf133629 where BoxStyle is applied to fully selected empty calc the Item- reuse fallback has to be used not only for ATTR_PATTERN, see comment @implCreateItemEntry. Maybe more... Problem with test_tdf156611_insert_hyperlink_like_excel. Found that in ScEditShell::GetFirstURLFieldFromCell the correct SvxURLField is found and returned as ptr, but it's usage crashes. That is due to the SfxItemSet aEditSet used there gets destroyed at function return what again deletes the SvxFieldItem that is holding the SvxURLField that gets returned. This shows a more general problem: There is no 'SfxPoolItemHolder' that safely holds a single SfxPoolItem - like a SfxItemSet for a single Item (if Items would be shared_ptrs, that would be a safe return value). That will be needed in the future, but for now use another solution: Since I see no reason why EE_FEATURE_FIELD should not be shareable I wil change this for ow in the SfxItemInfo for EditCharAttribField. That way the Item returned will be shared (RefCnt > 1) and thus not be deleted. I changed the return value for GetURLField() and GetFirstURLFieldFromCell() in ScEditShell: At least for GetFirstURLFieldFromCell the return type/value was not safe: The SvxFieldItem accessed there and held in the local temporary SfxItemSet may be deleted with it, so return value can be corrupted/deleted. To avoid that, return a Clone of SvxFieldData as a unique_ptr. With all that UnitTest debugging and hunting and to get the paradigm change working to no longer rely on shared/pooled items I lost a little bit focus on speed, so I made an optimization round for the two central methods implCreateItemEntry/implCleanupItemEntry to get back to the speed improvements that I detected when starting this change. It was mainly lost due to that 'strange' chained pool stuff we have, so I added to detect the target pool (the one at which the WhichID is registered) directly and only once. Next thing to cleanup will/should be the pool and it's concept, all this is not needed and really costs runtime. Since implCreateItemEntry/implCleanupItemEntry are executed millions of times, each cycle counts here. Had an error in the last changes: pool::*_Impl methods use index instead of WhichID - most of them. Another bad trap, I really need to cleanup pool stuff next. Change-Id: I6295f332325b33268ec396ed46f8d0a1026e2d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157559 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-11-07resave with newer glade versionBalazs Varga
Change-Id: Id2c8977d6ab9d0632ac0350a78e52edba2280f4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158988 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-06tdf#149935 - Hyperlink Target Dialog: remember last used position and sizeAndreas Heinisch
Change-Id: I87fdf78b6ec4963eb4450d937dd86209e03865a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158879 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-11-06tdf#158002 - UI: Part 19 - Unify lockdown behavior of Options dialogBalazs Varga
for LanguageTool Page. Change-Id: Ib1255dd7a67eae7e9c1f2cf6da984ba614f3453a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158931 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-06tdf#157518: add password policy and strength meter to save with password dialogSarper Akdemir
Introduces new configuration options PasswordPolicy and PasswordPolicyErrorMessage. PasswordPolicy takes a regular expression. When set, it only accepts passwords that match that regular expression. PasswordPolicyErrorMessage is the label displayed when the password does not meet the PasswordPolicy. In the ideal case, it should contain an explainer of the PasswordPolicy, so the user is aware of the requirements. Save with password dialog had maximum password length enforcing bits depending on the requirements of the saved file format. These are still applicable in combination with the password policy. Also introduces a visual password meter under the password entries. If the password policy isn't satisfied the password strength meter is capped at 70%. The entropy bits to password quality is taken as a linear range. Where the range of [0, 112] entropy bits is mapped to percentage [0, 100]. Entropy bits ≥ 112 are mapped to 100% since, according to KeePass' info page, ≥ 112 entropy bits correspond to a strong password: <https://keepass.info/help/kb/pw_quality_est.html> Change-Id: I2e70adacf271916661219f702dfc217292a1b59f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158453 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-11-04tdf#158001 - UI: Part 18 - Unify lockdown behavior of Options dialogBalazs Varga
for Languages Page. Change-Id: I3f4cf27980dd6d06da13f554feaca192ebd0b671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158882 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-04resave with newer glade versionBalazs Varga
Change-Id: I8c11067d813c2331e5f9ceae1cb780c73b45e0f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158881 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03tdf#158000 - UI: Part 17 - Unify lockdown behavior of Options dialogBalazs Varga
for Chart Page. Change-Id: I374a0dc8ff43be490e64a7173963e04005aec7e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158852 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03resave with newer glade versionBalazs Varga
Change-Id: Ib6c6b3d5619a5f1e30b7d4f59184ec232224a7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158851 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03tdf#157862 - UI: Part 16 - Unify lockdown behavior of Options dialogBalazs Varga
for Load/Save - HTML Page. Change-Id: I8e9599c25eba62f7b82d8e3f56de031a1c6366fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158849 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03resave with newer glade versionBalazs Varga
Change-Id: I08920f6d2f19a689d71cd1045f9262bd165d4677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158848 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03tdf#157861 - UI: Part 15 - Unify lockdown behavior of Options dialogBalazs Varga
for Load/Save - MS Office Page. Change-Id: Ifd576e5030e49bef3c73f55f4d3f23eea34a45f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158837 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03resave with latest gladeBalazs Varga
Change-Id: I1a890cfbbd04262c1baf9d0dfc4b09a9498744d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158836 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-03tdf#157801 Fix direct formatting is applied after pressing OK in theJim Raykowski
Character properties dialog when the Highlighting tab Color page is open and the color has not been changed This is noticeable when character highlighting direct formatting is already at paragraph level. The expected result of opening the properties dialog, and immediately pressing OK without changing anything (or alternatively, after changing something there and then pressing Reset then OK), is no changes in applied properties at all. Inspiration for rework of the background tab page. With this patch XATTR_FILL items need not be included in the InAttrs set, for example, as part of this patch, the XATTR_FILLSTYLE, XATTR_FILLCOLOR range is removed from the sw_CharDialog core set. Change-Id: Ic2de53a29579c33820fc381d354a4afebe048a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158100 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-11-02tdf#157860 - UI: Part 14 - Unify lockdown behavior of Options dialogBalazs Varga
for Load/Save VBA Properties Page. Change-Id: I9526c2a5aa25fbdea1edbc0051d9b6a29c643d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158781 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-02resave with latest gladeBalazs Varga
Change-Id: Id4482f53a84e93f44c1a0cda2d20bf3ece48d44a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158762 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-02Drop SvxHtmlOptions::IsPrintLayoutExtensionGabor Kelemen
as it is just now a simple wrapper over officecfg Change-Id: If41c7c9db191af7ebede9072fd995d015056bf1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-01new loplugin:fieldcanbelocalNoel Grandin
Change-Id: I33fe8afcbba1d461bee98c92507c878e4e5d41d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-30tdf#157859 - UI: Part 13 - Unify lockdown behavior of Options dialogBalazs Varga
for Load/Save General Page. Change-Id: I8e02b1b1188f42903ee164ee9f7ddd9113c602bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158565 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27tdf#157854 - UI: Part 12 - Unify lockdown behavior of Options dialogBalazs Varga
for Internet Proxy Page. Change-Id: I2332d272905e12a235d7729c0565922ad98960f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158499 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27tdf#157853 - UI: Part 11 - Unify lockdown behavior of Options dialogBalazs Varga
for Advanced Page. Change-Id: I3ef33e98cd5a39313f51eb90682f20cdc172f042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158496 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-27tdf#157850 - UI: Part 10 - Unify lockdown behavior of Options dialogBalazs Varga
for Online Update Page. Change-Id: I48f66f786c165d3958d34cca17ee2837aa7a6c66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158490 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
generated by cgit (git 2.34.1) at 2024-04-28 10:22:15 +0000