summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2024-03-11Hide "Add and resize" button from numbering and bullets dialog for ONLINEDarshan11
- Image tab had "Add and resize" option for numbering and bullets dialog - which is not need in online - so we will just hide that browseBtn for online Change-Id: Ib87f1e7ae7e6df5256ab77122b477695a45cf441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164587 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2024-01-07Resolves: tdf#158965 Find Record: Similarities dialog doesn't appearCaolán McNamara
and assert in DBG_UTIL mode regression since: commit 36343165c251e30c700360cc5c4266f576d4ac00 Date: Wed Jan 25 11:07:28 2023 +0000 cui: Make SimilaritySearch dialog async and enable use for jsdialog Change-Id: Iee2071874836ccf8a1ab10fbc6d6b3c491fd04ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161633 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-12-20Don't use the same store 2 times in WidgetTestDialog uiSzymon Kłos
Change-Id: I0fb9d4dec83dc37038a85dfc0039c7ec1af3b82d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160952 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-10-19crashreporting: svx::SentenceEditWindow_Impl::CreateSpellPortions()Caolán McNamara
cui/source/dialogs/SpellDialog.cxx:2005 aRet[ aRet.size() - 1 ].sText += aLeftOverText; presumably aRet is empty() here a) don't bother appending if aLeftOverText is empty() b) don't crah if aRet is empty() and aLeftOverText is not Change-Id: Ie9a9585f572d8afb17183b479fb6f2cce5952aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158047 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 3c0db58e51a24bf08ca443af62489e761063f456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158152
2023-10-05Add NUMBERSIGN key handler.Gökay Şatır
German keyboard layout has number sign key. Users can print number sign without using modification keys. So this key can be assigned a shortcut. Subscript is assigned to CTRL + NUMBERSIGN. Below PR is used as reference when adding the new key handler: https://gerrit.libreoffice.org/c/core/+/86713 Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I340dc47764e9200d2477f8db740a629f62f48004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157554 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-09-25COWASM-02 - Fix wasm build for co-23.05Balazs Varga
"Undeclared identifier mpParent in GetParent()" Change-Id: Ib613b2cf303b0ac50c6e899deda25d99c7e22343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157245 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-09-18tdf#157138: Can't switch from Use Background to None area fillJulien Nabet
Revert partly tdf#151260 fix Change-Id: I4c052e2cd1cb41dc8bda4b388b46e4416e351434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156669 (cherry picked from commit b69e14038288387b5f288a06821fb5df66dcf94e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7ccaecd33a30905e3929d43c8164b16bbb101b73) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156741 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-15tdf#157148 ensure we auto-scroll to current location to make it visibleCaolán McNamara
Change-Id: I03286c10e488adf3a882fa7fe2813724f27c66f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156746 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-11Hyperlink dialog: hide some buttons in LOKSzymon Kłos
Change-Id: I55a4ca5921b44a7c091a3742a85f2c9da5a188a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156760 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
2023-09-08Enable QR and barcode dialog for onlineDarshan-upadhyay1110
- enable QR and barcode genration dialog for online - Change Qr code genration dialog to async Change-Id: Ia46b8e27a3002adcc893e5ef4c2545d7edcc3e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156642 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-09-01tdf#157034: FILESAVE loext:theme-type is off by oneJulien Nabet
nItemId begins with 1 but list of themes begin with 0 so decrement nItemId part of bt here: https://bugs.documentfoundation.org/show_bug.cgi?id=157034#c1 + adapt QA tests Change-Id: I7913ea0f71abb9ff98039a9c45a49fdb8f709ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156350 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 85aa230aebfe383eecdb4fc6704d093db8a18402) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156434 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-28sd: remove theme tab pageTomaž Vajngerl
Change-Id: Iffb3d0f6d6933891333da68fa4569a3638ba18f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156123 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f4ed90bcad83ea24644c1cbf077b369ae05f004e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156174 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com>
2023-08-28cui: use common menthod to get the complex color from a NamedColorTomaž Vajngerl
NamedColor implements a getComplexColor method, which creates the ComplexColor from the NamedColor attributes. We don't need to do this ourselves. Change-Id: If2629d49b7b2e561b85b93314f56a95492cafd93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155863 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3f7e9b2ea67a8de9ad9dd819ec2eb91e8180af95) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156166 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28Fix setting ComplexColor for lines/strokes through the dialogTomaž Vajngerl
Setting the line/stroke color through the (tab) dialog did not work as the complex colors was not set to the XLineColorItem. Change-Id: Ie1404264f2f82964fe3a5507a6f61ba269254134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155683 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 37203cb43758048134584f7d52efbc9b3dc59f65) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156160 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28ComplexColor various clean-up and (trivial) refactoringsTomaž Vajngerl
Don't allow access to member variables of ComplexColor and makes them private. Needs a lot of changes. Change "scheme" to "theme" to be more consistent. In LO we usually call the "theme color" what is usually refered to as "scheme color" in OOXML, where it is sometimes refered to as "scheme" and other times as theme color. Remove ThemeColor class which was replaced with CmplexColor some time ago. Remove un-needed includes and un-needed components. Use isValidThemeColor in many places where we check that the ComplexColor is of "Theme" type and that ThemeColorType is set to a valid value. Change-Id: I325595fa65b8e56a4707e9d22acc6330aac28961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155359 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9d5a7d9257db78eb3f4d77c39eae1affe877ea6b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156150 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-25tdf#101895 don't unconditionally default to ch[ar]/lineCaolán McNamara
if CJK typography is available. Given that we choose to show cm vs inch based on SvtSysLocaleOptions::GetRealLanguageTag() also choose to use ch[ar] and line based on that setting when bApplyCharUnit is enabled. Change-Id: I812d05e0639f7e214d5c3d4dcca01b0709126fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155949 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-09Re-enable Bullets and Numbering → CustomizeSkyler Grey
- Revert change If0f7b953a40ca1d5f469087cb8f362a949c39b37 - Enable jsdialog for the customize page - Fix numbering not being selected when switching level - Fix start at field not having a default when changing level type to one that can use it - Disable types that rely on supporting graphics in LOK as we cannot provide them Change-Id: I2517289b553b8a3e9ed62c64b6514c6aab3702b6 Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153806 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-11tdf#150408: Implement UI for "Legal" numberingMike Kaganski
Change-Id: I16849a2d823539040ecb91416b5214d25851950a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154287 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154334 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-06sw: border and background theme color support for multiple props.Tomaž Vajngerl
This adds support for theme colors for multiple properties that are stored in SvxBoxItem and SvxBrushItem / XFillColorItem. For those items the ComplexColor member variable was introduced. The UNO properties for the colors are added. The properties with the added support includes paragraph border and background + styles, page border and background, frame border and background + styles. The ThemeColorChanges has been extended to support changing the colors for those propertes. Color picker and tab pages have been fixed so they pass or set the theme color properties to the items. Change-Id: Id27272f5c4a448703a62a759d829e8a9540066e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152397 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit cc6db9f418cae422a4733163f85801c5a14f47c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152590 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-06-05prefix aPreviousColor and aCurrentColor in SvxColorTabPageTomaž Vajngerl
Change-Id: I631ce120d7a2825c6d170f4b25ffefdd155e04e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152396 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit d7d2b172065f90aa2f61c0216f3722e868ae76a1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152518 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-06-04tdf#153361 improve theme color generation in color pickerTomaž Vajngerl
The theme color generator needs to take color luminocity into account, so that the very dark or very light colors are properly shaded. Otherwise a too dark color will generate a too dark (almost black) color variant, or a too light a too light (almost white) color variant. However those colors aren't useful. Change-Id: Id803a8f6f1a79cbc822ed2d7faca9bec228c0188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152237 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e6215c7233c0fb437a81b51c8a8a30bb53eef65f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152517 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-06-01svx: combine svx::NamedThemedColor into NamedColorTomaž Vajngerl
Change-Id: I9a9656ddce9c12564411cfcb3e8e8714ae74a418 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152236 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9a4b768b0a22bd3ae627c7355bbd223b9cf65015) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152265 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-06-01svx: change NamedColor be a struct instead of std::pairTomaž Vajngerl
Change-Id: Ice1625e8cae8da859ea8a940b3f8e40f6f9d7037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152235 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8e87f1f2ff4df763e29bdc097786230c6293744b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152264 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-01use ComplexColor instead of ThemeColor for better OOXML compat.Tomaž Vajngerl
In OOXML a color definition includes more represenations, one of which is scheme color (which is what is implemented in ThemeColor currently), but it supports other representations too (RGB, HSL, System,..). ComplexColor includes all the representations, so to have a better compatibility with OOXML, this changes all uses of ThemeColor to ComplexColor. In many cases the usage of ComplexColor isn't the same as the usage of ThemeColors, but this cases will need to be changed in a later commit. Change-Id: I9cc8acee2ac0a1998fe9b98247bcf4a96273149a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 1df0565fb92972bd410e7db85eef1e4bec3fcc31) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152234 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-25svx: use ComplexColor in SvxColorItem instead of the ThemeColorTomaž Vajngerl
ComplexColor includes everything a ThemeColor has and in addition also can have various other representations that are supported by OOXML. This is important for compatibility reasons to preserve the color information. Change-Id: I677775a96511dc1742c75b1949e002eaa8c622e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151226 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 900c3a2a854436fdbacd488ef1da12ea99fbceb0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152231 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-05-21MCGR: consolidations/cleanups for changes so farArmin Le Grand (allotropia)
Change-Id: I85cf40e4803b0485bb40349d8e81adc8123666c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151706 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-21Resolves: tdf#154958 add an empty spin button to use for the unused caseCaolán McNamara
instead of reusing the percentage one, which will set its min value under gtk Change-Id: I342f8f0588574c45c5752964b95232e419f752ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150944 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-05-18cui, lok: Hide options irrelevant for online in Spelling Options dialogAron Budea
User-defined Dictionaries part and Get more dictionaries URL + icon. Change-Id: I73825a481e1981145abbf36b44485fb1628fbe13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151212 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com> (cherry picked from commit 17e3aa456095cab2d9058f99f8523f080c0774e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151374 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-05-15MCGR: 2nd corrections/adaptions to MCGRArmin Le Grand (allotropia)
Adapted handling of 'border' argument from our gradients for oox export, so that it looks the same. Also added quite some cases to peserve in-between GradientStops for current UI implementations to be able to edit the gradients as usual without losing the in-between GradientStops. While we will not be able to modify these, we are at least able to modify all the other gradient attributes, including start/endColor. Done this for TransparencyGradients, too. Also moved more stuff to the gradient tooling in basegfx. Change-Id: I6e94011bbf3715baa1401ab97e5b59811298342f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150577 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-15MCGR: Model data changes for ColorStepsArmin Le Grand (allotropia)
Added tooling replaceStart/EndColor to allow simple transition for code that does not immediately adapt to multi color gradients. Also added createColorStepsFromStartEndColor for the same purpose. Adapted XGradient to no longer have Start/EndColor at all, but only use ColorSteps. Adapted all usages of XGradient to no longer use Get/Set/Start/EndColor, but access the ColorSteps instead. Replaced quite some XGradient constructors that used XGradient() as Start/EndColor since this is already the default. Adapted ColorBlending to black AKA Start/EndIntens in XGradient to work now on all ColorSteps in the required linearly-scaled manner. UNO API changes: Added com::sun::star::awt::ColorStep as basic data element that holds a pair of Offset and Color. Added com::sun::star::awt::ColorStepSequence to handle an array of sorted entries. Added com::sun::star::awt::Gradient2 derived from com::sun::star::awt::Gradient, extended by the needed com::sun::star::awt::ColorStepSequence. Added MID_GRADIENT_COLORSTEPSEQUENCE to UNO API to provide access to ColorSteps directly. Adapted XFillGradientItem::QueryValue/PutValue to make use of new UNO API data structures. To do so, added tooling methods for data transition: - fillColorStepSequenceFromColorSteps - fillGradient2FromXGradient - fillColorStepsFromAny - fillXGradientFromAny and adapted - case '0' (all data) - MID_FILLGRADIENT - MID_GRADIENT_COLORSTEPSEQUENCE - MID_GRADIENT_START/ENDCOLOR to make use of these. Tested usage of these in the office. Renamed from GradientStep to GradientStop after discussions with members on the list to make this closer related to other norms/definitions. Also renamed classes and class members to better reflect to GradientStop, so grepping/finding will be easier (e.g. 'Color' just exists pretty often, but 'StopColor' is more precise). Changed the used UNO API class for reprsenting the Color to better reflect to ranges [0.0 .. 1.0] and usage of RGB. Change-Id: I1eeb3e97e81d6785967615d1ff256551fc3b882d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148849 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-13tdf#154884: do not stop if the first pair is not what we looked forMike Kaganski
The same character can be added later with a different font, so keep searching Change-Id: I7b83438ca476ffab23ca08268cf957045d75f6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150937 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5a1d07a819bd0f14dd901b35ae245bcd681cb512) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150921 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-13Resolves: tdf#153441 use a TriStateEnabled helperCaolán McNamara
Change-Id: I976e4271a072bfb53c676091509e1d4ef7dbcccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150915 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-05-13Resolves: tdf#153958 Hyphenation crashes with -Alte...Caolán McNamara
nPos2 is 0 due to the -, so aLeft is empty, nPos is set to 0 then incremented to 1, aLeft.replaceFirst is run after its end pos so crashes/asserts. Presumably we can do nothing meaningful here so skip if nPos2 is 0 Change-Id: I09754c4b2567fe5c1b4c36de0b36ee99f575244d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150327 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-05-10Resolves tdf#155038 - Application Color is disabled with GTK3Heiko Tietze
Change-Id: If820e765f3477f4b5ec8609f2781f8f0ed06cd09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151093 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit d4d0921db42ef2cb0bf691b408da78f36ac4af88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151612 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-05-05Application color should follow system color patch backportParis Oplopoios
Patch https://gerrit.libreoffice.org/c/core/+/149059 removed dark mode and made application color follow system color. This patch backports that patch to co-23.05 and changes the tests to account for the new ways to change to dark mode. Change-Id: I49a99a73bce6cb26f8e8e2ab2f642483c9ee195b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151320 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-04-24Don't call CuiResId() in a global static variable initialiserTor Lillqvist
Instead, have a function that returns a reference to a local static variable. That local static is then initialised only when the function is called for the first time. Calling CuiResId() in a global initialiser is a bit questionable, and causes an uncaught exception when LO core is used in a WASM app. Possibly it would also have been problematic on other uncommon platforms. Change-Id: I4fd799ba3aa8d63fd3db1eb8cf6211aeed904ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147512 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 6f29310fe83873c7d6844cf5e3089ca981e147db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150149 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2023-04-21tdf#56258: allow i18npool to define SvxAdjust for outlineJustin Luth
This is a squashed commit, including pre-requisite commit b1226e1f225de4fa67a0d4f5a6aa4017284c7deb and follow-up commit 6cabd7d9bfed37799a344f872d5f8fcf3214116a Deciding whether the numbering should be Left, Right, or Center is a rather important setting. Specifically for Roman numerals (which grow very wide as they increment to 7 and 8) the numbering styles set these to right aligned. This really helps for keeping the text nicely aligned. The numbering styles are built-in LO defaults, but locale files can define numbering and outline choices. This patch add the setting for "adjust" on the outline levels. For en_US, it makes sense to right-align roman numeral levels. [The only other highly likely candidate for this that I could find was old Hungarian (SZEKELY_ROVAS), but it doesn't seem to be used in any locale definitions.] I only changed en_US for now, but of course many other locales are also using NumType="3" and NumType="4". This only applies to the toolbar/sidebar SVX code path. The Bullets and Numbering dialog does not currently modify any spacing, so I didn't apply the adjustment either. It also doesn't make sense to do this on single numbering changes (aka ContinuousNumberingLevels or LC_NumberingLevel) because we don't know or control the first line indent there either. But at least for toolbar Outlines, we do change every level, and so can set a (somewhat) appropriate spacing. [Setting SvxAdjust without adjusting the spacing is pointless. Don't make any changes at all if the spacing ends up causing problems.] The Numbering IVX/ivx styles set the firstLineIndent to -174, so I did the same here. This is the scariest part of this change. AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default, so hardcoding that for undefined LC_OutlineNumberingLevel shouldn't be too scary. Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150663 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-04-21tdf#56258 en_US: increase outline levels definitions to 6Justin Luth
This is a squashed commit that includes commit 894efac210a3871214d95a52c322b0bee40f00ba tdf#56258 i18npool en-US: partial revert 5th outline level There are 10 levels in numbering, so it only makes sense to allow outline definitions for all 10 levels. Note that DOC/X formats only allow 9 levels, There are two code paths that read these definitions. The SVX toolbar code to allow 10 levels (SVX_MAX_NUM) was already completed in the previous patch. This commit allows 10 levels for the Bullets and Numbering menu dialog. Since all choices MUST define the same number of levels, I only added one more. I hope that there isn't some secret kind of requirement that ALL LOCALE's must also use the same number of definitions - it doesn't seem to. [Although not a direct comparison, bg_BG defines 10 single number levels, compared to en_US's 8, and some Chinese locales also do more than 8.] Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150661 Tested-by: Justin Luth <jluth@mail.com>
2023-04-03tdf#154115 use correct column for searchCaolán McNamara
Change-Id: Iaa390e63d269221b7273fe15362cfbdf20f235da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1d2ad8e8823a8633534580d589270945f01f1ca1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149694 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#154296 Fix customize notebook bar regressionJim Raykowski
caused by commit e79741488cc740f49ebd4426c40b45e7139ff663 Change-Id: I04fe66124af831c73834b7f695458e1667198ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 48b7cf3182cc8fb0b728860f9cbb489390074101) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149600 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03tdf#153808 Fix numbering preview in dark modeRafael Lima
This patch fixes the color used for numbers and bullets in the preview of the Bullets and Numbering dialog in Impress. Currently the implementation causes the bullets and numbers to be rendered in white over a white background when using dark mode. The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of FieldColor and FieldTextColor. Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 3a4b32c9e1dfc56d9b00e3720834d21c9095f629) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149435 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-02Related tdf#129547 and tdf#154136: add COLON keyJulien Nabet
Change-Id: I17978dbb100fbfa6f6ddbbbdf96872076bc2a289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86713 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit e056c1ce10779b42ae17866913cf4db06b86a491) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149033 Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-23tdf#143660 Make color scheme names translatableRafael Lima
The color scheme names defined in UI.xcu are currently not translatable. This patch makes them translatable by mapping the names in the UI.xcu file to a translated string. Change-Id: I10ab3bbcc9b028955c3c179558f8040b3b1d6c9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145732 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins (cherry picked from commit 546ad5d17d3e363b75337c336cfb2b2f8acc55e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149244 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-03-22jsdialog: keep button under content in SpellCheck OptionsSzymon Kłos
Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-21jsdialog: enable spelling options dialogSzymon Kłos
and make it async Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-19Resolves: tdf#154087 update scrollbar range when search criteria changeCaolán McNamara
Change-Id: Iaf5f20c8952b15f3dcccb65277dadb171a705605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148607 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-12Hide Quickstarter from General options in Windows store appsMike Kaganski
In that environment, the shell:Startup shortcut created by us points to the quickstart.exe under Program Files\WindowsApps\<StoreSpecificAppDir>\program. The resulting shortcut can't launch, because of an inaccessible part in the path (the protected WindowsApps directory). So the feature does not work in the dialog. Windows store apps should advertise the Windows startup task in the manifest. Let's just hide the dialog entry in this case. A possible TODO would be to provide a button instead, which would open the Startup Apps system applet, similar to what we do for Default apps for file associations. Change-Id: Ieafdf6d23ced96506b01c6b3cf9fb12904696df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147735 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit bc9e978a5df5f2ee84b32d1a4a67d5e6eadb4e86) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147759 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2023-03-12tdf#150045 A few more supplemental labelsAdolfo Jayme Barrientos
Change-Id: Ifc0afe5c04145378b5fe32b12791c774d96f8a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146903 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 41c3c2dfaeee7fbd410fd76d4254ae9696a173a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148324 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
2023-03-12tdf#142942 Drop unused checkbox col in sw AutoCorrect opts dialogMichael Weghorn
While the extra checkbox column enabled by weld::TreeView::enable_toggle_buttons(weld::ColumnToggleType::Check) is used for the non-Writer case in the "Options" and "Localized Options" tabs in the AutoCorrect options dialog, they are not used in the case of Writer, where there are two columns of checkboxes handled separately ("[M]: Replace while modifying existing text" and "[T]: AutoCorrect while typing"). Before commit 714b2b617e9baef02510c482c6fd028e6e72acd8 Date: Tue Jun 30 15:03:31 2020 +0100 tdf#134270 rearrange so we know the final treeview width , setting column widths manually by calling `weld::TreeView::set_column_fixed_widths` would disable the extra space for the (unused) checkboxes (by setting `m_bDisableCheckBoxAutoWidth`). Since that commit, it no longer does, causing the separately handled real checkbox in the first visible column to be unnecessarily positioned further to the right in this dialog for Writer for the non-gtk case. Fix this by dropping the use of the unused checkbox column for the Writer case, i.e. the `bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and in `OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage`. The handling for the non-Writer modules (i.e. `!bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and `OfaAutocorrOptionsPage`) remains unchanged. Change-Id: If7bd216fc4efda506817cffb55230722bb2ac89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit abdb918f146ceb6ea7d310968a96cdeb6f801a8f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147437 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-12Revert "Mark ssXX and cvXX off by default in font features dialog"خالد حسني
This reverts commit 3f9a8a3b7656470cfcf04c18a46a7b7bbeca8950. Reason for revert: Needs more work, currently causes all ssXX and cvXX to be added to font string when the dialog is used. Change-Id: I07eff710a2813e60fa4de3c23eb0a3c31d40e41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147811 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-07-05 11:24:01 +0000