summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-10-10cui: avoid divide by zero in SvxNumberingPreview::PaintXisco Fauli
Just check for pActNum->GetLevelCount() > 1 as done later for nYStep See https://crashreport.libreoffice.org/stats/signature/SvxNumberingPreview::Paint(OutputDevice%20&,tools::Rectangle%20const%20&) Change-Id: I0e9518dafe50b2b10a83487e9247e2fd46f9decd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f171d9af9bb13ec037841d7c8aa11fcc628c303c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141056 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-02cui: fix crash in SpellDialog::SpellContinue_ImplMiklos Vajna
Crashreport signature: Fatal signal received: SIGSEGV code: 128 for address: 0x0 program/libcuilo.so svx::SpellDialog::GetNextSentence_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) include/com/sun/star/uno/Reference.hxx:114 program/libcuilo.so svx::SpellDialog::SpellContinue_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) cui/source/dialogs/SpellDialog.cxx:355 program/libcuilo.so svx::SpellDialog::ChangeHdl(weld::Button&) include/rtl/ustring.hxx:527 program/libmergedlo.so Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&) include/rtl/ref.hxx:208 program/libmergedlo.so Button::Click() /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/std_function.h:244 Change-Id: I2c7267118213ea7d915a28d77badf93f8ff75683 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140689 Tested-by: Jenkins (cherry picked from commit 9be24f694d42fc9cae55ed911e0dff7f729803f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140611 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ae1f8a426338770f0dd46c72553c405158415e65) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140761
2022-08-09tdf#119246: Dimensions dialog has wrong values in several fieldsJulien Nabet
Regression from a8dd49b9fc59371ff8edb31082bbd4f1b6179b1c Convert dimension lines tab page to widget UI Min and max should be -10000 and 10000 (in mm). Change-Id: I936857f4c10bd2b6fec7b0e492c069b88cc071dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit d39a6726b8583086215a4452ce6867eb20c118d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137524 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-06Resolves: rhbz#2081661 gtk-critical gtk_tree_view_scroll_to_cell assertionCaolán McNamara
Change-Id: I4c7c4caed907072ef3a73ccfafabe882d618fa0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133730 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-26tdf#136429: use FieldUnit value for min/max of some fields of numbering dialogJulien Nabet
Change-Id: I01428703a7bdb2090fd145e5373c37aff0d386ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133348 (cherry picked from commit 176021427fece6363df56022b63813e93505fdc2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133399 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-12Clean up unused translatable stringsAdolfo Jayme Barrientos
These icon themes no longer exist, and these items are ignored anyway since the list was made dynamic in tdf#63962, back in 2014. Change-Id: I5a4dd5001b449f94775447f22b726b99a4fe63ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132025 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 19c215e948678c5c8809df6ce8052122b32c97d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132037 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-04-06tdf#148397: Crash on font features dialog opening with EB GaramondJulien Nabet
bt: 0 0x00007f7ba5ef549c in rtl::str::acquire<_rtl_uString>(_rtl_uString*) (pThis=0x0) at sal/rtl/strtmpl.hxx:825 1 0x00007f7ba5ef8d45 in rtl_uString_acquire(rtl_uString*) (pThis=0x0) at sal/rtl/ustring.cxx:1199 2 0x00007f7b485757e3 in rtl::OUString::OUString(_rtl_uString*) (this=0x7ffc345a9f20, str=0x0) at include/rtl/ustring.hxx:252 3 0x00007f7b485fd1da in cui::FontFeaturesDialog::fillGrid(std::__debug::vector<vcl::font::Feature, std::allocator<vcl::font::Feature> > const&) (this= 0x7ffc345aa538, rFontFeatures=std::__debug::vector of length 43, capacity 64 = {...}) at cui/source/dialogs/FontFeaturesDialog.cxx:98 4 0x00007f7b485fcc83 in cui::FontFeaturesDialog::initialize() (this=0x7ffc345aa538) at cui/source/dialogs/FontFeaturesDialog.cxx:66 5 0x00007f7b485fc8b9 in cui::FontFeaturesDialog::FontFeaturesDialog(weld::Window*, rtl::OUString const&) (this=0x7ffc345aa538, pParent=0x6f2f748, rFontName="EB Garamond 12") at cui/source/dialogs/FontFeaturesDialog.cxx:28 6 0x00007f7b488f3165 in SvxCharNamePage::FontFeatureButtonClicked(weld::Button&) (this=0x6f0a620, rButton=...) at cui/source/tabpages/chardlg.cxx:1157 Revealed with 5afdcad4c0e7850b18996c549892b9360cd8973f Pass context and resource string down to boost::locale separately because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: I20b18c8f46014feb453f81d66dd7cb490124efa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132590 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins (cherry picked from commit ad3d2d1bc7e07f79a26841d89a85e94999a7c8ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132600 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-21Call corresponding base class method in SpellDialog::DeactivateMichael Weghorn
At a quick glance, the fact that `SpellDialog::Deactivate` previously did the same as `SpellDialog::Activate` looks like a copy-paste mistake; both were added in commit 5261417cbb3051b812164838d19c0f748573df45 Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog Change-Id: Ib06d19e46470141d5bfcfc7e790160c1879b6a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-21sw image dialog: fix fallback width/height for images with relative sizesMiklos Vajna
Make sure that we work with the up to date layout size of the image in the dialog, otherwise 80% shows up as 237%. Also fix SfxMacroTabPage::FillItemSet() to not put anything to the output item set when the macro table is empty, this way clicking OK in the image dialog results in an unmodified document when the user doesn't change anything. Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 9e8712ed6f9fb5dbd971e352a5709bd45fadc74f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131860 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-14tdf#146703 Rework previous fix to query extension metadataGabor Kelemen
to limit its error potential by encoding only the category string Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins (cherry picked from commit b1ec326619f7b91e56252b992159fd00bbff2ba7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128428 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-12tdf#146703 Fix URL encoding when querying extensionsGabor Kelemen
so that extension information files are properly downloaded such as: https://extensions.libreoffice.org/api/v0/Color Palette.json Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 348e0651cc5add15ac03b11dde08057cf33f9b16) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128246 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-10fix Options->LibreOffice->View->Visibility->Menu on Windows,Noel Grandin
impossible to set to Hide, regression from commit 131759a3db51140c21594308ed99c71aa7aba43a Date: Sun Jul 25 16:21:39 2021 +0200 use officecfg for menu options Change-Id: I5312be2963d15ab85c267ece073e52984b1a34de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 31872a382342060d6e1ecd9168b2a8c7a57d4717) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128152 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-09tdf#146423 don't set a size-request during a size-allocCaolán McNamara
and use a better width calculation Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128077 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-03changed CuiResId into SvxResId.Kiyotaka Nishibori
though some translation entries for tooltip for border preset images were in svx.mo, cui/source/tabpages/border.cxx referred the entries to cui.mo with CuiResId route, and the translations was not gotten. this commit is alternative change. Change-Id: Ica7a7ea71f7afe7044104b9d953f1b3edf9c2503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-02Bump copyright year to 2022Adolfo Jayme Barrientos
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169 (cherry picked from commit fb32c4d96141ccc1766fa4e39405130fcf409a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127848 Reviewed-by: Martin Srebotnjak <miles@filmsi.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-10Resolves tdf#145976 - Resizing issues with the macro dialogHeiko Tietze
Fill attributes removes; some spacing added to be HIG conform Change-Id: Ic45bab071db23498e98df5fbed34ee5a50df1390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126569 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 5b0707f66e2c49a11f3a23e3ec9940b26d881165) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126593 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-03Resolves: tdf#140254 don't expand the column with buttons if dialog expandsCaolán McNamara
Change-Id: Ic7ca17bb2df6de2107ddb7a2a935bf8b81d58607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-03some translations are searched for in the wrong .moCaolán McNamara
since... commit c895a6d8298a349784cd0aafff4bf518ac8d0a7d Date: Fri May 15 10:51:10 2020 +0200 Resolves tdf#132799 - Deleting of colors unclear Tooltips added for disabled states those ones are in cui.mo (CuiResId) not svx (SvxResId) Change-Id: I595bd5aadd8ead18291ff818405bec594c8d32db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126319 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-28tdf#145728 Update UI Strings about QR and BarcodeMing Hua
In commit d37a44a9ebdafec1435f98194417a1d8cc8208b5 (tdf#141193 Added support for bar codes in qrcode dialog box[API Change], 2021-10-29) which added support for one-dimensional "CODE_128" barcode in addition to the previously supported 2D QR code, the various labels and tooltips in UI were not fully updated accordingly. This commit should update all QR and barcode related UI strings to match the new status, mentioning both "QR and barcode" where emphasis or detail is desired, and just "code(s)" where brevity is desired. Also use one-word "barcode" instead of "bar code" everywhere for consistency. Change-Id: I4530e4ffee5155b12551d7b819031c3869d7ab2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125925 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit cf6823ea07047ad7681262e94721f88e768f5845) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125987
2021-11-27set png filter for import dialog in a more robust wayCaolán McNamara
Change-Id: Iec25e214b19e5a2ab8a7305aad307c3f03e67401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125946
2021-11-25tdf#145539 const OUString -> constexpr OUStringLiteralJeff Huang
Convert string literals defined as const char[] in header files to constexpr OUStringLiteral Change-Id: I69fdc34cfb663ff87fabc8efc72d6563aa23465b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124724 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-11-25remove unused defines and convert some to OUStringLiteralNoel Grandin
Also remove the associated links.txt entries Change-Id: I5028fab2feb828875a0b772418fc29cbdfe4ce72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-25loplugin:stringliteraldefine in cuiNoel Grandin
Change-Id: I3b0c8811b583d6edf48ccd7e368e50228e70c362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125480 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-24Border tab page: Use 'thin' widthSamuel Mehrbrodt
instead of random number Change-Id: I89f3be2d6bba02f1fbe52065fab81caded2656f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125699 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-24border tab page: Explain how thick lines areSamuel Mehrbrodt
Change-Id: I802c0736dde6d87c8548968cfa9ce0481aba4f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125700 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23cui, editeng, sw: WrdStt -> WordStartMiklos Vajna
Because I'm unable to remember if Stt is Start or Stat. Change-Id: Ie853c6e94e45c3e14e002a0218d11c61905a3180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125672 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-19Change About LO dialog to run asyncJan-Marek Glogowski
Change-Id: I7255a8510e4cf983ebab477cbdb7cdcf00dabc98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125512 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-19Reuse macros for AbstractDialogFactory_ImplJan-Marek Glogowski
Now that all the abstract dialogs are welded, update and rename the existing boilerplate macros, to cut down the C'n'P code size. Change-Id: Iff8f452ca3dfce9a63c4fb73ab3a5025566810e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125511 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-19loplugin:stringliteraldefine in toolsNoel Grandin
Change-Id: I348b9a844c009f9c19301baa76d31b12f67c6130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-16Related tdf#139031: add missing colonsIlmari Lauhakangas
Reporter mentioned a bunch of missing colons across the UI. Change-Id: I278d0ad7073fb399c979f0fc52adc306f51ae49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125147 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-15Resolves: tdf#140250 don't share adjustments between differerent spinbuttonsCaolán McNamara
Change-Id: Ib684c746ff3176cf45ea9364efc12f2d6dde1f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12call GetGetSpecialCharsFunction just onceCaolán McNamara
Change-Id: Ia2ea7b234216408f3209139fa57be8d6a0794ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125091 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-12Fix (mis-)uses of temporary O[U]StringLiteralStephan Bergmann
...as sub-expressions of ternary operators, which happened to keep compiling after 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String" and e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" because both branches are of the same type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling pointers to those temporary objects escaped the surrounding full expressions. This was found with an experimental build with VS 2022 with --enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking fix in the configure.ac detection code (which is forthcoming in a later commit) and flagged all these uses in ternary operators as error C7595 "call to immediate function is not a constant expression". That error looks bogus (and it also caused a false > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that compiler bug is fixed), but it nicely found all these cases that should arguably be cleaned up. Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-10add placeholder labels for gtkCaolán McNamara
Change-Id: I108816d264affff973d12428cad135edbf8fd7c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-09tdf#48622 Fix layout issue when "Custom" was selectedSamuel Mehrbrodt
Change-Id: Ie32a763b88cfc26b61d942214b16e008179d410c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124898 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-09Save with Glade 3.38.2Samuel Mehrbrodt
Change-Id: I238f8a5adee999fcaad09e8813742fba37a30396 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124897 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-08tdf#145128 "Perform file extension check" should be disabled if finalizedGabor Kelemen
Change-Id: I7181ab8dde28fd5580a90fb267b31eaffd6a9878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124567 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-11-05use more DECL_DLLPRIVATE_STATIC_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I224848cea217977088fe0643511660a7c99b7277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-05use more DECL_DLLPRIVATE_LINKNoel Grandin
to avoid unnecessarily exporting symbols Change-Id: I6855894d0166c300ced169e36861f38811baa48d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-04tdf#48622 Add new border line width defaultsSamuel Mehrbrodt
* Hairline (0.05pt) * Very thin (0.5pt) * Thin (0.75pt) * Medium (1.5pt) * Thick (2.25pt) * Extra thick (4.5pt) This unifies the default border line widths throughout the program. Users can still set any line width they want by chosing "Custom" in the "Border" tabpage. Also, existing documents won't be changed. The new defaults are just for newly added borders. Change-Id: I7af85dc189a688a749812824508c33c7814b50f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122683 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-11-03Upgrade mdds and liborcus to 2.0.0 and 0.17.0, respectively.Kohei Yoshida
Change-Id: I9e856fc2d61f1789a6f1702514837860539a0f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124573 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-11-02extract a ReorderingDropTarget for reuseCaolán McNamara
Change-Id: I0ae69bbf644e220e1bf3352d98eb4fd735167416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-01Removed duplicated includesAndrea Gelmini
Change-Id: I5414710ceee7a572173eae43c906e91e86b7a01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124433 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-01tdf#138698 remove/ignore 'distributed' if feature is unknownCaolán McNamara
which it is in dbaccess. Its is a calc feature added at... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I1e8856e2ab635d270a487f5a68ac5c386f46a080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124552 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-01Provide values for debug in cuiJulien Nabet
Change-Id: Ifda9ddae8c7ee946f01dfa0b6fc0bba59a9c8a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124538 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-30Related: tdf#145377 call select handler if restoring previously selected scriptCaolán McNamara
Change-Id: Ibab3e920e6830c86bb6bfba070f14ca8a153c25f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>