summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26More loplugin:unnecessaryparenStephan Bergmann
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-26cpp check, fix redundantAssignmentBán Róbert
Change-Id: I7cf826ecae59f501e1a240840d3ba186f2c65ed6 Reviewed-on: https://gerrit.libreoffice.org/43839 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-25cpp check, fix redundantAssignmentGábor Koruhely
Change-Id: I26d8353461d938e327baecf1ca0f529da45eb069 Reviewed-on: https://gerrit.libreoffice.org/43833 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-25Resolves: tdf#113378 wrong table border preset iconsCaolán McNamara
Change-Id: Ibb9d0bcab6720fd85d5d3e2ae82821ff1c003c5b Reviewed-on: https://gerrit.libreoffice.org/43820 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-25tdf#107569 Fix missing res/colorslider.pngMaxim Monastirsky
Change-Id: I83c719594a29cde8385a22793f17812e7d5c12bb Reviewed-on: https://gerrit.libreoffice.org/43796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-10-24loplugin:unnecessaryparenStephan Bergmann
...when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers. Change-Id: I81346edbef46cad72bf53a43f162a75d19b6c713
2017-10-24tdf#113001: Use real '+' and '−' icons for Customize dialog buttonsMuhammet Kara
Change-Id: I4084af0284e4b24126d6663dc4652f801034d41c Reviewed-on: https://gerrit.libreoffice.org/43727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-23loplugin:includeform: cuiStephan Bergmann
Change-Id: Ibd88b2ee4252733c5aeee97bec27f34b8e555364
2017-10-23Resolves: tdf#113355 need to explicitly call initial TwoFigureHdlCaolán McNamara
Change-Id: Ia328f9adf95eef6711d286c9bde5b9a6edbd9978
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20tdf#98212 make paragraph dialog alignment tab preview updateJim Raykowski
Change-Id: Ibd1d4f2c59bb832d6b2bba597e3f022c628e1887 Reviewed-on: https://gerrit.libreoffice.org/43577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-19Fix typosAndrea Gelmini
Change-Id: I101357736813bfd47fb15d347fd2c0a33133de56 Reviewed-on: https://gerrit.libreoffice.org/43506 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-18svx: remove pointless duplicate SdrFitToSizeTypeMichael Stahl
Change-Id: I7a59ecfdb8d09ecbc0b760003dbc453ac5646d1c
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-15tdf#112136: Resolve confusion of two 'Reset' buttonsMuhammet Kara
in the Customize dialog. Change-Id: I0703fccb45a3bac17890e481d6635872df7becd2 Reviewed-on: https://gerrit.libreoffice.org/43406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-05tdf#102053 make alt+a unique in hyperlink dialogYousuf Philips
Change-Id: Id41b7a2d7070fe05c561e8d43950284a78ca8f66 Reviewed-on: https://gerrit.libreoffice.org/43173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04tdf#112689 Replace chained O(U)StringBuffer::append with operator+ in cuiArkadiy Illarionov
Change-Id: I41392108792ee91e01e32eb88ef50f238c2d3717 Reviewed-on: https://gerrit.libreoffice.org/42996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02tdf#112677 Correcting buttons position in certificate path dialognigeldias
Change-Id: I80e00083e851cd3db44a3ca9391225657526bfe4 Reviewed-on: https://gerrit.libreoffice.org/43045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-10-02consistently apply std::unique_ptr to SvLBoxButtonDataCaolán McNamara
Change-Id: I307c9095aa562348ce1b9338203995d9d62eebb4 Reviewed-on: https://gerrit.libreoffice.org/43037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-01throw more useful uno::Exception'sNoel Grandin
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01simplify some OUString compareTo callsMuhammet Kara
to either startsWith or == or != Change-Id: I595dd9d89d32134827980c4ba10f88584430137d Reviewed-on: https://gerrit.libreoffice.org/42988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-30Related tdf#112393: avoid leak in SvxEditModulesDlg::CreateEntryJulien Nabet
by using unique_ptr bt: 0 0x00007fffee95a933 in SvLBoxButtonData::SvLBoxButtonData(Control const*) (this=0x55555c1c28d0, pControlForSettings=0x55555c1b9680) at /home/julien/lo/libreoffice/svtools/source/contnr/svlbitm.cxx:55 1 0x00007fff95cde826 in SvxEditModulesDlg::CreateEntry(rtl::OUString&, unsigned short) (this=0x55555c17f270, rTxt="Orthographe", nCol=1) at /home/julien/lo/libreoffice/cui/source/options/optlingu.cxx:1842 2 0x00007fff95cdf4dd in SvxEditModulesDlg::LangSelectHdl_Impl(ListBox const*) (this=0x55555c17f270, pBox=0x55555c19dc60) at /home/julien/lo/libreoffice/cui/source/options/optlingu.cxx:2004 Change-Id: I6f10d7adae4346b204e21bdaca16aacb2758003d Reviewed-on: https://gerrit.libreoffice.org/42962 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-28Remove dead code behind Calc "Live Data Streams" dialog's "scriptdata" buttonStephan Bergmann
...that has been disabled and hidden ever since 4c90ed782a09e2e4b8738b82028032c42d1a203d "Actually hide these two radio buttons (since there is no choice now)." This removes the sole user of SvScriptStream. (Unfortunately, removing the no longer needed #include <osl/process.h> from include/tools/stream.hxx triggered an avalanche of missing includes elsewhere.) Change-Id: I7b0e683b14c0eaf7f4737f62adc9d691826380c0 Reviewed-on: https://gerrit.libreoffice.org/42916 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-28tdf#112658: fix leak when calling TextEngine::SetAttribJulien Nabet
TextCharAttribList::RemoveAttrib lets a dangling pointer when release unique_ptr obj maAttribs[n] So retrieve a unique_ptr from the different layers until SentenceEditWindow_Impl::ChangeMarkedWord (SpellDialog.cxx). Change-Id: I734909dce86ec28d69c09b2a8c0fc4a6941f422a Reviewed-on: https://gerrit.libreoffice.org/42881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28Use sal_Int32 to stick with other SetAttrib methodsJulien Nabet
+ use size_t GetUndoActionCount like other existing ones Change-Id: Ibfae20e7fd75df980f395e055063f0bdba1047f7 Reviewed-on: https://gerrit.libreoffice.org/42873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28simplify Bitmap operator==/IsEqual (stage2)Noel Grandin
Now that we've sorted out which bits are rightfully internal (see commit 7a4064cf87d23bffac987b3e39bf87d9b4d158fc), and which bits need a comparison operator, rename IsEqual to operator==. Change-Id: Iec229a7571d76ee18fbc0a4fe672cc2e50a44948 Reviewed-on: https://gerrit.libreoffice.org/42851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27simplify Bitmap operator==/IsEqual (stage1)Noel Grandin
It looks like operator== is actually only useful internally. So inline that, and rename the other call sites to use IsEqual(). As a second stage, I will rename IsEqual to operator==, the intention being to make it obvious how the call sites are modified. Change-Id: I37f2920a8cafaffb25e8c5c16e6559546206684b Reviewed-on: https://gerrit.libreoffice.org/42846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27loplugin:unusedmethodsNoel Grandin
Change-Id: I5d75baa2af046f377b49e967783fb06cd9e885ef Reviewed-on: https://gerrit.libreoffice.org/42841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27Replace sal_uLong with sal_uInt32 in SpellDialogMuhammet Kara
It is now consistent with the param type of TextEngine::SetAttrib Change-Id: I3b0ef3fe01ee26cce8c3ec078f9ae93317d6ccdc Reviewed-on: https://gerrit.libreoffice.org/42787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Special character dialog small fixesTamás Zolnai
Use stock button for OK and identation fixes. Followup changes to: 4020945651b4f3c636980e2103db440b5c55459c Change-Id: I3fe2f2f9a4528d38086db453d7ea71f7ac8b7a9a Reviewed-on: https://gerrit.libreoffice.org/42800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26Cleanup unused strings in cuiMuhammet Kara
Change-Id: I7ab055f301785a73d189e58465056ac4b2e8b494 Reviewed-on: https://gerrit.libreoffice.org/42783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#111739 fix Selecting a custom character as a bullet symbol insertionDaniel
Change-Id: I638ef2467f27bd6214cde092be5a3055fd539ebc Reviewed-on: https://gerrit.libreoffice.org/42727 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Different take on tdf#108406: exclude helpimg from installed themesKatarina Behrens
as it still might get selected as default theme under some circumstances and removing it from list in optgdlg.cxx leads to crash This reverts commit 60adba3fb904ed66251ff39c82fe20bec151ef0b but allegedly still crashes on Debian Change-Id: Ib853cc27058d8635482f19a8db26075d64103e1b Reviewed-on: https://gerrit.libreoffice.org/42545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-21loplugin:flatten in connectivity..desktopNoel Grandin
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20unused sNumCharFmtName fieldsNoel Grandin
ever since commit 89ef4dea325a11c706ff9619ff4717124260f864 Date: Fri Jul 17 10:34:58 2015 +0200 loplugin:unusedmethods cui Change-Id: Ibfa3841168448d4f08075a684fa36262b303210f
2017-09-19inline some use-once fields in cuiNoel Grandin
Change-Id: Ib2abea6b1f68cf193325d312e67578b2d346e39a
2017-09-18tdf#108139 Remove Preview column from Application Colors config pageArkadiy Illarionov
Change-Id: Id342814f3a724a0534cd6fd43b49139af52c1d03 Reviewed-on: https://gerrit.libreoffice.org/42362 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-18tdf#106945 TSA Dialog: Disable delete buttonSabin Frandes
Change-Id: Idce5ccc36254d80aaf4b5d5f81cfe201e5c27a5f Reviewed-on: https://gerrit.libreoffice.org/42315 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-15tdf#106946 Removed ability to resize Spellchecking-Options dialogAndreas Brandner
Change-Id: I89182eeb01f8639aa7d7af61f0fe99d96568b6e3 Reviewed-on: https://gerrit.libreoffice.org/42330 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2024-07-17 23:19:17 +0000