summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-04-01Resolves: tdf#124410 crash cell border page with diagonal bordersCaolán McNamara
Change-Id: I0fd8738d42ad33f029381dae0ec9f41e7912b72c Reviewed-on: https://gerrit.libreoffice.org/69918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6c29dbb7a1c3a04f3cbaa3dd720db482755538d7) Reviewed-on: https://gerrit.libreoffice.org/69919 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 685c847a00ee653bd0c2bd42a7f7f866885896e8) Reviewed-on: https://gerrit.libreoffice.org/69965 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-21Resolves: tdf#122804 make bitmap page 'add' dialog title localizedCaolán McNamara
Change-Id: I0c4f6775b8bc9fae8dc81f07fec2e21218e36037 Reviewed-on: https://gerrit.libreoffice.org/69521 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-21Resolves: tdf#122803 make gallery 'add' dialog title localizedCaolán McNamara
Change-Id: Iaa2ee6c982c8fd5d5cf1b9b09a835b917217d85c Reviewed-on: https://gerrit.libreoffice.org/69517 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-21Resolves: tdf#123650 explicitly grab focus after modificationCaolán McNamara
of the widget after gaining focus, otherwise gtk loses track of where the focus should be and tdf#124226 do fill-on-demand hack only on first visit disconnect focus handler after the fill Change-Id: I90d9f36acf807aec8687c7f563449ef16d5eb574 Reviewed-on: https://gerrit.libreoffice.org/69356 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-19tdf#122790 Improve background tab page for writer tablesJim Raykowski
This patch improves the new background tab page use for setting Writer table cell, row, and table backgrounds. Now cell, row, and table backgrounds fill tab page according to the fill style of each and can all be set in the same opening of a Table Properties dialog. This patch also makes the Reset reset background settings to initial settings of dialog opening. Change-Id: I567ef9229232f02d98b45a81309e920dca854bed Reviewed-on: https://gerrit.libreoffice.org/66844 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 222b5b5b9b0d0419e30961261c63ff8585550b81) Reviewed-on: https://gerrit.libreoffice.org/69168 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-18Fix squeezed Bitmap fill style tab page layout in Background tab pageJim Raykowski
Just use the size set by the Area tab page class Change-Id: Ie87b4e86a3c80e94f6d916dab217e52c82558074 Reviewed-on: https://gerrit.libreoffice.org/66650 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit db4c828913cfc8c33b8cc87b576fddcc2e705176) Resolves: tdf#124058 factor bitmap page into size req when its toggled on post ctor time Change-Id: I8257c8ffdfc4dab9893ab7d2d67e218dd3f8097c don't need m_aColorSize Change-Id: I27740ae0bff0d1676799ddfba76eab5e7a299f66 Reviewed-on: https://gerrit.libreoffice.org/69364 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-14Resolves: tdf#124028 dangling "completion" entries block responsesCaolán McNamara
so e.g. math font dialog doesn't react to button clicks. since... commit ab8e0f5832fa910f8b1abd36d7cb3929cbac2395 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 18 17:08:58 2019 +0000 Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect remove the entrycompletions but left the reference to them Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22 Reviewed-on: https://gerrit.libreoffice.org/69209 Tested-by: Jenkins Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12tdf#123304: Allow the full feature syntax as pre 6.2Khaled Hosny
Fix regression from: commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Fri Jun 15 19:32:15 2018 +0200 vcl: parser of font features included in the font name Where hb_feature_from_string() was replaced by a simple parser that supports avery limited subset of the syntax it supports (as documented in https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string) Reviewed-on: https://gerrit.libreoffice.org/69062 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 45deb5b714d2d011eb2a5ad91721a9c2c508a426) Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f Reviewed-on: https://gerrit.libreoffice.org/69068 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2019-03-07menu of currency combobox in format-cells is too narrowCaolán McNamara
we want the combobox to be narrower than it wants to be. To make that happen we have only the option of shrinking the cell renderer of the combobox area. And that is also used by the menu. Setting a small value of e.g. 1 works to let the combobox not request more width than that, and the combobox will correctly render within the wider size it actually gets. But then the menu is a min width menu, which is undesirable, we want the menu to be as wide as it can be. So calculate what part of the combobox belongs to the cell area and set the widest cell area we can within the overall combobox width, resulting in the widest menu we can get. Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f Reviewed-on: https://gerrit.libreoffice.org/68168 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-04Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67820 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-02-28Related: tdf#123711 better optimal size for highlighting tabCaolán McNamara
it only uses the color subtab, so just measure ones which can be visible Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784 Reviewed-on: https://gerrit.libreoffice.org/68432 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-26these are dialog titles, so no use_underline for mnemonics wantedCaolán McNamara
Change-Id: I88c684c88df391beb62415240580064e97fe87f0 Reviewed-on: https://gerrit.libreoffice.org/68174 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-02-11Resolves: tdf#123309 destroy menu before menubuttonCaolán McNamara
Change-Id: Ib6b179c460bed4ffdcc2678294633004bbae816a Reviewed-on: https://gerrit.libreoffice.org/67678 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-06tdf#122748 Don't restore previous language selectionSzymon Kłos
Change-Id: I8688c65695080804bae22209ed5d4890ced1a8dc Reviewed-on: https://gerrit.libreoffice.org/66678 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 1b1999009962b9d79858139bd7573947f78e6669) Reviewed-on: https://gerrit.libreoffice.org/66738 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-04Resolves: tdf#122930 paper tray is to update on focus-inCaolán McNamara
which adds the problem that GtkComboBox doesn't send a focus-in, but its toggle does, to find and use that instead Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f Reviewed-on: https://gerrit.libreoffice.org/67016 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-02Resolves: tdf#123128 impress format->table dialog too tallCaolán McNamara
it needs to be resizable if it has the modifiable western vs ctl+cjk font page Change-Id: I0498baaf566328549a365e57ac440161b7199ad9 Reviewed-on: https://gerrit.libreoffice.org/67293 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-01tdf#123050: catch object does not have a key labeled 'theme_data'Xisco Fauli
json::document_error: node::child: this object does not have a key labeled 'theme_data' Change-Id: Ic4daf53cff4e3e25b83393cb92957bf60cd5a92c Reviewed-on: https://gerrit.libreoffice.org/67161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 45a0f2177b089065a2099a798639cb534ad67ac3) Reviewed-on: https://gerrit.libreoffice.org/67227 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-01tdf#123089: expand menulist horizontallyXisco Fauli
Change-Id: I578883c9eaf02b919fe2a7128d4255ab2a1cd2b8 Reviewed-on: https://gerrit.libreoffice.org/67225 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-30tdf#123036: fix assert in cfg.cxx (cui)Julien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=123036#c3 Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=52ccd8fabeea247da7077798b50a6db1da31a2eb Change-Id: I1c24a6c59bda7ce06ed93c31a21d9bc1c8abe2f5 Reviewed-on: https://gerrit.libreoffice.org/67107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29Resolves: tdf#122992 allow pre-selected fonts not in the font listCaolán McNamara
Change-Id: I75c1b6d3933a5773d9e1dce40744c2342ab63ee8 Reviewed-on: https://gerrit.libreoffice.org/67025 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28tdf#122912: Close option dialog if restart is confirmed ( part 2 )Xisco Fauli
forgot it in e961e08a3277158d4e3074bfacb8599296d2fa75 Change-Id: Id896bf407ca33faf0dbff74f3cbe98d23de0e0c7 Reviewed-on: https://gerrit.libreoffice.org/66846 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit c81340bcc73144e082efb9fc575ef62b9b046ca4) Reviewed-on: https://gerrit.libreoffice.org/66870 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-28tdf#122951: Fix insertion of graphics as bulletsXisco Fauli
Regression from 81260c448911069ce8cb051d3a973ec52b9b43a3 Change-Id: Iecf00ea8310a767ff7945e7c1a0efe9dca5edd20 Reviewed-on: https://gerrit.libreoffice.org/66903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 265a4fd43d207cd6a99fdd9c23d54259428ed709) Reviewed-on: https://gerrit.libreoffice.org/66905 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-25Related: tdf#122914 visiting alignment page sets an SvxAdjustItemCaolán McNamara
even if the user doesn't interact with anything, since... commit 122da2eea23faf6916c3f3b9e1895f5c404b26c7 Author: Jim Raykowski <raykowj@gmail.com> Date: Sat Nov 18 22:21:24 2017 -0900 tdf#107567 et al. Paragraph dialog preview windows fixes tdf#107567 tdf#98211 tdf#98212 tdf#113275 Checking those issues, I don't see a change if I put this part back to only set SvxAdjustItem in FillItemSet if the radio-button has changed (or justify subcontrols if justify was already set) Change-Id: Ia68c50fd659be5b507d6e0989caecb353b494df7 Reviewed-on: https://gerrit.libreoffice.org/66882 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Resolves: tdf#122914 missing save_valueCaolán McNamara
Change-Id: Ie28195f342b73b1420a1a120b1414941aab337b7 Reviewed-on: https://gerrit.libreoffice.org/66864 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22let return in format->cells: format-code entry widget activate okCaolán McNamara
Change-Id: Ibeb51624a12a62d9f93d1b1f712cbdde83cce2c7 Reviewed-on: https://gerrit.libreoffice.org/66734 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-22Resolves: tdf#122458 not enough values savedCaolán McNamara
Change-Id: Id71db408e756b273f8a90b15f86c76285cc2b1e1 Reviewed-on: https://gerrit.libreoffice.org/66433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-22Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselectCaolán McNamara
Change-Id: I941e32a973cdd1bc79e3739b24fdf834aa52cb11 Reviewed-on: https://gerrit.libreoffice.org/66688 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-22tdf#122846: Close option dialog if restart is confirmedXisco Fauli
use the same logic as 0fa14d58457e9418ff756a0efd66e365c4403a67 Change-Id: I485cb232bb787e176918caf2eee74b0fbb360e47 Reviewed-on: https://gerrit.libreoffice.org/66691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/66732 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-22Resolves: tdf#122786 use weld::SpinButton::set_value() instead of set_text()Eike Rathke
... otherwise get_value() returns 0. Change-Id: I345d31e888e40f1fc191cef7dac802eb860a824f Reviewed-on: https://gerrit.libreoffice.org/66539 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit af8d616fe7556716af8ccd4c4de7a68ae52ce2b7) Reviewed-on: https://gerrit.libreoffice.org/66546
2019-01-21tdf#122808 search formatting dialog should be modalCaolán McNamara
Change-Id: I8b33fcbbf538660703f6cdb9818e8fae2c623be9 Reviewed-on: https://gerrit.libreoffice.org/66675 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-17Resolves: tdf#122346 get font features to stick in entry properlyCaolán McNamara
Change-Id: I56058a2069600a4c8acba861a38e7e5d84f44d81 Reviewed-on: https://gerrit.libreoffice.org/66500 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17Resolves: tdf#122509 we have a second list with generated currency formatsEike Rathke
... which kicks in if SvxNumberFormatShell::FindEntry() determined a format index of NUMBERFORMAT_ENTRY_NEW_CURRENCY instead of a real existing index. Regression from commit e607f1da329a2d4dd91904053d7ff86ac05c77bf CommitDate: Thu Oct 4 15:02:13 2018 +0200 Select the current format if multiple instead of first matching format code The old (now removed as unused) SvxNumberFormatShell::GetListPos4Entry(const OUString&) used before took care of that, add the functionality back but combine into the existing GetListPos4Entry() function, the additional FindEntry() call wasn't necessary anyway because it was just called before in the caller. The actual crash happened elsewhere in SvNumberFormatter::GenerateFormat() because no format exists for the then determined entry, which should be changed independently to prevent such abuses. Change-Id: Id42efa152693119fbde82b234f367679f818cfab Reviewed-on: https://gerrit.libreoffice.org/66472 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit c9d19b70c93b02e5c666414097e835039c598731) Reviewed-on: https://gerrit.libreoffice.org/66477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-16Resolves: tdf#122356 on row-activate click ok buttonCaolán McNamara
instead of proceeding directy to the ok response. Because there is an additional handler installed in the okbutton to do extra stuff that is needed to make this work Change-Id: I9646ea6978533084c6c9c48b03806e46eaa49c33 Reviewed-on: https://gerrit.libreoffice.org/66047 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-16Related: tdf#122627 auto detect of toggle column doesn't workCaolán McNamara
so remove it and explicitly state what column contains the toggle Change-Id: I58fb12a4b8fa9eeb9c038f796e48b0aeaa0b2404 Reviewed-on: https://gerrit.libreoffice.org/66380 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-15Resolves: tdf#122701 opengl settings don't affect gtk3Caolán McNamara
Change-Id: Iffcf9b6ea8d191a509c2ca451f2ce4a249fde922 Reviewed-on: https://gerrit.libreoffice.org/66292 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-14Resolves: tdf#122627 be explicit about what column to checkCaolán McNamara
Change-Id: Icdd1cef6b0bc9d8dd61c309dc9de66021fc9422d Reviewed-on: https://gerrit.libreoffice.org/66287 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-09tdf#122527 dot symbols in chart menubutton not workingCaolán McNamara
a few problems here *) each symbol was drawn on top of the previous one instead of clearing it *) some spurious placeholder text in the menu entry *) m_nSymbolType not set correctly on activation of a submenu entry *) under gtk3 adding entries to the submenus didn't inform the menubutton of their addition *) we can drop m_xMenu because set_item_sensitive can be used instead, which didn't exist at the initial time of writing Change-Id: Id339992c4192f3782fddfd56cb3e9b67cfcbe2a2 Reviewed-on: https://gerrit.libreoffice.org/65978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-08Bump copyright year to 2019Adolfo Jayme Barrientos
Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd (cherry picked from commit 588dc2808c79da714cc107548631a65a7ddfe5d0) Reviewed-on: https://gerrit.libreoffice.org/65957 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-01-02Resolves tdf#122383 and tdf#122410Muhammet Kara
Add some null pointer checks Change-Id: I905c6dd46a5019e66d9c2e59374cc7d1ce83397b Reviewed-on: https://gerrit.libreoffice.org/65789 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit be8897d9c63a77b223a9c0aed1d2eb689e0e0082) Reviewed-on: https://gerrit.libreoffice.org/65798
2018-12-19tdf#122119 make fontfeature dialog size unlimitedCaolán McNamara
Change-Id: Iacfcce9ec3a71f43fb5ce491d23184691c269944 Reviewed-on: https://gerrit.libreoffice.org/65418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19set explicit color for font feature preview bgCaolán McNamara
Change-Id: Ia7e8e6e6d7b8297063798aaf63111490f356c5c9 Reviewed-on: https://gerrit.libreoffice.org/65412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18tdf#122136: select first element if there's at least oneJulien Nabet
See bt from https://bugs.documentfoundation.org/attachment.cgi?id=147594 Change-Id: Ibf031b8024aa4952e2d3263a445cafdb3c031390 Reviewed-on: https://gerrit.libreoffice.org/65221 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-18Resolves: tdf#122168 width/height transposedCaolán McNamara
don't need it anyway, the width req is already set by SvxNumberPreview::SetDrawingArea Change-Id: Ic5b03a13a98c76c5ce927b13fc295510b6d8686d Reviewed-on: https://gerrit.libreoffice.org/65354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18stray fprintfCaolán McNamara
Change-Id: I1bb4ee9354914db21d0440f83c156069a5efd9f9 Reviewed-on: https://gerrit.libreoffice.org/65356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18Related: tdf#122120 left align text if preview won't fitCaolán McNamara
in the number format page Change-Id: Ic398e5302ee54dfd437e07fdf892269e6eefd8fa Reviewed-on: https://gerrit.libreoffice.org/65285 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-17tdf#121180: close Options dialog when restart is confirmedMike Kaganski
Change-Id: Ieb6e62ca83921abed6b6432d70c6717dadfaaa34 Reviewed-on: https://gerrit.libreoffice.org/65090 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0fa14d58457e9418ff756a0efd66e365c4403a67) Reviewed-on: https://gerrit.libreoffice.org/65184 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-12-13Resolves: tdf#120481 gradient subpage 12 pixels too shortCaolán McNamara
because the max preferred-size of the subpages is taken and applied as the size-request of the container parent. But the container parent as a 6px border, so the subpages end up hosted in a parent which allocates them 12px less than they hoped for. As they are instantiated in the parent to measure them, measure their parent instead and that calculates in the parent's border to end up with what they wanted Change-Id: Ib270b90f9c2fed7f8bd042cc66d0d10ad3c6f183 Reviewed-on: https://gerrit.libreoffice.org/65059 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-05tdf#121620 Opening Image tab of Bullets and Numbering dialog resets selectionNoel Grandin
regression from commit 39e6bae2c4be24a3aad5ef8cd37d3d83c41a4abe loplugin:useuniqueptr in cui numpages Change-Id: I77e16880d0590793545da38b7a3c8c5d2626d8f5 Reviewed-on: https://gerrit.libreoffice.org/64441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c9e70af2bf6dc9427a9c1dd32d5e8ecccd32c3c2) Reviewed-on: https://gerrit.libreoffice.org/64536
2018-12-04weld OfaAutoCorrDlgCaolán McNamara
Change-Id: Iba217a2998de57bf963872f9b8c1cf38694eb935 Reviewed-on: https://gerrit.libreoffice.org/64507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-04weld OfaSmartTagOptionsTabPageCaolán McNamara
Change-Id: I34b6c654e65fa827e8efc8fd6ba97dc73d15df17 Reviewed-on: https://gerrit.libreoffice.org/64505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>