summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-08-29tdf#42949 Fix IWYU warnings in cui/source/{options,tabpages}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b6fda67ef7de65cc7b468dded862cd47dfd4269 Reviewed-on: https://gerrit.libreoffice.org/78078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27SmartArt edit UI: change plain text widget to tree viewGrzegorz Araminowicz
Added getChildren() data interface method, so that it's possible to recursively fill tree view with (id, text) pairs Change-Id: Ic100ded3a3e125bf79f5caa421cd8f91e5210954 Reviewed-on: https://gerrit.libreoffice.org/78169 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-27Use osl::FileBase::getSystemPathFromFileURLStephan Bergmann
...instead of INetURLObject FSysStyle::Detect guesswork (with the hope of eventually phasing out use of the latter). (In each of the three places where a filesystem pathname would need to be converted back to a URL with osl::FileBase::getFileURLFromSystemPath, failure is rather harmless, so they don't check error returns and are marked as "best effort".) Change-Id: Ia312b49b20543cdd83aff5609bb054e0fc1dc194 Reviewed-on: https://gerrit.libreoffice.org/78165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Proof-read and fixes of Tip of the day stringsHeiko Tietze
Change-Id: Ib33ab6c7b72164b61b21255f240b26ae5fb75a9e Author: Mike Saunders Reviewed-on: https://gerrit.libreoffice.org/78164 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-26Directly compare filesystem pathanmes in SvxJavaClassPathDlg::IsPathDuplicateStephan Bergmann
...instead of going back and forth between filesystem pathnames and file URLs Change-Id: I9afb00a48b4de907af31ebd571891dc6be0a0f49 Reviewed-on: https://gerrit.libreoffice.org/78158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26Fix: Allow border in QR-code-generator to take zero as a input.Shubham Goyal
Change-Id: I742980f2e221afc5aff5eb666e69f63f2f990e84 Reviewed-on: https://gerrit.libreoffice.org/78050 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-24loplugin:returnconstval in connectivity..cuiNoel Grandin
Change-Id: Ie6444713088c14d1821640f6eb219cee3d6ee542 Reviewed-on: https://gerrit.libreoffice.org/78056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-24Fix typoAndrea Gelmini
See: https://bugs.documentfoundation.org/show_bug.cgi?id=127103 Thanks a lot to Emil Tanev (e m o _ a s s e n o v at y a h o o dot c o m) Change-Id: I39fb0f3457383d07c0a48fdf52631ab11e510c02 Reviewed-on: https://gerrit.libreoffice.org/78005 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-23Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23tdf#126720 Fixing label length fix UI breakShubham Goyal
Change-Id: I4fefc4fcb64388fb3c3ca35b73a7264b381d4e6f Reviewed-on: https://gerrit.libreoffice.org/77751 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2019-08-23SmartArt: add Edit Diagram dialogGrzegorz Araminowicz
Currently it displays only text representation of diagram. Change-Id: I3ff12c4abf2ed32f68ea9d7437905afc13279e62 Reviewed-on: https://gerrit.libreoffice.org/77873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-22weld ODbTypeWizDialogSetupCaolán McNamara
split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22QR Code : ODF import/exportShubham Goyal
Change-Id: I6c1ae63a89d5ed34d2fa245279d4552949bb64a7 Reviewed-on: https://gerrit.libreoffice.org/74853 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-22Reduce default border value in the QRCode DialogShubham Goyal
Change-Id: Ie821f1762bbe941caedd58db330e84950e83f8be Reviewed-on: https://gerrit.libreoffice.org/77868 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-21Avoid extra calls to INetURLObject::decodeStephan Bergmann
Change-Id: I700c4093213395a12342534fb7685969b5e5b220 Reviewed-on: https://gerrit.libreoffice.org/77891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-21Resolves tdf#126805 - Alignment of Tip-of-the-day labelHeiko Tietze
Change-Id: Ic4845dd87325ec952b8b987b69eedd8530b1cf02 Reviewed-on: https://gerrit.libreoffice.org/77703 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-20Fix libreoffice version for links in tipofthedayChristophe JAILLET
tipoftheday.hrc has some URL with fixed LibreOffice version (6.0 and 6.2) Use %PRODUCTVERSION instead and perform the convertion to the correct version at run-time. Note, this can have the drawback to point to dead links if a newer version of the online doc removes a page or changes its path. 'en-US' could also certainly be handled the same way. Finaly the 'uiResId(aLink.toUtf8().getStr()' to get it converted is certainly a hack that should be implemented in a better way. So consider this patch as a PoC :) Change-Id: Ibdcaedde631f1a243e0ec54cdec6c488c04b8f29 Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-on: https://gerrit.libreoffice.org/75971 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-19Related: tdf#127029 true was substituted for FALSECaolán McNamara
presumably accidentally by... commit 6ed0bcdd5bc07692fc81406942509eb9c30d3904 Date: Tue Oct 5 07:57:51 2010 -0500 FASTBOOL to bool conversion @@ -1305,7 +1305,7 @@ BOOL SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp if ( m_pImpl->m_bInSearchMode && bChanged && aInfo.GetWeight() == WEIGHT_NORMAL && aInfo.GetItalic() != ITALIC_NONE ) - bChanged = FALSE; + bChanged = true; } if ( !bChanged && pExampleSet && Change-Id: I711e6dbf26570189f9940958b02ca4e9561bf318 Reviewed-on: https://gerrit.libreoffice.org/77736 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19loplugin:constvars in cppuhelper..desktopNoel Grandin
Change-Id: Iaf42114ab98875c4bc1545684f1893540b998ef2 Reviewed-on: https://gerrit.libreoffice.org/77723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-19Make QR code callable in Impress and DrawShubham Goyal
Change-Id: If11686189b0665f3918821269dd73d122e632194 Reviewed-on: https://gerrit.libreoffice.org/77438 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-16tdf#126254 Help - About is black with Linux gen and gtk2Caolán McNamara
Change-Id: If18693e1cb8a92a7a152dd9decc892fc5f2b7ab5 Reviewed-on: https://gerrit.libreoffice.org/77591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15embeddedobj: allow controlling if PDF documents are converted to Draw or notMiklos Vajna
This is a bit custom, since it's not a Microsoft filter. At the moment this affects only Insert -> Object -> OLE Object -> from file. Change-Id: If79602742a533db1b04e11a90890f8768186046d Reviewed-on: https://gerrit.libreoffice.org/77520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-15loplugin:sequenceloop in basic..cuiNoel Grandin
Change-Id: I15d825de3201808d188b461415f78a4d81b64127 Reviewed-on: https://gerrit.libreoffice.org/77494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15embeddedobj: allow controlling if Visio documents are converted to Draw or notMiklos Vajna
At the moment this affects only Insert -> Object -> OLE Object -> from file. Change-Id: I8d1c6456481610491916e3be3766b0bb04dfa296 Reviewed-on: https://gerrit.libreoffice.org/77489 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-15replace ".get->" with "->"Noel Grandin
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-13avoid invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
Change-Id: I6fbc991e288b150dcbcfb61018f97fdce69c90cd Reviewed-on: https://gerrit.libreoffice.org/77384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-13Fix overly restrictive limit checksStephan Bergmann
Change-Id: I7a67208e500e79f62dad1eee1b89f96e0958ccc3 Reviewed-on: https://gerrit.libreoffice.org/77380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-09Resolves: tdf#126736 change range on change of unitCaolán McNamara
and make the max % 800 instead of 500 while we're at it (0.15cm is considered 100% FWIW) when flipping from measurement unit to % Change-Id: Ia1b15559f3db0d1e11d4563ad7c6aacc3f9ba32d Reviewed-on: https://gerrit.libreoffice.org/77192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-08FIX: Error Correction in QR CodeShubham Goyal
Previously only Low Error Correction value was used to build the QR Code. This patch aims to fix this and make use of Error Correction what user selects. Is fix to the commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Patch also involves some beautification. Change-Id: Ib809569fdd7c1c7c6305c27552419c3e5e8d51b9 Reviewed-on: https://gerrit.libreoffice.org/76958 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-07Resolves: tdf#126691 width/height considered changed, but it didn'tCaolán McNamara
regression from... commit c4041a3b6c703254ee3977eef1a989992506772b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon May 28 14:33:42 2018 +0100 weld SvxSwPosSizeTabPage Change-Id: Ib8a5359a1aee9ac7b645621b9de9311cd56449f5 Reviewed-on: https://gerrit.libreoffice.org/77121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07Resolves: tdf#125483 locale separator label needs to be derived from originalCaolán McNamara
regression from... commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Change-Id: I940269d14a0a84768c4f8e62c153cfac51cf577f Reviewed-on: https://gerrit.libreoffice.org/77086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07tdf#61076 string validation on creation of new dictionary.Rtch90
Prevent having '/' or '\' within the dictionary name to prevent data loss. Change-Id: I392832c748effcdbbe58983a788ba6b38764628c Reviewed-on: https://gerrit.libreoffice.org/71059 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2019-08-07Fix wrong method in SAL_WARN (cui/optinet2.cxx)Julien Nabet
Change-Id: Ifb56d6d6c767b8f5d40e396638470be822355d6d Reviewed-on: https://gerrit.libreoffice.org/77075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-06ofz#16191 fix build failureCaolán McNamara
Change-Id: Iaa4e14e102374951ba8ab99507367556ff5920fd Reviewed-on: https://gerrit.libreoffice.org/77017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-06tdf#107471 Add checkbox to enable/disable sending crash reports to TDFGabor Kelemen
Also hide it when compiled with --disable-breakpad i.e. most Linux distributions Change-Id: I5d392e22410614550aa9602d0c30b0b81ec22ea0 Reviewed-on: https://gerrit.libreoffice.org/76771 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Fix Border feature QR CodeShubham Goyal
The change is in addition to the change 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Change-Id: I4fce9260d9276799f7c3fa089d23695c8419afd4 Reviewed-on: https://gerrit.libreoffice.org/76953 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAGMike Kaganski
... because RES_CHRATR_GRABBAG value may be later reset by initial value read from char format, when it's present there. OTOH, RES_PARATR_GRABBAG shouldn't be present in character format, so it should be safe to pass the grabbag item there. Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e. Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2 Reviewed-on: https://gerrit.libreoffice.org/76981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-05Make generated QR Code as a perfect squareShubham Goyal
Fix drawbacks of commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec Change-Id: I94503900250c2d8a10f5930c539bdc2f7da5cfd4 Reviewed-on: https://gerrit.libreoffice.org/76954 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-02Revert "fix some accessibility warnings"Noel Grandin
This reverts commit 885ae69174cf717edd00526e5cf8f1585c505c95. <caolan> noel_grandin, wrt the accessibility labelled-by and label-for. If the label really is a GtkLabel then setting its mnemonic target (in glade, general tab, and use underline and select a target) is the most straight forward thing to do and implies those a11y relations <caolan> the painful manual a11y labelled-by/label-for are typically for using something weird, like a checkbutton, as a label for something Change-Id: I13db8ec65d10248aa46cb6b01398ec302dd06b59 Reviewed-on: https://gerrit.libreoffice.org/76837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02fix some accessibility warningsNoel Grandin
Change-Id: I18f9a71ac4e2ef5c159e13bc3cb0e36cf7c550a5 Reviewed-on: https://gerrit.libreoffice.org/76834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02tdf#126643: avoid unnecessary asking for JRE in script organizer dialogMike Kaganski
Use two-pass search for the needed language node; if it fails with Java interaction disabled, only then repeat the search with it enabled, like in commit f3ce30ec75a4d7116b9cd4d7b21d9aaa0e237eeb. Change-Id: Icde5dbeb552a6837af02182f7b8cbbc90765c5a5 Reviewed-on: https://gerrit.libreoffice.org/76831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01weld SvxDefaultColorOptPageCaolán McNamara
Change-Id: I5741ee4d0df724e9f1df72ce668f9f2e53541280 Reviewed-on: https://gerrit.libreoffice.org/76802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01drop newly unused OptHeaderTabListBoxCaolán McNamara
Change-Id: I08926e91a61e7bdd4de4ac96083e970268801d6f Reviewed-on: https://gerrit.libreoffice.org/76789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld SvxPathTabPageCaolán McNamara
Change-Id: If9b982d9e73adbb55e940ae12e5d894dd803f7f3 Reviewed-on: https://gerrit.libreoffice.org/76788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01should toggle all others to false, not trueCaolán McNamara
regression since... commit 5c32ba63163d9556ff89782a8074924cdf9dc554 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 4 14:30:03 2019 +0100 weld OTableSubscriptionPage Change-Id: Iec3bec1b49af3e60b80301665ff3834f24f72222 Reviewed-on: https://gerrit.libreoffice.org/76787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31weld ConnectionPoolOptionsPageCaolán McNamara
Change-Id: I7a772fd441304eaa1f08c1474b28a471cf33af5a Reviewed-on: https://gerrit.libreoffice.org/76756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31weld SvxFontSubstTabPageCaolán McNamara
Change-Id: If24e80da4042ea37ea2613a6c62e015d0d925dc8 Reviewed-on: https://gerrit.libreoffice.org/76753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-31 07:10:38 +0000