summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08loplugin:passstuffbyrefNoel Grandin
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed-on: https://gerrit.libreoffice.org/57088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt
Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06tdf#117903 Add signature line feature to calcSamuel Mehrbrodt
Change-Id: I4e9121803a26cba1f40f8f1c673c7809543ef2ec Reviewed-on: https://gerrit.libreoffice.org/57015 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29Clean up SvxChartColorTableStephan Bergmann
* nNextElementNumber is unused since d57dfa29c2ba47293eb12a853cdccf4196565ef7 "Improvement of adding and removing color charts". * There appears to be no compelling reason to store sDefaultNamePre-/Postfix as members (but which are not even copied by the copy ctor). Just compute them whenever they are needed in getDefaultName (which is understood to not be a hot code path). * With those changes, the user-provided default and copy ctor can be left implicitly-declared, which avoids -Wdeprecated-copy (because the copy assignment op was implicitly-declared while the copy ctor was not) with GCC trunk towards GCC 9. Change-Id: I2bfa5f19c967e24407bf5b79adaf171200822f45 Reviewed-on: https://gerrit.libreoffice.org/56666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#117866 cui personalization: fix a possible raceMiklos Vajna
The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. Change-Id: I494c123a6225da60407391771622208c055ae49b Reviewed-on: https://gerrit.libreoffice.org/56585 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-28tdf#118429 Provide unsigned signature imageSamuel Mehrbrodt
when creating signature line. OOXML Export expects this. Change-Id: Ib6ab1f879c5ef27e8347002576ba95104117cadd Reviewed-on: https://gerrit.libreoffice.org/56576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-26tdf#118309 freeze/thaw adding large amounts to ComboBoxTextCaolán McNamara
Change-Id: I3072630c769224be730e6ec16b1a02fa4f1b10e6 Reviewed-on: https://gerrit.libreoffice.org/56485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26personalisation: check "Own Theme" button when clicking "Select Theme"Noel Grandin
to make it more obvios that the two belong together Change-Id: I8e0590679950e96802bab48cd78a8ef6b0a0b681 Reviewed-on: https://gerrit.libreoffice.org/55847 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-26loplugin:useuniqueptr in SvxEditModulesDlgNoel Grandin
Change-Id: I02f85df8e28ba53e22874b02c3134b1c48805ddf Reviewed-on: https://gerrit.libreoffice.org/56322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25followup fix for "tdf#109269 very slow loading of user-defined dictionary"Noel Grandin
i.e. commit 3b1f5ce3a37b09880b63f829bc0a349075fb6245 Change-Id: Ic03c9518fec2ca066bf31272cddd611b05c4773b Reviewed-on: https://gerrit.libreoffice.org/56391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25tdf#109269 very slow loading of user-defined dictionary word listNoel Grandin
this is about 10x faster for me Change-Id: I1d308c78dbdd04beaa432b546ba3b89bd617d57e Reviewed-on: https://gerrit.libreoffice.org/56378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in OfaViewTabPageNoel Grandin
Change-Id: I0a9f7fd5738a06ac60762b3242721df1634b4264 Reviewed-on: https://gerrit.libreoffice.org/56326 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in OfaAutocorrExceptPageNoel Grandin
Change-Id: If59ebc6cd5f73534e3e6c7e3765133c84d839958 Reviewed-on: https://gerrit.libreoffice.org/56325 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in cui numpagesNoel Grandin
Change-Id: I22eaeecb06bcf46cc494e8a0326922600e131cf3 Reviewed-on: https://gerrit.libreoffice.org/56324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SvxLineTabPageNoel Grandin
and move SvxBmpItemInfo inside cui/ since it is only used there. Change-Id: Ic80a8cace9e4664af18baddce3398e826e4c4851 Reviewed-on: https://gerrit.libreoffice.org/56323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in BackgroundPreviewImplNoel Grandin
Change-Id: If7a36baa663d052a9a41c126312abff185a14bdc Reviewed-on: https://gerrit.libreoffice.org/56321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22use Application::GetFrameWeld to tunnel weld::Window through XWindowCaolán McNamara
Change-Id: I137afe61acfb71337a45bedbe539b0096080e6cc Reviewed-on: https://gerrit.libreoffice.org/56246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21loplugin:useuniqueptr in SvxPatternTabPageNoel Grandin
Change-Id: I8b2493c723c65f90fd2dbef588c1fa1c669bcceb Reviewed-on: https://gerrit.libreoffice.org/56194 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxLinguTabPageNoel Grandin
Change-Id: I98e683bd23e854507c37e4d88a42a4c249bf5c44 Reviewed-on: https://gerrit.libreoffice.org/56195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxBackgroundTabPageNoel Grandin
Change-Id: Icfabf2bcbe49142871d6bef70ce0d73ed371a5b3 Reviewed-on: https://gerrit.libreoffice.org/56193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxMacroTabPage_Noel Grandin
Change-Id: I1720d624efee71611e8c2f7dab2aed22a0ecee10 Reviewed-on: https://gerrit.libreoffice.org/56192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxSecurityTabPageNoel Grandin
Change-Id: I36fc9076e2190e37bf002a384ee503442c5781df Reviewed-on: https://gerrit.libreoffice.org/56191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21loplugin:useuniqueptr in SvxNumberFormatTabPageNoel Grandin
Change-Id: If0fefe4a1e7af7331c708e7e944483ec3ce07614 Reviewed-on: https://gerrit.libreoffice.org/56190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxSearchFormatDialogNoel Grandin
Change-Id: Ie7da9255e27734f93f7a7758ca9ec25108c0e547 Reviewed-on: https://gerrit.libreoffice.org/56104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SfxAcceleratorConfigPageNoel Grandin
Change-Id: I12c6ca5542729d4af77a7d4253ea1bbaae81781c Reviewed-on: https://gerrit.libreoffice.org/56096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20fix new a11y warningCaolán McNamara
Change-Id: I637c48335bb8e532bb8bad3b05e60fb1c06f6414
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20loplugin:useuniqueptr in SvxFontSubstTabPageNoel Grandin
Change-Id: I3e9e1c91f541c7e191ceb3d7ee6974fa46d26c6b Reviewed-on: https://gerrit.libreoffice.org/56101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in AlignmentTabPageNoel Grandin
Change-Id: I78dc902ae41eb8d8423c83a4ec32a4ca932bbc5e Reviewed-on: https://gerrit.libreoffice.org/56103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxDefaultColorOptPageNoel Grandin
Change-Id: I398ba3828bddf295e99624d7caa8d636e96c360c Reviewed-on: https://gerrit.libreoffice.org/56100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxColorOptionsTabPageNoel Grandin
Change-Id: Iefd1719a4f9c529840b4c584df8c7f2104d29fb3 Reviewed-on: https://gerrit.libreoffice.org/56102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in IconChoiceDialogNoel Grandin
Change-Id: I4a97cd8497056b48f8fb6439b2dc428887e0a0b9 Reviewed-on: https://gerrit.libreoffice.org/56098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in SvxCharacterMapNoel Grandin
Change-Id: I85e254fc59b4b0954bbed3876935f56e6480f525 Reviewed-on: https://gerrit.libreoffice.org/56097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20loplugin:useuniqueptr in TPGalleryThemePropertiesNoel Grandin
Change-Id: I4a288f9bd1b8abd7c588c1c895c8b6a8ef399fc2 Reviewed-on: https://gerrit.libreoffice.org/56099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20personalization: disable "own theme" button if we don't have anyNoel Grandin
Change-Id: I3a5bfb757361208ce4ec193698a6e87b66285906 Reviewed-on: https://gerrit.libreoffice.org/55846 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-19tdf#118212: fix crash with character formatJulien Nabet
see bt: https://bugs.documentfoundation.org/attachment.cgi?id=142938 Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=3aa8a048776bdf0d4868847baac2a72aa55cd6a3 Change-Id: Id4705865dac5f337f30ca7118a6b29735075b295 Reviewed-on: https://gerrit.libreoffice.org/56124 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-18set explicit parent for signing warning messagesCaolán McNamara
Change-Id: Ifbd1aaec13e2f3a51963c4942face64847eefc07 Reviewed-on: https://gerrit.libreoffice.org/55989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17weld SvxPageDescPageCaolán McNamara
Change-Id: I5e2457b51a294cbdacc5c78db4ec0a048567b93d Reviewed-on: https://gerrit.libreoffice.org/55877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-16tdf#58941 Manipulate with font features using FontFeatureDialogTomaž Vajngerl
This adds a font feature dialog activated on the Character page, which adds a way to manipulate the available font features for the current selected font (by adding them to the font name). Change-Id: Icd0eda31b235d3cc8ef6eaee582fb78b4b346d78 Reviewed-on: https://gerrit.libreoffice.org/55894 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-14weld SvxStdParagraphTabPageCaolán McNamara
Change-Id: I02b0f2e4f049b407a3ac0c7f304cbcd0cc652749 Reviewed-on: https://gerrit.libreoffice.org/55818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxParaAlignTabPageCaolán McNamara
Change-Id: I843b264d44266213e91b7e75bf35e4f6cf41dd88 Reviewed-on: https://gerrit.libreoffice.org/55792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14loplugin:unusedmethodsNoel Grandin
Change-Id: Ibd9f4757ec26da7acc645f33573ace3280e84834 Reviewed-on: https://gerrit.libreoffice.org/55788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14weld SvxExtParagraphTabPageCaolán McNamara
Change-Id: I6836bc659f28ebae35ed0ca33ffd9425212c3622 Reviewed-on: https://gerrit.libreoffice.org/55784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxAsianTabPageCaolán McNamara
Change-Id: Ib1e229a9780dd0959ce847a2d4c15eab7fb92c33 Reviewed-on: https://gerrit.libreoffice.org/55769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharTwoLinesPageCaolán McNamara
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>