summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2019-03-06remove sal_IntPtr in OfaMSFilterTabPage2Noel Grandin
and just use a scoped enum Change-Id: Ie229d61866be4a03ccd93b73787b8813b9bd932d Reviewed-on: https://gerrit.libreoffice.org/68744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-05rename CuiConfigGroupBoxResource_Impl back to SvxConfigGroupBoxResource_ImplCaolán McNamara
Change-Id: I21e9258f5f57acd5e27cee5c1cca37b8b56f3040 Reviewed-on: https://gerrit.libreoffice.org/68702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05unused SfxConfigGroupListBoxCaolán McNamara
Change-Id: Ia31f70b0d22b4bca13e46f3fbce440288bafd26f Reviewed-on: https://gerrit.libreoffice.org/68700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05weld SfxAcceleratorConfigPageCaolán McNamara
fixes a leak in the KeyList too Change-Id: I603218ff99481bc006df329c770ea6fe6f147483 Reviewed-on: https://gerrit.libreoffice.org/68694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-05re-land "new loplugin typedefparam""Noel Grandin
This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-04tdf#42949 Fix IWYU warnings in include/linguistic/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iec1ca76e9b3a0896a732ab2b7fd34dd5a7f219fb Reviewed-on: https://gerrit.libreoffice.org/68367 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-04Revert "new loplugin typedefparam"Noel Grandin
This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8. This is not ready to land yet, seems like the latest update of the logic reveals a bunch more places I need to fix before it can land.
2019-03-04new loplugin typedefparamNoel Grandin
verify that parameters use the exact same typedef-names (if any) in definition and declaration Change-Id: I55d2817f599b0253904dce2d35a1a93967e15a77 Reviewed-on: https://gerrit.libreoffice.org/68439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-03can rename CuiMacroEventListBox back to MacroEventListBox nowCaolán McNamara
Change-Id: I2f88488e7bb931238a31eb62f616c33c60c7ec2e Reviewed-on: https://gerrit.libreoffice.org/68650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-03weld SvxMacroAssignDlgCaolán McNamara
and SvxEventConfigPage, SvxMacroTabPage_, SvxMacroTabPage Change-Id: I98a2e71794f098015927dc7cd7ec4e258f56e703 Reviewed-on: https://gerrit.libreoffice.org/68649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-03Fix typoAndrea Gelmini
Change-Id: I405a69e54efef1cf86e9039659fd63573763d090 Reviewed-on: https://gerrit.libreoffice.org/68633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-02weld SvxIconSelectorDialogCaolán McNamara
and use a ValueSet here instead of the odd toolbar use Change-Id: Ic2e78664ebde31751055d2c9fec66c7dabe8d05f Reviewed-on: https://gerrit.libreoffice.org/68598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-02tdf#122790 Improve background tab page for writer tablesJim Raykowski
This patch improves the new background tab page use for setting Writer table cell, row, and table backgrounds. Now cell, row, and table backgrounds fill tab page according to the fill style of each and can all be set in the same opening of a Table Properties dialog. This patch also makes the Reset reset background settings to initial settings of dialog opening. Change-Id: I567ef9229232f02d98b45a81309e920dca854bed Reviewed-on: https://gerrit.libreoffice.org/66844 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-03-01weld CuiAboutConfigValueDialogCaolán McNamara
Change-Id: I91f5fb2bcd7eb365214278d9683d71c78ad45617 Reviewed-on: https://gerrit.libreoffice.org/68547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-28GetDialogController not valid yetCaolán McNamara
Change-Id: I476744d8f351f4ab2afce5974355a066edc8a4a6 Reviewed-on: https://gerrit.libreoffice.org/68489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Related: tdf#123711 better optimal size for highlighting tabCaolán McNamara
it only uses the color subtab, so just measure ones which can be visible Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784 Reviewed-on: https://gerrit.libreoffice.org/68431 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27weld LicenseDialogImplCaolán McNamara
Change-Id: I4b2dbd2446779e7179d2b79bf81cc2ff879377bf Reviewed-on: https://gerrit.libreoffice.org/68389 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Related: tdf#123711 make border page potentially narrowerCaolán McNamara
use size groups to align things rather than forcing homogenous cols Change-Id: I4a1496f15663c4dcbcd6aaf3ea7901c9c7b170d2 Reviewed-on: https://gerrit.libreoffice.org/68427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Remove redundant conditionArkadiy Illarionov
Change-Id: I21385a37a5e2107069919250dd35812ac5972422 Reviewed-on: https://gerrit.libreoffice.org/68411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:simplifybool improve search for negated operatorNoel Grandin
Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34 Reviewed-on: https://gerrit.libreoffice.org/68379 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-25loplugin:unusedfields in cuiNoel Grandin
Change-Id: Idf3cea56649c0f6eeb6c901ac33b128eb2dd97fb Reviewed-on: https://gerrit.libreoffice.org/68278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22weld SvxScriptSelectorDialogCaolán McNamara
Change-Id: I885acfcdfd9544d7f4eb0e602a7acf0215cb9d92 Reviewed-on: https://gerrit.libreoffice.org/68220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-22weld SvxScriptOrgDialogCaolán McNamara
Change-Id: Ic196887e963bb96f330e47a7a507c143f95e7a61 Reviewed-on: https://gerrit.libreoffice.org/68204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-22these are dialog titles, so no use_underline for mnemonics wantedCaolán McNamara
Change-Id: I88c684c88df391beb62415240580064e97fe87f0 Reviewed-on: https://gerrit.libreoffice.org/68173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-22update commentCaolán McNamara
Change-Id: I5972213747dcb453ff9076d48747772c3f528fd7 Reviewed-on: https://gerrit.libreoffice.org/68181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21menu of currency combobox in format-cells is too narrowCaolán McNamara
we want the combobox to be narrower than it wants to be. To make that happen we have only the option of shrinking the cell renderer of the combobox area. And that is also used by the menu. Setting a small value of e.g. 1 works to let the combobox not request more width than that, and the combobox will correctly render within the wider size it actually gets. But then the menu is a min width menu, which is undesirable, we want the menu to be as wide as it can be. So calculate what part of the combobox belongs to the cell area and set the widest cell area we can within the overall combobox width, resulting in the widest menu we can get. Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f Reviewed-on: https://gerrit.libreoffice.org/68167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21missing standard border-widthCaolán McNamara
Change-Id: I4aa1fd132e3d6e153bdc03a51bf81469301eb1fb Reviewed-on: https://gerrit.libreoffice.org/68169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21weld HangulHanjaConversionDialogCaolán McNamara
Change-Id: Ia41f1a03581a0a48d59706ac5b3c569fc39c7f4d Reviewed-on: https://gerrit.libreoffice.org/68099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20drop unused argumentCaolán McNamara
Change-Id: I5d229a0afb822c9e7b81d3d8f27962c52d27d815 Reviewed-on: https://gerrit.libreoffice.org/68094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20m_pIgnoreNonPrimary is not usedCaolán McNamara
Change-Id: I86198f7b4476a2a7b61daf3f21f3bd43a18de77f Reviewed-on: https://gerrit.libreoffice.org/68070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-20minimumSize is overwritten so CalcMinimumSize is unusedCaolán McNamara
Change-Id: I4161ed90d9e8c7d540fab1df0535ec9213d1ddc4 Reviewed-on: https://gerrit.libreoffice.org/68067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19weld ChineseDictionaryDialogCaolán McNamara
and ChineseTranslationDialog Change-Id: I3b754c405c8379fc0c5fa94437cc0464a1dea999 Reviewed-on: https://gerrit.libreoffice.org/67991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17weld HangulHanjaOptionsDialogCaolán McNamara
Change-Id: Ic155a1f393bfcc95e094ed194acba0d98fce248d Reviewed-on: https://gerrit.libreoffice.org/67945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17weld HangulHanjaEditDictDialogCaolán McNamara
Change-Id: If0d49a65735b66eaa8db11686099ed29b01711c4 Reviewed-on: https://gerrit.libreoffice.org/67929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16Options pops up a dialog, so add ... to itCaolán McNamara
Change-Id: I01a72c0a74fa4a57dd641f8d513a28b35f1e2dcd Reviewed-on: https://gerrit.libreoffice.org/67916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16tdf#123021 Fix options dialog cancel doesn't cancel chart color changesJim Raykowski
...and add missed variable inititialization in options uitest that causes Jenkins to report test failure when testing patches concerning options charts default colors page. Change-Id: I324bcbb7834abf1a270bfce01eb84db280420409 Reviewed-on: https://gerrit.libreoffice.org/67236 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-14Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14weld MacroSecurity clusterCaolán McNamara
MacroSecurity, MacroSecurityLevelTP and MacroSecurityTrustedSourcesTP Change-Id: I0c3494a051cdac2723710484d5e00146d3f3dfe7 Reviewed-on: https://gerrit.libreoffice.org/67797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14[API CHANGE] add setParentWindow to XDocumentDigitalSignaturesCaolán McNamara
so we can specify which window modal dialogs are modal to Change-Id: I7cd7348b5cd0f55d698553f313f745d5e0d6389d Reviewed-on: https://gerrit.libreoffice.org/67765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-12merge together as get_checkbox_column_widthCaolán McNamara
Change-Id: I183d2d94ab60c128b136674ef40eeb30057b281c Reviewed-on: https://gerrit.libreoffice.org/67714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12weld ScSolverOptionsDialogCaolán McNamara
Change-Id: I940fe1c5b4edf41c66a729c56fa789488fd39ba6 Reviewed-on: https://gerrit.libreoffice.org/67713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12“Fax” has never been an initialism—don’t write it thusAdolfo Jayme Barrientos
It was originally short for “facsimile”. Change-Id: Icaadde5c1beaf8bbbc72144a7ce60f96794f8a33
2019-02-11weld SvBaseLinksDlgCaolán McNamara
Change-Id: I40afcb99ae0e8fd27387077aea688906f037d6f4 Reviewed-on: https://gerrit.libreoffice.org/67676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11Resolves: tdf#123309 destroy menu before menubuttonCaolán McNamara
Change-Id: Ib6b179c460bed4ffdcc2678294633004bbae816a Reviewed-on: https://gerrit.libreoffice.org/67677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-10weld FmSearchDialogCaolán McNamara
Change-Id: If7e87f725ea44732080fc0c57e4503c82b0cf4a0 Reviewed-on: https://gerrit.libreoffice.org/67595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09weld SvxSearchAttributeDialogCaolán McNamara
Change-Id: Ib929afd143cd02b49f87ae6d910500354197e826 Reviewed-on: https://gerrit.libreoffice.org/67572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-15 17:51:29 +0000