summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2020-11-03Resolves tdf#137059 - Use application colors for font previewHeiko Tietze
Background is set to document's application color now (options > application colors > document) to provide a true WYSIWYG experience (except for modifications to the page background color). Change-Id: Ifd78e667f3eeff3573ff09bcb4d2a9634dd49c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105011 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03tdf#137912 update toolbarmode previewsandreas kainz
Change-Id: Ic326758b3c25a4acd22dd5a029619b1972f43267 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105245 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-03ucbGet needs a non-null interaction handler after allStephan Bergmann
In db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files", I had not further investigated why using the (GUI) interaction handler within utl::UcbStreamHelper::CreateStream would lead to deadlock during UITest_sw_options (UITEST_TEST_NAME=optionsDialog.optionsDialog.test_moreIconsDialog). Instead, I had passed a null XInteractionHandler into utl::UcbStreamHelper::CreateStream, assuming that would solve whatever the issue was (and it did make the UITest pass). However, that caused the AdditionsDialog to not be populated at all, with > warn:cui.dialogs:26878:26950:cui/source/dialogs/AdditionsDialog.cxx:95: Reading <https://yusufketen.com/api/Templates.json> failed with 0x20d(Error Area:Io Class:General Code:13) (see comment at <https://bugs.documentfoundation.org/show_bug.cgi?id=137922#c1> "Extensions button in Template choose does not show anything"), because interaction requests like com.sun.star.ucb.CertificateValidationRequest were not handled properly. As it turns out, the real reason for the deadlock was that the UITest quickly closes the dialog, causing the main thread to block at m_pSearchThread->join(); in ~AdditionsDialog waiting for the SearchAndParseThread to finish, while SearchAndParseThread::execute encountered a CertificateValidationRequest that needs to be handled and thus blocks in UUIInteractionHelper::handleRequest (uui/source/iahndl.cxx) waiting for the main thread to process the PostUserEvent. In an ideal world, the UCB would allow to cancel the download request issued from ucbGet while that download is waiting for the CertificateValidationRequest to be handled, and the AdditionsDialog CloseButtonHdl would initiate such cancellation. Lacking that, just keep the Close button disabled until the SearchAndParseThread has finished downloading. (Pressing the Close button earlier, ~AdditionsDialog would have blocked the main thread anyway until SearchAndParseThread had finished downloading, so this should not actually worsen the user experience. And the UITest now blocks waiting for the Close button to become enabled before pressing it; there would already be UITest.wait_until_property_is_updated available, but it has a hard-coded timeout which might or might not be relevant in existing uses of that function, so leave it alone and repeat the relevant code without an unhelpful timeout here.) This means that the additional utl::UcbStreamHelper::CreateStream overload introduced in db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files" is not necessary after all, so remove it again. Two further items that should be looked into: * Should ucbGet pass the AdditionsDialog into utl::UcbStreamHelper::CreateStream as css::uno::Reference<css::awt::XWindow> xParentWin argument (which defaults to null)? * There might be similar deadlock issues involving ucbDownload, which can also be called (indirectly) from SearchAndParseThread::execute. Change-Id: I8d549066940fa4f259a814a31ec7c62960e0db8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105169 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-11-03Drop the #undef ABSOLUTE FIXMEStephan Bergmann
c4bee547b02fbe3d07b1e9ee203c73e48f86e6bf "tdf#133026: Additions: Better Search Function" does not tell which #include had brought in the macro definition. It might have been the #include <curl/curl.h> that has meanwhile been dropped with db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files". Change-Id: Ib9cf761ca11e5cb7496b21dc04faee3491ef9dcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-02Cell Alignment Dialog updateandreas kainz
Change-Id: I86954c4fa8910d8d7e4d4e815ffcd600e2b11c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105161 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-02use officecfg or MacroRecorderModeNoel Grandin
Change-Id: I2a8d4f401ddfd4368a7b50b4c3c8a72724f9afa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemPrintDialogNoel Grandin
Change-Id: I0e0bdc925f106884cbcede6405cc6ef7152ad405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-29have just the one handler for ok/apply optionsCaolán McNamara
'apply' is only really working the first time it is pressed in a page, I want to be able to apply to change e.g. notebookbar icon size and then change that again and apply and get the expected display size Change-Id: I7f051ad4063f0e99f822cc06fbe4a0ab49588fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29call ExtPage::DeactivatePage for apply as well as okCaolán McNamara
I think the concerns at https://gerrit.libreoffice.org/c/core/+/54980/ are on balance overly conservative and its safer to make apply behave the same as ok wrt that call Change-Id: I889290c23dc9a7d4bb751769a509932142be5795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29move block for RET_OK conditional return into Ok handlerCaolán McNamara
making it clearer what happens on "ok", no logic change intended Change-Id: I1d57500d2fbeded4cd7c7fd48fd1f4296b78e41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105018 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29Options Viewpage widget alignment updateandreas kainz
Change-Id: Ib8f0cfb9c46e7c8c13f07d956fc79f648998509a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104986 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-28Use UCB instead of cURL to download https filesStephan Bergmann
Since 7dc6fc32eb618da6defb8a9f330978fa019677b8 "uitest: Check the more icons dialog opens" started to test the AdditionsDialog code, some ASan builds started to report use-after-poison from within SearchAndParseThread::execute -> curlGet -> curl_easy_perform -> ... -> https_connecting -> ... -> secmod_ModuleInit -> pemC_Initialize -> ..., see the comments starting at <https://gerrit.libreoffice.org/c/core/+/98226/ 10#message-2a55980ab2477e41dc7515e4aeabc7234afc2053> "tdf#133026: Tight integration of extensions - Adding thread structure". The exact cause for that ASan use-after-poison is not quite clear to me. First, I thought it was due to liberal use of curl_easy_init (without a central curl_global_init) in a multi-threaded process; see <https://curl.haxx.se/libcurl/c/curl_easy_init.html> for this being considered "lethal". But then, another issue could be that most of the nss libraries like instdir/program/libnss3.so (implementing the "... -> secmod_ModuleInit" part) come from LO's bundled --without-system-nss while /lib64/libnsspem.so (implementing the "pemC_Initialize -> ..." part) comes from the system, and there could be some mismatch when mixing these (esp. if the former are built with ASan). So whatever the actual cause, the right fix should be to use LO's UCB instead of directly calling into cURL anyway. That required a version of utl::UcbStreamHelper::CreateStream that uses a given XInteractionHandler (which may be null to indicate no interaction handling, instead reporting all interaction requests as exceptions) instead of internally creating an XInteractionHandler using the GUI, and which would cause deadlock in 7dc6fc32eb618da6defb8a9f330978fa019677b8's UITest_sw_options. (And introducing that additional utl::UcbStreamHelper::CreateStream overload required css::awt::XWindow to be a complete type now in vcl/source/graphic/GraphicLoader.cxx, for > include/com/sun/star/uno/Reference.h:277:18: note: in instantiation of variable template specialization 'std::is_base_of_v<com::sun::star::task::XInteractionHandler, com::sun::star::awt::XWindow>' requested here > std::is_base_of_v<interface_type, derived_type> > ^ ) (The removed code in cui/source/dialogs/AdditionsDialog.cxx should have been the last remaining use of curl in Library_cui. Apparently, e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 "Kill Mozilla personas" had forgotten to remove it from cui/Library_cui.mk the last time Library_cui had become curl-free, before the introduction of the AdditionsDialog code.) (I did not remove the #undef ABSOLUTE FIXME from cui/source/dialogs/AdditionsDialog.cxx. c4bee547b02fbe3d07b1e9ee203c73e48f86e6bf "tdf#133026: Additions: Better Search Function" does not tell whether it had been added to mitigate a macro definition from the (now removed) #include <curl/curl.h>.) Change-Id: I1fec7488d36df81c3543d12d97da1291f77712fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-28cid#1468666 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Ie27df6c7e4a10d943d0a2e2a6880a5fe2c34fbcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-28tdf#137790 calc: Minimal line width for different line stylesSerge Krot
Change-Id: I4d062f054a5ef6da7ef595190a7b3c6e2a0b191e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104865 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-28Extend loplugin:elidestringvar to OStringStephan Bergmann
(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-27Partially resolves: tdf#127279 Change "register-true" to "Page line-spacing"Seth Chaiklin
in Page and Paragraph For all places in UI where "register-true" appears, change to "Page line-spacing". -For Paragraph dialog, remove section heading and rename checkbox to "Activate page line-spacing" -For Page Style dialog, change label to: "Use page line-spacing" -Add tooltip and extended tooltip in Paragraph dialog; -Shorten tooltip in Page dialog, and add extended tooltip Bonus: -Add tooltip to "Automatic" in Paragraph dialog -Remove contraction in control label (in accordance with UI guidelines) Change-Id: I826ce35051b1d2c04f0e52d4e9fe4e6cfd1d7cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104331 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-27Teach loplugin:toolslong about curl_easy_getinfoStephan Bergmann
...see a9266c39cc71c6f23bfcad4ff6d33ccac53b5e52 "loplugin:toolslong (--enable-online-update)" arguing that "the third argument to curl_easy_getinfo(..., CURLINFO_RESPONSE_CODE, ...) must be a pointer to long". Change-Id: I7c542595219d2387cf869953fe40faef2b41b44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104857 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-26Fixes to TipOfTheDayHeiko Tietze
Callback removed Change-Id: I09eb95004151cf2ca068a0c23c02267d89b0ba20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104800 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-26tdf#137650 sw page top border relative orientation: add UISzabolcs Toth
as new menu item "page text area top" of Position/Vertical popup menu "to:" in Position and Size dialog window of shapes. Follow-up of commit 1c593e1916c9164c7db71da2017cfc26972f8e9f (tdf#133045 sw: add shape alignment to the top page border). See also commit 8af2c4e3a517e3b75f2ace9719c1ca03153baddf (sw from-bottom relative orientation: add UI) Change-Id: I98671fa9c7c184c8f360ccb35e671df68cd271b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104661 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-24Show animated GIFs in TotDHeiko Tietze
marchingants.gif added as an example Change-Id: I555aebc4a4e191b8afb4be06dfc1e5f3e6d1a911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104718 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22Don't make list of JREs active when parent frame is inactiveMichael Weghorn
When the Java framework's direct mode is used, there is no use in allowing the user to change the Java options in the "Advanced" options page, so the corresponding frame is grayed out, s. commit 2976590ed9f727c24064c97d80a51e9891253119 ("Gray out Java options when framework's direct mode is used", 2020-10-21). For the native gtk3 implementation, this also means that the child widget holding the list of JREs ('m_xJavaList') automatically remains grayed out as long as the parent widget ('m_xJavaFrame') is. However, it turns out that this is not true for the plain VCL implementation (used e.g. by the gen or kf5 VCL plugins) where the child widget can be made sensitive while the parent widget is insensitive. Therefore, commit 3935a0bd3bcf747aa9bede59b045d23ab598f2d4 ("Properly (un)tick Java checkbox in Java options in direct mode", 2020-10-21) resulted in the widget holding the list of JREs becoming active again when the 'EnableHdl_Impl' handler was called in the non-gtk3 case (while the parent widget and the buttons to add JREs, edit Java parameters and classpath would remained grayed out). Make sure the widget holding the list of JREs remains grayed out along with the whole frame holding the Java options. Change-Id: Ic46bf317afec9bc566493ec56ab5319a78050da0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104657 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-10-22Resolves tdf#137607 and tdf#137500 - Improvements to TotDHeiko Tietze
Shows tooltip for UNO commands Check if the UNO command is available in the current module Don't show the menu entry on the start center Change-Id: I5c67ec3f8543b5442a6e2c2a478bfeb4ec0e1f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104558 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-22Properly (un)tick Java checkbox in Java options in direct modeMichael Weghorn
While the Java settings cannot be changed when the direct mode of the Java framework is used (s. Change-ID Ife017f9b5c6c6488f84201dd78b23305c67bec1b, "Gray out Java options when framework's direct mode is used"), it still makes sense to (un)tick the (grayed out) checkbox which indicates whether a JRE is used or not, which depends on whether the JRE that is set (e.g. via env variable 'UNO_JAVA_JFW_JREHOME') is usable or not. Change-Id: I13822bb7535e3f05cbc6ef83b3c82e2739c45ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104064 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-10-22Gray out Java options when framework's direct mode is usedMichael Weghorn
The 'javasettings_${_OS}_${_ARCH}.xml' files are only meant to be used when the application mode of the Java framework is used, not in direct mode. From ure/source/README: > You can also use the > UNO_JAVA_JFW_JREHOME deployment variable to specify the location of a JDK/JRE > installation. For more information on this variable, see > http://udk.openoffice.org/common/man/spec/javavendorextension.sxw. From that http://udk.openoffice.org/common/man/spec/javavendorextension.sxw : > The direct mode of the framework is used within the build environment. > Java is needed there in order to register Java UNO components with the > regcomp tool. Direct mode means that no settings are written or read. > That is the parameters UNO_JAVA_JFW_USER_DATA and > UNO_JAVA_JFW_SHARED_DATA are not used. > [...] > Another example for using the direct mode is the SDK. The SDK uses the > libraries from the office installation. When an SDK is configured then > one specifies what Java is to be used. This Java shall then be used for > all task which require Java including registration of UNO components. In > order to override the java settings of the office the script which > prepares the SDK environment sets these environment variables: > UNO_JAVA_JFW_JREHOME=<file_URL_to_selected_Java> > UNO_JAVA_JFW_ENV_CLASSPATH=true > UNO_JAVA_JFW_VENDOR_SETTINGS=<file_URL_to_javavendors.xml_from_OOo> > By setting UNO_JAVA_JFW_JREHOME the framework is switched into direct mode > and the office settings are disregarded. Therefore, gray out the Java options in the "Advanced" page in "Tools" -> "Options" to not give the user the wrong impression that settings made there actually have any effect when using direct mode, e.g. by starting LibreOffice like this UNO_JAVA_JFW_JREHOME=file:///usr/lib/jvm/java-11-openjdk-amd64/ ./instdir/program/soffice --writer and then realizing on restart that all manually made settings were discarded (e.g. newly added Java installation does not show up,...). Change-Id: Ife017f9b5c6c6488f84201dd78b23305c67bec1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104002 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-10-21Fix typosAndrea Gelmini
Change-Id: Ia66e31a0ad71dde1a6c1caa911d6083e1fb9eb61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104538 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-21use tools::Long in comphelper..cuiNoel
Change-Id: I65167999c6049038f8f5d530a0c5cb0552ab0e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21new tools::Degree10 strong typedefNoel Grandin
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20Related: tdf#137608 use same max-page in textflow as insert, breakCaolán McNamara
table-textflow too as well as para-textflow Change-Id: I779d61389ed0b3e424dbe830cf063fab8db13360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104566 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20clean up handling of the UI Skia optionsLuboš Luňák
Disable the sub-option when the main option is disabled. Enable it for the proper VCL backends ("win" and "gen"). Change-Id: I38c2f605c10eb0f3cfae3f05cd4bada4877cdc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104426 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20remove ui for 'forceskia' AKA 'ignore skia denylist' (tdf#137159)Luboš Luňák
I originally copy&pasted this from the OpenGL code, but now that I think of it, having an easy checkbox to make LO use drivers that LO decides are faulty is a bad idea. There's still the expert configuration if somebody insists (and if they're not expert enough to find the expert setting then they better not mess with it), but this is asking for unnecessary trouble. This also solves the problem that the UI option is misleading. As the description in Common.xcs says, "This one forces the use of Skia even if the denylist would block the driver.", so the option is independent of the 'enable skia' option, but the UI didn't make it appear so. Change-Id: I74bf3574f16899405272dbb3aec54580a5e3f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104425 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20Beautification of code and fix for on-/offline helpHeiko Tietze
Change-Id: I0c731f2c472ceb435f529956011a7fd5a00a27ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104358 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-18clang-format customize/SvxToolbarConfigPageMuhammet Kara
Change-Id: If9b3fcbaa8e900d73c8dd0e727b4059c3b30ac01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104485 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format customize/SvxMenuConfigPageMuhammet Kara
Change-Id: I9ad8012d31c8e727fa4c8c840f15a93ca47541cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104483 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format customize/SvxConfigPageHelperMuhammet Kara
Change-Id: Ia802bfc4a6cd8d970fbb3c37a55959729ea19257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104481 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18clang-format CommandCategoryListBoxMuhammet Kara
Change-Id: If7ae64a0b9be01b3fa73310a4d9834ae3c151c10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104479 Reviewed-by: Yusuf Keten <ketenyusuf@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Jenkins
2020-10-18tdf#137460: Additions: Fix crash on error 404Muhammet Kara
Change-Id: Id1eb6d43add5d5d9c9f6c09a1e5a4137462f596e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104473 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-16Resolves: tdf#137508 use AtkObject::accessible-roleCaolán McNamara
Change-Id: I385d16668a7145cc2f6a6574533b07281e36d37a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-15tdf#137432 only do EnableInvalidate(false) optimization when not shownCaolán McNamara
Change-Id: If7f35d19061a7a2db2e5df31227834526bbf0905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-15Use correct icon on additions dialogHeiko Tietze
Change-Id: If0dd70721dd5edd95a46f8735fe1d90b6843a2af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104355 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-10-15This field only holds a compile-time constantMike Kaganski
Change-Id: I9796f97af5d45211b67070fc020547e2b63ef411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104348 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-14tdf#137294 don't change subset sensitivity after setting search modeCaolán McNamara
Change-Id: Iaa76e2bc8029ac8f8a52b0c45f74b57395090088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Fixes to TipOfTheDay dialogHeiko Tietze
* Reverts 231a4e024b85aa0ad06a5632d3f514152babea30 and sets initial value to -1 to start from zero * Improves translatability of string Change-Id: Ib541a72fa3f6eecdf5bbdf17ce2a4e56ff90c397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104276 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-10-14Resolves: tdf#137382 update label to "Keep inside text boundaries"Seth Chaiklin
was "Follow text flow" uses same non-conflicting keyboard accelerator as before 'x' Change-Id: I61d93f0c73efc813a71f8625c38caebccdac5793 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104163 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-14Fix of accessibility warnings for the additions dialogHeiko Tietze
Adds also an icon to the dicitionaries linkbutton Change-Id: I49d40f92bd055ec976dd1ba8f02e9c88064512b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14Resolves tdf#137429 - Ensure first tip is shown firstHeiko Tietze
Starting in safe mode (or the first time) shows now array[0] instead of [1] Change-Id: I50643c4443705a5137080c6dbdb1ad329151b308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104230 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-14Resolves tdf#137447 - Access icon themes via tight extensionsHeiko Tietze
Button and code added to optgdlg Change-Id: Ib4aa0883a6af2844ab68ed3c0b7f0e21bc655d94 Signed-off-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-13Resolves tdf#137424 - UI Picker missing 'Contextual single'Heiko Tietze
Exclusion by experimental on/off updated Change-Id: I714b8ffc5a148d09607ab20763b6d35de2a9e2be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104231 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2024-07-19 02:03:21 +0000