summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-16convert dialog result methods from long->sal_Int32Noel Grandin
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c Reviewed-on: https://gerrit.libreoffice.org/41206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16tdf#111797 Fix alignment of 'For the current document only' checkboxGabor Kelemen
Change-Id: Ie7cc004e02e3bb1ac8d52a9c0b67b9fa9f946c8c Reviewed-on: https://gerrit.libreoffice.org/41167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-15Disable subset LB when search mode is enabledAkshay Deep
Change-Id: Ic8fa88f1e471fe3eab965e5f0106de0348e62ec0 Reviewed-on: https://gerrit.libreoffice.org/41161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-15tdf#111337 - Introduce alternative workflows at the special characters dialogAkshay Deep
Change-Id: I6a8fe2476adc5c4379c76dfaef090d1b5cd81ea0 Reviewed-on: https://gerrit.libreoffice.org/41170 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-15tdf#109217 - State of the favorite button is not updated immediatelyAkshay Deep
Change-Id: Ibc93277c71e51709d56345e8934f045c60d322ca Reviewed-on: https://gerrit.libreoffice.org/40914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-13move the SvxBackgroundColorItem<->SvxBrushItem conversionCaolán McNamara
into the dialog itself Change-Id: I83db9f02145a4927257dd5691f82dad1a11eaea6 Reviewed-on: https://gerrit.libreoffice.org/41029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-12tdf#105966 Solved Increment:Automatic checkbox problem in Area->Gradient tabpv2k
Change-Id: I7025b63df830853867b1b6dd17b7985ec16be83b Reviewed-on: https://gerrit.libreoffice.org/38882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-11vcl: use default copy-ctor for TextAttribJochen Nitschke
Type of TextAttrib (mnWhich) never changes, const it up. Derived classes can use implicit default copy-ctor. No need to explicitly delete default-ctor if there is a user provided ctor. And no need to define a default override dtor here either. Change-Id: I7a0d1896f659801319dc5fa74844df94c5888a7b Reviewed-on: https://gerrit.libreoffice.org/41022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11Revert "Build with kde5, first stab"Katarina Behrens
this was meant to go to a feature branch *sigh it must be Friday
2017-08-11Build with kde5, first stabKatarina Behrens
this is largely based on jmux's work Change-Id: I5897f3ecb90f83a29e0824bfe7a0ea875347e360
2017-08-11Remove useless if checkMuhammet Kara
And the return in the default case, which could cause the UI element to stop updating Change-Id: I29d35818b015f71890f615a02ea215034c048326 Reviewed-on: https://gerrit.libreoffice.org/41020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-11improve scoping a littleCaolán McNamara
Change-Id: Ie2e86852f7c4754070d3eb7e8981d674f04a6d80
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11tdf#109216 - Alignment/spacing at the new controls in the special charactersAkshay Deep
Change-Id: I7c07750e131060fb8ba796e7dcdc5f5bafcb1d74 Reviewed-on: https://gerrit.libreoffice.org/40916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-10Search feature for Special CharactersAkshay Deep
1. Name data stored in map 2. Retrive the data to compare with search string 3. create search control 4. populate search results 5. Read-only subset listbox meanwhile Change-Id: I689bbee0dd9a226261c37a5824af7f83a510167d Reviewed-on: https://gerrit.libreoffice.org/40563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-09Resolves: tdf#111416 missing draw/impress optionsCaolán McNamara
Change-Id: I2dc3627e754670b9fa4c799a6728bdb16b3dc983 Reviewed-on: https://gerrit.libreoffice.org/40910 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-07Rename “Basic IDE Options” to just “Basic IDE”Adolfo Jayme Barrientos
None of the other Options/Preferences pages have the word “Options” in their names, because: a) it’s obvious that they’re options, and b) having that word repeated there contravenes the macOS convention of calling the options “preferences”. Change-Id: I7349d20eefc50d5a92d6442a256249f64db688e7
2017-08-06tdf#109863: use SID_PATTERN_LIST after bitmap tab convertingJulien Nabet
instead of SID_BITMAP_LIST Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I880ca149d5865ed5b80c57d7c5b390cc5606d66c Reviewed-on: https://gerrit.libreoffice.org/40798 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-04rename SIP_SA_EDGELINEDELTAANZ->SIP_SA_EDGELINEDELTACOUNTNoel Grandin
and SIP_SA_EDGELINEDELTAANZ->SIP_SA_EDGELINEDELTACOUNT Change-Id: Ib6c370025a56586df1cdf7abcab2f0dfe599a64a Reviewed-on: https://gerrit.libreoffice.org/40738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02split out VclBuilder static methodsCaolán McNamara
Change-Id: Ic94b39351c9a6131fb61883a98ae9e3ee60ad119
2017-08-02tdf#110448: Remove "Memory" page from Options dialogMike Kaganski
The relevant caches settings are still available under Expert Configuration: /org.openoffice.Office.Common/Cache/GraphicManager/TotalCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectCacheSize /org.openoffice.Office.Common/Cache/GraphicManager/ObjectReleaseTime /org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects /org.openoffice.Office.Common/Cache/Writer/OLE_Objects Change-Id: I7692fd94a873ba7220a21d51ff8a943598c6a9fc Reviewed-on: https://gerrit.libreoffice.org/40640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:constparams in cuiNoel Grandin
Change-Id: I5f3e4ba8d953bbce22c3c359bb1c3ae2ac47eb1d Reviewed-on: https://gerrit.libreoffice.org/40593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31Resolves: tdf#109007 SvxCharView is in sfx2 not cuiCaolán McNamara
Change-Id: I54f19f61161f3473cbdf2b1bfdc04e9354cc39a8
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28add comment on max char name lengthCaolán McNamara
Change-Id: I9e542f6e131de1a05dd54a84a260453ea2edcb62
2017-07-28merge duplicate blocksCaolán McNamara
Change-Id: I62e021b2ec7ac9df122389fd128f7a7770317a43
2017-07-28check that u_charName was successfulCaolán McNamara
Change-Id: I55896eb939a864c3437e3f3c5b13c272966e4b85
2017-07-28replace snprintf with our own convertersCaolán McNamara
Change-Id: I27b0b82ac5be631c0d47f486603e241026dcabd9
2017-07-28pass char code directly rather than as-textCaolán McNamara
and then turning it back into the code again Change-Id: Iae9cddb18a6bdad4b1ba8c2af81f3d29a7f26725
2017-07-28declare at init pointCaolán McNamara
Change-Id: I986352cd2db4a9bd794ec25fbef9168be08a70ce
2017-07-28Unicode Character Names Integration using ICUAkshay Deep
Change-Id: I0624690f8af05adb2466219a4e508e634c490ef1 Reviewed-on: https://gerrit.libreoffice.org/40436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-27Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumerCaolán McNamara
inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected Change-Id: Ifccb1657d2565005e6f9e239c6118f2e5ae7970c
2017-07-26tdf#36747 add sort to match format list in file dialogsJames Raykowski
Change-Id: Ia2883bfe4c020b5c9664eef3001fc90a99c82981 Reviewed-on: https://gerrit.libreoffice.org/38375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25Clear Recent View and Fav view using Right ClickAkshay Deep
Conflicts: sfx2/inc/doc.hrc sfx2/source/doc/doc.src Change-Id: I0aa2919815a3fa63ee180b808834a8aa760af649 Reviewed-on: https://gerrit.libreoffice.org/40234 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25convert UNO event ids to scoped enumNoel Grandin
I'm fairly sure there are more simplifications that could be make here. It seems like we have both an ID and a string name for all of these events, and we could probably get by with just one of those, or alternately, centralise the name<->id mapping somewhere Change-Id: I978073822ddbebce94ac5b560fea675bea905a35 Reviewed-on: https://gerrit.libreoffice.org/40392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24loplugin:unusedfields readonly fieldsNoel Grandin
Change-Id: I6629926df06f71ff86e9fb23ae4fc1ae73bc9406 Reviewed-on: https://gerrit.libreoffice.org/40360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22Add new helper class to cui for SvxConfigPageMuhammet Kara
And kill the temporary namespace killmelater. This class will contain helper functions/methods for use of the tab pages of the Customize Dialog. Change-Id: I63a05c9495a79009ed5b47f7790a46cff9f58c6a Reviewed-on: https://gerrit.libreoffice.org/39617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-on: https://gerrit.libreoffice.org/40308
2017-07-22Cleanup duplicate functions in cfg.cxxMuhammet Kara
And move all helper functions to the temporary namespace killmelater Change-Id: If74102209a05b8d28c96d51a623ac14c1700630c Reviewed-on: https://gerrit.libreoffice.org/39404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40302 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-22loplugin:unusedfields in cppcanvas..cuiNoel Grandin
Change-Id: I1cf1f7919e03d863c6f7756e1caf3b9313777479 Reviewed-on: https://gerrit.libreoffice.org/40294 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22Separate SvxToolbarConfigPage from cfg.cxxMuhammet Kara
Change-Id: I4aa504b92e9507635152c623a07d0538079860de Reviewed-on: https://gerrit.libreoffice.org/39389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40297 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-21add msgctxt to new stringsCaolán McNamara
Change-Id: I3a0a7620c9ed0aec438d149bee80c6979b0a3bd7
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e