summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-01-25Related: tdf#146971 remove %PRODUCTNAME from accessible-descriptionCaolán McNamara
Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25Related: tdf#146971 rename %PRODUCTNAME Macros to Application MacrosCaolán McNamara
Change-Id: I6a11c335b28cfaeaceba93b22e7d2db30ee803db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-24gtk4: adapt to window_[g|s]et_default_widgetCaolán McNamara
Change-Id: I916e5db05f8ea10ecc8b319cc77a671ca7cbcb93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128859 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-21tdf#145517 Reduce overload of term “style” in Options > LO > ViewAdolfo Jayme Barrientos
Change-Id: I23e43e4fdbfb7caded2537e6b92ec74a5b996675
2022-01-20Move credits link to configSamuel Mehrbrodt
as all other related URLs and replace with a hub link, see https://redmine.documentfoundation.org/issues/3569 Change-Id: Ic30f2a5980ae17b5dfff184ead391b21cff7ab7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128660 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-01-20WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)
... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-18tdf#146612 Drop confirmation question when applying new doc hyperlinkGabor Kelemen
To be consistent with other tabs of the dialog where Apply does not show a similar question Change-Id: Id3bced8ec861b7166974da5ad223513dbfec25c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128424 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-18Use "smart" INetURLObject ctor for user input right awayMike Kaganski
... instead of trying to process it strict, falling back to smart processing on error. Similar change was implemented to SvxHyperlinkInternetTp in commit 6b973753d407d66dfa5fda86547246c486ab7087. Trying to parse it strict initially there resulted in wrong detection of "generic" protocol in incomplete URLs missing scheme and having port. This change simply unifies the code, no specific behavior change intended. Change-Id: I48ba4187a27644f42f3fd5a3b6cd77e55038cb0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-16add missing placeholder labelsCaolán McNamara
Change-Id: Iae743fd6d7e13f91501e386e609e5965ef742db0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16restore the explicit translatable="no" for some labelsCaolán McNamara
Change-Id: Ifbb05dc12a02afd11470e868b88d72fa18c1a388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Resolves tdf#139395 - Redesign of font name and effects pagesHeiko Tietze
* Western/CJK/CTL selection placed into a GtkNotebook * Font color and transparency in one line * Alignment adjusted at font effects page * Char-, para- & style dialogs made non-resizable according the guideline Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-15tdf#146754: consider xyz:123 as host:port when parsing URLs smartMike Kaganski
... rather than scheme: and path. Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-14tdf#146703 Rework previous fix to query extension metadataGabor Kelemen
to limit its error potential by encoding only the category string Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-01-14resave with latest gladeCaolán McNamara
Change-Id: I7d41fa2fbfd188c75b690be34f7c9baf6ae20044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13Related: tdf#145625 adapt the reportdesign color section marginsCaolán McNamara
to the changes of: commit 8d2bf9b679dec223a78e1fd8f3684f76c5802bae Date: Wed Jan 12 13:32:13 2022 +0100 Resolves tdf#145625 - Alignment issue at color options Change-Id: I66c43e964b19da3bdfd4f13cc343dc399ae9cd5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13restore some placeholder labelsCaolán McNamara
glade tends to clobber the GtkMenuButtons placeholder labels Change-Id: I2f1e8dd3f9b86e09a9fe7ce311b40a84f298b4a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128377 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-13Recheck modules [a-c]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-01-13Resolves tdf#145625 - Alignment issue at color optionsHeiko Tietze
* Label "On" cleared (kept internally for size calculation) * Deprecated xalign removed * margin-start set to 0, halign=start, valign=center for color labels and checkboxes * margin set to 12 at the right edge to have more space for the scrollbar Change-Id: I32b7c1fc4ad93b1e9fa7b78968eedbbc3580a379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128322 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-12Bump Glade version to 3.38Heiko Tietze
Change-Id: Icddb8f9ee67d929a4fcacde72263439976ff2f4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128315 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-12tdf#142564 Localize extension category namesGabor Kelemen
Change-Id: I57ca7cb194bd325f621841edc24e3af9ef7c3b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128305 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12tdf#146703 Fix URL encoding when querying extensionsGabor Kelemen
so that extension information files are properly downloaded such as: https://extensions.libreoffice.org/api/v0/Color Palette.json Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-11tdf#145919 Localize strings in Graphics Test dialogGabor Kelemen
but not in the saved log file Change-Id: I65c580e7b8762b654f1812c96bc53841b882a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128087 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-10cui: no need to fetch the property from the map twiceTomaž Vajngerl
Change-Id: I7597c352b2ae166657f1e431e3405fc690520afa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128206 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-01-08fix Options->LibreOffice->View->Visibility->Menu on Windows,Noel Grandin
impossible to set to Hide, regression from commit 131759a3db51140c21594308ed99c71aa7aba43a Date: Sun Jul 25 16:21:39 2021 +0200 use officecfg for menu options Change-Id: I5312be2963d15ab85c267ece073e52984b1a34de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07tdf#146423 don't set a size-request during a size-allocCaolán McNamara
and use a better width calculation Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128051 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07add truncate-multiline to match the vcl defaultCaolán McNamara
Change-Id: Idd188ed20191668c412791e8f081be7ca377478f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07Drop unused define CLASSPATH_DELIMITERGabor Kelemen
since commit 200cc2d20a21ceb5d176604f9c384f15c6a87570 (2014) Change-Id: Idf0eb7b484eff26be6b341cbb217572eb8da7306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127809 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-05Fix typoAndrea Gelmini
Change-Id: I8663c82eac06305a2ce7be131c240eacd2e2de9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127281 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-01-05Disable epoxy test with --disable-guiJan-Marek Glogowski
Instead of always testing for DISABLE_GUI, just disable the epoxy test and handle !ENABLE_EPOXY in RepositoryExternal.mk. Change-Id: I38213ffa77353bc93f32caa1b4164c5fa88170ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127999 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-01-04changed CuiResId into SvxResId.Kiyotaka Nishibori
though some translation entries for tooltip for border preset images were in svx.mo, cui/source/tabpages/border.cxx referred the entries to cui.mo with CuiResId route, and the translations was not gotten. this commit is alternative change. Change-Id: Ica7a7ea71f7afe7044104b9d953f1b3edf9c2503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-03loplugin:unusedmethodsNoel Grandin
Change-Id: I922778e8ced0ad922d90a153b0eda47abbec94ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-01Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169
2021-12-31fix ubsan --disable-extensions error seen in oss-fuzz buildCaolán McNamara
i.e. instdir/program/libcuilo.a(dlgfact.o): error: undefined reference to 'typeinfo for AdditionsDialog' Change-Id: I6445632d81ca9d87b44cf9b0be59358ccd8f57ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127791 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-30tdf#145538 Use range based loopsAnkur Khandelwal
* Use range based loops in cui/source/tabpages/swpossizetabpage.cxx + Goal: Better readability of the code Change-Id: I8df81be6d6d628d4f3366bc2de4b3e44adbc430f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123871 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-12-24Recheck include/[s-x]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Iaebddd648c52c175da17d2a55a1e8de82c213f4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127330 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-21tdf#109390 Warn about empty New Document only on Apply, not OKGabor Kelemen
Creating new document type hyperlink shows a warning about empty file name only when pressing Apply, and closes silently on OK Change-Id: I00e7b20a12df8e35e154e3cf532067cbad72c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127010 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-21loplugin:flatten in canvas..cuiNoel Grandin
Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21sd theme: allow setting color effects in the chardlgMiklos Vajna
Which means not only the 12 colors from the theme are offered (which comes from the current master page), but also lighter/darker variants. And once these are selected, their theme index and luminance modulation / offset is also remembered. This means if you pick light blue and later change accent1 from blue to orange, you get light orange out of the box. Change-Id: Ia83b8971ad894d02ed4ec5ca914684fc9cf9a677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127211 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-21Transfer preferred DPI into SfxTabPage with additional propertiesTomaž Vajngerl
This adds to SfxTabPage a new member maAdditionalProperties, to make it easier to transfer additional properties into a tab page. This is then used to transfer the preferred DPI into the tab page, which was previously done by user data, which is less than ideal and always doesn't work. Change-Id: Ia4daa72093d96310009b0065f8a0e26be6bedec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127205 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-12-20sd theme: allow setting the color's theme index in the chardlgMiklos Vajna
This routes not only the rgb color and a name, but also a theme index from the color picker to the chardlg (only there as a start). That way the picked color will be updated if the master page theme changes. Change-Id: I7a45d7cf63c7c36013e4656c66d9b2dbc3aa0b88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127135 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-20Set the original size in crop dialog to preferred DPI calc. sizeTomaž Vajngerl
If we have the document setting preferred image size set, then use that as the default DPI and recalcualte the logical image size using the DPI and the size in pixels. This is useful so we have the preferred DPI size as 100% in the crop dialog, so we can adjust the size in relation to that value. Change-Id: I50806f194032e228ee2cf56a39e5735a57358d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127096 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-16sd theme: add UI to set individual colors of a color setMiklos Vajna
Which completes the UI to set and get various parts of the theme itself (not yet referring to a theme). Change-Id: I30cb575046d1146083cb5723377400b67de79a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126905 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-15sd theme: add UI to set/get the name of a color setMiklos Vajna
The two names make sense because the theme can have not only color sets but also font names, etc -- but for now we just care about the theme name and a named color set. Change-Id: Ieafca36da005a9c74964e39216bee3c33f6427cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126850 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-14sd: add initial theme UI for master slidesMiklos Vajna
Click Sidebar -> properties -> slide -> master view, then launch the Slide -> Slide properties menu item, this adds a new Theme tab page there. This is just an initial UI, only the theme name can be edited as a start. Change-Id: Ia2faa828c57a0e858881fb8640431f046b5739a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126798 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-10Resolves tdf#145976 - Resizing issues with the macro dialogHeiko Tietze
Fill attributes removes; some spacing added to be HIG conform Change-Id: Ic45bab071db23498e98df5fbed34ee5a50df1390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126569 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-12-03Resolves: tdf#140254 don't expand the column with buttons if dialog expandsCaolán McNamara
Change-Id: Ic7ca17bb2df6de2107ddb7a2a935bf8b81d58607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-03some translations are searched for in the wrong .moCaolán McNamara
since... commit c895a6d8298a349784cd0aafff4bf518ac8d0a7d Date: Fri May 15 10:51:10 2020 +0200 Resolves tdf#132799 - Deleting of colors unclear Tooltips added for disabled states those ones are in cui.mo (CuiResId) not svx (SvxResId) which is more obvious now we only SVXSTR for strings in svx Change-Id: I595bd5aadd8ead18291ff818405bec594c8d32db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>