summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2022-10-26crashreporting: crash in thesaurus dialog PostUserEventCaolán McNamara
not reproducible, but a common error to post an event that outlives the owner Change-Id: Ic2633c504d853116d03e3322f552ae66e7e7e14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-25Address a constexpr template point of instantiation issueStephan Bergmann
...that hits at least when building with Clang and --with-latest-c++ against recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and more class template member functions constexpr). My understanding is that there is some leeway at what point a compiler should instantiate such function specializations, and Clang decides to instantiate constexpr ones early (cf. <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511> "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do not defer instantiations of constexpr functions" comment, and the discussion at <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>). > In file included from cui/source/dialogs/cuihyperdlg.cxx:23: > In file included from include/comphelper/lok.hxx:14: > In file included from include/rtl/ustring.hxx:34: > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:168: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'IconChoicePage' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<IconChoicePage>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<IconChoicePage>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > cui/source/inc/iconcdlg.hxx:43:5: note: in instantiation of member function 'std::unique_ptr<IconChoicePage>::~unique_ptr' requested here > IconChoicePageData(OString aId, std::unique_ptr<IconChoicePage> xInPage) > ^ > cui/source/inc/iconcdlg.hxx:28:7: note: forward declaration of 'IconChoicePage' > class IconChoicePage; > ^ Change-Id: I789c85e0661969679c88fea1dfc7a65475fb3037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-25Simplify recently added code a bitStephan Bergmann
Change-Id: If4e3eec9f3a32cc94ffe0f148704a949328b4e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-24Always include target CPU architecture in About dialog Version InformationStephan Bergmann
...not just for Windows. This information is occasionally useful also on other platforms that can run executables targeting different CPU architectures (like Linux x86 and x86-64, or macOS Aarch64 and x86-64), e.g. when trying to track down why a bug reporter's system doesn't find a JRE matching the architecture of their LibreOffice installation. For simplicity, use the existing _ARCH bootstrap variable, even if its values differ from the hardcoded "x64" and "x86" that have been used here so far. Change-Id: I76b40dd044397bf19e014d8a56d0314f455bc8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-24make all the color menubuttons the same layoutCaolán McNamara
Change-Id: Id4c3a3ae0b9bf7cfe10b0f455e334638bcddbffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-24Resolves: tdf#151711 don't use an intermediate Color to pass data aroundCaolán McNamara
just pass the desired value directly Change-Id: Ib2a6d4c24a18e4a4d735d408e8179e3e204eff13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141687 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-24Related: tdf#147817 validateDatePatterns() also when (re-)setting/initializingEike Rathke
... so a bad pattern possibly stored in configuration gives a visual indicator already on first view. Also reset the edit indicator to normal when initializing from a locale's default patterns. Change-Id: Ib87b01e057bc1409eba6ccb4d2717a731d0773d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141689 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-23Related: tdf#147817 Extract validateDatePatterns() from DatePatternsHdl()Eike Rathke
To be able to reuse it. Change-Id: I11932708a3f1d04180f806f8de12ff42e3d13954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141688 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-23Related: tdf#147817 prevent date acceptance pattern with numeric ambiguityEike Rathke
i.e. matching input with numeric decinmal separator, like M.D Change-Id: Ice977b3e92373829cd2f5df7c065d55bc49fc23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141686 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-20resave with latest gladeMaxim Monastirsky
Change-Id: I0ec13675efa1bd70fa4517bfcff0531da85a8e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141540 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-10-15tdf#151522 add Accessibility::HighContrastCaolán McNamara
0 Automatic, do what the system says 1 Disable 2 Enable Forcing Disable/Enable won't have (much of) an effect on the widgetry, but will affect how document content is rendered where typically content color is mapped to fore/back ground color. Change-Id: I71a2dcf8bc334080414a01691f942a5b7de7b84a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-15tdf#151522 drop Accessibility::AutoDetectSystemHCCaolán McNamara
which doesn't preclude having a different option to force it on/off against the system HighContrast mode setting. Change-Id: Iab9f7f501ac5fd7bb865d07b30b6fad9f1f6809c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-15resave with latest gladeCaolán McNamara
Change-Id: Ie69261feb7fed7f8fda7ac8cb6ee3b8613a1302f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-15tdf#151526 Improve TOTD about text in curvesRafael Lima
Change-Id: Ib035608c0ee0cea413c5f8dc71b2e10fdc29e763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141394 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-14Start to fix the "BASIC Macros" dialog's "Assign..." buttonStephan Bergmann
c79212479f42cadd39173e77acc5e6446480ff05 "Fix a misuse of two-argument std string_view rfind" found that e.g. in Writer "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My Macros - Standard - Module1" and in "Existing Macros in: Module 1" select "Main", then "Assign..." had apparently rotten over time and brought up the "Customize" dialog's default "Menus" tab. With this fix, it now brings up the "Customize" dialog's "Keyboard" tab, in the "Category" tree list selects the appropriate "Module1" line, and in the "Function" list shows all the corresponding functions (just "Main" in this case). It doesn't yet select the appropriate line ("Main") in the "Function" list, though. That apparently needs further fixing. Change-Id: Ia5b9ef88d29e01f4f5e22ce3aec20f5fc22b5d45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-12new uno command uno:Translate with deepl apiMert Tumer
New Uno command added for translation right now it is only using deepl translation api There's a section in the options > language settings for setting up the api url and auth key uno:Translate is a menu button under Format tab which will bring up Language Selection dialog for translation. DeepL can accept html as the input for translation, this new feature leverages that by exporting paragraphs/selections to html and paste them back without losing the formatting (in theory) This works good in general but we may lose formatting in very complex styled sentences. Translation works in two ways; 1) Whole document when there is no selection, it assumes that we want to translate whole document. Each paragraphs is sent one by one so that the output timeout can be minimum for each paragraph. 2) Selection Change-Id: Ia2d3ab2f6757faf565b939e1d670a7dedac33390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140624 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-10Use correct color in cuicharmap.cxxRafael Lima
While fixing bug tdf#151232 (commited as 3e4697c7675430f5e4e2221c951971caee0bdeb8) I used the wrong color in cuicharmap. This patch fixes this error. Change-Id: I1435489424c5a2e343ab009852e51267cbc8eb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141175 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2022-10-06[API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics"Heiko Tietze
Option is out-dated and access via UI confusing * UI access removed from Tools > Options > General (Impress, Calc) resp. > Compatibility (Writer) * Unit tests updated * Tip-Of-The-Day cleaned-up * remove UsePrtMetrics value Change-Id: Ib645f6e1f648455e0536a437be14c2c6a7b25a49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-10-06tdf#151352 crash closing form while the tip of the day dialog is displayedNoel Grandin
Change-Id: I61826ab4d8873f82f7885e26a22d307e2d574e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-05Resolves: tdf#130529 reduce height of customize dialogCaolán McNamara
to fit in 768px height (with default UI font size) Change-Id: I2359e39205e7c13335a7ed266dd367cf45e5dcb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-05Add on-the-fly language tag to proper language list Western/Asian/ComplexEike Rathke
In which combobox wherever it was added, the correct SfxItem will be updated and at least when switching to another dialog tab and back it will appear in the correct list. (shouldn't tabbing out of the combobox already trigger that?) Change-Id: I5aa78797dc24527c753c97d0357c3058271fa4d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140991 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-05tdf#151232 Fix lines in Special Characters dialog in dark modeRafael Lima
This patch makes the lines in the Special Characters dialog visible in dark mode. The Insert Symbols widget is also fixed with this patch. Tested in gen, gtk3 and kf5. Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759 Tested-by: Jenkins Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-03cui: avoid divide by zero in SvxNumberingPreview::PaintXisco Fauli
Just check for pActNum->GetLevelCount() > 1 as done later for nYStep See https://crashreport.libreoffice.org/stats/signature/SvxNumberingPreview::Paint(OutputDevice%20&,tools::Rectangle%20const%20&) Change-Id: I0e9518dafe50b2b10a83487e9247e2fd46f9decd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140921 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-03tdf#151260: crash in SfxItemPool::SetDefaults (reportdesign/ReportController)Julien Nabet
+ deal with the case when there's no XATTR_FILLUSESLIDEBACKGROUND (like here) Change-Id: I2a4cccc80eea69aa88d45b3485d7f6d4448816e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-28cui: fix crash in SpellDialog::SpellContinue_ImplMiklos Vajna
Crashreport signature: Fatal signal received: SIGSEGV code: 128 for address: 0x0 program/libcuilo.so svx::SpellDialog::GetNextSentence_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) include/com/sun/star/uno/Reference.hxx:114 program/libcuilo.so svx::SpellDialog::SpellContinue_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) cui/source/dialogs/SpellDialog.cxx:355 program/libcuilo.so svx::SpellDialog::ChangeHdl(weld::Button&) include/rtl/ustring.hxx:527 program/libmergedlo.so Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&) include/rtl/ref.hxx:208 program/libmergedlo.so Button::Click() /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/std_function.h:244 Change-Id: I2c7267118213ea7d915a28d77badf93f8ff75683 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140689 Tested-by: Jenkins
2022-09-27use more string_view in cui,extensionsNoel Grandin
Change-Id: I76253ae06af53f63206a47a84035317c6a5058b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-26Be sure the number format dialog content is in correct placeSzymon Kłos
- use special container for content which is always above action area (place where ok/cancel buttons are) Change-Id: I53dea3d98e7c74d0b571fdc8a35932deb48a8ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138668 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140578 Tested-by: Jenkins
2022-09-23Fix a misuse of two-argument std string_view rfindStephan Bergmann
...similar to 93e234c45c62af9d57041de676d888f7695ac0e8 "Fix a misuse of two- argument std string_view rfind". This one got introduce in 15d8762dd07289447e782a3812dfd4425fe9a82b "use more string_view in cui". (And if it wasn't for other bugs elsewhere, this code could be reached e.g. in Writer with "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My Macros - Standard - Module1" and in "Existing Macros in: Module 1" select "Main", then "Assign...", and this code would have miscomputed aModule as "Main" rather than as "Module1".) Change-Id: Id3fd66e0bd252d79af629abbbf1e38b37679de70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140490 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-23Related: tdf#35030 hide the "reset" button more reliablyCaolán McNamara
otherwise it won't end up hidden if the "keyboard" tab page is the initial page, this handler only happens when the user switches tabs. use the newly added virtual methods to manage this instead Change-Id: I3eef6b4d7d453a5ec16ec62b2ebb558bd4757caa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-23resave with latest gladeCaolán McNamara
Change-Id: I461177666d04db2250e3f9cd617551343db832b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140487 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21use more string_view in svtoolsNoel Grandin
Change-Id: Id0317c400d7bc868916b97cd1c7abae04c4a9e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20tdf#151070 Leverage UI layout to show relation between buddy optionsAdolfo Jayme Barrientos
And this is why LibreOffice is found by users to be hard to use: because we suck at layouting. Just by swapping a checkbox and a combobox, the relation between the two magically becomes INTUITIVE. Change-Id: Id3801015a6e75d1372d46f1e2d99cfb3a662496d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140213 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-20tdf#112237 Show tooltips for Assigned Commands in Customize dialogJim Raykowski
Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-16vcl: AnimationBitmap -> AnimationFrameChris Sherlock
The emphasis is not quite right. An animation is made up a sequence of *frames*, not bitmaps. A frame includes such things as position, size, timeout till the next frame *as well as* a bitmap. Note: had to regenerate a bunch of precompiled headers Change-Id: Ib1959452653857555f41e01ac0151d08c41a3b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-09-16tdf#136928 Use dialog text color for signs in "Tabs" dialogMichael Weghorn
and use an explicit matching background of dialog color Since the font color is black even in dark themes like "Adwaita-Dark", using a dark style/theme would previously result in black signs on a dark background for the Qt-based VCL plugins (qt5/kf5/qt6). Change-Id: I470011c26861221310e898c8f63fceef5e1aca3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140029 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-14move ErrCode to comphelper and improve debug output stringNoel Grandin
need to move it, because modules "below" vcl want to use the debug output method Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14tdf#142631 use document background color in the spelling widgetCaolán McNamara
Change-Id: Ie33a0e305192697c18e20c3b6c1a554ccddf4284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07add truncate-multiline for consistency with vcl and all the othersCaolán McNamara
Change-Id: I7ccc294308d487ce2443699a946753290344a92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06cid#1500594 Explicit null dereferencedCaolán McNamara
since commit 5480d9237af1cf25ac464bf49ba364a757fcf6f5 Date: Sun Jan 24 22:17:49 2021 -0900 tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse lets make a copy of the iterator Change-Id: I855c58377871d7fb55ea676ebac48c0abc67e98c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139519 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-06tdf#150682 - bad shortcut in french langageNoel Grandin
the = key is } on a french keyboard, so remap the ctrl-alt-= shortcuts to ctrl-alt-} which means the user gets to keep pressing keys in roughly the same physical location for this action, regardless of keyboard Change-Id: I03e251dacc1c19e543182a44ae23fde2a57cfa45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-04tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macrojsala
Change associated for by std::find_if in sqlbison.y Also change some integer by std::size_t Change-Id: I0d2100fbd7c22729da6ce0462c6cc093e0767fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136263 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-08-29ref-count SdrObjectNoel Grandin
Which means we can get rid of the majestic hack of ScCaptionPtr Previously, SdrObject was manually managed, and the ownership passed around in very complicated fashion. Notes: (*) SvxShape has a strong reference to SdrObject, where previously it had a weak reference. It is now strong since otherwise the SdrObject will go away very eagerly. (*) SdrObject still has a weak reference to SvxShape (*) In the existing places that an SdrObject is being deleted, we now just clear the reference (*) instead of SwVirtFlyDrawObj removing itself from the page that contains inside it's destructor, make the call site do the removing from the page. (*) Needed to take the SolarMutex in UndoManagerHelper_Impl::impl_clear because this can be called from UNO (e.g. sfx2_complex JUnit test) and the SdrObjects need the SolarMutex when destructing. (*) handle a tricky situation with SwDrawVirtObj in the SwDrawModel destructor because the existing code wants mpDrawObj in SwAnchoredObject to be sometimes owning, sometimes not, which results in a cycle with the new code. Change-Id: I4d79df1660e386388e5d51030653755bca02a163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-29tdf#150246 Show CL and threaded in About dialog in the same timeRoman Kuznetsov
Change-Id: I8d4974967e1595159251275f58d88c25b9e91e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138824 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2022-08-25FeatureCollector: SimplifyKhaled Hosny
We are not using the script or language information for anything, so we can use HarfBuzz API to query the GSUB/GPOS tables directly. Change-Id: Ie68c51a1662494ba33ec192edb78afa0d8added4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138745 Tested-by: خالد حسني <khaled@aliftype.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-23tdf#127423: Allow disabling default features in Font Features dialogKhaled Hosny
In OpenType fonts we have no way if detecting what features are on by default and what not (short of hard-coding this, since HarfBuzz has no API of giving us this information, and it is also not a fixed set per-font, depends also on the text being shaped). The dialog currently does not differentiate between a disabled feature and unset feature. To make this distinction, feature value is now signed and negative value means the feature is unset (i.e. the default is used), and the checkbox is now a try state one to reflect this. Change-Id: Iba5d13f02610e7b761677acc19872788c72afde1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-17Resolves tdf#65473 - Unintuitive paragraph alignment optionsHeiko Tietze
Switched Center and Right Change-Id: I7b24bb23d113dfa76b878b1533f3e7df1a2ba3dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138376 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-08-17Raise Glade versionHeiko Tietze
No actual changes Change-Id: I79d3831c3aa1399df95fa5c33f7c624468525a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138375 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-08-16Related tdf#82087: hyphenation: allow 1 character at line beginJulien Nabet
The default "Characters at line begin" value is still 2 in Paragraph Styles->Text Flow, but now it's possible to set 1, too. See end of comment here: https://bugs.documentfoundation.org/show_bug.cgi?id=82087#c22 Change-Id: Ib10e8a919715666214c7e4ac19f1506f111a6519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137937 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2025-01-23 17:46:52 +0000