summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)Author
2024-07-17Use IsRunningUnitTest / IsRunningUITest consistentlyMike Kaganski
The functions are moved to o3tl as inline functions. Change-Id: Ief7d7e292ef15e055ad04ab5707e5e6a2a05b916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170636 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-17Simplify checking for "running under unit/ui test"Noel Grandin
In various places, the code checks if we are running as a unit test or a UI test. This code grew organically, and is most re-using environment variables that were designed for narrower purposes. Rather than being clever, just add two new explicit and simple environment variables in the natural place (the command that runs them), and check for those variables in the code. Change-Id: Icce0997914fa0be30a5ac1f29bd870bdb5893a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170618 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-17Resolves: tdf#161989 unset gtk emphasis defaults to lightCaolán McNamara
Change-Id: Id347671ed7f9b1b36c29578566c4a82e9181aeb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-16cid#1554709 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554745 COPY_INSTEAD_OF_MOVE cid#1554758 COPY_INSTEAD_OF_MOVE cid#1554766 COPY_INSTEAD_OF_MOVE cid#1554771 COPY_INSTEAD_OF_MOVE cid#1554787 COPY_INSTEAD_OF_MOVE cid#1554802 COPY_INSTEAD_OF_MOVE cid#1554820 COPY_INSTEAD_OF_MOVE cid#1554828 COPY_INSTEAD_OF_MOVE cid#1554829 COPY_INSTEAD_OF_MOVE cid#1554832 COPY_INSTEAD_OF_MOVE cid#1554842 COPY_INSTEAD_OF_MOVE cid#1554885 COPY_INSTEAD_OF_MOVE Change-Id: I43ec20250a04dc087f3d7fdeafc75f0c1dd0de25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-16tdf#155069 Make "Run Graphics Test" button experimentalKira Tubo
Hide "Run Graphics Test" button unless Experimental Mode is turned on. Change-Id: Idcfe2627e525626cce9dd866a9b697c69599626f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169480 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-07-11Don't save bullet changes when dialog was cancelledSamuel Mehrbrodt
Change-Id: Ia2a7feb2f47a59f7c693e2023f9c2c8b3b934f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170336 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-07-10regain the SvxCharacterMap "pre-run" logic in async modeCaolán McNamara
since: commit 6a5ef1a2b009f208745a251828bf8e8c51146bfe Date: Mon Jan 22 12:35:50 2024 +0200 make charmap dialog async Change-Id: I5fc13e759eb8f1d1e6ab7c09f39cabc1d4c4ad7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-06cid#1545304 silence Using invalid iteratorCaolán McNamara
Change-Id: I653c9b9313a854646028c7b2d9982c1233377ea0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-04make SvxEscapementItem hashableNoel Grandin
Change-Id: Ic03c78f6dde68f5557d474147336fa62be6f3aaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-02cid#1607340 Use of auto that causes a copyCaolán McNamara
Change-Id: I46bd4bf5cf6df3dba8518b40a8a9ace7dfef2e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169853 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-01Resave with newer Glade versionBogdan Buzea
Change-Id: Ia6e4011bff54f8c471def8f2b4d764beb462c05d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169384 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-30Resave with newer Glade versionBogdan Buzea
Change-Id: I062f3dc2671beb0c82b43905f2b9afb5050f9e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169429 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-29tdf#96787 AutoCorrect: find item with ".*" and between :colons:László Németh
It was very hard to disable autocorrection of (c)->© and other AutoCorrect items, because the searched Replace string "(c)" etc. didn't jump the list cursor to the corresponding ".*(c)" item. Now skip ".*" pattern matching marks, also colon (emoji replacement) characters, so the list cursor jumps to the line ".*(c)"->© typing only "(c" etc., allowing users to press Delete to disable its autocorrection without knowing about the special AutoCorrect patterns. Follow-up to commit 50be3fa1f0f3b8870af5bda88b65f835ef37d77e "tdf#141773 AutoCorrect: fix broken [All] dictionaries". Change-Id: I72be1ecb2fdc5ae67c72727ce7fbd70b28a4125b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169714 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-06-28make additionsdialog show connection errorsSarper Akdemir
use non-scoped interaction handler instead of the scoped SimpleFileAccessInteraction so that errors will be handled with correct pop-up dialogs. Also throw the correct type of DAVException for USC_CONNECT_FAILED in Content::Open Change-Id: If2031dfa2796f91fad6866bc9608194c92658b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169519 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-06-28Resave with newer Glade versionBogdan Buzea
Change-Id: Iaa30a56068f7db4a735793d99e04f31054f8e17c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169426 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24Add newline at end of fileTaichi Haradaguchi
Change-Id: I731d8d80e075c8df8a104ec963b89337a91d536c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169376 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: If519ec2547d462b418ce51dbd56f0f497c29b4c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169406 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: I78c7d3d4ae4643fa9f669177263d8c7bf4f681e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169377 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-24Resave with newer Glade versionBogdan Buzea
Change-Id: Ief1e76e4888d33d353b73d26a2aca914b5b087dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169405 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-21Fix typoAndrea Gelmini
Change-Id: I05003d690d10ad03aa498a69063368e33340596d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169210 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-06-20tdf#146468: Match border tooltips in toolbar/sidebarKira Tubo
Update the border tooltips within Calc's toolbar and sidebar so that they have matching descriptions. Also update tooltips in Writer toolbar so that descriptions match across both apps. Change-Id: Ib7c682ed5035fe61d991209c4f2cf7f0a1a08a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
2024-06-18tdf#161579 userautosave: fix wording to match 24.2 implementationJustin Luth
The implementation changed with my LO 24.2 commit 63bb760acc8aa50c352f3349e8adf3db381b4911 https://gerrit.libreoffice.org/c/core/+/155273 for bug 57414 When the document successfully saved, there was no reason to create a recovery version of it immediately afterward. Change-Id: If62b9c60cf6b39d25ee42001eb6344593479c716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168897 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-06-18tdf#131688 - RemoveDirectCharFormats <Ctrl>+<Shift>+X usage tipkubak
Change-Id: I89c2c7d6af663904223834664aeb635cb99068bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167164 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-06-18Add SfxItemType to SfxPoolItemOliver Specht
The SfxPoolItem has a new member SfxItemType m_eItemType to compare types based on enums instead of typeinfo() which consumes a lot of time e.g. while AutoFormat is running Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-06-10fix Gtk-WARNING **: Could not load image 'res/unlocked.png'Caolán McNamara
use icon-name instead of pixbuf Change-Id: Ibb0a09047ada6ac3301ca0a40dbeb25351c41ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168609 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-10fix GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
Change-Id: I29024237cc2d92d16433cf432f87e2b42107a487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-10tdf#99528 Use vertical tabs in para dialogSamuel Mehrbrodt
Change-Id: I7ec61c07f75e9a8aa124ac5b3d67c90077cca033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166625 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-06the remaining Help::GetHelpText calls don't want their parent as fallbackCaolán McNamara
so we can drop the hierarchical search these probably do nothing in the absence of the classic help. fpicker case might benefit from moving some a11y translations out of help into core. Change-Id: I01b8d0c7cc1a1b3697d3332e330c6b4654e76af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06customization entry help never wants to search for parent widget helpCaolán McNamara
it's not a widget context help where help about the parent widget might help in the case of nothing available for the child widget, but help for the specific selected command/script see also: https://bugs.documentfoundation.org/show_bug.cgi?id=116494 Change-Id: Ib4b5650ca00c90b4b4b2a76ef0e3d8a438023327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168504 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-06tdf#159375: turn cursor into a wait cursor while searchBayram Çiçek
- Tools>Options: change cursor type to "wait cursor" while search is running - m_xSearchEdit->set_busy_cursor(true) adds a spinner next to/(or in place of) the mouse cursor. Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I944db49b14a652b4a52f0d38696f60385ee9f85b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168402 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-06-03tdf#69724 Disable 'Change Bullet' btn until selection existsSamuel Mehrbrodt
Change-Id: I9c1fdeb4423a8fe45121ff58097582dcccdd12ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168359 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-30AreObjectsMarked -> GetMarkedObjectList().GetMarkCount() != 0Xisco Fauli
In order to reduce number of calls to GetMarkedObjectList() later on Change-Id: Ib2eb7c88338e64744f886a338acca65f782f8170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168218 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-22tdf#161209 - Reverts WhatsNew/Welcome dialogHeiko Tietze
dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1 Change-Id: Idf0594c546e4d9ca263272ed1534b27948e8e930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167956 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-05-21tdf#69724 Allow to change default bullet symbols in UITibor Nagy
Change-Id: Ife700096fb55ebc752ae289398a36ee78b3e5ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167660 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-05-16Related tdf#159573 - WhatsNew dialog: 1px glitch with WaylandHeiko Tietze
Change-Id: I6565fa32f4484e74abecc795c67e7afa13f7f55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167734 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-05-12replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I487828fd11e1b22da2cc651b413f0744bf43b6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I6029cd4c894c6ab079cc508ba15df41ec5d4f8db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167516 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-10replace createFromAscii with OUString literals in SvxPathTabPageNoel Grandin
Change-Id: I831bc78f4934c7d1c137ad70c7bb189d75237e88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-10replace createFromAscii with OUString literals in OfaTreeOptionsDialogNoel Grandin
Change-Id: Ibe4de7e2ac6f0f00ba495ecbd18d97154283169c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-10replace createFromAscii with OUString literals in SvxMacroAssignDlgNoel Grandin
Change-Id: I360d1dc46909f904ac9f984b2f06bb80f4a72c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'László Németh
Add new hyphenation option to limit hyphenation of the last full line of the hyphenated paragraph. Move also loext:hyphenation-keep-type to paragraph-properties, following the associated hyphenation-keep. Note: value "always" is defined by CSS 4 hyphenate-limit-last, see https://www.w3.org/TR/css-text-4/#hyphenate-line-limits. Follow-up to commit 6e8819f29b6051a0e551d77512830539913ec277 "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type". Change-Id: I2121269205fc89fb5367dccdca00195aac68f3e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167232 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-05-07loplugin:ostr in cuiNoel Grandin
Change-Id: I593eb3c02768423fc8cea8d93c112655860228d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07tdf#145614 Convert #define to enumZainab Abbasi
Change-Id: I50cad24e9cbda04cfe1209d824cad61da2287def Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166191 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-06tdf#159375: remove initialization on Tools>OptionsBayram Çiçek
- Initializing some dialogs at the startup of Options makes it opening very slow on some low-power systems. - This patch removes this initialization. This means, all dialogs will be initialized at the time of search. Therefore, we should wait a bit longer when typing on the search bar to get the results... - remove the default parameter "nNumberOfNode" from initializeFirstNDialog() - rename initializeFirstNDialog() to initializeAllDialogs() Change-Id: I4fd9c5673f7edecfe6a6621b6018d5d405f112a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167023 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
2024-05-04WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I95bc5dae73f6e9a0ae54b1570df51d6d37062695 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-03tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/Miklos Vajna
The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the anchor paragraph is RTL, so swapped the "from left" label to a "from right" label. Don't do this when the compat option is enabled, so not only we render correctly but the UI now correctly explains why we came up with the correct position. Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167031 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-01Resolves tdf#141778 - Size issues on view options UIHeiko Tietze
Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166885 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-04-29Drop uses of css::uno::Sequence::getConstArray in cppuhelper .. cuiMike Kaganski
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code 2021-11-05). Change-Id: Ia2b60af973183bbe79656e67b5e37d7efa39a308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-29tdf#99528 Properly layout vertical tabs without iconsSamuel Mehrbrodt
Implement a proper list mode for VerticalTabControl. Before this was only used in the Hyperlink dialog with large icons. Change-Id: I227643392ef4840a705555b379734e2993db0f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166702 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
generated by cgit (git 2.34.1) at 2025-01-12 13:07:43 +0000